From: "Andreas Färber" <afaerber@suse.de>
To: malc <av1474@comtv.ru>
Cc: Blue Swirl <blauwirbel@gmail.com>,
qemu-devel@nongnu.org, Evgeny Voevodin <e.voevodin@samsung.com>,
Dmitry Solodkiy <d.solodkiy@samsung.com>
Subject: Re: [Qemu-devel] Restore consistent formatting
Date: Wed, 08 Feb 2012 13:41:10 +0100 [thread overview]
Message-ID: <4F326D66.6060808@suse.de> (raw)
In-Reply-To: <4F324A60.7070600@samsung.com>
malc,
Arbitrarily reformatting your files is not okay. If you want a different
formatting, you need to fix checkpatch.pl first to not error on that
formatting in your files.
And please post your patches to the mailing list.
Thanks,
Andreas
Am 08.02.2012 11:11, schrieb Evgeny Voevodin:
> The last commit "Restore consistent formatting"
> (cf4dc461a4cfc3e056ee24edb26154f4d34a6278) which is on the master but
> absent in mailing list results in such output of checkpatch.pl:
>
> ./scripts/checkpatch.pl --no-tree --file hw/cs4231a.c
> ...
> total: 107 errors, 88 warnings, 696 lines checked
>
> -----------------------------------------------------------------
>
> ./scripts/checkpatch.pl --no-tree --file hw/adlib.c
> ...
> total: 7 errors, 58 warnings, 337 lines checked
>
> -----------------------------------------------------------------
>
> ./scripts/checkpatch.pl --no-tree --file hw/ac97.c
> ...
> total: 16 errors, 324 warnings, 1380 lines checked
>
>
> and so on.
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-02-08 12:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 10:11 [Qemu-devel] Restore consistent formatting Evgeny Voevodin
2012-02-08 12:41 ` Andreas Färber [this message]
2012-02-08 15:04 ` malc
2012-02-08 15:23 ` Anthony Liguori
2012-02-08 15:36 ` Andreas Färber
2012-02-08 15:48 ` Anthony Liguori
2012-02-11 9:19 ` Blue Swirl
2012-02-11 12:18 ` Andreas Färber
2012-02-09 9:48 ` Markus Armbruster
2012-02-09 13:46 ` Anthony Liguori
2012-02-11 9:05 ` Blue Swirl
2012-02-08 15:28 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F326D66.6060808@suse.de \
--to=afaerber@suse.de \
--cc=av1474@comtv.ru \
--cc=blauwirbel@gmail.com \
--cc=d.solodkiy@samsung.com \
--cc=e.voevodin@samsung.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.