All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Markus Armbruster <armbru@redhat.com>
Cc: "Blue Swirl" <blauwirbel@gmail.com>,
	"Andreas Färber" <afaerber@suse.de>,
	qemu-devel@nongnu.org, "Evgeny Voevodin" <e.voevodin@samsung.com>,
	"Dmitry Solodkiy" <d.solodkiy@samsung.com>
Subject: Re: [Qemu-devel] Restore consistent formatting
Date: Thu, 09 Feb 2012 07:46:24 -0600	[thread overview]
Message-ID: <4F33CE30.1040706@codemonkey.ws> (raw)
In-Reply-To: <m3k43wcp7z.fsf@blackfin.pond.sub.org>

On 02/09/2012 03:48 AM, Markus Armbruster wrote:
> Anthony Liguori<anthony@codemonkey.ws>  writes:
>
>> On 02/08/2012 09:04 AM, malc wrote:
>>> On Wed, 8 Feb 2012, Andreas F?rber wrote:
>>>
>>>> malc,
>>>>
>>>> Arbitrarily reformatting your files is not okay. If you want a different
>>>> formatting, you need to fix checkpatch.pl first to not error on that
>>>> formatting in your files.
>>>
>>> It was always formatter like this (internally consistent), then others
>>> added code which made it not so.
>>
>> We do have a mixed style in the audio layer.  I'm not happy about that
>> but I also feel strongly that going through and doing a reformat is
>> not a worthwhile exercise.
>>
>> I can also understand the desire to keep things consistent.  But
>> patches should always go to the mailing list.  I certainly would have
>> acked such a patch FWIW.
>
> You buried the one truly important sentence, let me dig it out for you:
>
>          *** Patches should always go to the mailing list ***
>
> Exceptions need justification.  Responsible handling embargoed security
> issues may qualify.  Style fixes certainly not.

100% agreed.

Regards,

Anthony Liguori


>
> [...]
>

  reply	other threads:[~2012-02-09 13:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-08 10:11 [Qemu-devel] Restore consistent formatting Evgeny Voevodin
2012-02-08 12:41 ` Andreas Färber
2012-02-08 15:04   ` malc
2012-02-08 15:23     ` Anthony Liguori
2012-02-08 15:36       ` Andreas Färber
2012-02-08 15:48         ` Anthony Liguori
2012-02-11  9:19         ` Blue Swirl
2012-02-11 12:18           ` Andreas Färber
2012-02-09  9:48       ` Markus Armbruster
2012-02-09 13:46         ` Anthony Liguori [this message]
2012-02-11  9:05       ` Blue Swirl
2012-02-08 15:28     ` Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F33CE30.1040706@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=afaerber@suse.de \
    --cc=armbru@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=d.solodkiy@samsung.com \
    --cc=e.voevodin@samsung.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.