* [U-Boot] [PATCH] ARM: omap3: temporary disable USB on TAM3517 boards
@ 2012-01-16 8:53 Stefano Babic
2012-01-16 11:06 ` Wolfgang Denk
2012-02-26 23:10 ` Marek Vasut
0 siblings, 2 replies; 6+ messages in thread
From: Stefano Babic @ 2012-01-16 8:53 UTC (permalink / raw)
To: u-boot
The TAM3517 boards require a patch for EHCI OMAP
that does not yet find a way to mainline. The patch
disables temporary USB until EHCI OMAP will be supported.
Signed-off-by: Stefano Babic <sbabic@denx.de>
Cc: Tom Rini <tom.rini@gmail.com>
Cc: Albert Aribaud <albert.u.boot@aribaud.net>
---
include/configs/tam3517-common.h | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/include/configs/tam3517-common.h b/include/configs/tam3517-common.h
index 817d468..081dbc8 100644
--- a/include/configs/tam3517-common.h
+++ b/include/configs/tam3517-common.h
@@ -97,12 +97,16 @@
#define CONFIG_DOS_PARTITION
/* EHCI */
+#undef CONFIG_CMD_USB
+#ifdef CONFIG_CMD_USB
#define CONFIG_OMAP3_GPIO_5
#define CONFIG_USB_EHCI
#define CONFIG_USB_EHCI_OMAP
-#define CONFIG_OMAP_EHCI_PHY1_RESET_GPIO 25
#define CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS 3
#define CONFIG_USB_STORAGE
+#endif
+
+#define CONFIG_OMAP_EHCI_PHY1_RESET_GPIO 25
/* #define CONFIG_EHCI_DCACHE */
@@ -121,7 +125,6 @@
#define CONFIG_CMD_NFS
#define CONFIG_CMD_NAND /* NAND support */
#define CONFIG_CMD_PING
-#define CONFIG_CMD_USB
#undef CONFIG_CMD_FLASH /* only NAND on the SOM */
#undef CONFIG_CMD_IMLS
--
1.7.5.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] ARM: omap3: temporary disable USB on TAM3517 boards
2012-01-16 8:53 [U-Boot] [PATCH] ARM: omap3: temporary disable USB on TAM3517 boards Stefano Babic
@ 2012-01-16 11:06 ` Wolfgang Denk
2012-02-26 23:10 ` Marek Vasut
1 sibling, 0 replies; 6+ messages in thread
From: Wolfgang Denk @ 2012-01-16 11:06 UTC (permalink / raw)
To: u-boot
Dear Stefano Babic,
In message <1326704008-18464-1-git-send-email-sbabic@denx.de> you wrote:
>
> +#undef CONFIG_CMD_USB
> +#ifdef CONFIG_CMD_USB
Please do not undef what is not defined in the first place.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Boss, n.: According to the Oxford English Dictionary, in the Middle
Ages the words "boss" and "botch" were largely synonymous, except
that boss, in addition to meaning "a supervisor of workers" also
meant "an ornamental stud."
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] ARM: omap3: temporary disable USB on TAM3517 boards
2012-01-16 8:53 [U-Boot] [PATCH] ARM: omap3: temporary disable USB on TAM3517 boards Stefano Babic
2012-01-16 11:06 ` Wolfgang Denk
@ 2012-02-26 23:10 ` Marek Vasut
2012-02-27 7:07 ` Igor Grinberg
2012-02-27 8:48 ` Stefano Babic
1 sibling, 2 replies; 6+ messages in thread
From: Marek Vasut @ 2012-02-26 23:10 UTC (permalink / raw)
To: u-boot
> The TAM3517 boards require a patch for EHCI OMAP
> that does not yet find a way to mainline. The patch
> disables temporary USB until EHCI OMAP will be supported.
>
> Signed-off-by: Stefano Babic <sbabic@denx.de>
> Cc: Tom Rini <tom.rini@gmail.com>
> Cc: Albert Aribaud <albert.u.boot@aribaud.net>
> ---
> include/configs/tam3517-common.h | 7 +++++--
> 1 files changed, 5 insertions(+), 2 deletions(-)
>
Hi,
what's the status of this patch/patchset?
Thanks
M
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] ARM: omap3: temporary disable USB on TAM3517 boards
2012-02-26 23:10 ` Marek Vasut
@ 2012-02-27 7:07 ` Igor Grinberg
2012-02-27 8:48 ` Stefano Babic
1 sibling, 0 replies; 6+ messages in thread
From: Igor Grinberg @ 2012-02-27 7:07 UTC (permalink / raw)
To: u-boot
On 02/27/12 01:10, Marek Vasut wrote:
>> The TAM3517 boards require a patch for EHCI OMAP
>> that does not yet find a way to mainline. The patch
>> disables temporary USB until EHCI OMAP will be supported.
>>
>> Signed-off-by: Stefano Babic <sbabic@denx.de>
>> Cc: Tom Rini <tom.rini@gmail.com>
>> Cc: Albert Aribaud <albert.u.boot@aribaud.net>
>> ---
>> include/configs/tam3517-common.h | 7 +++++--
>> 1 files changed, 5 insertions(+), 2 deletions(-)
>>
>
> Hi,
>
> what's the status of this patch/patchset?
Superseded by:
8c589d6f (OMAP3: TAM3517: update ehci interface)
--
Regards,
Igor.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] ARM: omap3: temporary disable USB on TAM3517 boards
2012-02-26 23:10 ` Marek Vasut
2012-02-27 7:07 ` Igor Grinberg
@ 2012-02-27 8:48 ` Stefano Babic
2012-02-27 13:53 ` Marek Vasut
1 sibling, 1 reply; 6+ messages in thread
From: Stefano Babic @ 2012-02-27 8:48 UTC (permalink / raw)
To: u-boot
On 27/02/2012 00:10, Marek Vasut wrote:
>> The TAM3517 boards require a patch for EHCI OMAP
>> that does not yet find a way to mainline. The patch
>> disables temporary USB until EHCI OMAP will be supported.
>>
>> Signed-off-by: Stefano Babic <sbabic@denx.de>
>> Cc: Tom Rini <tom.rini@gmail.com>
>> Cc: Albert Aribaud <albert.u.boot@aribaud.net>
>> ---
>> include/configs/tam3517-common.h | 7 +++++--
>> 1 files changed, 5 insertions(+), 2 deletions(-)
>>
>
> Hi,
>
> what's the status of this patch/patchset?
The patch must be dropped - after I sent it, Govindraj's patches cleaned
up the code adding OMAP4 support and these patches are now mainline.
Everything is mainlined now, we need only to discharge this patch.
Stefano
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] ARM: omap3: temporary disable USB on TAM3517 boards
2012-02-27 8:48 ` Stefano Babic
@ 2012-02-27 13:53 ` Marek Vasut
0 siblings, 0 replies; 6+ messages in thread
From: Marek Vasut @ 2012-02-27 13:53 UTC (permalink / raw)
To: u-boot
> On 27/02/2012 00:10, Marek Vasut wrote:
> >> The TAM3517 boards require a patch for EHCI OMAP
> >> that does not yet find a way to mainline. The patch
> >> disables temporary USB until EHCI OMAP will be supported.
> >>
> >> Signed-off-by: Stefano Babic <sbabic@denx.de>
> >> Cc: Tom Rini <tom.rini@gmail.com>
> >> Cc: Albert Aribaud <albert.u.boot@aribaud.net>
> >> ---
> >>
> >> include/configs/tam3517-common.h | 7 +++++--
> >> 1 files changed, 5 insertions(+), 2 deletions(-)
> >
> > Hi,
> >
> > what's the status of this patch/patchset?
>
> The patch must be dropped - after I sent it, Govindraj's patches cleaned
> up the code adding OMAP4 support and these patches are now mainline.
> Everything is mainlined now, we need only to discharge this patch.
>
> Stefano
Updated status in patchwork, Thanks!
M
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-02-27 13:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-16 8:53 [U-Boot] [PATCH] ARM: omap3: temporary disable USB on TAM3517 boards Stefano Babic
2012-01-16 11:06 ` Wolfgang Denk
2012-02-26 23:10 ` Marek Vasut
2012-02-27 7:07 ` Igor Grinberg
2012-02-27 8:48 ` Stefano Babic
2012-02-27 13:53 ` Marek Vasut
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.