From: Orit Wasserman <owasserm@redhat.com> To: Amos Kong <akong@redhat.com> Cc: Paolo Bonzini <pbonzini@redhat.com>, aliguori@us.ibm.com, kvm@vger.kernel.org, quintela@redhat.com, jasowang@redhat.com, qemu-devel@nongnu.org, laine@redhat.com Subject: Re: [Qemu-devel] [PATCH v3 1/9] net: introduce tcp_server_start() Date: Wed, 14 Mar 2012 12:03:13 +0200 [thread overview] Message-ID: <4F606CE1.2060401@redhat.com> (raw) In-Reply-To: <4F604DE5.1050101@redhat.com> On 03/14/2012 09:51 AM, Amos Kong wrote: > On 14/03/12 15:27, Paolo Bonzini wrote: >> > > Hi Paolo, > >> Il 14/03/2012 08:14, Orit Wasserman ha scritto: >>> if (bind(*fd, (struct sockaddr *)&saddr, sizeof(saddr))< 0) >>> { >>> closesocket(*fd); >>> return -socket_error(); >>> } >>> return 0; >>> >>> and than you will not need ret >> >> But closesocket could clobber socket_error(), no? Completely correct. > > Yes, it will effect socket_error() > > How about this fix ? > > ret = bind(*fd, (struct sockaddr *)&saddr, sizeof(saddr)); > if (ret < 0) { > ret = -socket_error(); > closesocket(*fd); > } > return ret; > } > Looks good. Orit
WARNING: multiple messages have this Message-ID (diff)
From: Orit Wasserman <owasserm@redhat.com> To: Amos Kong <akong@redhat.com> Cc: aliguori@us.ibm.com, kvm@vger.kernel.org, quintela@redhat.com, jasowang@redhat.com, qemu-devel@nongnu.org, laine@redhat.com, Paolo Bonzini <pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 1/9] net: introduce tcp_server_start() Date: Wed, 14 Mar 2012 12:03:13 +0200 [thread overview] Message-ID: <4F606CE1.2060401@redhat.com> (raw) In-Reply-To: <4F604DE5.1050101@redhat.com> On 03/14/2012 09:51 AM, Amos Kong wrote: > On 14/03/12 15:27, Paolo Bonzini wrote: >> > > Hi Paolo, > >> Il 14/03/2012 08:14, Orit Wasserman ha scritto: >>> if (bind(*fd, (struct sockaddr *)&saddr, sizeof(saddr))< 0) >>> { >>> closesocket(*fd); >>> return -socket_error(); >>> } >>> return 0; >>> >>> and than you will not need ret >> >> But closesocket could clobber socket_error(), no? Completely correct. > > Yes, it will effect socket_error() > > How about this fix ? > > ret = bind(*fd, (struct sockaddr *)&saddr, sizeof(saddr)); > if (ret < 0) { > ret = -socket_error(); > closesocket(*fd); > } > return ret; > } > Looks good. Orit
next prev parent reply other threads:[~2012-03-14 10:03 UTC|newest] Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-03-06 22:47 [PATCH v3 0/9] support to migrate with IPv6 address Amos Kong 2012-03-06 22:47 ` [Qemu-devel] " Amos Kong 2012-03-06 22:47 ` [PATCH v3 1/9] net: introduce tcp_server_start() Amos Kong 2012-03-06 22:47 ` [Qemu-devel] " Amos Kong 2012-03-13 16:39 ` Michael Roth 2012-03-14 8:33 ` Amos Kong 2012-03-14 14:58 ` Michael Roth 2012-03-16 10:47 ` Amos Kong 2012-03-16 10:47 ` [Qemu-devel] " Amos Kong 2012-03-14 7:14 ` Orit Wasserman 2012-03-14 7:27 ` Paolo Bonzini 2012-03-14 7:27 ` Paolo Bonzini 2012-03-14 7:51 ` Amos Kong 2012-03-14 7:51 ` Amos Kong 2012-03-14 8:28 ` Paolo Bonzini 2012-03-14 8:28 ` Paolo Bonzini 2012-03-14 10:03 ` Orit Wasserman [this message] 2012-03-14 10:03 ` Orit Wasserman 2012-03-14 11:39 ` Kevin Wolf 2012-03-14 11:39 ` Kevin Wolf 2012-03-06 22:47 ` [PATCH v3 2/9] net: use tcp_server_start() for tcp server creation Amos Kong 2012-03-06 22:47 ` [Qemu-devel] " Amos Kong 2012-03-06 22:48 ` [PATCH v3 3/9] net: introduce tcp_client_start() Amos Kong 2012-03-06 22:48 ` [Qemu-devel] " Amos Kong 2012-03-13 18:35 ` Michael Roth 2012-03-14 10:19 ` Amos Kong 2012-03-14 15:30 ` Michael Roth 2012-03-14 7:31 ` Orit Wasserman 2012-03-06 22:48 ` [PATCH v3 4/9] net: use tcp_client_start for tcp client creation Amos Kong 2012-03-06 22:48 ` [Qemu-devel] " Amos Kong 2012-03-06 22:48 ` [PATCH v3 5/9] net: refector tcp_*_start functions Amos Kong 2012-03-06 22:48 ` [Qemu-devel] " Amos Kong 2012-03-06 22:48 ` [PATCH v3 6/9] net: use getaddrinfo() in tcp_start_common Amos Kong 2012-03-06 22:48 ` [Qemu-devel] " Amos Kong 2012-03-06 22:48 ` [PATCH v3 7/9] net: introduce parse_host_port_info() Amos Kong 2012-03-06 22:48 ` [Qemu-devel] " Amos Kong 2012-03-06 22:48 ` [PATCH v3 8/9] net: split hostname and service by last colon Amos Kong 2012-03-06 22:48 ` [Qemu-devel] " Amos Kong 2012-03-13 19:34 ` Michael Roth 2012-03-06 22:48 ` [PATCH v3 9/9] net: support to include ipv6 address by brackets Amos Kong 2012-03-06 22:48 ` [Qemu-devel] " Amos Kong 2012-03-13 19:47 ` Michael Roth 2012-03-14 9:58 ` Amos Kong 2012-03-14 9:58 ` [Qemu-devel] " Amos Kong 2012-03-14 15:38 ` Michael Roth
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4F606CE1.2060401@redhat.com \ --to=owasserm@redhat.com \ --cc=akong@redhat.com \ --cc=aliguori@us.ibm.com \ --cc=jasowang@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=laine@redhat.com \ --cc=pbonzini@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=quintela@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.