[Qemu-devel] Breakage

[Qemu-devel] Breakage

[malc]

97161e177b4ea2730dff13c4df01475762ab6048 broke booting of a DOS image
i've been using for years, the VM stalls at "Booting from hard disk"
BIOS message never making any progress.

-- 
mailto:av1474@comtv.ru

Re: [Qemu-devel] Breakage

[Avi Kivity]

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

On 03/18/2012 06:12 PM, malc wrote:
> 97161e177b4ea2730dff13c4df01475762ab6048 broke booting of a DOS image
> i've been using for years, the VM stalls at "Booting from hard disk"
> BIOS message never making any progress.

Can you post an image that exhibits the problem?

Also, try the attached patch.

-- 
error compiling committee.c: too many arguments to function


[-- Attachment #2: 0001-exec-fix-write-tlb-entry-misused-as-iotlb.patch --]
[-- Type: text/x-patch, Size: 2073 bytes --]

>From bb363db2608dfc9b49b53994dc20d68169e66774 Mon Sep 17 00:00:00 2001
From: Avi Kivity <avi@redhat.com>
Date: Wed, 14 Mar 2012 16:19:39 +0200
Subject: [PATCH] exec: fix write tlb entry misused as iotlb

A couple of code paths check the lower bits of CPUTLBEntry::addr_write
against io_mem_ram as a way of looking for a dirty RAM page.  This works
by accident since the value is zero, which matches all clear bits for
TLB_INVALID, TLB_MMIO, and TLB_NOTDIRTY (indicating dirty RAM).

Make it work by design by checking for the proper bits.

Signed-off-by: Avi Kivity <avi@redhat.com>
---
 exec.c |   11 ++++++++---
 1 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/exec.c b/exec.c
index 8fd50a1..d8b089e 100644
--- a/exec.c
+++ b/exec.c
@@ -2031,14 +2031,19 @@ static void tlb_unprotect_code_phys(CPUArchState *env, ram_addr_t ram_addr,
     cpu_physical_memory_set_dirty_flags(ram_addr, CODE_DIRTY_FLAG);
 }
 
+static bool tlb_is_dirty_ram(CPUTLBEntry *tlbe)
+{
+    return (tlbe->addr_write & (TLB_INVALID_MASK|TLB_MMIO|TLB_NOTDIRTY)) == 0;
+}
+
 static inline void tlb_reset_dirty_range(CPUTLBEntry *tlb_entry,
                                          unsigned long start, unsigned long length)
 {
     unsigned long addr;
-    if ((tlb_entry->addr_write & ~TARGET_PAGE_MASK) == io_mem_ram.ram_addr) {
+    if (tlb_is_dirty_ram(tlb_entry)) {
         addr = (tlb_entry->addr_write & TARGET_PAGE_MASK) + tlb_entry->addend;
         if ((addr - start) < length) {
-            tlb_entry->addr_write = (tlb_entry->addr_write & TARGET_PAGE_MASK) | TLB_NOTDIRTY;
+            tlb_entry->addr_write |= TLB_NOTDIRTY;
         }
     }
 }
@@ -2091,7 +2096,7 @@ static inline void tlb_update_dirty(CPUTLBEntry *tlb_entry)
     ram_addr_t ram_addr;
     void *p;
 
-    if ((tlb_entry->addr_write & ~TARGET_PAGE_MASK) == io_mem_ram.ram_addr) {
+    if (tlb_is_dirty_ram(tlb_entry)) {
         p = (void *)(unsigned long)((tlb_entry->addr_write & TARGET_PAGE_MASK)
             + tlb_entry->addend);
         ram_addr = qemu_ram_addr_from_host_nofail(p);
-- 
1.7.9

Re: [Qemu-devel] Breakage

[malc]

On Sun, 18 Mar 2012, Avi Kivity wrote:

> On 03/18/2012 06:12 PM, malc wrote:
> > 97161e177b4ea2730dff13c4df01475762ab6048 broke booting of a DOS image
> > i've been using for years, the VM stalls at "Booting from hard disk"
> > BIOS message never making any progress.
> 
> Can you post an image that exhibits the problem?

It's 400+MB

> 
> Also, try the attached patch.

Boots with the patch.

-- 
mailto:av1474@comtv.ru

Re: [Qemu-devel] Breakage

[Roy Tam]

2012/3/19 Avi Kivity <avi@redhat.com>:
> On 03/18/2012 06:12 PM, malc wrote:
>> 97161e177b4ea2730dff13c4df01475762ab6048 broke booting of a DOS image
>> i've been using for years, the VM stalls at "Booting from hard disk"
>> BIOS message never making any progress.
>
> Can you post an image that exhibits the problem?
>
> Also, try the attached patch.
>

Confirmed fixed for Windows XP.
But I get "*** stack smashing detected ***:  terminated" and crash
when booting BeOS 5.

> --
> error compiling committee.c: too many arguments to function
>

Re: [Qemu-devel] Breakage

[Avi Kivity]

On 03/19/2012 06:34 AM, Roy Tam wrote:
> But I get "*** stack smashing detected ***:  terminated" and crash
> when booting BeOS 5.
>

Is that a regression?  From what commit?

-- 
error compiling committee.c: too many arguments to function

Re: [Qemu-devel] Breakage

[Luiz Capitulino]

On Sun, 18 Mar 2012 20:21:45 +0400 (MSK)
malc <av1474@comtv.ru> wrote:

> On Sun, 18 Mar 2012, Avi Kivity wrote:
> 
> > On 03/18/2012 06:12 PM, malc wrote:
> > > 97161e177b4ea2730dff13c4df01475762ab6048 broke booting of a DOS image
> > > i've been using for years, the VM stalls at "Booting from hard disk"
> > > BIOS message never making any progress.
> > 
> > Can you post an image that exhibits the problem?
> 
> It's 400+MB
> 
> > 
> > Also, try the attached patch.
> 
> Boots with the patch.

I was just bisecting a problem during win95 install that seems to be
caused by the same commit. The attached patch fixes it too.

Re: [Qemu-devel] Breakage

[Roy Tam]

2012/3/19 Avi Kivity <avi@redhat.com>:
> On 03/19/2012 06:34 AM, Roy Tam wrote:
>> But I get "*** stack smashing detected ***:  terminated" and crash
>> when booting BeOS 5.
>>
>
> Is that a regression?  From what commit?

It seems to be a regression from 0.15.1.
1.0 (mingw) build fails to boot also (a fresh compile just done before
I type this message)

>
> --
> error compiling committee.c: too many arguments to function
>

Re: [Qemu-devel] Breakage

[malc]

On Tue, 18 Sep 2012, Max Filippov wrote:

> On Tue, Sep 18, 2012 at 12:15 AM, Eduardo Habkost <ehabkost@redhat.com> wrote:
> > On Mon, Sep 17, 2012 at 11:54:42PM +0400, malc wrote:
> >> On Mon, 17 Sep 2012, Anthony Liguori wrote:
> >>
> >> > malc <av1474@comtv.ru> writes:
> >> >
> >> > > Some(thing|one) broke compilation with pcspk enabled.
> >> > > Symptoms being:
> >> > >
> >> > > ../libhw32/hw/pcspk.o: In function `pcspk_io_write':
> >> > > /home/malc/x/rcs/git/qemu/hw/pcspk.c:145: undefined reference to `pit_set_gate'
> >> > > ../libhw32/hw/pcspk.o: In function `pcspk_io_read':
> >> > > /home/malc/x/rcs/git/qemu/hw/pcspk.c:130: undefined reference to `pit_get_channel_info'
> >> > > ../libhw32/hw/pcspk.o: In function `pcspk_callback':
> >> > > /home/malc/x/rcs/git/qemu/hw/pcspk.c:81: undefined reference to `pit_get_channel_info'
> >> > > collect2: ld returned 1 exit status
> >> >
> >> > Try cleaning your build directory.
> >> >
> >> > It builds fine for me.
> >> >
> >>
> >> --target-list=xtensa-softmmu --audio-card-list=pcspk
> >
> > It looks like this particular configuration never worked, since
> > xtensa-softmmu was introduced (commit cfa550c6acc6718c3f932e858366e3e1e81266d6).
> 
> Other embedded platforms (I've tried cris-softmmu, lm32-softmmu, or32-softmmu,
> sh4-softmmu) give the same result.
> 
> > Does it even make sense to have a PC-speaker on a Xtensa machine?
> > Should the machine have a i8254 PIT?
> 
> I doubt that it's meaningful for any of the mentioned _architectures_,
> definitely not for xtensa.
> 

Condensed version of long story:

I have a script that invokes QEMU's configure with tons of command line
arguments (i.e. turn on most of the audio drivers, most of the audio
cards, disable stuff i don't have or need; enable ccache and so forth), 
this script was used to configure xtensa-softmmu configure never
complained but the make later bombed in the way mentioned above.

To avoid this "surprise" result we can(should?) filter out the
cards requested by the user based on contents of audio_possible_card_list
(in a fashion similar to the one employed for driver list filtering)

-- 
mailto:av1474@comtv.ru

Re: [Qemu-devel] Breakage

[Max Filippov]

On Tue, Sep 18, 2012 at 12:15 AM, Eduardo Habkost <ehabkost@redhat.com> wrote:
> On Mon, Sep 17, 2012 at 11:54:42PM +0400, malc wrote:
>> On Mon, 17 Sep 2012, Anthony Liguori wrote:
>>
>> > malc <av1474@comtv.ru> writes:
>> >
>> > > Some(thing|one) broke compilation with pcspk enabled.
>> > > Symptoms being:
>> > >
>> > > ../libhw32/hw/pcspk.o: In function `pcspk_io_write':
>> > > /home/malc/x/rcs/git/qemu/hw/pcspk.c:145: undefined reference to `pit_set_gate'
>> > > ../libhw32/hw/pcspk.o: In function `pcspk_io_read':
>> > > /home/malc/x/rcs/git/qemu/hw/pcspk.c:130: undefined reference to `pit_get_channel_info'
>> > > ../libhw32/hw/pcspk.o: In function `pcspk_callback':
>> > > /home/malc/x/rcs/git/qemu/hw/pcspk.c:81: undefined reference to `pit_get_channel_info'
>> > > collect2: ld returned 1 exit status
>> >
>> > Try cleaning your build directory.
>> >
>> > It builds fine for me.
>> >
>>
>> --target-list=xtensa-softmmu --audio-card-list=pcspk
>
> It looks like this particular configuration never worked, since
> xtensa-softmmu was introduced (commit cfa550c6acc6718c3f932e858366e3e1e81266d6).

Other embedded platforms (I've tried cris-softmmu, lm32-softmmu, or32-softmmu,
sh4-softmmu) give the same result.

> Does it even make sense to have a PC-speaker on a Xtensa machine?
> Should the machine have a i8254 PIT?

I doubt that it's meaningful for any of the mentioned _architectures_,
definitely not for xtensa.

-- 
Thanks.
-- Max

Re: [Qemu-devel] Breakage

[Jan Kiszka]

On 2012-09-17 21:54, malc wrote:
> On Mon, 17 Sep 2012, Anthony Liguori wrote:
> 
>> malc <av1474@comtv.ru> writes:
>>
>>> Some(thing|one) broke compilation with pcspk enabled.
>>> Symptoms being:
>>>
>>> ../libhw32/hw/pcspk.o: In function `pcspk_io_write':
>>> /home/malc/x/rcs/git/qemu/hw/pcspk.c:145: undefined reference to `pit_set_gate'
>>> ../libhw32/hw/pcspk.o: In function `pcspk_io_read':
>>> /home/malc/x/rcs/git/qemu/hw/pcspk.c:130: undefined reference to `pit_get_channel_info'
>>> ../libhw32/hw/pcspk.o: In function `pcspk_callback':
>>> /home/malc/x/rcs/git/qemu/hw/pcspk.c:81: undefined reference to `pit_get_channel_info'
>>> collect2: ld returned 1 exit status
>>
>> Try cleaning your build directory.
>>
>> It builds fine for me.
>>
> 
> --target-list=xtensa-softmmu --audio-card-list=pcspk

pcspk is not supposed to be specified like this. It's automatically
built for those targets that support it.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux

Re: [Qemu-devel] Breakage

[Eduardo Habkost]

On Mon, Sep 17, 2012 at 11:54:42PM +0400, malc wrote:
> On Mon, 17 Sep 2012, Anthony Liguori wrote:
> 
> > malc <av1474@comtv.ru> writes:
> > 
> > > Some(thing|one) broke compilation with pcspk enabled.
> > > Symptoms being:
> > >
> > > ../libhw32/hw/pcspk.o: In function `pcspk_io_write':
> > > /home/malc/x/rcs/git/qemu/hw/pcspk.c:145: undefined reference to `pit_set_gate'
> > > ../libhw32/hw/pcspk.o: In function `pcspk_io_read':
> > > /home/malc/x/rcs/git/qemu/hw/pcspk.c:130: undefined reference to `pit_get_channel_info'
> > > ../libhw32/hw/pcspk.o: In function `pcspk_callback':
> > > /home/malc/x/rcs/git/qemu/hw/pcspk.c:81: undefined reference to `pit_get_channel_info'
> > > collect2: ld returned 1 exit status
> > 
> > Try cleaning your build directory.
> > 
> > It builds fine for me.
> > 
> 
> --target-list=xtensa-softmmu --audio-card-list=pcspk

It looks like this particular configuration never worked, since
xtensa-softmmu was introduced (commit cfa550c6acc6718c3f932e858366e3e1e81266d6).

Does it even make sense to have a PC-speaker on a Xtensa machine?
Should the machine have a i8254 PIT?

-- 
Eduardo

Re: [Qemu-devel] Breakage

[malc]

On Mon, 17 Sep 2012, Anthony Liguori wrote:

> malc <av1474@comtv.ru> writes:
> 
> > Some(thing|one) broke compilation with pcspk enabled.
> > Symptoms being:
> >
> > ../libhw32/hw/pcspk.o: In function `pcspk_io_write':
> > /home/malc/x/rcs/git/qemu/hw/pcspk.c:145: undefined reference to `pit_set_gate'
> > ../libhw32/hw/pcspk.o: In function `pcspk_io_read':
> > /home/malc/x/rcs/git/qemu/hw/pcspk.c:130: undefined reference to `pit_get_channel_info'
> > ../libhw32/hw/pcspk.o: In function `pcspk_callback':
> > /home/malc/x/rcs/git/qemu/hw/pcspk.c:81: undefined reference to `pit_get_channel_info'
> > collect2: ld returned 1 exit status
> 
> Try cleaning your build directory.
> 
> It builds fine for me.
> 

--target-list=xtensa-softmmu --audio-card-list=pcspk

-- 
mailto:av1474@comtv.ru

Re: [Qemu-devel] Breakage

[Anthony Liguori]

malc <av1474@comtv.ru> writes:

> Some(thing|one) broke compilation with pcspk enabled.
> Symptoms being:
>
> ../libhw32/hw/pcspk.o: In function `pcspk_io_write':
> /home/malc/x/rcs/git/qemu/hw/pcspk.c:145: undefined reference to `pit_set_gate'
> ../libhw32/hw/pcspk.o: In function `pcspk_io_read':
> /home/malc/x/rcs/git/qemu/hw/pcspk.c:130: undefined reference to `pit_get_channel_info'
> ../libhw32/hw/pcspk.o: In function `pcspk_callback':
> /home/malc/x/rcs/git/qemu/hw/pcspk.c:81: undefined reference to `pit_get_channel_info'
> collect2: ld returned 1 exit status

Try cleaning your build directory.

It builds fine for me.

Regards,

Anthony Liguori

>
> -- 
> mailto:av1474@comtv.ru

[Qemu-devel] Breakage

[malc]

Some(thing|one) broke compilation with pcspk enabled.
Symptoms being:

../libhw32/hw/pcspk.o: In function `pcspk_io_write':
/home/malc/x/rcs/git/qemu/hw/pcspk.c:145: undefined reference to `pit_set_gate'
../libhw32/hw/pcspk.o: In function `pcspk_io_read':
/home/malc/x/rcs/git/qemu/hw/pcspk.c:130: undefined reference to `pit_get_channel_info'
../libhw32/hw/pcspk.o: In function `pcspk_callback':
/home/malc/x/rcs/git/qemu/hw/pcspk.c:81: undefined reference to `pit_get_channel_info'
collect2: ld returned 1 exit status

-- 
mailto:av1474@comtv.ru

[Qemu-devel] Breakage

[malc]

a. qemu-commits does not work again
b. 4dd75c702c96ec84db4efe24fcc80a4d7bb32df2 (make pthreads mandatory)
   broke the build in cygwin

-- 
mailto:av1474@comtv.ru