All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH uq/master] kvm: Drop unused kvm_pit_in_kernel
@ 2012-03-21 12:36 ` Jan Kiszka
  0 siblings, 0 replies; 23+ messages in thread
From: Jan Kiszka @ 2012-03-21 12:36 UTC (permalink / raw)
  To: Avi Kivity, Marcelo Tosatti; +Cc: qemu-devel, kvm

This is now implied by kvm_irqchip_in_kernel.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 kvm-all.c  |    6 ------
 kvm-stub.c |    6 ------
 kvm.h      |    2 --
 3 files changed, 0 insertions(+), 14 deletions(-)

diff --git a/kvm-all.c b/kvm-all.c
index 21c7dd2..7f8c188 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -75,7 +75,6 @@ struct KVMState
 #ifdef KVM_CAP_SET_GUEST_DEBUG
     struct kvm_sw_breakpoint_head kvm_sw_breakpoints;
 #endif
-    int pit_in_kernel;
     int pit_state2;
     int xsave, xcrs;
     int many_ioeventfds;
@@ -195,11 +194,6 @@ static void kvm_reset_vcpu(void *opaque)
     kvm_arch_reset_vcpu(env);
 }
 
-int kvm_pit_in_kernel(void)
-{
-    return kvm_state->pit_in_kernel;
-}
-
 int kvm_init_vcpu(CPUState *env)
 {
     KVMState *s = kvm_state;
diff --git a/kvm-stub.c b/kvm-stub.c
index 1f1c686..fab3ab1 100644
--- a/kvm-stub.c
+++ b/kvm-stub.c
@@ -16,12 +16,6 @@
 #include "gdbstub.h"
 #include "kvm.h"
 
-int kvm_pit_in_kernel(void)
-{
-    return 0;
-}
-
-
 int kvm_init_vcpu(CPUState *env)
 {
     return -ENOSYS;
diff --git a/kvm.h b/kvm.h
index 8ef4476..128cc8f 100644
--- a/kvm.h
+++ b/kvm.h
@@ -83,8 +83,6 @@ int kvm_update_guest_debug(CPUState *env, unsigned long reinject_trap);
 int kvm_set_signal_mask(CPUState *env, const sigset_t *sigset);
 #endif
 
-int kvm_pit_in_kernel(void);
-
 int kvm_on_sigbus_vcpu(CPUState *env, int code, void *addr);
 int kvm_on_sigbus(int code, void *addr);
 
-- 
1.7.3.4

^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [Qemu-devel] [PATCH uq/master] kvm: Drop unused kvm_pit_in_kernel
@ 2012-03-21 12:36 ` Jan Kiszka
  0 siblings, 0 replies; 23+ messages in thread
From: Jan Kiszka @ 2012-03-21 12:36 UTC (permalink / raw)
  To: Avi Kivity, Marcelo Tosatti; +Cc: qemu-devel, kvm

This is now implied by kvm_irqchip_in_kernel.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 kvm-all.c  |    6 ------
 kvm-stub.c |    6 ------
 kvm.h      |    2 --
 3 files changed, 0 insertions(+), 14 deletions(-)

diff --git a/kvm-all.c b/kvm-all.c
index 21c7dd2..7f8c188 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -75,7 +75,6 @@ struct KVMState
 #ifdef KVM_CAP_SET_GUEST_DEBUG
     struct kvm_sw_breakpoint_head kvm_sw_breakpoints;
 #endif
-    int pit_in_kernel;
     int pit_state2;
     int xsave, xcrs;
     int many_ioeventfds;
@@ -195,11 +194,6 @@ static void kvm_reset_vcpu(void *opaque)
     kvm_arch_reset_vcpu(env);
 }
 
-int kvm_pit_in_kernel(void)
-{
-    return kvm_state->pit_in_kernel;
-}
-
 int kvm_init_vcpu(CPUState *env)
 {
     KVMState *s = kvm_state;
diff --git a/kvm-stub.c b/kvm-stub.c
index 1f1c686..fab3ab1 100644
--- a/kvm-stub.c
+++ b/kvm-stub.c
@@ -16,12 +16,6 @@
 #include "gdbstub.h"
 #include "kvm.h"
 
-int kvm_pit_in_kernel(void)
-{
-    return 0;
-}
-
-
 int kvm_init_vcpu(CPUState *env)
 {
     return -ENOSYS;
diff --git a/kvm.h b/kvm.h
index 8ef4476..128cc8f 100644
--- a/kvm.h
+++ b/kvm.h
@@ -83,8 +83,6 @@ int kvm_update_guest_debug(CPUState *env, unsigned long reinject_trap);
 int kvm_set_signal_mask(CPUState *env, const sigset_t *sigset);
 #endif
 
-int kvm_pit_in_kernel(void);
-
 int kvm_on_sigbus_vcpu(CPUState *env, int code, void *addr);
 int kvm_on_sigbus(int code, void *addr);
 
-- 
1.7.3.4

^ permalink raw reply related	[flat|nested] 23+ messages in thread

* Re: [PATCH uq/master] kvm: Drop unused kvm_pit_in_kernel
  2012-03-21 12:36 ` [Qemu-devel] " Jan Kiszka
@ 2012-03-21 13:36   ` Avi Kivity
  -1 siblings, 0 replies; 23+ messages in thread
From: Avi Kivity @ 2012-03-21 13:36 UTC (permalink / raw)
  To: Jan Kiszka; +Cc: Marcelo Tosatti, kvm, qemu-devel

On 03/21/2012 02:36 PM, Jan Kiszka wrote:
> This is now implied by kvm_irqchip_in_kernel.
>
>

So we can't have -no-kvm-pit?

No huge loss, but unexpected.

-- 
error compiling committee.c: too many arguments to function


^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [Qemu-devel] [PATCH uq/master] kvm: Drop unused kvm_pit_in_kernel
@ 2012-03-21 13:36   ` Avi Kivity
  0 siblings, 0 replies; 23+ messages in thread
From: Avi Kivity @ 2012-03-21 13:36 UTC (permalink / raw)
  To: Jan Kiszka; +Cc: Marcelo Tosatti, qemu-devel, kvm

On 03/21/2012 02:36 PM, Jan Kiszka wrote:
> This is now implied by kvm_irqchip_in_kernel.
>
>

So we can't have -no-kvm-pit?

No huge loss, but unexpected.

-- 
error compiling committee.c: too many arguments to function

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH uq/master] kvm: Drop unused kvm_pit_in_kernel
  2012-03-21 13:36   ` [Qemu-devel] " Avi Kivity
@ 2012-03-21 13:39     ` Jan Kiszka
  -1 siblings, 0 replies; 23+ messages in thread
From: Jan Kiszka @ 2012-03-21 13:39 UTC (permalink / raw)
  To: Avi Kivity; +Cc: Marcelo Tosatti, kvm, qemu-devel

On 2012-03-21 14:36, Avi Kivity wrote:
> On 03/21/2012 02:36 PM, Jan Kiszka wrote:
>> This is now implied by kvm_irqchip_in_kernel.
>>
>>
> 
> So we can't have -no-kvm-pit?
> 
> No huge loss, but unexpected.

See e81dda195556e72f8cd294998296c1051aab30a8.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [Qemu-devel] [PATCH uq/master] kvm: Drop unused kvm_pit_in_kernel
@ 2012-03-21 13:39     ` Jan Kiszka
  0 siblings, 0 replies; 23+ messages in thread
From: Jan Kiszka @ 2012-03-21 13:39 UTC (permalink / raw)
  To: Avi Kivity; +Cc: Marcelo Tosatti, qemu-devel, kvm

On 2012-03-21 14:36, Avi Kivity wrote:
> On 03/21/2012 02:36 PM, Jan Kiszka wrote:
>> This is now implied by kvm_irqchip_in_kernel.
>>
>>
> 
> So we can't have -no-kvm-pit?
> 
> No huge loss, but unexpected.

See e81dda195556e72f8cd294998296c1051aab30a8.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH uq/master] kvm: Drop unused kvm_pit_in_kernel
  2012-03-21 13:39     ` [Qemu-devel] " Jan Kiszka
@ 2012-03-21 13:41       ` Gleb Natapov
  -1 siblings, 0 replies; 23+ messages in thread
From: Gleb Natapov @ 2012-03-21 13:41 UTC (permalink / raw)
  To: Jan Kiszka; +Cc: Avi Kivity, Marcelo Tosatti, kvm, qemu-devel

On Wed, Mar 21, 2012 at 02:39:47PM +0100, Jan Kiszka wrote:
> On 2012-03-21 14:36, Avi Kivity wrote:
> > On 03/21/2012 02:36 PM, Jan Kiszka wrote:
> >> This is now implied by kvm_irqchip_in_kernel.
> >>
> >>
> > 
> > So we can't have -no-kvm-pit?
> > 
> > No huge loss, but unexpected.
> 
> See e81dda195556e72f8cd294998296c1051aab30a8.
> 
I am curious what is the reason for upstream to not supporting disabling the
in-kernel PIT separately?

--
			Gleb.

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [Qemu-devel] [PATCH uq/master] kvm: Drop unused kvm_pit_in_kernel
@ 2012-03-21 13:41       ` Gleb Natapov
  0 siblings, 0 replies; 23+ messages in thread
From: Gleb Natapov @ 2012-03-21 13:41 UTC (permalink / raw)
  To: Jan Kiszka; +Cc: Marcelo Tosatti, Avi Kivity, kvm, qemu-devel

On Wed, Mar 21, 2012 at 02:39:47PM +0100, Jan Kiszka wrote:
> On 2012-03-21 14:36, Avi Kivity wrote:
> > On 03/21/2012 02:36 PM, Jan Kiszka wrote:
> >> This is now implied by kvm_irqchip_in_kernel.
> >>
> >>
> > 
> > So we can't have -no-kvm-pit?
> > 
> > No huge loss, but unexpected.
> 
> See e81dda195556e72f8cd294998296c1051aab30a8.
> 
I am curious what is the reason for upstream to not supporting disabling the
in-kernel PIT separately?

--
			Gleb.

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH uq/master] kvm: Drop unused kvm_pit_in_kernel
  2012-03-21 13:41       ` [Qemu-devel] " Gleb Natapov
@ 2012-03-21 13:49         ` Jan Kiszka
  -1 siblings, 0 replies; 23+ messages in thread
From: Jan Kiszka @ 2012-03-21 13:49 UTC (permalink / raw)
  To: Gleb Natapov; +Cc: Avi Kivity, Marcelo Tosatti, kvm, qemu-devel

On 2012-03-21 14:41, Gleb Natapov wrote:
> On Wed, Mar 21, 2012 at 02:39:47PM +0100, Jan Kiszka wrote:
>> On 2012-03-21 14:36, Avi Kivity wrote:
>>> On 03/21/2012 02:36 PM, Jan Kiszka wrote:
>>>> This is now implied by kvm_irqchip_in_kernel.
>>>>
>>>>
>>>
>>> So we can't have -no-kvm-pit?
>>>
>>> No huge loss, but unexpected.
>>
>> See e81dda195556e72f8cd294998296c1051aab30a8.
>>
> I am curious what is the reason for upstream to not supporting disabling the
> in-kernel PIT separately?

It was considered no longer relevant:
http://thread.gmane.org/gmane.comp.emulators.kvm.devel/85393

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [Qemu-devel] [PATCH uq/master] kvm: Drop unused kvm_pit_in_kernel
@ 2012-03-21 13:49         ` Jan Kiszka
  0 siblings, 0 replies; 23+ messages in thread
From: Jan Kiszka @ 2012-03-21 13:49 UTC (permalink / raw)
  To: Gleb Natapov; +Cc: Marcelo Tosatti, Avi Kivity, kvm, qemu-devel

On 2012-03-21 14:41, Gleb Natapov wrote:
> On Wed, Mar 21, 2012 at 02:39:47PM +0100, Jan Kiszka wrote:
>> On 2012-03-21 14:36, Avi Kivity wrote:
>>> On 03/21/2012 02:36 PM, Jan Kiszka wrote:
>>>> This is now implied by kvm_irqchip_in_kernel.
>>>>
>>>>
>>>
>>> So we can't have -no-kvm-pit?
>>>
>>> No huge loss, but unexpected.
>>
>> See e81dda195556e72f8cd294998296c1051aab30a8.
>>
> I am curious what is the reason for upstream to not supporting disabling the
> in-kernel PIT separately?

It was considered no longer relevant:
http://thread.gmane.org/gmane.comp.emulators.kvm.devel/85393

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH v2 uq/master] kvm: Drop unused kvm_pit_in_kernel
  2012-03-21 12:36 ` [Qemu-devel] " Jan Kiszka
@ 2012-03-21 23:00   ` Jan Kiszka
  -1 siblings, 0 replies; 23+ messages in thread
From: Jan Kiszka @ 2012-03-21 23:00 UTC (permalink / raw)
  To: Avi Kivity, Marcelo Tosatti; +Cc: qemu-devel, kvm

From: Jan Kiszka <jan.kiszka@siemens.com>

This is now implied by kvm_irqchip_in_kernel.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---

Rebased over latest uq/master.

 kvm-all.c  |    6 ------
 kvm-stub.c |    6 ------
 kvm.h      |    2 --
 3 files changed, 0 insertions(+), 14 deletions(-)

diff --git a/kvm-all.c b/kvm-all.c
index ba2cee1..3a1fa40 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -75,7 +75,6 @@ struct KVMState
 #ifdef KVM_CAP_SET_GUEST_DEBUG
     struct kvm_sw_breakpoint_head kvm_sw_breakpoints;
 #endif
-    int pit_in_kernel;
     int pit_state2;
     int xsave, xcrs;
     int many_ioeventfds;
@@ -198,11 +197,6 @@ static void kvm_reset_vcpu(void *opaque)
     kvm_arch_reset_vcpu(env);
 }
 
-int kvm_pit_in_kernel(void)
-{
-    return kvm_state->pit_in_kernel;
-}
-
 int kvm_init_vcpu(CPUArchState *env)
 {
     KVMState *s = kvm_state;
diff --git a/kvm-stub.c b/kvm-stub.c
index 69a1228..ec8fe74 100644
--- a/kvm-stub.c
+++ b/kvm-stub.c
@@ -16,12 +16,6 @@
 #include "gdbstub.h"
 #include "kvm.h"
 
-int kvm_pit_in_kernel(void)
-{
-    return 0;
-}
-
-
 int kvm_init_vcpu(CPUArchState *env)
 {
     return -ENOSYS;
diff --git a/kvm.h b/kvm.h
index 330f17b..55f107d 100644
--- a/kvm.h
+++ b/kvm.h
@@ -83,8 +83,6 @@ int kvm_update_guest_debug(CPUArchState *env, unsigned long reinject_trap);
 int kvm_set_signal_mask(CPUArchState *env, const sigset_t *sigset);
 #endif
 
-int kvm_pit_in_kernel(void);
-
 int kvm_on_sigbus_vcpu(CPUArchState *env, int code, void *addr);
 int kvm_on_sigbus(int code, void *addr);
 

^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [Qemu-devel] [PATCH v2 uq/master] kvm: Drop unused kvm_pit_in_kernel
@ 2012-03-21 23:00   ` Jan Kiszka
  0 siblings, 0 replies; 23+ messages in thread
From: Jan Kiszka @ 2012-03-21 23:00 UTC (permalink / raw)
  To: Avi Kivity, Marcelo Tosatti; +Cc: qemu-devel, kvm

From: Jan Kiszka <jan.kiszka@siemens.com>

This is now implied by kvm_irqchip_in_kernel.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---

Rebased over latest uq/master.

 kvm-all.c  |    6 ------
 kvm-stub.c |    6 ------
 kvm.h      |    2 --
 3 files changed, 0 insertions(+), 14 deletions(-)

diff --git a/kvm-all.c b/kvm-all.c
index ba2cee1..3a1fa40 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -75,7 +75,6 @@ struct KVMState
 #ifdef KVM_CAP_SET_GUEST_DEBUG
     struct kvm_sw_breakpoint_head kvm_sw_breakpoints;
 #endif
-    int pit_in_kernel;
     int pit_state2;
     int xsave, xcrs;
     int many_ioeventfds;
@@ -198,11 +197,6 @@ static void kvm_reset_vcpu(void *opaque)
     kvm_arch_reset_vcpu(env);
 }
 
-int kvm_pit_in_kernel(void)
-{
-    return kvm_state->pit_in_kernel;
-}
-
 int kvm_init_vcpu(CPUArchState *env)
 {
     KVMState *s = kvm_state;
diff --git a/kvm-stub.c b/kvm-stub.c
index 69a1228..ec8fe74 100644
--- a/kvm-stub.c
+++ b/kvm-stub.c
@@ -16,12 +16,6 @@
 #include "gdbstub.h"
 #include "kvm.h"
 
-int kvm_pit_in_kernel(void)
-{
-    return 0;
-}
-
-
 int kvm_init_vcpu(CPUArchState *env)
 {
     return -ENOSYS;
diff --git a/kvm.h b/kvm.h
index 330f17b..55f107d 100644
--- a/kvm.h
+++ b/kvm.h
@@ -83,8 +83,6 @@ int kvm_update_guest_debug(CPUArchState *env, unsigned long reinject_trap);
 int kvm_set_signal_mask(CPUArchState *env, const sigset_t *sigset);
 #endif
 
-int kvm_pit_in_kernel(void);
-
 int kvm_on_sigbus_vcpu(CPUArchState *env, int code, void *addr);
 int kvm_on_sigbus(int code, void *addr);
 

^ permalink raw reply related	[flat|nested] 23+ messages in thread

* Re: [PATCH uq/master] kvm: Drop unused kvm_pit_in_kernel
  2012-03-21 13:49         ` [Qemu-devel] " Jan Kiszka
@ 2012-03-22  7:18           ` Gleb Natapov
  -1 siblings, 0 replies; 23+ messages in thread
From: Gleb Natapov @ 2012-03-22  7:18 UTC (permalink / raw)
  To: Jan Kiszka; +Cc: Avi Kivity, Marcelo Tosatti, kvm, qemu-devel

On Wed, Mar 21, 2012 at 02:49:09PM +0100, Jan Kiszka wrote:
> On 2012-03-21 14:41, Gleb Natapov wrote:
> > On Wed, Mar 21, 2012 at 02:39:47PM +0100, Jan Kiszka wrote:
> >> On 2012-03-21 14:36, Avi Kivity wrote:
> >>> On 03/21/2012 02:36 PM, Jan Kiszka wrote:
> >>>> This is now implied by kvm_irqchip_in_kernel.
> >>>>
> >>>>
> >>>
> >>> So we can't have -no-kvm-pit?
> >>>
> >>> No huge loss, but unexpected.
> >>
> >> See e81dda195556e72f8cd294998296c1051aab30a8.
> >>
> > I am curious what is the reason for upstream to not supporting disabling the
> > in-kernel PIT separately?
> 
> It was considered no longer relevant:
> http://thread.gmane.org/gmane.comp.emulators.kvm.devel/85393
> 
Hmm, may be we should think about this some more. If in the (not so far)
future we want to drop pit emulation from the kernel we may want to support
-no-kvm-pit to allow migration from old kernels to new one.

--
			Gleb.

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [Qemu-devel] [PATCH uq/master] kvm: Drop unused kvm_pit_in_kernel
@ 2012-03-22  7:18           ` Gleb Natapov
  0 siblings, 0 replies; 23+ messages in thread
From: Gleb Natapov @ 2012-03-22  7:18 UTC (permalink / raw)
  To: Jan Kiszka; +Cc: Marcelo Tosatti, Avi Kivity, kvm, qemu-devel

On Wed, Mar 21, 2012 at 02:49:09PM +0100, Jan Kiszka wrote:
> On 2012-03-21 14:41, Gleb Natapov wrote:
> > On Wed, Mar 21, 2012 at 02:39:47PM +0100, Jan Kiszka wrote:
> >> On 2012-03-21 14:36, Avi Kivity wrote:
> >>> On 03/21/2012 02:36 PM, Jan Kiszka wrote:
> >>>> This is now implied by kvm_irqchip_in_kernel.
> >>>>
> >>>>
> >>>
> >>> So we can't have -no-kvm-pit?
> >>>
> >>> No huge loss, but unexpected.
> >>
> >> See e81dda195556e72f8cd294998296c1051aab30a8.
> >>
> > I am curious what is the reason for upstream to not supporting disabling the
> > in-kernel PIT separately?
> 
> It was considered no longer relevant:
> http://thread.gmane.org/gmane.comp.emulators.kvm.devel/85393
> 
Hmm, may be we should think about this some more. If in the (not so far)
future we want to drop pit emulation from the kernel we may want to support
-no-kvm-pit to allow migration from old kernels to new one.

--
			Gleb.

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH uq/master] kvm: Drop unused kvm_pit_in_kernel
  2012-03-22  7:18           ` [Qemu-devel] " Gleb Natapov
@ 2012-03-22 12:41             ` Jan Kiszka
  -1 siblings, 0 replies; 23+ messages in thread
From: Jan Kiszka @ 2012-03-22 12:41 UTC (permalink / raw)
  To: Gleb Natapov; +Cc: Avi Kivity, Marcelo Tosatti, kvm, qemu-devel

On 2012-03-22 08:18, Gleb Natapov wrote:
> On Wed, Mar 21, 2012 at 02:49:09PM +0100, Jan Kiszka wrote:
>> On 2012-03-21 14:41, Gleb Natapov wrote:
>>> On Wed, Mar 21, 2012 at 02:39:47PM +0100, Jan Kiszka wrote:
>>>> On 2012-03-21 14:36, Avi Kivity wrote:
>>>>> On 03/21/2012 02:36 PM, Jan Kiszka wrote:
>>>>>> This is now implied by kvm_irqchip_in_kernel.
>>>>>>
>>>>>>
>>>>>
>>>>> So we can't have -no-kvm-pit?
>>>>>
>>>>> No huge loss, but unexpected.
>>>>
>>>> See e81dda195556e72f8cd294998296c1051aab30a8.
>>>>
>>> I am curious what is the reason for upstream to not supporting disabling the
>>> in-kernel PIT separately?
>>
>> It was considered no longer relevant:
>> http://thread.gmane.org/gmane.comp.emulators.kvm.devel/85393
>>
> Hmm, may be we should think about this some more. If in the (not so far)
> future we want to drop pit emulation from the kernel we may want to support
> -no-kvm-pit to allow migration from old kernels to new one.

That's not an issue. Both device models are compatible, and you can
migrate between kernel_irqchip=on/off theses days with QEMU.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [Qemu-devel] [PATCH uq/master] kvm: Drop unused kvm_pit_in_kernel
@ 2012-03-22 12:41             ` Jan Kiszka
  0 siblings, 0 replies; 23+ messages in thread
From: Jan Kiszka @ 2012-03-22 12:41 UTC (permalink / raw)
  To: Gleb Natapov; +Cc: Marcelo Tosatti, Avi Kivity, kvm, qemu-devel

On 2012-03-22 08:18, Gleb Natapov wrote:
> On Wed, Mar 21, 2012 at 02:49:09PM +0100, Jan Kiszka wrote:
>> On 2012-03-21 14:41, Gleb Natapov wrote:
>>> On Wed, Mar 21, 2012 at 02:39:47PM +0100, Jan Kiszka wrote:
>>>> On 2012-03-21 14:36, Avi Kivity wrote:
>>>>> On 03/21/2012 02:36 PM, Jan Kiszka wrote:
>>>>>> This is now implied by kvm_irqchip_in_kernel.
>>>>>>
>>>>>>
>>>>>
>>>>> So we can't have -no-kvm-pit?
>>>>>
>>>>> No huge loss, but unexpected.
>>>>
>>>> See e81dda195556e72f8cd294998296c1051aab30a8.
>>>>
>>> I am curious what is the reason for upstream to not supporting disabling the
>>> in-kernel PIT separately?
>>
>> It was considered no longer relevant:
>> http://thread.gmane.org/gmane.comp.emulators.kvm.devel/85393
>>
> Hmm, may be we should think about this some more. If in the (not so far)
> future we want to drop pit emulation from the kernel we may want to support
> -no-kvm-pit to allow migration from old kernels to new one.

That's not an issue. Both device models are compatible, and you can
migrate between kernel_irqchip=on/off theses days with QEMU.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH uq/master] kvm: Drop unused kvm_pit_in_kernel
  2012-03-22 12:41             ` [Qemu-devel] " Jan Kiszka
@ 2012-03-22 12:52               ` Gleb Natapov
  -1 siblings, 0 replies; 23+ messages in thread
From: Gleb Natapov @ 2012-03-22 12:52 UTC (permalink / raw)
  To: Jan Kiszka; +Cc: Avi Kivity, Marcelo Tosatti, kvm, qemu-devel

On Thu, Mar 22, 2012 at 01:41:18PM +0100, Jan Kiszka wrote:
> On 2012-03-22 08:18, Gleb Natapov wrote:
> > On Wed, Mar 21, 2012 at 02:49:09PM +0100, Jan Kiszka wrote:
> >> On 2012-03-21 14:41, Gleb Natapov wrote:
> >>> On Wed, Mar 21, 2012 at 02:39:47PM +0100, Jan Kiszka wrote:
> >>>> On 2012-03-21 14:36, Avi Kivity wrote:
> >>>>> On 03/21/2012 02:36 PM, Jan Kiszka wrote:
> >>>>>> This is now implied by kvm_irqchip_in_kernel.
> >>>>>>
> >>>>>>
> >>>>>
> >>>>> So we can't have -no-kvm-pit?
> >>>>>
> >>>>> No huge loss, but unexpected.
> >>>>
> >>>> See e81dda195556e72f8cd294998296c1051aab30a8.
> >>>>
> >>> I am curious what is the reason for upstream to not supporting disabling the
> >>> in-kernel PIT separately?
> >>
> >> It was considered no longer relevant:
> >> http://thread.gmane.org/gmane.comp.emulators.kvm.devel/85393
> >>
> > Hmm, may be we should think about this some more. If in the (not so far)
> > future we want to drop pit emulation from the kernel we may want to support
> > -no-kvm-pit to allow migration from old kernels to new one.
> 
> That's not an issue. Both device models are compatible, and you can
> migrate between kernel_irqchip=on/off theses days with QEMU.
> 
Cool. Including PIT lost tick compensation?

--
			Gleb.

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [Qemu-devel] [PATCH uq/master] kvm: Drop unused kvm_pit_in_kernel
@ 2012-03-22 12:52               ` Gleb Natapov
  0 siblings, 0 replies; 23+ messages in thread
From: Gleb Natapov @ 2012-03-22 12:52 UTC (permalink / raw)
  To: Jan Kiszka; +Cc: Marcelo Tosatti, Avi Kivity, kvm, qemu-devel

On Thu, Mar 22, 2012 at 01:41:18PM +0100, Jan Kiszka wrote:
> On 2012-03-22 08:18, Gleb Natapov wrote:
> > On Wed, Mar 21, 2012 at 02:49:09PM +0100, Jan Kiszka wrote:
> >> On 2012-03-21 14:41, Gleb Natapov wrote:
> >>> On Wed, Mar 21, 2012 at 02:39:47PM +0100, Jan Kiszka wrote:
> >>>> On 2012-03-21 14:36, Avi Kivity wrote:
> >>>>> On 03/21/2012 02:36 PM, Jan Kiszka wrote:
> >>>>>> This is now implied by kvm_irqchip_in_kernel.
> >>>>>>
> >>>>>>
> >>>>>
> >>>>> So we can't have -no-kvm-pit?
> >>>>>
> >>>>> No huge loss, but unexpected.
> >>>>
> >>>> See e81dda195556e72f8cd294998296c1051aab30a8.
> >>>>
> >>> I am curious what is the reason for upstream to not supporting disabling the
> >>> in-kernel PIT separately?
> >>
> >> It was considered no longer relevant:
> >> http://thread.gmane.org/gmane.comp.emulators.kvm.devel/85393
> >>
> > Hmm, may be we should think about this some more. If in the (not so far)
> > future we want to drop pit emulation from the kernel we may want to support
> > -no-kvm-pit to allow migration from old kernels to new one.
> 
> That's not an issue. Both device models are compatible, and you can
> migrate between kernel_irqchip=on/off theses days with QEMU.
> 
Cool. Including PIT lost tick compensation?

--
			Gleb.

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH uq/master] kvm: Drop unused kvm_pit_in_kernel
  2012-03-22 12:52               ` [Qemu-devel] " Gleb Natapov
@ 2012-03-22 13:27                 ` Jan Kiszka
  -1 siblings, 0 replies; 23+ messages in thread
From: Jan Kiszka @ 2012-03-22 13:27 UTC (permalink / raw)
  To: Gleb Natapov; +Cc: Avi Kivity, Marcelo Tosatti, kvm, qemu-devel

On 2012-03-22 13:52, Gleb Natapov wrote:
> On Thu, Mar 22, 2012 at 01:41:18PM +0100, Jan Kiszka wrote:
>> On 2012-03-22 08:18, Gleb Natapov wrote:
>>> On Wed, Mar 21, 2012 at 02:49:09PM +0100, Jan Kiszka wrote:
>>>> On 2012-03-21 14:41, Gleb Natapov wrote:
>>>>> On Wed, Mar 21, 2012 at 02:39:47PM +0100, Jan Kiszka wrote:
>>>>>> On 2012-03-21 14:36, Avi Kivity wrote:
>>>>>>> On 03/21/2012 02:36 PM, Jan Kiszka wrote:
>>>>>>>> This is now implied by kvm_irqchip_in_kernel.
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>> So we can't have -no-kvm-pit?
>>>>>>>
>>>>>>> No huge loss, but unexpected.
>>>>>>
>>>>>> See e81dda195556e72f8cd294998296c1051aab30a8.
>>>>>>
>>>>> I am curious what is the reason for upstream to not supporting disabling the
>>>>> in-kernel PIT separately?
>>>>
>>>> It was considered no longer relevant:
>>>> http://thread.gmane.org/gmane.comp.emulators.kvm.devel/85393
>>>>
>>> Hmm, may be we should think about this some more. If in the (not so far)
>>> future we want to drop pit emulation from the kernel we may want to support
>>> -no-kvm-pit to allow migration from old kernels to new one.
>>
>> That's not an issue. Both device models are compatible, and you can
>> migrate between kernel_irqchip=on/off theses days with QEMU.
>>
> Cool. Including PIT lost tick compensation?

The feature is not yet available for the userspace PIT (we only support
tick compensation for the userspace RTC - IIRC). Requires better IRQ
injection feedback, you likely remember. ;)

Also, I wonder if the kernel exports all tick-compensation related
states for save/restore. Need to check again...

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [Qemu-devel] [PATCH uq/master] kvm: Drop unused kvm_pit_in_kernel
@ 2012-03-22 13:27                 ` Jan Kiszka
  0 siblings, 0 replies; 23+ messages in thread
From: Jan Kiszka @ 2012-03-22 13:27 UTC (permalink / raw)
  To: Gleb Natapov; +Cc: Marcelo Tosatti, Avi Kivity, kvm, qemu-devel

On 2012-03-22 13:52, Gleb Natapov wrote:
> On Thu, Mar 22, 2012 at 01:41:18PM +0100, Jan Kiszka wrote:
>> On 2012-03-22 08:18, Gleb Natapov wrote:
>>> On Wed, Mar 21, 2012 at 02:49:09PM +0100, Jan Kiszka wrote:
>>>> On 2012-03-21 14:41, Gleb Natapov wrote:
>>>>> On Wed, Mar 21, 2012 at 02:39:47PM +0100, Jan Kiszka wrote:
>>>>>> On 2012-03-21 14:36, Avi Kivity wrote:
>>>>>>> On 03/21/2012 02:36 PM, Jan Kiszka wrote:
>>>>>>>> This is now implied by kvm_irqchip_in_kernel.
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>> So we can't have -no-kvm-pit?
>>>>>>>
>>>>>>> No huge loss, but unexpected.
>>>>>>
>>>>>> See e81dda195556e72f8cd294998296c1051aab30a8.
>>>>>>
>>>>> I am curious what is the reason for upstream to not supporting disabling the
>>>>> in-kernel PIT separately?
>>>>
>>>> It was considered no longer relevant:
>>>> http://thread.gmane.org/gmane.comp.emulators.kvm.devel/85393
>>>>
>>> Hmm, may be we should think about this some more. If in the (not so far)
>>> future we want to drop pit emulation from the kernel we may want to support
>>> -no-kvm-pit to allow migration from old kernels to new one.
>>
>> That's not an issue. Both device models are compatible, and you can
>> migrate between kernel_irqchip=on/off theses days with QEMU.
>>
> Cool. Including PIT lost tick compensation?

The feature is not yet available for the userspace PIT (we only support
tick compensation for the userspace RTC - IIRC). Requires better IRQ
injection feedback, you likely remember. ;)

Also, I wonder if the kernel exports all tick-compensation related
states for save/restore. Need to check again...

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH uq/master] kvm: Drop unused kvm_pit_in_kernel
  2012-03-22 13:27                 ` [Qemu-devel] " Jan Kiszka
@ 2012-03-27 10:48                   ` Gleb Natapov
  -1 siblings, 0 replies; 23+ messages in thread
From: Gleb Natapov @ 2012-03-27 10:48 UTC (permalink / raw)
  To: Jan Kiszka; +Cc: Marcelo Tosatti, Avi Kivity, kvm, qemu-devel

On Thu, Mar 22, 2012 at 02:27:37PM +0100, Jan Kiszka wrote:
> On 2012-03-22 13:52, Gleb Natapov wrote:
> > On Thu, Mar 22, 2012 at 01:41:18PM +0100, Jan Kiszka wrote:
> >> On 2012-03-22 08:18, Gleb Natapov wrote:
> >>> On Wed, Mar 21, 2012 at 02:49:09PM +0100, Jan Kiszka wrote:
> >>>> On 2012-03-21 14:41, Gleb Natapov wrote:
> >>>>> On Wed, Mar 21, 2012 at 02:39:47PM +0100, Jan Kiszka wrote:
> >>>>>> On 2012-03-21 14:36, Avi Kivity wrote:
> >>>>>>> On 03/21/2012 02:36 PM, Jan Kiszka wrote:
> >>>>>>>> This is now implied by kvm_irqchip_in_kernel.
> >>>>>>>>
> >>>>>>>>
> >>>>>>>
> >>>>>>> So we can't have -no-kvm-pit?
> >>>>>>>
> >>>>>>> No huge loss, but unexpected.
> >>>>>>
> >>>>>> See e81dda195556e72f8cd294998296c1051aab30a8.
> >>>>>>
> >>>>> I am curious what is the reason for upstream to not supporting disabling the
> >>>>> in-kernel PIT separately?
> >>>>
> >>>> It was considered no longer relevant:
> >>>> http://thread.gmane.org/gmane.comp.emulators.kvm.devel/85393
> >>>>
> >>> Hmm, may be we should think about this some more. If in the (not so far)
> >>> future we want to drop pit emulation from the kernel we may want to support
> >>> -no-kvm-pit to allow migration from old kernels to new one.
> >>
> >> That's not an issue. Both device models are compatible, and you can
> >> migrate between kernel_irqchip=on/off theses days with QEMU.
> >>
> > Cool. Including PIT lost tick compensation?
> 
> The feature is not yet available for the userspace PIT (we only support
> tick compensation for the userspace RTC - IIRC). Requires better IRQ
> injection feedback, you likely remember. ;)
> 
Unfortunately I do, no matter how hard I try to forget :)

> Also, I wonder if the kernel exports all tick-compensation related
> states for save/restore. Need to check again...
> 
Looks like it does not.

--
			Gleb.

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [Qemu-devel] [PATCH uq/master] kvm: Drop unused kvm_pit_in_kernel
@ 2012-03-27 10:48                   ` Gleb Natapov
  0 siblings, 0 replies; 23+ messages in thread
From: Gleb Natapov @ 2012-03-27 10:48 UTC (permalink / raw)
  To: Jan Kiszka; +Cc: Marcelo Tosatti, Avi Kivity, kvm, qemu-devel

On Thu, Mar 22, 2012 at 02:27:37PM +0100, Jan Kiszka wrote:
> On 2012-03-22 13:52, Gleb Natapov wrote:
> > On Thu, Mar 22, 2012 at 01:41:18PM +0100, Jan Kiszka wrote:
> >> On 2012-03-22 08:18, Gleb Natapov wrote:
> >>> On Wed, Mar 21, 2012 at 02:49:09PM +0100, Jan Kiszka wrote:
> >>>> On 2012-03-21 14:41, Gleb Natapov wrote:
> >>>>> On Wed, Mar 21, 2012 at 02:39:47PM +0100, Jan Kiszka wrote:
> >>>>>> On 2012-03-21 14:36, Avi Kivity wrote:
> >>>>>>> On 03/21/2012 02:36 PM, Jan Kiszka wrote:
> >>>>>>>> This is now implied by kvm_irqchip_in_kernel.
> >>>>>>>>
> >>>>>>>>
> >>>>>>>
> >>>>>>> So we can't have -no-kvm-pit?
> >>>>>>>
> >>>>>>> No huge loss, but unexpected.
> >>>>>>
> >>>>>> See e81dda195556e72f8cd294998296c1051aab30a8.
> >>>>>>
> >>>>> I am curious what is the reason for upstream to not supporting disabling the
> >>>>> in-kernel PIT separately?
> >>>>
> >>>> It was considered no longer relevant:
> >>>> http://thread.gmane.org/gmane.comp.emulators.kvm.devel/85393
> >>>>
> >>> Hmm, may be we should think about this some more. If in the (not so far)
> >>> future we want to drop pit emulation from the kernel we may want to support
> >>> -no-kvm-pit to allow migration from old kernels to new one.
> >>
> >> That's not an issue. Both device models are compatible, and you can
> >> migrate between kernel_irqchip=on/off theses days with QEMU.
> >>
> > Cool. Including PIT lost tick compensation?
> 
> The feature is not yet available for the userspace PIT (we only support
> tick compensation for the userspace RTC - IIRC). Requires better IRQ
> injection feedback, you likely remember. ;)
> 
Unfortunately I do, no matter how hard I try to forget :)

> Also, I wonder if the kernel exports all tick-compensation related
> states for save/restore. Need to check again...
> 
Looks like it does not.

--
			Gleb.

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH v2 uq/master] kvm: Drop unused kvm_pit_in_kernel
  2012-03-21 23:00   ` [Qemu-devel] " Jan Kiszka
  (?)
@ 2012-04-11  1:33   ` Marcelo Tosatti
  -1 siblings, 0 replies; 23+ messages in thread
From: Marcelo Tosatti @ 2012-04-11  1:33 UTC (permalink / raw)
  To: Jan Kiszka; +Cc: Avi Kivity, qemu-devel, kvm

On Thu, Mar 22, 2012 at 12:00:48AM +0100, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> This is now implied by kvm_irqchip_in_kernel.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> 
> Rebased over latest uq/master.
> 
>  kvm-all.c  |    6 ------
>  kvm-stub.c |    6 ------
>  kvm.h      |    2 --
>  3 files changed, 0 insertions(+), 14 deletions(-)

Applied, thanks.


^ permalink raw reply	[flat|nested] 23+ messages in thread

end of thread, other threads:[~2012-04-11  1:38 UTC | newest]

Thread overview: 23+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-21 12:36 [PATCH uq/master] kvm: Drop unused kvm_pit_in_kernel Jan Kiszka
2012-03-21 12:36 ` [Qemu-devel] " Jan Kiszka
2012-03-21 13:36 ` Avi Kivity
2012-03-21 13:36   ` [Qemu-devel] " Avi Kivity
2012-03-21 13:39   ` Jan Kiszka
2012-03-21 13:39     ` [Qemu-devel] " Jan Kiszka
2012-03-21 13:41     ` Gleb Natapov
2012-03-21 13:41       ` [Qemu-devel] " Gleb Natapov
2012-03-21 13:49       ` Jan Kiszka
2012-03-21 13:49         ` [Qemu-devel] " Jan Kiszka
2012-03-22  7:18         ` Gleb Natapov
2012-03-22  7:18           ` [Qemu-devel] " Gleb Natapov
2012-03-22 12:41           ` Jan Kiszka
2012-03-22 12:41             ` [Qemu-devel] " Jan Kiszka
2012-03-22 12:52             ` Gleb Natapov
2012-03-22 12:52               ` [Qemu-devel] " Gleb Natapov
2012-03-22 13:27               ` Jan Kiszka
2012-03-22 13:27                 ` [Qemu-devel] " Jan Kiszka
2012-03-27 10:48                 ` Gleb Natapov
2012-03-27 10:48                   ` [Qemu-devel] " Gleb Natapov
2012-03-21 23:00 ` [PATCH v2 " Jan Kiszka
2012-03-21 23:00   ` [Qemu-devel] " Jan Kiszka
2012-04-11  1:33   ` Marcelo Tosatti

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.