* [PATCH] documentation: fix alphabetic ordered list for git-rebase man page
@ 2012-03-23 11:31 Nelson Benitez Leon
2012-03-23 19:28 ` Junio C Hamano
0 siblings, 1 reply; 5+ messages in thread
From: Nelson Benitez Leon @ 2012-03-23 11:31 UTC (permalink / raw)
To: git
An alphabetic ordered list (a.) is converted to numerical in
the man page (1.) so context comments naming 'a' were confusing,
fix that by not using ordered list notation for 'a' anb 'b' items.
---
Hi, "Interactive mode" section of git-rebase man page has an error,
where the source says:
a. regular use
1. finish something worthy of a commit
2. commit
the converted man page says:
1. regular use
1. finish something worthy of a commit
2. commit
so the comments in following paragraph talking about "b.2." and "plenty of
a's and b's" don't have any meaning. I've fixed it by not using ordered
list notation for the alphabetical list.
Here you can see images of the man page before and after the patch:
Before patch: http://static.inky.ws/image/1567/image.jpg
After patch: http://static.inky.ws/image/1568/image.jpg
Regards,
Documentation/git-rebase.txt | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/Documentation/git-rebase.txt b/Documentation/git-rebase.txt
index 504945c..520aaa9 100644
--- a/Documentation/git-rebase.txt
+++ b/Documentation/git-rebase.txt
@@ -409,10 +409,13 @@ The interactive mode is meant for this type of workflow:
where point 2. consists of several instances of
-a. regular use
+a) regular use
+
1. finish something worthy of a commit
2. commit
-b. independent fixup
+
+b) independent fixup
+
1. realize that something does not work
2. fix that
3. commit it
--
1.7.7.6
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] documentation: fix alphabetic ordered list for git-rebase man page
2012-03-23 11:31 [PATCH] documentation: fix alphabetic ordered list for git-rebase man page Nelson Benitez Leon
@ 2012-03-23 19:28 ` Junio C Hamano
2012-03-26 11:57 ` Andreas Ericsson
0 siblings, 1 reply; 5+ messages in thread
From: Junio C Hamano @ 2012-03-23 19:28 UTC (permalink / raw)
To: Nelson Benitez Leon; +Cc: git
Thanks; sign-off?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] documentation: fix alphabetic ordered list for git-rebase man page
2012-03-23 19:28 ` Junio C Hamano
@ 2012-03-26 11:57 ` Andreas Ericsson
2012-03-26 17:32 ` Junio C Hamano
0 siblings, 1 reply; 5+ messages in thread
From: Andreas Ericsson @ 2012-03-26 11:57 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Nelson Benitez Leon, git
On 03/23/2012 08:28 PM, Junio C Hamano wrote:
> Thanks; sign-off?
Having just checked up on this myself for a project I maintain and
was sent a patch without signoff (we shamelessly stole git.git's
meaning of signoffs), I have it on a copyright lawyer's word that
you can safely forge the sign-off for anything that provides a
bugfix without adding a new way of doing things, since only changes
that carry a certain amount of originality can be copyright protected.
Fixing an alphabetic ordering is too trivial to grant the author of
the fix any right to the resulting work, as are typo-, grammar and
one-line syntactical fixes (adding missing braces, etc), and therefore
they do not need to sign off on the fact that they have a right to
give others the right to use that work, since they in fact do not have
the right to restrict others from using it in the first place.
Just thought I'd throw that out there in case you, like I did, run into
useful patches you dare not use because the original author gets hard
to contact all of a sudden.
--
Andreas Ericsson andreas.ericsson@op5.se
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
Considering the successes of the wars on alcohol, poverty, drugs and
terror, I think we should give some serious thought to declaring war
on peace.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] documentation: fix alphabetic ordered list for git-rebase man page
2012-03-26 11:57 ` Andreas Ericsson
@ 2012-03-26 17:32 ` Junio C Hamano
2012-03-27 10:40 ` Nelson Benitez Leon
0 siblings, 1 reply; 5+ messages in thread
From: Junio C Hamano @ 2012-03-26 17:32 UTC (permalink / raw)
To: Andreas Ericsson; +Cc: Nelson Benitez Leon, git
Andreas Ericsson <ae@op5.se> writes:
> On 03/23/2012 08:28 PM, Junio C Hamano wrote:
>> Thanks; sign-off?
> ...
> Just thought I'd throw that out there in case you, like I did, run into
> useful patches you dare not use because the original author gets hard
> to contact all of a sudden.
Thanks, but after seeing another series that is not as trivial as this one
from the same author, I was hoping that Nelson will become a part of our
regular contributor base ;-)
And obviously it will be less work on me in the longer term if I train the
regular contributors to do S-o-b themselves earlier in the process.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] documentation: fix alphabetic ordered list for git-rebase man page
2012-03-26 17:32 ` Junio C Hamano
@ 2012-03-27 10:40 ` Nelson Benitez Leon
0 siblings, 0 replies; 5+ messages in thread
From: Nelson Benitez Leon @ 2012-03-27 10:40 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
An alphabetic ordered list (a.) is converted to numerical in
the man page (1.) so context comments naming 'a' were confusing,
fix that by not using ordered list notation for 'a' anb 'b' items.
Signed-off-by: Nelson Benitez Leon <nbenitezl@gmail.com>
---
Sorry for the delay and forgetting the sign-off, should have made
an alias for that, hope to keep contributing as I found things that
need to be improved. thanks!
Documentation/git-rebase.txt | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/Documentation/git-rebase.txt b/Documentation/git-rebase.txt
index 504945c..520aaa9 100644
--- a/Documentation/git-rebase.txt
+++ b/Documentation/git-rebase.txt
@@ -409,10 +409,13 @@ The interactive mode is meant for this type of workflow:
where point 2. consists of several instances of
-a. regular use
+a) regular use
+
1. finish something worthy of a commit
2. commit
-b. independent fixup
+
+b) independent fixup
+
1. realize that something does not work
2. fix that
3. commit it
--
1.7.7.6
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-03-27 9:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-23 11:31 [PATCH] documentation: fix alphabetic ordered list for git-rebase man page Nelson Benitez Leon
2012-03-23 19:28 ` Junio C Hamano
2012-03-26 11:57 ` Andreas Ericsson
2012-03-26 17:32 ` Junio C Hamano
2012-03-27 10:40 ` Nelson Benitez Leon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.