All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	Wanpeng Li <liwp@linux.vnet.ibm.com>,
	Jan Kiszka <jan.kiszka@siemens.com>,
	qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Gavin Shan <shangw@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM
Date: Mon, 26 Mar 2012 12:29:33 -0500	[thread overview]
Message-ID: <4F70A77D.3020204@codemonkey.ws> (raw)
In-Reply-To: <20120326155444.GJ6016@valinux.co.jp>

On 03/26/2012 10:54 AM, Isaku Yamahata wrote:
> On Mon, Mar 26, 2012 at 02:20:24PM +0200, Jan Kiszka wrote:
>> I'm also sure we will have to refactor the merge significantly again for
>> the introduction of additional chipsets and PC boards. But unless those
>> requirements can already be specified (Isaku?), that might be unavoidable.
>
> Agreed. At least I'd like pam/smram stuff decoupled from piix.

s/piix/i440fx/

PAM/SRAM has nothing do to with the piix.  Part of the problem with the current 
layout is that the distinction between i440fx and piix is not clear.  The piix 
is just a SuperIO chip (and southbridge).

I think the better approach is to have a PCNorthBridge base-class that contains 
functionality like PAM/SRAM that both I440FX and Q35 inherit from.

Obviously, without getting the I440FX/PIIX3 modeling in shape, we can't look 
reasonable at how to share code.

Regards,

Anthony Liguori

> It is difficult to understand why patches of 5, 6 are needed without further
> patches because they don't show how the code will look like eventually.
> Anyway I expect some sort of refactor again and am waiting for QOM related
> stuff stabilizing.
>
> thanks,

  reply	other threads:[~2012-03-26 17:29 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-26  2:06 [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM Wanpeng Li
2012-03-26  2:06 ` [Qemu-devel] [PATCH 1/6] eliminate piix_pci.c and module i440fx and piix3 Wanpeng Li
2012-03-26  2:06 ` [Qemu-devel] [PATCH 2/6] convert MemoryRegion to QOM Wanpeng Li
2012-03-26  2:06 ` [Qemu-devel] [PATCH 3/6] convert pci-host " Wanpeng Li
2012-03-26  7:32   ` Stefan Hajnoczi
2012-03-26  9:22   ` Wanpeng Li
2012-03-26 14:25   ` Andreas Färber
2012-03-26  2:06 ` [Qemu-devel] [PATCH 4/6] prepare to create HPET, RTC and i8254 through composition Wanpeng Li
2012-03-26  2:06 ` [Qemu-devel] [PATCH 5/6] merge pc_piix.c to pc.c Wanpeng Li
2012-03-26 12:42   ` Avi Kivity
2012-03-26 12:47     ` Jan Kiszka
2012-03-26 17:37       ` Anthony Liguori
2012-03-26  2:06 ` [Qemu-devel] [PATCH 6/6] make some functions static Wanpeng Li
2012-03-26 12:20 ` [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM Jan Kiszka
2012-03-26 15:54   ` Isaku Yamahata
2012-03-26 17:29     ` Anthony Liguori [this message]
2012-03-27 10:31       ` Avi Kivity
2012-03-27 13:52         ` Anthony Liguori
2012-03-27 14:18           ` Avi Kivity
2012-03-26 17:17   ` Blue Swirl
2012-03-26 17:33   ` Anthony Liguori
2012-03-26 19:30     ` Jan Kiszka
2012-03-26 19:35       ` Anthony Liguori
2012-03-26 19:37         ` Jan Kiszka
2012-03-26 19:39           ` Anthony Liguori
2012-03-26 19:44             ` Jan Kiszka
2012-03-26 19:49               ` Anthony Liguori
2012-03-26 20:10                 ` Jan Kiszka
2012-03-26 20:13                   ` Anthony Liguori
2012-03-26 20:30                     ` Jan Kiszka
2012-03-26 21:00                       ` Anthony Liguori
2012-03-26 19:52               ` Anthony Liguori
2012-03-26 12:47 ` Andreas Färber
2012-03-26 12:57   ` Wanpeng Li
2012-03-26 17:09 ` Blue Swirl
2012-03-26 17:35   ` Anthony Liguori
2012-03-26 17:43     ` Blue Swirl
2012-03-26 17:45       ` Anthony Liguori
2012-03-26 18:01         ` Blue Swirl
2012-03-26 18:07           ` Anthony Liguori
2012-03-26 18:25             ` Blue Swirl
2012-03-26 17:25 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F70A77D.3020204@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=aliguori@us.ibm.com \
    --cc=avi@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=liwp@linux.vnet.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=shangw@linux.vnet.ibm.com \
    --cc=yamahata@valinux.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.