All of lore.kernel.org
 help / color / mirror / Atom feed
From: Blue Swirl <blauwirbel@gmail.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org, Anthony Liguori <aliguori@us.ibm.com>,
	Wanpeng Li <liwp@linux.vnet.ibm.com>, Avi Kivity <avi@redhat.com>,
	Gavin Shan <shangw@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM
Date: Mon, 26 Mar 2012 18:01:03 +0000	[thread overview]
Message-ID: <CAAu8pHsZMX_EG0ma76ARaXcpab6YK_+9H5XQ9O8YrFvriNxChw@mail.gmail.com> (raw)
In-Reply-To: <4F70AB4A.8050000@codemonkey.ws>

On Mon, Mar 26, 2012 at 17:45, Anthony Liguori <anthony@codemonkey.ws> wrote:
> On 03/26/2012 12:43 PM, Blue Swirl wrote:
>>
>> On Mon, Mar 26, 2012 at 17:35, Anthony Liguori<anthony@codemonkey.ws>
>>  wrote:
>>>
>>> On 03/26/2012 12:09 PM, Blue Swirl wrote:
>>>>
>>>>
>>>> On Mon, Mar 26, 2012 at 02:06, Wanpeng Li<liwp@linux.vnet.ibm.com>
>>>>  wrote:
>>>>>
>>>>>
>>>>>
>>>>> From: Anthony Liguori<aliguori@us.ibm.com>
>>>>>
>>>>>
>>>>> This series aggressively refactors the PC machine initialization to be
>>>>> more
>>>>> modelled and less ad-hoc.  The highlights of this series are:
>>>>
>>>>
>>>>
>>>> Please fix coding style while moving.
>>>
>>>
>>>
>>> I disagree.  That makes reviewing the movement and rebasing the movement
>>> pretty difficult.
>>
>>
>> Yes, a separate step would be nice.
>>
>>> If we were to fix the issues, it should before or after.  But in that
>>> context, I think it makes it orthogonal to moving the code and should be
>>> treated independently.
>>
>>
>> I'd fix the style in the first patch, then perform moves etc. That way
>> no patch would add noncompliant code, only remove.
>
>
> Is this something we universally want to do?  What would we do about patches
> to audio?

I'd do it in cases when there is code movement, then git blame will
not be very useful anyway and other people have to rebase their
patches as well.

The audio case has an additional factor, namely maintainer disagreeing
with global style and consistency. There are several ways how to
handle that case, one of which is to maintain status quo.

> I'd prefer not to go down this road.  Let's keep discussion of fixing
> CODING_STYLE of existing code separate from rearchitecting/enhancing code.

When code is moved, rearchitected or enhanced, that would be a good
point when to fix style too. Though this assumes that just fixing
style without those events is evil, but is it? I think you have not
been fully consistent in this matter.

> Regards,
>
> Anthony Liguori
>
>>
>>> Regards,
>>>
>>> Anthony Liguori
>
>

  reply	other threads:[~2012-03-26 18:01 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-26  2:06 [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM Wanpeng Li
2012-03-26  2:06 ` [Qemu-devel] [PATCH 1/6] eliminate piix_pci.c and module i440fx and piix3 Wanpeng Li
2012-03-26  2:06 ` [Qemu-devel] [PATCH 2/6] convert MemoryRegion to QOM Wanpeng Li
2012-03-26  2:06 ` [Qemu-devel] [PATCH 3/6] convert pci-host " Wanpeng Li
2012-03-26  7:32   ` Stefan Hajnoczi
2012-03-26  9:22   ` Wanpeng Li
2012-03-26 14:25   ` Andreas Färber
2012-03-26  2:06 ` [Qemu-devel] [PATCH 4/6] prepare to create HPET, RTC and i8254 through composition Wanpeng Li
2012-03-26  2:06 ` [Qemu-devel] [PATCH 5/6] merge pc_piix.c to pc.c Wanpeng Li
2012-03-26 12:42   ` Avi Kivity
2012-03-26 12:47     ` Jan Kiszka
2012-03-26 17:37       ` Anthony Liguori
2012-03-26  2:06 ` [Qemu-devel] [PATCH 6/6] make some functions static Wanpeng Li
2012-03-26 12:20 ` [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM Jan Kiszka
2012-03-26 15:54   ` Isaku Yamahata
2012-03-26 17:29     ` Anthony Liguori
2012-03-27 10:31       ` Avi Kivity
2012-03-27 13:52         ` Anthony Liguori
2012-03-27 14:18           ` Avi Kivity
2012-03-26 17:17   ` Blue Swirl
2012-03-26 17:33   ` Anthony Liguori
2012-03-26 19:30     ` Jan Kiszka
2012-03-26 19:35       ` Anthony Liguori
2012-03-26 19:37         ` Jan Kiszka
2012-03-26 19:39           ` Anthony Liguori
2012-03-26 19:44             ` Jan Kiszka
2012-03-26 19:49               ` Anthony Liguori
2012-03-26 20:10                 ` Jan Kiszka
2012-03-26 20:13                   ` Anthony Liguori
2012-03-26 20:30                     ` Jan Kiszka
2012-03-26 21:00                       ` Anthony Liguori
2012-03-26 19:52               ` Anthony Liguori
2012-03-26 12:47 ` Andreas Färber
2012-03-26 12:57   ` Wanpeng Li
2012-03-26 17:09 ` Blue Swirl
2012-03-26 17:35   ` Anthony Liguori
2012-03-26 17:43     ` Blue Swirl
2012-03-26 17:45       ` Anthony Liguori
2012-03-26 18:01         ` Blue Swirl [this message]
2012-03-26 18:07           ` Anthony Liguori
2012-03-26 18:25             ` Blue Swirl
2012-03-26 17:25 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAu8pHsZMX_EG0ma76ARaXcpab6YK_+9H5XQ9O8YrFvriNxChw@mail.gmail.com \
    --to=blauwirbel@gmail.com \
    --cc=aliguori@us.ibm.com \
    --cc=anthony@codemonkey.ws \
    --cc=avi@redhat.com \
    --cc=liwp@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=shangw@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.