* [PATCH] pnfs-obj: Remove unused variable from objlayout_get_deviceinfo()
@ 2012-03-30 21:29 Boaz Harrosh
2012-03-30 21:51 ` [osd-dev] " Boaz Harrosh
0 siblings, 1 reply; 3+ messages in thread
From: Boaz Harrosh @ 2012-03-30 21:29 UTC (permalink / raw)
To: Trond Myklebust, NFS list, open-osd
From: Sachin Bhamare <sbhamare@panasas.com>
Local variable 'sb' was not being used in objlayout_get_deviceinfo().
Signed-off-by: Sachin Bhamare <sbhamare@panasas.com>
Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
---
fs/nfs/objlayout/objlayout.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/fs/nfs/objlayout/objlayout.c b/fs/nfs/objlayout/objlayout.c
index 1ae53eb..b158d1b 100644
--- a/fs/nfs/objlayout/objlayout.c
+++ b/fs/nfs/objlayout/objlayout.c
@@ -604,7 +604,6 @@ int objlayout_get_deviceinfo(struct pnfs_layout_hdr *pnfslay,
{
struct objlayout_deviceinfo *odi;
struct pnfs_device pd;
- struct super_block *sb;
struct page *page, **pages;
u32 *p;
int err;
@@ -623,7 +622,6 @@ int objlayout_get_deviceinfo(struct pnfs_layout_hdr *pnfslay,
pd.pglen = PAGE_SIZE;
pd.mincount = 0;
- sb = pnfslay->plh_inode->i_sb;
err = nfs4_proc_getdeviceinfo(NFS_SERVER(pnfslay->plh_inode), &pd);
dprintk("%s nfs_getdeviceinfo returned %d\n", __func__, err);
if (err)
--
1.7.6.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [osd-dev] [PATCH] pnfs-obj: Remove unused variable from objlayout_get_deviceinfo()
2012-03-30 21:29 [PATCH] pnfs-obj: Remove unused variable from objlayout_get_deviceinfo() Boaz Harrosh
@ 2012-03-30 21:51 ` Boaz Harrosh
2012-04-03 13:45 ` Benny Halevy
0 siblings, 1 reply; 3+ messages in thread
From: Boaz Harrosh @ 2012-03-30 21:51 UTC (permalink / raw)
To: Trond Myklebust, NFS list, open-osd, Benny Halevy
On 03/30/2012 02:29 PM, Boaz Harrosh wrote:
> From: Sachin Bhamare <sbhamare@panasas.com>
>
> Local variable 'sb' was not being used in objlayout_get_deviceinfo().
>
> Signed-off-by: Sachin Bhamare <sbhamare@panasas.com>
> Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
I was transitioning all my tree's to the 3.4-rc0 Kernel and noticed
we forgot this patch, Please add it to what ever next-kernel branch you
have.
Benny could you please make a pnfs-all-3.3 branch? It should be identical
to the 3.3-rc6, probably, but just for completeness.
Tell me if you also want to add the autologin patches to it I can help
out with that. Else the client side went into 3.4-rc0 so I'll send you
the exofs side for your future 3.4-rc1 tree.
Thanks
Boaz
> ---
> fs/nfs/objlayout/objlayout.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/fs/nfs/objlayout/objlayout.c b/fs/nfs/objlayout/objlayout.c
> index 1ae53eb..b158d1b 100644
> --- a/fs/nfs/objlayout/objlayout.c
> +++ b/fs/nfs/objlayout/objlayout.c
> @@ -604,7 +604,6 @@ int objlayout_get_deviceinfo(struct pnfs_layout_hdr *pnfslay,
> {
> struct objlayout_deviceinfo *odi;
> struct pnfs_device pd;
> - struct super_block *sb;
> struct page *page, **pages;
> u32 *p;
> int err;
> @@ -623,7 +622,6 @@ int objlayout_get_deviceinfo(struct pnfs_layout_hdr *pnfslay,
> pd.pglen = PAGE_SIZE;
> pd.mincount = 0;
>
> - sb = pnfslay->plh_inode->i_sb;
> err = nfs4_proc_getdeviceinfo(NFS_SERVER(pnfslay->plh_inode), &pd);
> dprintk("%s nfs_getdeviceinfo returned %d\n", __func__, err);
> if (err)
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [osd-dev] [PATCH] pnfs-obj: Remove unused variable from objlayout_get_deviceinfo()
2012-03-30 21:51 ` [osd-dev] " Boaz Harrosh
@ 2012-04-03 13:45 ` Benny Halevy
0 siblings, 0 replies; 3+ messages in thread
From: Benny Halevy @ 2012-04-03 13:45 UTC (permalink / raw)
To: Boaz Harrosh; +Cc: Trond Myklebust, NFS list, open-osd
On Sat, Mar 31, 2012 at 12:51 AM, Boaz Harrosh <bharrosh@panasas.com> wrote:
> On 03/30/2012 02:29 PM, Boaz Harrosh wrote:
>
>> From: Sachin Bhamare <sbhamare@panasas.com>
>>
>> Local variable 'sb' was not being used in objlayout_get_deviceinfo().
>>
>> Signed-off-by: Sachin Bhamare <sbhamare@panasas.com>
>> Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
>
>
> I was transitioning all my tree's to the 3.4-rc0 Kernel and noticed
> we forgot this patch, Please add it to what ever next-kernel branch you
> have.
>
> Benny could you please make a pnfs-all-3.3 branch? It should be identical
> to the 3.3-rc6, probably, but just for completeness.
I'll do that after rebasing to v3.3 (which I've been chasing my tail to do)
>
> Tell me if you also want to add the autologin patches to it I can help
> out with that. Else the client side went into 3.4-rc0 so I'll send you
> the exofs side for your future 3.4-rc1 tree.
I prefer to apply it for 3.4-rc.
>
> Thanks
Sure :)
Benny
> Boaz
>
>> ---
>> fs/nfs/objlayout/objlayout.c | 2 --
>> 1 files changed, 0 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/nfs/objlayout/objlayout.c b/fs/nfs/objlayout/objlayout.c
>> index 1ae53eb..b158d1b 100644
>> --- a/fs/nfs/objlayout/objlayout.c
>> +++ b/fs/nfs/objlayout/objlayout.c
>> @@ -604,7 +604,6 @@ int objlayout_get_deviceinfo(struct pnfs_layout_hdr *pnfslay,
>> {
>> struct objlayout_deviceinfo *odi;
>> struct pnfs_device pd;
>> - struct super_block *sb;
>> struct page *page, **pages;
>> u32 *p;
>> int err;
>> @@ -623,7 +622,6 @@ int objlayout_get_deviceinfo(struct pnfs_layout_hdr *pnfslay,
>> pd.pglen = PAGE_SIZE;
>> pd.mincount = 0;
>>
>> - sb = pnfslay->plh_inode->i_sb;
>> err = nfs4_proc_getdeviceinfo(NFS_SERVER(pnfslay->plh_inode), &pd);
>> dprintk("%s nfs_getdeviceinfo returned %d\n", __func__, err);
>> if (err)
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-04-03 13:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-30 21:29 [PATCH] pnfs-obj: Remove unused variable from objlayout_get_deviceinfo() Boaz Harrosh
2012-03-30 21:51 ` [osd-dev] " Boaz Harrosh
2012-04-03 13:45 ` Benny Halevy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.