* [PATCH] ARM: include linux/bug.h in insn.c
@ 2012-03-30 21:13 Joachim Eastwood
2012-03-30 22:06 ` Paul Gortmaker
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Joachim Eastwood @ 2012-03-30 21:13 UTC (permalink / raw)
To: linux-arm-kernel
After commit d82227cf8 building the kernel fails with:
arch/arm/kernel/insn.c: In function '__arm_gen_branch_thumb2':
arch/arm/kernel/insn.c:13: error: implicit declaration of function 'WARN_ON_ONCE'
make[1]: *** [arch/arm/kernel/insn.o] Error 1
make: *** [arch/arm/kernel] Error 2
insn.c uses WARN_ON_ONCE so lets include bug.h.
Signed-off-by: Joachim Eastwood <joachim.eastwood@jotron.com>
---
arch/arm/kernel/insn.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/kernel/insn.c b/arch/arm/kernel/insn.c
index ab312e5..080fc70 100644
--- a/arch/arm/kernel/insn.c
+++ b/arch/arm/kernel/insn.c
@@ -1,4 +1,5 @@
#include <linux/kernel.h>
+#include <linux/bug.h>
#include <asm/opcodes.h>
static unsigned long
--
1.7.9.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ARM: include linux/bug.h in insn.c
2012-03-30 21:13 [PATCH] ARM: include linux/bug.h in insn.c Joachim Eastwood
@ 2012-03-30 22:06 ` Paul Gortmaker
2012-03-31 8:16 ` Russell King - ARM Linux
2012-03-31 21:21 ` Sergei Shtylyov
2 siblings, 0 replies; 4+ messages in thread
From: Paul Gortmaker @ 2012-03-30 22:06 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Mar 30, 2012 at 5:13 PM, Joachim Eastwood <manabian@gmail.com> wrote:
> After commit d82227cf8 building the kernel fails with:
Please also list the shortlog when giving a commit ID, i.e.
"ARM: 7331/1: extract out insn generation code from ftrace"
Thanks,
Paul.
> ?arch/arm/kernel/insn.c: In function '__arm_gen_branch_thumb2':
> ?arch/arm/kernel/insn.c:13: error: implicit declaration of function 'WARN_ON_ONCE'
> ?make[1]: *** [arch/arm/kernel/insn.o] Error 1
> ?make: *** [arch/arm/kernel] Error 2
>
> insn.c uses WARN_ON_ONCE so lets include bug.h.
>
> Signed-off-by: Joachim Eastwood <joachim.eastwood@jotron.com>
> ---
> ?arch/arm/kernel/insn.c | ? ?1 +
> ?1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/kernel/insn.c b/arch/arm/kernel/insn.c
> index ab312e5..080fc70 100644
> --- a/arch/arm/kernel/insn.c
> +++ b/arch/arm/kernel/insn.c
> @@ -1,4 +1,5 @@
> ?#include <linux/kernel.h>
> +#include <linux/bug.h>
> ?#include <asm/opcodes.h>
>
> ?static unsigned long
> --
> 1.7.9.2
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: include linux/bug.h in insn.c
2012-03-30 21:13 [PATCH] ARM: include linux/bug.h in insn.c Joachim Eastwood
2012-03-30 22:06 ` Paul Gortmaker
@ 2012-03-31 8:16 ` Russell King - ARM Linux
2012-03-31 21:21 ` Sergei Shtylyov
2 siblings, 0 replies; 4+ messages in thread
From: Russell King - ARM Linux @ 2012-03-31 8:16 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Mar 30, 2012 at 11:13:22PM +0200, Joachim Eastwood wrote:
> After commit d82227cf8 building the kernel fails with:
> arch/arm/kernel/insn.c: In function '__arm_gen_branch_thumb2':
> arch/arm/kernel/insn.c:13: error: implicit declaration of function 'WARN_ON_ONCE'
> make[1]: *** [arch/arm/kernel/insn.o] Error 1
> make: *** [arch/arm/kernel] Error 2
>
> insn.c uses WARN_ON_ONCE so lets include bug.h.
I already have this in my tree.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: include linux/bug.h in insn.c
2012-03-30 21:13 [PATCH] ARM: include linux/bug.h in insn.c Joachim Eastwood
2012-03-30 22:06 ` Paul Gortmaker
2012-03-31 8:16 ` Russell King - ARM Linux
@ 2012-03-31 21:21 ` Sergei Shtylyov
2 siblings, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2012-03-31 21:21 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 31-03-2012 1:13, Joachim Eastwood wrote:
> After commit d82227cf8 building the kernel fails with:
Please also specify that commit summary in parens.
> arch/arm/kernel/insn.c: In function '__arm_gen_branch_thumb2':
> arch/arm/kernel/insn.c:13: error: implicit declaration of function 'WARN_ON_ONCE'
> make[1]: *** [arch/arm/kernel/insn.o] Error 1
> make: *** [arch/arm/kernel] Error 2
> insn.c uses WARN_ON_ONCE so lets include bug.h.
Let's.
> Signed-off-by: Joachim Eastwood<joachim.eastwood@jotron.com>
WBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-03-31 21:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-30 21:13 [PATCH] ARM: include linux/bug.h in insn.c Joachim Eastwood
2012-03-30 22:06 ` Paul Gortmaker
2012-03-31 8:16 ` Russell King - ARM Linux
2012-03-31 21:21 ` Sergei Shtylyov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.