* [PATCH] af9035: add several new USB IDs
@ 2012-04-04 11:47 Gianluca Gennari
2012-04-04 11:59 ` Antti Palosaari
0 siblings, 1 reply; 11+ messages in thread
From: Gianluca Gennari @ 2012-04-04 11:47 UTC (permalink / raw)
To: linux-media, crope; +Cc: m, hfvogt, mchehab, Gianluca Gennari
Add several new USB IDs extracted from the Windows and Linux drivers published
by the manufacturers (Terratec and AVerMedia).
Terratec Cinergy T Stick rev. 2 (tua9001):
http://linux.terratec.de/tv_en.html
AVerMedia AverTV TwinStar A825 (2 x mxl5007t):
http://www.avermedia.com/Support/DownloadCount.aspx?FDFId=3145
AVerMedia A835 (tda18218):
http://www.avermedia.com/Support/DownloadCount.aspx?FDFId=4528
Afatech Sticks and AVerMedia A867 (mxl5007t):
http://www.avermedia.com/Support/DownloadCount.aspx?FDFId=5172
http://www.avermedia.com/Support/DownloadCount.aspx?FDFId=5171
http://www.avermedia.com/Support/DownloadCount.aspx?FDFId=4591 (Linux driver)
The AVerMedia A825 is a dual tuner stick that was reported as fully working
on the OpenPli forum, using a modified version of the old af9035 driver:
http://openpli.org/forums/topic/22295-is-the-avertv-twinstar-a825-dvb-t-usb-twin-tuner-supported-by-the-newest-openpli/page__view__findpost__p__254634
so I think it should work also on the new driver version, at least in
single-tuner mode.
Signed-off-by: Gianluca Gennari <gennarone@gmail.com>
---
drivers/media/dvb/dvb-usb/af9035.c | 60 +++++++++++++++++++++++++++++-
drivers/media/dvb/dvb-usb/dvb-usb-ids.h | 15 +++++++-
2 files changed, 72 insertions(+), 3 deletions(-)
diff --git a/drivers/media/dvb/dvb-usb/af9035.c b/drivers/media/dvb/dvb-usb/af9035.c
index 26b4ead..e2107cd 100644
--- a/drivers/media/dvb/dvb-usb/af9035.c
+++ b/drivers/media/dvb/dvb-usb/af9035.c
@@ -821,29 +821,68 @@ err:
enum af9035_id_entry {
AF9035_0CCD_0093,
+ AF9035_0CCD_00AA,
AF9035_15A4_9035,
+ AF9035_15A4_1000,
AF9035_15A4_1001,
+ AF9035_15A4_1002,
+ AF9035_15A4_1003,
+ AF9035_07CA_0825,
+ AF9035_07CA_A825,
+ AF9035_07CA_0835,
AF9035_07CA_A835,
AF9035_07CA_B835,
+ AF9035_07CA_A333,
+ AF9035_07CA_0337,
+ AF9035_07CA_F337,
+ AF9035_07CA_0867,
AF9035_07CA_1867,
+ AF9035_07CA_3867,
AF9035_07CA_A867,
+ AF9035_07CA_B867,
};
static struct usb_device_id af9035_id[] = {
[AF9035_0CCD_0093] = {
USB_DEVICE(USB_VID_TERRATEC, USB_PID_TERRATEC_CINERGY_T_STICK)},
+ [AF9035_0CCD_00AA] = {
+ USB_DEVICE(USB_VID_TERRATEC, USB_PID_TERRATEC_CINERGY_T_STICK_2)},
[AF9035_15A4_9035] = {
USB_DEVICE(USB_VID_AFATECH, USB_PID_AFATECH_AF9035)},
- [AF9035_15A4_1001] = {
+ [AF9035_15A4_1000] = {
USB_DEVICE(USB_VID_AFATECH, USB_PID_AFATECH_AF9035_2)},
+ [AF9035_15A4_1001] = {
+ USB_DEVICE(USB_VID_AFATECH, USB_PID_AFATECH_AF9035_3)},
+ [AF9035_15A4_1002] = {
+ USB_DEVICE(USB_VID_AFATECH, USB_PID_AFATECH_AF9035_4)},
+ [AF9035_15A4_1003] = {
+ USB_DEVICE(USB_VID_AFATECH, USB_PID_AFATECH_AF9035_5)},
+ [AF9035_07CA_0825] = {
+ USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_0825)},
+ [AF9035_07CA_A825] = {
+ USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_A825)},
+ [AF9035_07CA_0835] = {
+ USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_0835)},
[AF9035_07CA_A835] = {
USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_A835)},
[AF9035_07CA_B835] = {
USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_B835)},
+ [AF9035_07CA_A333] = {
+ USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_A333)},
+ [AF9035_07CA_0337] = {
+ USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_0337)},
+ [AF9035_07CA_F337] = {
+ USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_F337)},
+ [AF9035_07CA_0867] = {
+ USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_0867)},
[AF9035_07CA_1867] = {
USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_1867)},
+ [AF9035_07CA_3867] = {
+ USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_3867)},
[AF9035_07CA_A867] = {
USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_A867)},
+ [AF9035_07CA_B867] = {
+ USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_B867)},
{},
};
@@ -886,30 +925,47 @@ static struct dvb_usb_device_properties af9035_properties[] = {
.i2c_algo = &af9035_i2c_algo,
- .num_device_descs = 4,
+ .num_device_descs = 5,
.devices = {
{
.name = "TerraTec Cinergy T Stick",
.cold_ids = {
&af9035_id[AF9035_0CCD_0093],
+ &af9035_id[AF9035_0CCD_00AA],
},
}, {
.name = "Afatech Technologies DVB-T stick",
.cold_ids = {
&af9035_id[AF9035_15A4_9035],
+ &af9035_id[AF9035_15A4_1000],
&af9035_id[AF9035_15A4_1001],
+ &af9035_id[AF9035_15A4_1002],
+ &af9035_id[AF9035_15A4_1003],
+ },
+ }, {
+ .name = "AVerMedia AVerTV TwinStar (A825)",
+ .cold_ids = {
+ &af9035_id[AF9035_07CA_0825],
+ &af9035_id[AF9035_07CA_A825],
},
}, {
.name = "AVerMedia AVerTV Volar HD/PRO (A835)",
.cold_ids = {
+ &af9035_id[AF9035_07CA_0835],
&af9035_id[AF9035_07CA_A835],
&af9035_id[AF9035_07CA_B835],
},
}, {
.name = "AVerMedia HD Volar (A867)",
.cold_ids = {
+ &af9035_id[AF9035_07CA_A333],
+ &af9035_id[AF9035_07CA_0337],
+ &af9035_id[AF9035_07CA_F337],
+ &af9035_id[AF9035_07CA_0867],
&af9035_id[AF9035_07CA_1867],
+ &af9035_id[AF9035_07CA_3867],
&af9035_id[AF9035_07CA_A867],
+ &af9035_id[AF9035_07CA_B867],
},
},
}
diff --git a/drivers/media/dvb/dvb-usb/dvb-usb-ids.h b/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
index 6a761c5..b7e46c7 100644
--- a/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
+++ b/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
@@ -77,7 +77,10 @@
#define USB_PID_AFATECH_AF9015_9015 0x9015
#define USB_PID_AFATECH_AF9015_9016 0x9016
#define USB_PID_AFATECH_AF9035 0x9035
-#define USB_PID_AFATECH_AF9035_2 0x1001
+#define USB_PID_AFATECH_AF9035_2 0x1000
+#define USB_PID_AFATECH_AF9035_3 0x1001
+#define USB_PID_AFATECH_AF9035_4 0x1002
+#define USB_PID_AFATECH_AF9035_5 0x1003
#define USB_PID_TREKSTOR_DVBT 0x901b
#define USB_VID_ALINK_DTU 0xf170
#define USB_PID_ANSONIC_DVBT_USB 0x6000
@@ -155,6 +158,7 @@
#define USB_PID_TERRATEC_CINERGY_T_USB_XE 0x0055
#define USB_PID_TERRATEC_CINERGY_T_USB_XE_REV2 0x0069
#define USB_PID_TERRATEC_CINERGY_T_STICK 0x0093
+#define USB_PID_TERRATEC_CINERGY_T_STICK_2 0x00aa
#define USB_PID_TERRATEC_CINERGY_T_STICK_RC 0x0097
#define USB_PID_TERRATEC_CINERGY_T_STICK_DUAL_RC 0x0099
#define USB_PID_TWINHAN_VP7041_COLD 0x3201
@@ -224,10 +228,19 @@
#define USB_PID_AVERMEDIA_A850T 0x850b
#define USB_PID_AVERMEDIA_A805 0xa805
#define USB_PID_AVERMEDIA_A815M 0x815a
+#define USB_PID_AVERMEDIA_0825 0x0825
+#define USB_PID_AVERMEDIA_A825 0xa825
+#define USB_PID_AVERMEDIA_0835 0x0835
#define USB_PID_AVERMEDIA_A835 0xa835
#define USB_PID_AVERMEDIA_B835 0xb835
+#define USB_PID_AVERMEDIA_A333 0xa333
+#define USB_PID_AVERMEDIA_0337 0x0337
+#define USB_PID_AVERMEDIA_F337 0xf337
+#define USB_PID_AVERMEDIA_0867 0x0867
#define USB_PID_AVERMEDIA_1867 0x1867
+#define USB_PID_AVERMEDIA_3867 0x3867
#define USB_PID_AVERMEDIA_A867 0xa867
+#define USB_PID_AVERMEDIA_B867 0xb867
#define USB_PID_TECHNOTREND_CONNECT_S2400 0x3006
#define USB_PID_TECHNOTREND_CONNECT_CT3650 0x300d
#define USB_PID_TERRATEC_CINERGY_DT_XS_DIVERSITY 0x005a
--
1.7.5.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] af9035: add several new USB IDs
2012-04-04 11:47 [PATCH] af9035: add several new USB IDs Gianluca Gennari
@ 2012-04-04 11:59 ` Antti Palosaari
2012-04-04 12:11 ` David Cohen
2012-04-04 12:40 ` Gianluca Gennari
0 siblings, 2 replies; 11+ messages in thread
From: Antti Palosaari @ 2012-04-04 11:59 UTC (permalink / raw)
To: Gianluca Gennari; +Cc: linux-media, m, hfvogt, mchehab
On 04.04.2012 14:47, Gianluca Gennari wrote:
> Add several new USB IDs extracted from the Windows and Linux drivers published
> by the manufacturers (Terratec and AVerMedia).
> + [AF9035_07CA_0867] = {
> + USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_0867)},
> [AF9035_07CA_1867] = {
> USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_1867)},
> + [AF9035_07CA_3867] = {
> + USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_3867)},
> [AF9035_07CA_A867] = {
> USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_A867)},
> + [AF9035_07CA_B867] = {
> + USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_B867)},
It have been common practise to use product names for USB PID
definitions instead of USB ID numbers. I vote to continue that practise.
Also, I am not very sure if it is wise to add new IDs without any
testing. Likely those are just reference design and will work, but
sometimes there is also some changes done for schematic wiring.
Especially for Avermedia, see hacks needed some AF9015 Avermedia
devices. They have put invalid data to eeprom and thus hacks are needed
for overriding tuner IDs etc.
Not to mention, driver supports also dynamic IDs and even device ID is
missing user can load driver using dynamic ID and report it working or
non-working.
Anyone else any thoughts about adding IDs without testing ?
regards
Antti
--
http://palosaari.fi/
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] af9035: add several new USB IDs
2012-04-04 11:59 ` Antti Palosaari
@ 2012-04-04 12:11 ` David Cohen
2012-04-04 12:40 ` Gianluca Gennari
1 sibling, 0 replies; 11+ messages in thread
From: David Cohen @ 2012-04-04 12:11 UTC (permalink / raw)
To: Antti Palosaari; +Cc: Gianluca Gennari, linux-media, m, hfvogt, mchehab
Hi Antti,
On 04/04/2012 02:59 PM, Antti Palosaari wrote:
> On 04.04.2012 14:47, Gianluca Gennari wrote:
>> Add several new USB IDs extracted from the Windows and Linux drivers
>> published
>> by the manufacturers (Terratec and AVerMedia).
>> + [AF9035_07CA_0867] = {
>> + USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_0867)},
>> [AF9035_07CA_1867] = {
>> USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_1867)},
>> + [AF9035_07CA_3867] = {
>> + USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_3867)},
>> [AF9035_07CA_A867] = {
>> USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_A867)},
>> + [AF9035_07CA_B867] = {
>> + USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_B867)},
>
> It have been common practise to use product names for USB PID
> definitions instead of USB ID numbers. I vote to continue that practise.
>
> Also, I am not very sure if it is wise to add new IDs without any
> testing. Likely those are just reference design and will work, but
> sometimes there is also some changes done for schematic wiring.
> Especially for Avermedia, see hacks needed some AF9015 Avermedia
> devices. They have put invalid data to eeprom and thus hacks are needed
> for overriding tuner IDs etc.
> Not to mention, driver supports also dynamic IDs and even device ID is
> missing user can load driver using dynamic ID and report it working or
> non-working.
>
> Anyone else any thoughts about adding IDs without testing ?
In my experience, it's not always workable out-of-the-box (for the
reasons you mentioned).
IMO it would be better either them adding as long as they're been
tested, or at least to add comments when untested but likely to work.
Br,
David
>
> regards
> Antti
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] af9035: add several new USB IDs
2012-04-04 11:59 ` Antti Palosaari
2012-04-04 12:11 ` David Cohen
@ 2012-04-04 12:40 ` Gianluca Gennari
2012-04-04 13:09 ` Antti Palosaari
1 sibling, 1 reply; 11+ messages in thread
From: Gianluca Gennari @ 2012-04-04 12:40 UTC (permalink / raw)
To: Antti Palosaari; +Cc: linux-media, m, hfvogt, mchehab
Il 04/04/2012 13:59, Antti Palosaari ha scritto:
> On 04.04.2012 14:47, Gianluca Gennari wrote:
>> Add several new USB IDs extracted from the Windows and Linux drivers
>> published
>> by the manufacturers (Terratec and AVerMedia).
>> + [AF9035_07CA_0867] = {
>> + USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_0867)},
>> [AF9035_07CA_1867] = {
>> USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_1867)},
>> + [AF9035_07CA_3867] = {
>> + USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_3867)},
>> [AF9035_07CA_A867] = {
>> USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_A867)},
>> + [AF9035_07CA_B867] = {
>> + USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_B867)},
>
> It have been common practise to use product names for USB PID
> definitions instead of USB ID numbers. I vote to continue that practise.
>
> Also, I am not very sure if it is wise to add new IDs without any
> testing. Likely those are just reference design and will work, but
> sometimes there is also some changes done for schematic wiring.
> Especially for Avermedia, see hacks needed some AF9015 Avermedia
> devices. They have put invalid data to eeprom and thus hacks are needed
> for overriding tuner IDs etc.
> Not to mention, driver supports also dynamic IDs and even device ID is
> missing user can load driver using dynamic ID and report it working or
> non-working.
>
> Anyone else any thoughts about adding IDs without testing ?
>
> regards
> Antti
Regarding the USB PID definition naming, there is no problem for me.
Actually, some product names were used in the modified versions of your
old driver, so I converted them to the format above just for
convenience. The only problem is that there are so many variations of
the Avermedia sticks that it's hard to give them proper names.
Some of this IDs are already tested (if we include the several
modifications of your old driver).
In particular:
AF9035_0CCD_00AA : confirmed working on Ubuntu.it forum with the old
driver (don't have the link);
AF9035_07CA_0825 : confirmed working on OpenPli forum with the old
driver (see link above);
Others comes from the official Windows drivers so they should be just
little variations of the retail products:
AF9035_07CA_A825, AF9035_07CA_0835, AF9035_07CA_3867.
This IDs are can be the more problematic:
AF9035_15A4_1000, AF9035_15A4_1002, AF9035_15A4_1003,
AF9035_07CA_A333, AF9035_07CA_0337, AF9035_07CA_F337
since there is little or no information about this products.
Anyway, this patch can be a reference for users willing to test the new
driver.
Regards,
Gianluca
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] af9035: add several new USB IDs
2012-04-04 12:40 ` Gianluca Gennari
@ 2012-04-04 13:09 ` Antti Palosaari
2012-04-04 13:27 ` Gianluca Gennari
0 siblings, 1 reply; 11+ messages in thread
From: Antti Palosaari @ 2012-04-04 13:09 UTC (permalink / raw)
To: gennarone; +Cc: linux-media, m, hfvogt, mchehab
On 04.04.2012 15:40, Gianluca Gennari wrote:
> Il 04/04/2012 13:59, Antti Palosaari ha scritto:
>> On 04.04.2012 14:47, Gianluca Gennari wrote:
>>> Add several new USB IDs extracted from the Windows and Linux drivers
>>> published
>>> by the manufacturers (Terratec and AVerMedia).
>>> + [AF9035_07CA_0867] = {
>>> + USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_0867)},
>>> [AF9035_07CA_1867] = {
>>> USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_1867)},
>>> + [AF9035_07CA_3867] = {
>>> + USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_3867)},
>>> [AF9035_07CA_A867] = {
>>> USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_A867)},
>>> + [AF9035_07CA_B867] = {
>>> + USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_B867)},
>>
>> It have been common practise to use product names for USB PID
>> definitions instead of USB ID numbers. I vote to continue that practise.
>>
>> Also, I am not very sure if it is wise to add new IDs without any
>> testing. Likely those are just reference design and will work, but
>> sometimes there is also some changes done for schematic wiring.
>> Especially for Avermedia, see hacks needed some AF9015 Avermedia
>> devices. They have put invalid data to eeprom and thus hacks are needed
>> for overriding tuner IDs etc.
>> Not to mention, driver supports also dynamic IDs and even device ID is
>> missing user can load driver using dynamic ID and report it working or
>> non-working.
>>
>> Anyone else any thoughts about adding IDs without testing ?
>>
>> regards
>> Antti
>
> Regarding the USB PID definition naming, there is no problem for me.
> Actually, some product names were used in the modified versions of your
> old driver, so I converted them to the format above just for
> convenience. The only problem is that there are so many variations of
> the Avermedia sticks that it's hard to give them proper names.
>
> Some of this IDs are already tested (if we include the several
> modifications of your old driver).
>
> In particular:
> AF9035_0CCD_00AA : confirmed working on Ubuntu.it forum with the old
> driver (don't have the link);
> AF9035_07CA_0825 : confirmed working on OpenPli forum with the old
> driver (see link above);
>
> Others comes from the official Windows drivers so they should be just
> little variations of the retail products:
> AF9035_07CA_A825, AF9035_07CA_0835, AF9035_07CA_3867.
>
> This IDs are can be the more problematic:
> AF9035_15A4_1000, AF9035_15A4_1002, AF9035_15A4_1003,
> AF9035_07CA_A333, AF9035_07CA_0337, AF9035_07CA_F337
> since there is little or no information about this products.
>
> Anyway, this patch can be a reference for users willing to test the new
> driver.
I mean those definitions that goes to common file named: dvb-usb-ids.h.
Those are named as a USB_PID_<VENDOR_NAME>_<PRODUCT_NAME>
PIDs inside af9035.c (enum af9035_id_entry) are used only for generating
table index. Before it was used plain index numbers but that causes in
past few times problems when people added new device IDs between then
the table. Meaning of that enum is only keep index in order
automatically - and it is just fine as it is short unique name as
currently AF9035_<VID>_<PID>.
Add those IDs you know working and sent patch. Lets add more IDs when
those are confirmed to work. And as I said I added dynamic ID support
for that driver, so even there is no USB ID defined inside driver, it
can be still used without compiling whole Kernel.
regards
Antti
--
http://palosaari.fi/
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] af9035: add several new USB IDs
2012-04-04 13:09 ` Antti Palosaari
@ 2012-04-04 13:27 ` Gianluca Gennari
2012-04-05 14:23 ` pierigno
0 siblings, 1 reply; 11+ messages in thread
From: Gianluca Gennari @ 2012-04-04 13:27 UTC (permalink / raw)
To: Antti Palosaari; +Cc: linux-media, m, hfvogt, mchehab
Il 04/04/2012 15:09, Antti Palosaari ha scritto:
> On 04.04.2012 15:40, Gianluca Gennari wrote:
>> Il 04/04/2012 13:59, Antti Palosaari ha scritto:
>>> On 04.04.2012 14:47, Gianluca Gennari wrote:
>>>> Add several new USB IDs extracted from the Windows and Linux drivers
>>>> published
>>>> by the manufacturers (Terratec and AVerMedia).
>>>> + [AF9035_07CA_0867] = {
>>>> + USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_0867)},
>>>> [AF9035_07CA_1867] = {
>>>> USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_1867)},
>>>> + [AF9035_07CA_3867] = {
>>>> + USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_3867)},
>>>> [AF9035_07CA_A867] = {
>>>> USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_A867)},
>>>> + [AF9035_07CA_B867] = {
>>>> + USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_B867)},
>>>
>>> It have been common practise to use product names for USB PID
>>> definitions instead of USB ID numbers. I vote to continue that practise.
>>>
>>> Also, I am not very sure if it is wise to add new IDs without any
>>> testing. Likely those are just reference design and will work, but
>>> sometimes there is also some changes done for schematic wiring.
>>> Especially for Avermedia, see hacks needed some AF9015 Avermedia
>>> devices. They have put invalid data to eeprom and thus hacks are needed
>>> for overriding tuner IDs etc.
>>> Not to mention, driver supports also dynamic IDs and even device ID is
>>> missing user can load driver using dynamic ID and report it working or
>>> non-working.
>>>
>>> Anyone else any thoughts about adding IDs without testing ?
>>>
>>> regards
>>> Antti
>>
>> Regarding the USB PID definition naming, there is no problem for me.
>> Actually, some product names were used in the modified versions of your
>> old driver, so I converted them to the format above just for
>> convenience. The only problem is that there are so many variations of
>> the Avermedia sticks that it's hard to give them proper names.
>>
>> Some of this IDs are already tested (if we include the several
>> modifications of your old driver).
>>
>> In particular:
>> AF9035_0CCD_00AA : confirmed working on Ubuntu.it forum with the old
>> driver (don't have the link);
>> AF9035_07CA_0825 : confirmed working on OpenPli forum with the old
>> driver (see link above);
>>
>> Others comes from the official Windows drivers so they should be just
>> little variations of the retail products:
>> AF9035_07CA_A825, AF9035_07CA_0835, AF9035_07CA_3867.
>>
>> This IDs are can be the more problematic:
>> AF9035_15A4_1000, AF9035_15A4_1002, AF9035_15A4_1003,
>> AF9035_07CA_A333, AF9035_07CA_0337, AF9035_07CA_F337
>> since there is little or no information about this products.
>>
>> Anyway, this patch can be a reference for users willing to test the new
>> driver.
>
> I mean those definitions that goes to common file named: dvb-usb-ids.h.
> Those are named as a USB_PID_<VENDOR_NAME>_<PRODUCT_NAME>
>
> PIDs inside af9035.c (enum af9035_id_entry) are used only for generating
> table index. Before it was used plain index numbers but that causes in
> past few times problems when people added new device IDs between then
> the table. Meaning of that enum is only keep index in order
> automatically - and it is just fine as it is short unique name as
> currently AF9035_<VID>_<PID>.
>
> Add those IDs you know working and sent patch. Lets add more IDs when
> those are confirmed to work. And as I said I added dynamic ID support
> for that driver, so even there is no USB ID defined inside driver, it
> can be still used without compiling whole Kernel.
>
> regards
> Antti
>
Ok, roger.
As soon as the new driver is merged into the media_build tree, we should
start getting feedback anyway, so let's wait.
Regards,
Gianluca
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] af9035: add several new USB IDs
2012-04-04 13:27 ` Gianluca Gennari
@ 2012-04-05 14:23 ` pierigno
2012-04-05 14:34 ` pierigno
0 siblings, 1 reply; 11+ messages in thread
From: pierigno @ 2012-04-05 14:23 UTC (permalink / raw)
To: gennarone; +Cc: Antti Palosaari, linux-media, m, hfvogt, mchehab
hello,
these are the definitions needed for AVermedia Twinstar. The stick
works correctly so far: I was also able to tune many channels through
kaffeine (~300 channels here in Turin, Italy). and watching
continuously a channel for 4 hours without interruptions or visual
glitches. Switching from one channel to another takes ~1 sec. Just one
tuner is recognized at the moment.
Regards,
Pierangelo Terzulli
--- a/drivers/media/dvb/dvb-usb/af9035.c
+++ b/drivers/media/dvb/dvb-usb/af9035.c
@@ -821,29 +821,68 @@ err:
enum af9035_id_entry {
AF9035_0CCD_0093,
+ AF9035_0CCD_00AA,
AF9035_15A4_9035,
+ AF9035_15A4_1000,
AF9035_15A4_1001,
+ AF9035_15A4_1002,
+ AF9035_15A4_1003,
+ AF9035_07CA_0825,
+ AF9035_07CA_A825,
+ AF9035_07CA_0835,
AF9035_07CA_A835,
AF9035_07CA_B835,
+ AF9035_07CA_A333,
+ AF9035_07CA_0337,
+ AF9035_07CA_F337,
+ AF9035_07CA_0867,
AF9035_07CA_1867,
+ AF9035_07CA_3867,
AF9035_07CA_A867,
+ AF9035_07CA_B867,
};
static struct usb_device_id af9035_id[] = {
[AF9035_0CCD_0093] = {
USB_DEVICE(USB_VID_TERRATEC, USB_PID_TERRATEC_CINERGY_T_STICK)},
+ [AF9035_0CCD_00AA] = {
+ USB_DEVICE(USB_VID_TERRATEC,
USB_PID_TERRATEC_CINERGY_T_STICK_2)},
[AF9035_15A4_9035] = {
USB_DEVICE(USB_VID_AFATECH, USB_PID_AFATECH_AF9035)},
- [AF9035_15A4_1001] = {
+ [AF9035_15A4_1000] = {
USB_DEVICE(USB_VID_AFATECH, USB_PID_AFATECH_AF9035_2)},
+ [AF9035_15A4_1001] = {
+ USB_DEVICE(USB_VID_AFATECH, USB_PID_AFATECH_AF9035_3)},
+ [AF9035_15A4_1002] = {
+ USB_DEVICE(USB_VID_AFATECH, USB_PID_AFATECH_AF9035_4)},
+ [AF9035_15A4_1003] = {
+ USB_DEVICE(USB_VID_AFATECH, USB_PID_AFATECH_AF9035_5)},
+ [AF9035_07CA_0825] = {
+ USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_0825)},
+ [AF9035_07CA_A825] = {
+ USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_A825)},
+ [AF9035_07CA_0835] = {
+ USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_0835)},
[AF9035_07CA_A835] = {
USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_A835)},
[AF9035_07CA_B835] = {
USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_B835)},
+ [AF9035_07CA_A333] = {
+ USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_A333)},
+ [AF9035_07CA_0337] = {
+ USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_0337)},
+ [AF9035_07CA_F337] = {
+ USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_F337)},
+ [AF9035_07CA_0867] = {
+ USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_0867)},
[AF9035_07CA_1867] = {
USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_1867)},
+ [AF9035_07CA_3867] = {
+ USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_3867)},
[AF9035_07CA_A867] = {
USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_A867)},
+ [AF9035_07CA_B867] = {
+ USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_B867)},
{},
};
@@ -886,30 +925,47 @@ static struct dvb_usb_device_properties
af9035_properties[] = {
.i2c_algo = &af9035_i2c_algo,
- .num_device_descs = 4,
+ .num_device_descs = 5,
.devices = {
{
.name = "TerraTec Cinergy T Stick",
.cold_ids = {
&af9035_id[AF9035_0CCD_0093],
+ &af9035_id[AF9035_0CCD_00AA],
},
}, {
.name = "Afatech Technologies DVB-T stick",
.cold_ids = {
&af9035_id[AF9035_15A4_9035],
+ &af9035_id[AF9035_15A4_1000],
&af9035_id[AF9035_15A4_1001],
+ &af9035_id[AF9035_15A4_1002],
+ &af9035_id[AF9035_15A4_1003],
+ },
+ }, {
+ .name = "AVerMedia AVerTV TwinStar (A825)",
+ .cold_ids = {
+ &af9035_id[AF9035_07CA_0825],
+ &af9035_id[AF9035_07CA_A825],
},
}, {
.name = "AVerMedia AVerTV Volar HD/PRO (A835)",
.cold_ids = {
+ &af9035_id[AF9035_07CA_0835],
&af9035_id[AF9035_07CA_A835],
&af9035_id[AF9035_07CA_B835],
},
}, {
.name = "AVerMedia HD Volar (A867)",
.cold_ids = {
+ &af9035_id[AF9035_07CA_A333],
+ &af9035_id[AF9035_07CA_0337],
+ &af9035_id[AF9035_07CA_F337],
+ &af9035_id[AF9035_07CA_0867],
&af9035_id[AF9035_07CA_1867],
+ &af9035_id[AF9035_07CA_3867],
&af9035_id[AF9035_07CA_A867],
+ &af9035_id[AF9035_07CA_B867],
},
},
}
--- a/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
+++ b/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
@@ -77,7 +77,10 @@
#define USB_PID_AFATECH_AF9015_9015 0x9015
#define USB_PID_AFATECH_AF9015_9016 0x9016
#define USB_PID_AFATECH_AF9035 0x9035
-#define USB_PID_AFATECH_AF9035_2 0x1001
+#define USB_PID_AFATECH_AF9035_2 0x1000
+#define USB_PID_AFATECH_AF9035_3 0x1001
+#define USB_PID_AFATECH_AF9035_4 0x1002
+#define USB_PID_AFATECH_AF9035_5 0x1003
#define USB_PID_TREKSTOR_DVBT 0x901b
#define USB_VID_ALINK_DTU 0xf170
#define USB_PID_ANSONIC_DVBT_USB 0x6000
@@ -155,6 +158,7 @@
#define USB_PID_TERRATEC_CINERGY_T_USB_XE 0x0055
#define USB_PID_TERRATEC_CINERGY_T_USB_XE_REV2 0x0069
#define USB_PID_TERRATEC_CINERGY_T_STICK 0x0093
+#define USB_PID_TERRATEC_CINERGY_T_STICK_2 0x00aa
#define USB_PID_TERRATEC_CINERGY_T_STICK_RC 0x0097
#define USB_PID_TERRATEC_CINERGY_T_STICK_DUAL_RC 0x0099
#define USB_PID_TWINHAN_VP7041_COLD 0x3201
@@ -224,10 +228,19 @@
#define USB_PID_AVERMEDIA_A850T 0x850b
#define USB_PID_AVERMEDIA_A805 0xa805
#define USB_PID_AVERMEDIA_A815M 0x815a
+#define USB_PID_AVERMEDIA_0825 0x0825
+#define USB_PID_AVERMEDIA_A825 0xa825
+#define USB_PID_AVERMEDIA_0835 0x0835
#define USB_PID_AVERMEDIA_A835 0xa835
#define USB_PID_AVERMEDIA_B835 0xb835
+#define USB_PID_AVERMEDIA_A333 0xa333
+#define USB_PID_AVERMEDIA_0337 0x0337
+#define USB_PID_AVERMEDIA_F337 0xf337
+#define USB_PID_AVERMEDIA_0867 0x0867
#define USB_PID_AVERMEDIA_1867 0x1867
+#define USB_PID_AVERMEDIA_3867 0x3867
#define USB_PID_AVERMEDIA_A867 0xa867
+#define USB_PID_AVERMEDIA_B867 0xb867
#define USB_PID_TECHNOTREND_CONNECT_S2400 0x3006
#define USB_PID_TECHNOTREND_CONNECT_CT3650 0x300d
#define USB_PID_TERRATEC_CINERGY_DT_XS_DIVERSITY 0x005a
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] af9035: add several new USB IDs
2012-04-05 14:23 ` pierigno
@ 2012-04-05 14:34 ` pierigno
2012-04-05 16:20 ` Gianluca Gennari
0 siblings, 1 reply; 11+ messages in thread
From: pierigno @ 2012-04-05 14:34 UTC (permalink / raw)
To: gennarone; +Cc: Antti Palosaari, linux-media, m, hfvogt, mchehab
gosh!! I pasted the wrong patch, sorry for the noise, here it is (it
should be applied against
http://git.linuxtv.org/anttip/media_tree.git/shortlog/refs/heads/af9035_experimental):
--- drivers/media/dvb/dvb-usb/af9035.c.origin 2012-04-05
15:31:55.431075058 +0200
+++ drivers/media/dvb/dvb-usb/af9035.c 2012-04-05 15:26:44.483073976 +0200
@@ -827,6 +827,7 @@ enum af9035_id_entry {
AF9035_07CA_B835,
AF9035_07CA_1867,
AF9035_07CA_A867,
+ AF9035_07CA_0825,
};
static struct usb_device_id af9035_id[] = {
@@ -844,6 +845,8 @@ static struct usb_device_id af9035_id[]
USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_1867)},
[AF9035_07CA_A867] = {
USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_A867)},
+ [AF9035_07CA_0825] = {
+ USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_TWINSTAR)},
{},
};
@@ -886,7 +889,7 @@ static struct dvb_usb_device_properties
.i2c_algo = &af9035_i2c_algo,
- .num_device_descs = 4,
+ .num_device_descs = 5,
.devices = {
{
.name = "TerraTec Cinergy T Stick",
@@ -911,6 +914,10 @@ static struct dvb_usb_device_properties
&af9035_id[AF9035_07CA_1867],
&af9035_id[AF9035_07CA_A867],
},
+ }, {
+ .name = "AVerMedia Twinstar (0825)",
+ .cold_ids = {
+ &af9035_id[AF9035_07CA_0235],
},
}
},
--- drivers/media/dvb/dvb-usb/dvb-usb-ids.h.origin 2012-04-05
15:32:15.229075128 +0200
+++ drivers/media/dvb/dvb-usb/dvb-usb-ids.h 2012-04-05 15:27:22.775074099 +0200
@@ -228,6 +228,7 @@
#define USB_PID_AVERMEDIA_B835 0xb835
#define USB_PID_AVERMEDIA_1867 0x1867
#define USB_PID_AVERMEDIA_A867 0xa867
+#define USB_PID_AVERMEDIA_TWINSTAR 0x0825
#define USB_PID_TECHNOTREND_CONNECT_S2400 0x3006
#define USB_PID_TECHNOTREND_CONNECT_CT3650 0x300d
#define USB_PID_TERRATEC_CINERGY_DT_XS_DIVERSITY 0x005a
Il 05 aprile 2012 16:23, pierigno <pierigno@gmail.com> ha scritto:
> hello,
>
> these are the definitions needed for AVermedia Twinstar. The stick
> works correctly so far: I was also able to tune many channels through
> kaffeine (~300 channels here in Turin, Italy). and watching
> continuously a channel for 4 hours without interruptions or visual
> glitches. Switching from one channel to another takes ~1 sec. Just one
> tuner is recognized at the moment.
>
> Regards,
> Pierangelo Terzulli
>
>
> --- a/drivers/media/dvb/dvb-usb/af9035.c
> +++ b/drivers/media/dvb/dvb-usb/af9035.c
> @@ -821,29 +821,68 @@ err:
>
> enum af9035_id_entry {
> AF9035_0CCD_0093,
> + AF9035_0CCD_00AA,
> AF9035_15A4_9035,
> + AF9035_15A4_1000,
> AF9035_15A4_1001,
> + AF9035_15A4_1002,
> + AF9035_15A4_1003,
> + AF9035_07CA_0825,
> + AF9035_07CA_A825,
> + AF9035_07CA_0835,
> AF9035_07CA_A835,
> AF9035_07CA_B835,
> + AF9035_07CA_A333,
> + AF9035_07CA_0337,
> + AF9035_07CA_F337,
> + AF9035_07CA_0867,
> AF9035_07CA_1867,
> + AF9035_07CA_3867,
> AF9035_07CA_A867,
> + AF9035_07CA_B867,
> };
>
> static struct usb_device_id af9035_id[] = {
> [AF9035_0CCD_0093] = {
> USB_DEVICE(USB_VID_TERRATEC, USB_PID_TERRATEC_CINERGY_T_STICK)},
> + [AF9035_0CCD_00AA] = {
> + USB_DEVICE(USB_VID_TERRATEC,
> USB_PID_TERRATEC_CINERGY_T_STICK_2)},
> [AF9035_15A4_9035] = {
> USB_DEVICE(USB_VID_AFATECH, USB_PID_AFATECH_AF9035)},
> - [AF9035_15A4_1001] = {
> + [AF9035_15A4_1000] = {
> USB_DEVICE(USB_VID_AFATECH, USB_PID_AFATECH_AF9035_2)},
> + [AF9035_15A4_1001] = {
> + USB_DEVICE(USB_VID_AFATECH, USB_PID_AFATECH_AF9035_3)},
> + [AF9035_15A4_1002] = {
> + USB_DEVICE(USB_VID_AFATECH, USB_PID_AFATECH_AF9035_4)},
> + [AF9035_15A4_1003] = {
> + USB_DEVICE(USB_VID_AFATECH, USB_PID_AFATECH_AF9035_5)},
> + [AF9035_07CA_0825] = {
> + USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_0825)},
> + [AF9035_07CA_A825] = {
> + USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_A825)},
> + [AF9035_07CA_0835] = {
> + USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_0835)},
> [AF9035_07CA_A835] = {
> USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_A835)},
> [AF9035_07CA_B835] = {
> USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_B835)},
> + [AF9035_07CA_A333] = {
> + USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_A333)},
> + [AF9035_07CA_0337] = {
> + USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_0337)},
> + [AF9035_07CA_F337] = {
> + USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_F337)},
> + [AF9035_07CA_0867] = {
> + USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_0867)},
> [AF9035_07CA_1867] = {
> USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_1867)},
> + [AF9035_07CA_3867] = {
> + USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_3867)},
> [AF9035_07CA_A867] = {
> USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_A867)},
> + [AF9035_07CA_B867] = {
> + USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_B867)},
> {},
> };
>
> @@ -886,30 +925,47 @@ static struct dvb_usb_device_properties
> af9035_properties[] = {
>
> .i2c_algo = &af9035_i2c_algo,
>
> - .num_device_descs = 4,
> + .num_device_descs = 5,
> .devices = {
> {
> .name = "TerraTec Cinergy T Stick",
> .cold_ids = {
> &af9035_id[AF9035_0CCD_0093],
> + &af9035_id[AF9035_0CCD_00AA],
> },
> }, {
> .name = "Afatech Technologies DVB-T stick",
> .cold_ids = {
> &af9035_id[AF9035_15A4_9035],
> + &af9035_id[AF9035_15A4_1000],
> &af9035_id[AF9035_15A4_1001],
> + &af9035_id[AF9035_15A4_1002],
> + &af9035_id[AF9035_15A4_1003],
> + },
> + }, {
> + .name = "AVerMedia AVerTV TwinStar (A825)",
> + .cold_ids = {
> + &af9035_id[AF9035_07CA_0825],
> + &af9035_id[AF9035_07CA_A825],
> },
> }, {
> .name = "AVerMedia AVerTV Volar HD/PRO (A835)",
> .cold_ids = {
> + &af9035_id[AF9035_07CA_0835],
> &af9035_id[AF9035_07CA_A835],
> &af9035_id[AF9035_07CA_B835],
> },
> }, {
> .name = "AVerMedia HD Volar (A867)",
> .cold_ids = {
> + &af9035_id[AF9035_07CA_A333],
> + &af9035_id[AF9035_07CA_0337],
> + &af9035_id[AF9035_07CA_F337],
> + &af9035_id[AF9035_07CA_0867],
> &af9035_id[AF9035_07CA_1867],
> + &af9035_id[AF9035_07CA_3867],
> &af9035_id[AF9035_07CA_A867],
> + &af9035_id[AF9035_07CA_B867],
> },
> },
> }
>
> --- a/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
> +++ b/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
> @@ -77,7 +77,10 @@
> #define USB_PID_AFATECH_AF9015_9015 0x9015
> #define USB_PID_AFATECH_AF9015_9016 0x9016
> #define USB_PID_AFATECH_AF9035 0x9035
> -#define USB_PID_AFATECH_AF9035_2 0x1001
> +#define USB_PID_AFATECH_AF9035_2 0x1000
> +#define USB_PID_AFATECH_AF9035_3 0x1001
> +#define USB_PID_AFATECH_AF9035_4 0x1002
> +#define USB_PID_AFATECH_AF9035_5 0x1003
> #define USB_PID_TREKSTOR_DVBT 0x901b
> #define USB_VID_ALINK_DTU 0xf170
> #define USB_PID_ANSONIC_DVBT_USB 0x6000
> @@ -155,6 +158,7 @@
> #define USB_PID_TERRATEC_CINERGY_T_USB_XE 0x0055
> #define USB_PID_TERRATEC_CINERGY_T_USB_XE_REV2 0x0069
> #define USB_PID_TERRATEC_CINERGY_T_STICK 0x0093
> +#define USB_PID_TERRATEC_CINERGY_T_STICK_2 0x00aa
> #define USB_PID_TERRATEC_CINERGY_T_STICK_RC 0x0097
> #define USB_PID_TERRATEC_CINERGY_T_STICK_DUAL_RC 0x0099
> #define USB_PID_TWINHAN_VP7041_COLD 0x3201
> @@ -224,10 +228,19 @@
> #define USB_PID_AVERMEDIA_A850T 0x850b
> #define USB_PID_AVERMEDIA_A805 0xa805
> #define USB_PID_AVERMEDIA_A815M 0x815a
> +#define USB_PID_AVERMEDIA_0825 0x0825
> +#define USB_PID_AVERMEDIA_A825 0xa825
> +#define USB_PID_AVERMEDIA_0835 0x0835
> #define USB_PID_AVERMEDIA_A835 0xa835
> #define USB_PID_AVERMEDIA_B835 0xb835
> +#define USB_PID_AVERMEDIA_A333 0xa333
> +#define USB_PID_AVERMEDIA_0337 0x0337
> +#define USB_PID_AVERMEDIA_F337 0xf337
> +#define USB_PID_AVERMEDIA_0867 0x0867
> #define USB_PID_AVERMEDIA_1867 0x1867
> +#define USB_PID_AVERMEDIA_3867 0x3867
> #define USB_PID_AVERMEDIA_A867 0xa867
> +#define USB_PID_AVERMEDIA_B867 0xb867
> #define USB_PID_TECHNOTREND_CONNECT_S2400 0x3006
> #define USB_PID_TECHNOTREND_CONNECT_CT3650 0x300d
> #define USB_PID_TERRATEC_CINERGY_DT_XS_DIVERSITY 0x005a
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] af9035: add several new USB IDs
2012-04-05 14:34 ` pierigno
@ 2012-04-05 16:20 ` Gianluca Gennari
2012-04-05 19:03 ` pierigno
0 siblings, 1 reply; 11+ messages in thread
From: Gianluca Gennari @ 2012-04-05 16:20 UTC (permalink / raw)
To: pierigno; +Cc: Antti Palosaari, linux-media, m, hfvogt, mchehab
Thanks Pierangelo,
but there are still issues with your patch.
See in-line comments.
Il 05/04/2012 16:34, pierigno ha scritto:
> gosh!! I pasted the wrong patch, sorry for the noise, here it is (it
> should be applied against
> http://git.linuxtv.org/anttip/media_tree.git/shortlog/refs/heads/af9035_experimental):
>
>
> --- drivers/media/dvb/dvb-usb/af9035.c.origin 2012-04-05
> 15:31:55.431075058 +0200
> +++ drivers/media/dvb/dvb-usb/af9035.c 2012-04-05 15:26:44.483073976 +0200
> @@ -827,6 +827,7 @@ enum af9035_id_entry {
> AF9035_07CA_B835,
> AF9035_07CA_1867,
> AF9035_07CA_A867,
> + AF9035_07CA_0825,
here you define AF9035_07CA_0825....
> };
>
> static struct usb_device_id af9035_id[] = {
> @@ -844,6 +845,8 @@ static struct usb_device_id af9035_id[]
> USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_1867)},
> [AF9035_07CA_A867] = {
> USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_A867)},
> + [AF9035_07CA_0825] = {
> + USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_TWINSTAR)},
> {},
> };
>
> @@ -886,7 +889,7 @@ static struct dvb_usb_device_properties
>
> .i2c_algo = &af9035_i2c_algo,
>
> - .num_device_descs = 4,
> + .num_device_descs = 5,
> .devices = {
> {
> .name = "TerraTec Cinergy T Stick",
> @@ -911,6 +914,10 @@ static struct dvb_usb_device_properties
> &af9035_id[AF9035_07CA_1867],
> &af9035_id[AF9035_07CA_A867],
> },
> + }, {
> + .name = "AVerMedia Twinstar (0825)",
> + .cold_ids = {
> + &af9035_id[AF9035_07CA_0235],
... and here you use AF9035_07CA_0235!
Also, I think the name should be something like "AVerMedia Twinstar
(A825)" since Avermedia code names usually are "Axxx".
> },
> }
> },
>
> --- drivers/media/dvb/dvb-usb/dvb-usb-ids.h.origin 2012-04-05
> 15:32:15.229075128 +0200
> +++ drivers/media/dvb/dvb-usb/dvb-usb-ids.h 2012-04-05 15:27:22.775074099 +0200
> @@ -228,6 +228,7 @@
> #define USB_PID_AVERMEDIA_B835 0xb835
> #define USB_PID_AVERMEDIA_1867 0x1867
> #define USB_PID_AVERMEDIA_A867 0xa867
> +#define USB_PID_AVERMEDIA_TWINSTAR 0x0825
> #define USB_PID_TECHNOTREND_CONNECT_S2400 0x3006
> #define USB_PID_TECHNOTREND_CONNECT_CT3650 0x300d
> #define USB_PID_TERRATEC_CINERGY_DT_XS_DIVERSITY 0x005a
>
>
Also, remember to put your "Signed-off-by" line on the patch.
Regards,
Gianluca
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] af9035: add several new USB IDs
2012-04-05 16:20 ` Gianluca Gennari
@ 2012-04-05 19:03 ` pierigno
2012-04-06 0:30 ` Antti Palosaari
0 siblings, 1 reply; 11+ messages in thread
From: pierigno @ 2012-04-05 19:03 UTC (permalink / raw)
To: gennarone; +Cc: Antti Palosaari, linux-media, m, hfvogt, mchehab
Damn!! here it is again, corrected. I'm really sorry, thanks for the patience :)
> Also, I think the name should be something like "AVerMedia Twinstar
> (A825)" since Avermedia code names usually are "Axxx".
I thought the name between parenthesis was after the usb pvid value so
I used that value.
This is what I get with lsusb:
# lsusb
bus 003 Device 002: ID 07ca:0825 AVerMedia Technologies, Inc.
I've modified the name with "AVermedia Twinstar (A825) as you
suggested, should I revert it?
--- drivers/media/dvb/dvb-usb/af9035.c.origin 2012-04-05
15:31:55.431075058 +0200
+++ drivers/media/dvb/dvb-usb/af9035.c 2012-04-05 15:26:44.483073976 +0200
@@ -827,6 +827,7 @@ enum af9035_id_entry {
AF9035_07CA_B835,
AF9035_07CA_1867,
AF9035_07CA_A867,
+ AF9035_07CA_0825,
};
static struct usb_device_id af9035_id[] = {
@@ -844,6 +845,8 @@ static struct usb_device_id af9035_id[]
USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_1867)},
[AF9035_07CA_A867] = {
USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_A867)},
+ [AF9035_07CA_0825] = {
+ USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_TWINSTAR)},
{},
};
@@ -886,7 +889,7 @@ static struct dvb_usb_device_properties
.i2c_algo = &af9035_i2c_algo,
- .num_device_descs = 4,
+ .num_device_descs = 5,
.devices = {
{
.name = "TerraTec Cinergy T Stick",
@@ -911,6 +914,10 @@ static struct dvb_usb_device_properties
&af9035_id[AF9035_07CA_1867],
&af9035_id[AF9035_07CA_A867],
},
+ }, {
+ .name = "AVerMedia Twinstar (A825)",
+ .cold_ids = {
+ &af9035_id[AF9035_07CA_0825],
},
}
},
--- drivers/media/dvb/dvb-usb/dvb-usb-ids.h.origin 2012-04-05
15:32:15.229075128 +0200
+++ drivers/media/dvb/dvb-usb/dvb-usb-ids.h 2012-04-05
15:27:22.775074099 +0200
@@ -228,6 +228,7 @@
#define USB_PID_AVERMEDIA_B835 0xb835
#define USB_PID_AVERMEDIA_1867 0x1867
#define USB_PID_AVERMEDIA_A867 0xa867
+#define USB_PID_AVERMEDIA_TWINSTAR 0x0825
#define USB_PID_TECHNOTREND_CONNECT_S2400 0x3006
#define USB_PID_TECHNOTREND_CONNECT_CT3650 0x300d
#define USB_PID_TERRATEC_CINERGY_DT_XS_DIVERSITY 0x005a
Signed-off-by: Pierangelo Terzulli <pierigno@gmail.com>
Il 05 aprile 2012 18:20, Gianluca Gennari <gennarone@gmail.com> ha scritto:
> Thanks Pierangelo,
> but there are still issues with your patch.
> See in-line comments.
>
> Il 05/04/2012 16:34, pierigno ha scritto:
>> gosh!! I pasted the wrong patch, sorry for the noise, here it is (it
>> should be applied against
>> http://git.linuxtv.org/anttip/media_tree.git/shortlog/refs/heads/af9035_experimental):
>>
>>
>> --- drivers/media/dvb/dvb-usb/af9035.c.origin 2012-04-05
>> 15:31:55.431075058 +0200
>> +++ drivers/media/dvb/dvb-usb/af9035.c 2012-04-05 15:26:44.483073976 +0200
>> @@ -827,6 +827,7 @@ enum af9035_id_entry {
>> AF9035_07CA_B835,
>> AF9035_07CA_1867,
>> AF9035_07CA_A867,
>> + AF9035_07CA_0825,
>
> here you define AF9035_07CA_0825....
>
>> };
>>
>> static struct usb_device_id af9035_id[] = {
>> @@ -844,6 +845,8 @@ static struct usb_device_id af9035_id[]
>> USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_1867)},
>> [AF9035_07CA_A867] = {
>> USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_A867)},
>> + [AF9035_07CA_0825] = {
>> + USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_TWINSTAR)},
>> {},
>> };
>>
>> @@ -886,7 +889,7 @@ static struct dvb_usb_device_properties
>>
>> .i2c_algo = &af9035_i2c_algo,
>>
>> - .num_device_descs = 4,
>> + .num_device_descs = 5,
>> .devices = {
>> {
>> .name = "TerraTec Cinergy T Stick",
>> @@ -911,6 +914,10 @@ static struct dvb_usb_device_properties
>> &af9035_id[AF9035_07CA_1867],
>> &af9035_id[AF9035_07CA_A867],
>> },
>> + }, {
>> + .name = "AVerMedia Twinstar (0825)",
>> + .cold_ids = {
>> + &af9035_id[AF9035_07CA_0235],
>
> ... and here you use AF9035_07CA_0235!
> Also, I think the name should be something like "AVerMedia Twinstar
> (A825)" since Avermedia code names usually are "Axxx".
>
>
>> },
>> }
>> },
>>
>> --- drivers/media/dvb/dvb-usb/dvb-usb-ids.h.origin 2012-04-05
>> 15:32:15.229075128 +0200
>> +++ drivers/media/dvb/dvb-usb/dvb-usb-ids.h 2012-04-05 15:27:22.775074099 +0200
>> @@ -228,6 +228,7 @@
>> #define USB_PID_AVERMEDIA_B835 0xb835
>> #define USB_PID_AVERMEDIA_1867 0x1867
>> #define USB_PID_AVERMEDIA_A867 0xa867
>> +#define USB_PID_AVERMEDIA_TWINSTAR 0x0825
>> #define USB_PID_TECHNOTREND_CONNECT_S2400 0x3006
>> #define USB_PID_TECHNOTREND_CONNECT_CT3650 0x300d
>> #define USB_PID_TERRATEC_CINERGY_DT_XS_DIVERSITY 0x005a
>>
>>
>
> Also, remember to put your "Signed-off-by" line on the patch.
>
> Regards,
> Gianluca
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] af9035: add several new USB IDs
2012-04-05 19:03 ` pierigno
@ 2012-04-06 0:30 ` Antti Palosaari
0 siblings, 0 replies; 11+ messages in thread
From: Antti Palosaari @ 2012-04-06 0:30 UTC (permalink / raw)
To: pierigno; +Cc: gennarone, linux-media, m, hfvogt, mchehab
On 05.04.2012 22:03, pierigno wrote:
> Damn!! here it is again, corrected. I'm really sorry, thanks for the patience :)
>
>> Also, I think the name should be something like "AVerMedia Twinstar
>> (A825)" since Avermedia code names usually are "Axxx".
>
> I thought the name between parenthesis was after the usb pvid value so
> I used that value.
> This is what I get with lsusb:
>
> # lsusb
> bus 003 Device 002: ID 07ca:0825 AVerMedia Technologies, Inc.
>
> I've modified the name with "AVermedia Twinstar (A825) as you
> suggested, should I revert it?
I applied it!
http://git.linuxtv.org/anttip/media_tree.git/shortlog/refs/heads/af9035_experimental
It didn't apply for git since errors, but as it was small patch I
applied it manually.
regards
Antti
--
http://palosaari.fi/
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2012-04-06 0:30 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-04 11:47 [PATCH] af9035: add several new USB IDs Gianluca Gennari
2012-04-04 11:59 ` Antti Palosaari
2012-04-04 12:11 ` David Cohen
2012-04-04 12:40 ` Gianluca Gennari
2012-04-04 13:09 ` Antti Palosaari
2012-04-04 13:27 ` Gianluca Gennari
2012-04-05 14:23 ` pierigno
2012-04-05 14:34 ` pierigno
2012-04-05 16:20 ` Gianluca Gennari
2012-04-05 19:03 ` pierigno
2012-04-06 0:30 ` Antti Palosaari
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.