* [Qemu-devel] [PATCH] configure: Remove useless uses of ARCH_CFLAGS
@ 2012-04-04 16:03 Peter Maydell
2012-04-05 7:19 ` Andreas Färber
0 siblings, 1 reply; 2+ messages in thread
From: Peter Maydell @ 2012-04-04 16:03 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Juan Quintela, Michael S. Tsirkin, patches
Remove some useless uses of ARCH_CFLAGS -- this variable was never set
so will always be empty. The uses were accidental: in commit 0c439cbf8
Juan Quintela removed ARCH_CFLAGS in favour of CFLAGS (which in turn
became QEMU_CFLAGS). However in commit be17dc90 a use of it was
reintroduced (apparently accidentally) by Michael S. Tsirkin, and then
I subsequently cut-n-pasted that into a number of other configure
feature tests.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
configure | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/configure b/configure
index 4b3adc9..80a3e8d 100755
--- a/configure
+++ b/configure
@@ -2361,7 +2361,7 @@ int main(void)
return 0;
}
EOF
-if compile_prog "$ARCH_CFLAGS" "" ; then
+if compile_prog "" "" ; then
fallocate=yes
fi
@@ -2376,7 +2376,7 @@ int main(void)
return 0;
}
EOF
-if compile_prog "$ARCH_CFLAGS" "" ; then
+if compile_prog "" "" ; then
sync_file_range=yes
fi
@@ -2393,7 +2393,7 @@ int main(void)
return 0;
}
EOF
-if compile_prog "$ARCH_CFLAGS" "" ; then
+if compile_prog "" "" ; then
fiemap=yes
fi
@@ -2423,7 +2423,7 @@ int main(void)
return 0;
}
EOF
-if compile_prog "$ARCH_CFLAGS" "" ; then
+if compile_prog "" "" ; then
epoll=yes
fi
@@ -2446,7 +2446,7 @@ int main(void)
return epoll_create1 == epoll_create1;
}
EOF
-if compile_prog "$ARCH_CFLAGS" "" ; then
+if compile_prog "" "" ; then
epoll_create1=yes
fi
@@ -2460,7 +2460,7 @@ int main(void)
return 0;
}
EOF
-if compile_prog "$ARCH_CFLAGS" "" ; then
+if compile_prog "" "" ; then
epoll_pwait=yes
fi
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: Remove useless uses of ARCH_CFLAGS
2012-04-04 16:03 [Qemu-devel] [PATCH] configure: Remove useless uses of ARCH_CFLAGS Peter Maydell
@ 2012-04-05 7:19 ` Andreas Färber
0 siblings, 0 replies; 2+ messages in thread
From: Andreas Färber @ 2012-04-05 7:19 UTC (permalink / raw)
To: Peter Maydell
Cc: qemu-trivial, Michael S. Tsirkin, qemu-devel, patches, Juan Quintela
Am 04.04.2012 18:03, schrieb Peter Maydell:
> Remove some useless uses of ARCH_CFLAGS -- this variable was never set
> so will always be empty. The uses were accidental: in commit 0c439cbf8
> Juan Quintela removed ARCH_CFLAGS in favour of CFLAGS (which in turn
> became QEMU_CFLAGS). However in commit be17dc90 a use of it was
> reintroduced (apparently accidentally) by Michael S. Tsirkin, and then
> I subsequently cut-n-pasted that into a number of other configure
> feature tests.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Andreas Färber <afaerber@suse.de>
Thanks,
/-F
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-05 7:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-04 16:03 [Qemu-devel] [PATCH] configure: Remove useless uses of ARCH_CFLAGS Peter Maydell
2012-04-05 7:19 ` Andreas Färber
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.