All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konstantin Khlebnikov <khlebnikov@openvz.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Hugh Dickins <hughd@google.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	Markus Trippelsdorf <markus@trippelsdorf.de>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH v2] mm: correctly synchronize rss-counters at exit/exec
Date: Wed, 11 Apr 2012 00:09:14 +0400	[thread overview]
Message-ID: <4F84936A.1060708@openvz.org> (raw)
In-Reply-To: <20120410191059.GA5678@redhat.com>

Oleg Nesterov wrote:
> On 04/10, Konstantin Khlebnikov wrote:
>>
>> This patch moves sync_mm_rss() into mm_release(), and moves mm_release() out of
>> do_exit() and calls it earlier. After mm_release() there should be no page-faults.
>
> Can't prove, but I feel there should be a simpler fix...
>
> Anyway, this patch is not exactly correct.
>
>> @@ -959,9 +959,10 @@ void do_exit(long code)
>>   				preempt_count());
>>
>>   	acct_update_integrals(tsk);
>> -	/* sync mm's RSS info before statistics gathering */
>> -	if (tsk->mm)
>> -		sync_mm_rss(tsk->mm);
>> +
>> +	/* Release mm and sync mm's RSS info before statistics gathering */
>> +	mm_release(tsk, tsk->mm);
>
> This breaks kthread_stop() at least.
>
> The exiting kthread shouldn't do complete_vfork_done() until it
> sets ->exit_code.

Ouch, I was afraid something like that.

>
> Oleg.
>


WARNING: multiple messages have this Message-ID (diff)
From: Konstantin Khlebnikov <khlebnikov@openvz.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Hugh Dickins <hughd@google.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	Markus Trippelsdorf <markus@trippelsdorf.de>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH v2] mm: correctly synchronize rss-counters at exit/exec
Date: Wed, 11 Apr 2012 00:09:14 +0400	[thread overview]
Message-ID: <4F84936A.1060708@openvz.org> (raw)
In-Reply-To: <20120410191059.GA5678@redhat.com>

Oleg Nesterov wrote:
> On 04/10, Konstantin Khlebnikov wrote:
>>
>> This patch moves sync_mm_rss() into mm_release(), and moves mm_release() out of
>> do_exit() and calls it earlier. After mm_release() there should be no page-faults.
>
> Can't prove, but I feel there should be a simpler fix...
>
> Anyway, this patch is not exactly correct.
>
>> @@ -959,9 +959,10 @@ void do_exit(long code)
>>   				preempt_count());
>>
>>   	acct_update_integrals(tsk);
>> -	/* sync mm's RSS info before statistics gathering */
>> -	if (tsk->mm)
>> -		sync_mm_rss(tsk->mm);
>> +
>> +	/* Release mm and sync mm's RSS info before statistics gathering */
>> +	mm_release(tsk, tsk->mm);
>
> This breaks kthread_stop() at least.
>
> The exiting kthread shouldn't do complete_vfork_done() until it
> sets ->exit_code.

Ouch, I was afraid something like that.

>
> Oleg.
>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2012-04-10 20:09 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-09 20:03 [PATCH] mm: sync rss-counters at the end of exit_mm() Konstantin Khlebnikov
2012-04-09 20:03 ` Konstantin Khlebnikov
2012-04-09 21:04 ` KOSAKI Motohiro
2012-04-09 21:04   ` KOSAKI Motohiro
2012-04-09 22:03   ` Hugh Dickins
2012-04-10  0:33     ` KAMEZAWA Hiroyuki
2012-04-10  0:33       ` KAMEZAWA Hiroyuki
2012-04-10  6:34     ` Konstantin Khlebnikov
2012-04-10  6:34       ` Konstantin Khlebnikov
2012-04-10 16:04       ` Markus Trippelsdorf
2012-04-10 16:04         ` Markus Trippelsdorf
2012-04-10  0:35 ` KAMEZAWA Hiroyuki
2012-04-10  0:35   ` KAMEZAWA Hiroyuki
2012-04-10  5:43   ` Konstantin Khlebnikov
2012-04-10  5:43     ` Konstantin Khlebnikov
2012-04-10 17:07 ` [PATCH v2] mm: correctly synchronize rss-counters at exit/exec Konstantin Khlebnikov
2012-04-10 17:07   ` Konstantin Khlebnikov
2012-04-10 18:43   ` Andrew Morton
2012-04-10 18:43     ` Andrew Morton
2012-04-10 19:52     ` Konstantin Khlebnikov
2012-04-10 19:52       ` Konstantin Khlebnikov
2012-04-10 19:10   ` Oleg Nesterov
2012-04-10 19:10     ` Oleg Nesterov
2012-04-10 20:09     ` Konstantin Khlebnikov [this message]
2012-04-10 20:09       ` Konstantin Khlebnikov
2012-04-12  8:09 ` [PATCH 1/2] mm: set task exit code before complete_vfork_done() Konstantin Khlebnikov
2012-04-12  8:09   ` Konstantin Khlebnikov
2012-04-12 23:35   ` Andrew Morton
2012-04-12 23:35     ` Andrew Morton
2012-04-12 23:54   ` Oleg Nesterov
2012-04-12 23:54     ` Oleg Nesterov
2012-04-20 17:59     ` Oleg Nesterov
2012-04-20 17:59       ` Oleg Nesterov
2012-04-20 19:23       ` Konstantin Khlebnikov
2012-04-20 19:23         ` Konstantin Khlebnikov
2012-04-20 20:41         ` Oleg Nesterov
2012-04-20 20:41           ` Oleg Nesterov
2012-04-25 20:01           ` Andrew Morton
2012-04-25 20:01             ` Andrew Morton
2012-04-12  8:09 ` [PATCH 2/2] mm: call complete_vfork_done() after clearing child_tid and flushing rss-counters Konstantin Khlebnikov
2012-04-12  8:09   ` Konstantin Khlebnikov
2012-04-12 23:39   ` Andrew Morton
2012-04-12 23:39     ` Andrew Morton
2012-04-13  6:43     ` Konstantin Khlebnikov
2012-04-13  6:43       ` Konstantin Khlebnikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F84936A.1060708@openvz.org \
    --to=khlebnikov@openvz.org \
    --cc=akpm@linux-foundation.org \
    --cc=hughd@google.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=markus@trippelsdorf.de \
    --cc=oleg@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.