All of lore.kernel.org
 help / color / mirror / Atom feed
* Network problem with 3.3
@ 2012-04-11 16:09 Gary Thomas
  0 siblings, 0 replies; 5+ messages in thread
From: Gary Thomas @ 2012-04-11 16:09 UTC (permalink / raw)
  To: linuxppc-dev

I'm trying to port my MPC8379 board from 3.0 to 3.3.  In 3.0, I have
this setup in my device tree:

		mdio@24520 {
			#address-cells = <1>;
			#size-cells = <0>;
			compatible = "fsl,gianfar-mdio";
			reg = <0x24520 0x20>;

			phy0: ethernet-phy@0 {
				interrupt-parent = <&ipic>;
				interrupts = <17 0x8>;
				reg = <0x01>;
				device_type = "ethernet-phy";
			};
			phy1: ethernet-phy@1 {
				interrupt-parent = <&ipic>;
				interrupts = <18 0x8>;
				reg = <0x00>;
				device_type = "ethernet-phy";
			};
		};

		enet0: ethernet@24000 {
			cell-index = <0>;
			device_type = "network";
			model = "TSEC";
			compatible = "gianfar";
			reg = <0x24000 0x1000>;
			local-mac-address = [ 00 08 e5 11 32 33 ];
			interrupts = <32 0x8 33 0x8 34 0x8>;
			interrupt-parent = <&ipic>;
			phy-handle = <&phy0>;
			linux,network-index = <0>;
		};

		enet1: ethernet@25000 {
			cell-index = <1>;
			device_type = "network";
			model = "TSEC";
			compatible = "gianfar";
			reg = <0x25000 0x1000>;
			local-mac-address = [ 00 08 e5 11 32 34 ];
			interrupts = <35 0x8 36 0x8 37 0x8>;
			interrupt-parent = <&ipic>;
			phy-handle = <&phy1>;
			linux,network-index = <1>;
		};

On 3.0, this works just fine.  When I boot the same setup on 3.3,
I get this error:
   fsl-pq_mdio: probe of ff024520.mdio failed with error -16

Is there something I need to change in my DTS file to make this work?
Something else I might be missing?

Thanks

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Network problem with 3.3
  2012-04-11 16:57   ` Joakim Tjernlund
@ 2012-04-11 17:06     ` Gary Thomas
  0 siblings, 0 replies; 5+ messages in thread
From: Gary Thomas @ 2012-04-11 17:06 UTC (permalink / raw)
  To: Joakim Tjernlund; +Cc: linuxppc-dev

On 2012-04-11 10:57, Joakim Tjernlund wrote:
>>
>> On 2012-04-11 10:14, Gary Thomas wrote:
>>>
>>> n.b. sorry if you receive this twice - ThunderBird seems very crashy lately!
>>>
>>> I'm trying to update my MPC8379 board from 3.0 to 3.3. I have
>>> this setup in my device tree:
>>>
>>> mdio@24520 {
>>> #address-cells =<1>;
>>> #size-cells =<0>;
>>> compatible = "fsl,gianfar-mdio";
>>> reg =<0x24520 0x20>;
>>>
>>> phy0: ethernet-phy@0 {
>>> interrupt-parent =<&ipic>;
>>> interrupts =<17 0x8>;
>>> reg =<0x01>;
>>> device_type = "ethernet-phy";
>>> };
>>> phy1: ethernet-phy@1 {
>>> interrupt-parent =<&ipic>;
>>> interrupts =<18 0x8>;
>>> reg =<0x00>;
>>> device_type = "ethernet-phy";
>>> };
>>> };
>>>
>>> enet0: ethernet@24000 {
>>> cell-index =<0>;
>>> device_type = "network";
>>> model = "TSEC";
>>> compatible = "gianfar";
>>> reg =<0x24000 0x1000>;
>>> local-mac-address = [ 00 08 e5 11 32 33 ];
>>> interrupts =<32 0x8 33 0x8 34 0x8>;
>>> interrupt-parent =<&ipic>;
>>> phy-handle =<&phy0>;
>>> linux,network-index =<0>;
>>> };
>>>
>>> enet1: ethernet@25000 {
>>> cell-index =<1>;
>>> device_type = "network";
>>> model = "TSEC";
>>> compatible = "gianfar";
>>> reg =<0x25000 0x1000>;
>>> local-mac-address = [ 00 08 e5 11 32 34 ];
>>> interrupts =<35 0x8 36 0x8 37 0x8>;
>>> interrupt-parent =<&ipic>;
>>> phy-handle =<&phy1>;
>>> linux,network-index =<1>;
>>> };
>>>
>>> On 3.0, this works just fine. When I boot the same setup on 3.3,
>>> I get this error:
>>> fsl-pq_mdio: probe of ff024520.mdio failed with error -16
>>>
>>> Is there something I need to change in my DTS file to make this work?
>>> Something else I might be missing?
>>
>> I think I found it - I need to add a TBI node to my PHY setup.
>> It's working now.
>
> Do you have a TBI PHY? There is a bug in 3.3 where every non-TBI PHY would fail, see
>    http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=464b57da56910c8737ede75ad820b9a7afc46b3e
> for a fix.

Thanks.  After applying this patch, networking is working fine on
my board, with no TBI node in the PHY.

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Network problem with 3.3
  2012-04-11 16:22 ` Gary Thomas
@ 2012-04-11 16:57   ` Joakim Tjernlund
  2012-04-11 17:06     ` Gary Thomas
  0 siblings, 1 reply; 5+ messages in thread
From: Joakim Tjernlund @ 2012-04-11 16:57 UTC (permalink / raw)
  To: Gary Thomas; +Cc: linuxppc-dev

>
> On 2012-04-11 10:14, Gary Thomas wrote:
> >
> > n.b. sorry if you receive this twice - ThunderBird seems very crashy lately!
> >
> > I'm trying to update my MPC8379 board from 3.0 to 3.3. I have
> > this setup in my device tree:
> >
> > mdio@24520 {
> > #address-cells = <1>;
> > #size-cells = <0>;
> > compatible = "fsl,gianfar-mdio";
> > reg = <0x24520 0x20>;
> >
> > phy0: ethernet-phy@0 {
> > interrupt-parent = <&ipic>;
> > interrupts = <17 0x8>;
> > reg = <0x01>;
> > device_type = "ethernet-phy";
> > };
> > phy1: ethernet-phy@1 {
> > interrupt-parent = <&ipic>;
> > interrupts = <18 0x8>;
> > reg = <0x00>;
> > device_type = "ethernet-phy";
> > };
> > };
> >
> > enet0: ethernet@24000 {
> > cell-index = <0>;
> > device_type = "network";
> > model = "TSEC";
> > compatible = "gianfar";
> > reg = <0x24000 0x1000>;
> > local-mac-address = [ 00 08 e5 11 32 33 ];
> > interrupts = <32 0x8 33 0x8 34 0x8>;
> > interrupt-parent = <&ipic>;
> > phy-handle = <&phy0>;
> > linux,network-index = <0>;
> > };
> >
> > enet1: ethernet@25000 {
> > cell-index = <1>;
> > device_type = "network";
> > model = "TSEC";
> > compatible = "gianfar";
> > reg = <0x25000 0x1000>;
> > local-mac-address = [ 00 08 e5 11 32 34 ];
> > interrupts = <35 0x8 36 0x8 37 0x8>;
> > interrupt-parent = <&ipic>;
> > phy-handle = <&phy1>;
> > linux,network-index = <1>;
> > };
> >
> > On 3.0, this works just fine. When I boot the same setup on 3.3,
> > I get this error:
> > fsl-pq_mdio: probe of ff024520.mdio failed with error -16
> >
> > Is there something I need to change in my DTS file to make this work?
> > Something else I might be missing?
>
> I think I found it - I need to add a TBI node to my PHY setup.
> It's working now.

Do you have a TBI PHY? There is a bug in 3.3 where every non-TBI PHY would fail, see
  http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=464b57da56910c8737ede75ad820b9a7afc46b3e
for a fix.

 Jocke

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Network problem with 3.3
  2012-04-11 16:14 Gary Thomas
@ 2012-04-11 16:22 ` Gary Thomas
  2012-04-11 16:57   ` Joakim Tjernlund
  0 siblings, 1 reply; 5+ messages in thread
From: Gary Thomas @ 2012-04-11 16:22 UTC (permalink / raw)
  To: linuxppc-dev

On 2012-04-11 10:14, Gary Thomas wrote:
>
> n.b. sorry if you receive this twice - ThunderBird seems very crashy lately!
>
> I'm trying to update my MPC8379 board from 3.0 to 3.3. I have
> this setup in my device tree:
>
> mdio@24520 {
> #address-cells = <1>;
> #size-cells = <0>;
> compatible = "fsl,gianfar-mdio";
> reg = <0x24520 0x20>;
>
> phy0: ethernet-phy@0 {
> interrupt-parent = <&ipic>;
> interrupts = <17 0x8>;
> reg = <0x01>;
> device_type = "ethernet-phy";
> };
> phy1: ethernet-phy@1 {
> interrupt-parent = <&ipic>;
> interrupts = <18 0x8>;
> reg = <0x00>;
> device_type = "ethernet-phy";
> };
> };
>
> enet0: ethernet@24000 {
> cell-index = <0>;
> device_type = "network";
> model = "TSEC";
> compatible = "gianfar";
> reg = <0x24000 0x1000>;
> local-mac-address = [ 00 08 e5 11 32 33 ];
> interrupts = <32 0x8 33 0x8 34 0x8>;
> interrupt-parent = <&ipic>;
> phy-handle = <&phy0>;
> linux,network-index = <0>;
> };
>
> enet1: ethernet@25000 {
> cell-index = <1>;
> device_type = "network";
> model = "TSEC";
> compatible = "gianfar";
> reg = <0x25000 0x1000>;
> local-mac-address = [ 00 08 e5 11 32 34 ];
> interrupts = <35 0x8 36 0x8 37 0x8>;
> interrupt-parent = <&ipic>;
> phy-handle = <&phy1>;
> linux,network-index = <1>;
> };
>
> On 3.0, this works just fine. When I boot the same setup on 3.3,
> I get this error:
> fsl-pq_mdio: probe of ff024520.mdio failed with error -16
>
> Is there something I need to change in my DTS file to make this work?
> Something else I might be missing?

I think I found it - I need to add a TBI node to my PHY setup.
It's working now.

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Network problem with 3.3
@ 2012-04-11 16:14 Gary Thomas
  2012-04-11 16:22 ` Gary Thomas
  0 siblings, 1 reply; 5+ messages in thread
From: Gary Thomas @ 2012-04-11 16:14 UTC (permalink / raw)
  To: linuxppc-dev


n.b. sorry if you receive this twice - ThunderBird seems very crashy lately!

I'm trying to update my MPC8379 board from 3.0 to 3.3.  I have
this setup in my device tree:

		mdio@24520 {
			#address-cells = <1>;
			#size-cells = <0>;
			compatible = "fsl,gianfar-mdio";
			reg = <0x24520 0x20>;

			phy0: ethernet-phy@0 {
				interrupt-parent = <&ipic>;
				interrupts = <17 0x8>;
				reg = <0x01>;
				device_type = "ethernet-phy";
			};
			phy1: ethernet-phy@1 {
				interrupt-parent = <&ipic>;
				interrupts = <18 0x8>;
				reg = <0x00>;
				device_type = "ethernet-phy";
			};
		};

		enet0: ethernet@24000 {
			cell-index = <0>;
			device_type = "network";
			model = "TSEC";
			compatible = "gianfar";
			reg = <0x24000 0x1000>;
			local-mac-address = [ 00 08 e5 11 32 33 ];
			interrupts = <32 0x8 33 0x8 34 0x8>;
			interrupt-parent = <&ipic>;
			phy-handle = <&phy0>;
			linux,network-index = <0>;
		};

		enet1: ethernet@25000 {
			cell-index = <1>;
			device_type = "network";
			model = "TSEC";
			compatible = "gianfar";
			reg = <0x25000 0x1000>;
			local-mac-address = [ 00 08 e5 11 32 34 ];
			interrupts = <35 0x8 36 0x8 37 0x8>;
			interrupt-parent = <&ipic>;
			phy-handle = <&phy1>;
			linux,network-index = <1>;
		};

On 3.0, this works just fine.  When I boot the same setup on 3.3,
I get this error:
   fsl-pq_mdio: probe of ff024520.mdio failed with error -16

Is there something I need to change in my DTS file to make this work?
Something else I might be missing?

Thanks

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2012-04-11 17:06 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-11 16:09 Network problem with 3.3 Gary Thomas
2012-04-11 16:14 Gary Thomas
2012-04-11 16:22 ` Gary Thomas
2012-04-11 16:57   ` Joakim Tjernlund
2012-04-11 17:06     ` Gary Thomas

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.