From: Laxman Dewangan <ldewangan@nvidia.com> To: Jonathan Cameron <jic23@cam.ac.uk> Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>, "grant.likely@secretlab.ca" <grant.likely@secretlab.ca>, "rob.herring@calxeda.com" <rob.herring@calxeda.com>, "jbrenner@taosinc.com" <jbrenner@taosinc.com>, Rhyland Klein <rklein@nvidia.com>, "max@stro.at" <max@stro.at>, "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>, "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "devicetree-discuss@lists.ozlabs.org" <devicetree-discuss@lists.ozlabs.org> Subject: Re: [PATCH V2 2/2] staging: Documentation: add proximity_sampling_period as sysfs details Date: Thu, 12 Apr 2012 15:18:27 +0530 [thread overview] Message-ID: <4F86A4EB.4040202@nvidia.com> (raw) In-Reply-To: <4F86A26B.1090209@cam.ac.uk> On Thursday 12 April 2012 03:07 PM, Jonathan Cameron wrote: > On 4/12/2012 8:08 AM, Laxman Dewangan wrote: >> +What: /sys/bus/iio/devices/device[n]/proximity_sampling_period >> +KernelVersion: 3.5 >> +Contact: linux-iio@vger.kernel.org >> +Description: >> + Hardware dependent mode for proximity sensor device to set/get >> + the sampling rate of proximity sensing and conversion. > Ah, that explains what it is. Sorry, use > in_proximitiy0_sampling_frequency to provide equivalent > control please. Might be a pain here, but this interface will just > provide the same info as the existing > one in a different form. Note that sampling_frequency is documented as > a general one, but can > be extended to individual channels. > Ooop, I did not realize that it is there as part of sysfs.h. I was looking for other header to get support for this. I can use this for proximity only but I think I should go with you other suggestion to implement this on channel basis. This will help also in future for other drivers to have different sampling on different channel. > Actually add it to the iio-core as an element in the info_mask as I > doubt this will be the last time > we see this control. This will need to be a precursor patch to the > driver obviously. > > IIO_CHAN_INFO_SAMP_FREQ and the relevant shared and separate macros need > to go in > iio.h + the text entry in industrialio-core.c > > If you like I can do this but it'll be quicker if you do :) I will send the patch for implementing this first and then modified version of my driver which actually uses this one.
WARNING: multiple messages have this Message-ID (diff)
From: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> To: Jonathan Cameron <jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org> Cc: "gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org" <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>, "grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org" <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>, "rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org" <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>, "jbrenner-yYKgigLBUwlBDgjK7y7TUQ@public.gmane.org" <jbrenner-yYKgigLBUwlBDgjK7y7TUQ@public.gmane.org>, Rhyland Klein <rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>, "max-U9r9yeDMy7A@public.gmane.org" <max-U9r9yeDMy7A@public.gmane.org>, "linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org" <devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org>, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" <devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org> Subject: Re: [PATCH V2 2/2] staging: Documentation: add proximity_sampling_period as sysfs details Date: Thu, 12 Apr 2012 15:18:27 +0530 [thread overview] Message-ID: <4F86A4EB.4040202@nvidia.com> (raw) In-Reply-To: <4F86A26B.1090209-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org> On Thursday 12 April 2012 03:07 PM, Jonathan Cameron wrote: > On 4/12/2012 8:08 AM, Laxman Dewangan wrote: >> +What: /sys/bus/iio/devices/device[n]/proximity_sampling_period >> +KernelVersion: 3.5 >> +Contact: linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> +Description: >> + Hardware dependent mode for proximity sensor device to set/get >> + the sampling rate of proximity sensing and conversion. > Ah, that explains what it is. Sorry, use > in_proximitiy0_sampling_frequency to provide equivalent > control please. Might be a pain here, but this interface will just > provide the same info as the existing > one in a different form. Note that sampling_frequency is documented as > a general one, but can > be extended to individual channels. > Ooop, I did not realize that it is there as part of sysfs.h. I was looking for other header to get support for this. I can use this for proximity only but I think I should go with you other suggestion to implement this on channel basis. This will help also in future for other drivers to have different sampling on different channel. > Actually add it to the iio-core as an element in the info_mask as I > doubt this will be the last time > we see this control. This will need to be a precursor patch to the > driver obviously. > > IIO_CHAN_INFO_SAMP_FREQ and the relevant shared and separate macros need > to go in > iio.h + the text entry in industrialio-core.c > > If you like I can do this but it'll be quicker if you do :) I will send the patch for implementing this first and then modified version of my driver which actually uses this one.
next prev parent reply other threads:[~2012-04-12 10:00 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-04-12 7:08 [PATCH V2 0/2] staging: iio: add isl29028 driver Laxman Dewangan 2012-04-12 7:08 ` Laxman Dewangan 2012-04-12 7:08 ` [PATCH V2 1/2] staging: iio: add driver for isl29028 Laxman Dewangan 2012-04-12 7:35 ` Dan Carpenter 2012-04-12 7:35 ` Dan Carpenter 2012-04-12 9:32 ` Jonathan Cameron 2012-04-12 9:32 ` Jonathan Cameron 2012-04-12 7:08 ` [PATCH V2 2/2] staging: Documentation: add proximity_sampling_period as sysfs details Laxman Dewangan 2012-04-12 9:37 ` Jonathan Cameron 2012-04-12 9:37 ` Jonathan Cameron 2012-04-12 9:48 ` Laxman Dewangan [this message] 2012-04-12 9:48 ` Laxman Dewangan 2012-04-12 9:48 ` Laxman Dewangan 2012-04-12 10:01 ` Jonathan Cameron 2012-04-12 10:01 ` Jonathan Cameron 2012-04-12 10:01 ` Jonathan Cameron
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4F86A4EB.4040202@nvidia.com \ --to=ldewangan@nvidia.com \ --cc=devel@driverdev.osuosl.org \ --cc=devicetree-discuss@lists.ozlabs.org \ --cc=grant.likely@secretlab.ca \ --cc=gregkh@linuxfoundation.org \ --cc=jbrenner@taosinc.com \ --cc=jic23@cam.ac.uk \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=max@stro.at \ --cc=rklein@nvidia.com \ --cc=rob.herring@calxeda.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.