[Patch 1/1]:Package Boost: Reexecution of task is giving error.

[Patch 1/1]:Package Boost: Reexecution of task is giving error.

[Venkata ramana gollamudi]

Failure:
"error: duplicate initialization of gcc with the following parameters" during compilation.

Steps to reproduce: 
1> bitbake -c cleansstate boost 
2> bitbake boost 
3> bitbake -c boostconfig boost -f 
4> bitbake -c compile boost -f

Defect:
	https://bugzilla.yoctoproject.org/show_bug.cgi?id=2194

Fix details:
Boost package task do_boostconfigure is appending content to 
build/tmp/work/i586-poky-linux/boost-1.49.0-r2.0/boost_1_49_0/tools/build/v2/user-config.jam file 
without checking if the content is already present in that file. 
So check is added for the same.

Please find the below patch :
--------------------------------------------------------------

diff -Nupr prev/meta/recipes-support/boost/boost.inc new/meta/recipes-support/boost/boost.inc
--- prev/meta/recipes-support/boost/boost.inc	2012-04-12 11:12:49.916786261 +0530
+++ new/meta/recipes-support/boost/boost.inc	2012-04-12 11:30:32.535786134 +0530
@@ -135,7 +135,11 @@ BJAM_OPTS    = '${BJAM_TOOLS} \
 do_boostconfig() {
 	cp -f boost/config/platform/linux.hpp boost/config/platform/linux-gnueabi.hpp
 
-	echo 'using gcc : 4.3.1 : ${CXX} : compileflags -DBOOST_SP_USE_PTHREADS -I${includedir} linkflags -L${libdir} ;' >> ${S}/tools/build/v2/user-config.jam
+	# D2194:Fixing the failure of "error: duplicate initialization of gcc with the following parameters" during compilation.
+	if ! grep -qe "^using gcc : 4.3.1" ${S}/tools/build/v2/user-config.jam 
+	then
+		echo 'using gcc : 4.3.1 : ${CXX} : compileflags -DBOOST_SP_USE_PTHREADS -I${includedir} linkflags -L${libdir} ;' >> ${S}/tools/build/v2/user-config.jam
+	fi	
 }
 
 addtask do_boostconfig after do_patch before do_configure

Re: [Patch 1/1]:Package Boost: Reexecution of task is giving error.

[Saul Wold]

On 04/12/2012 06:06 AM, Venkata ramana gollamudi wrote:
> Failure:
> "error: duplicate initialization of gcc with the following parameters" during compilation.
>
> Steps to reproduce:
> 1>  bitbake -c cleansstate boost
> 2>  bitbake boost
> 3>  bitbake -c boostconfig boost -f
> 4>  bitbake -c compile boost -f
>
> Defect:
> 	https://bugzilla.yoctoproject.org/show_bug.cgi?id=2194
>
Venkata,

This set of patches that you sent do not follow the conventions for 
patch submissions.  There are a couple of items missing here.

1) Subject should be more like
boost: fix re-execution of task

2) No Signed-off-by: Read Name <username@example.com>

3) When fixing bugs, please include the following formatted info:
[YOCTO #2194]

More details about the commit messages and patches are available at:

http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines

Also, for sending multiple patches, please look at the 
create-pull-request and send-pull-request scripts that are part of the 
Yocto Project in scripts, they can help.

Sau!


> Fix details:
> Boost package task do_boostconfigure is appending content to
> build/tmp/work/i586-poky-linux/boost-1.49.0-r2.0/boost_1_49_0/tools/build/v2/user-config.jam file
> without checking if the content is already present in that file.
> So check is added for the same.
>
> Please find the below patch :
> --------------------------------------------------------------
>
> diff -Nupr prev/meta/recipes-support/boost/boost.inc new/meta/recipes-support/boost/boost.inc
> --- prev/meta/recipes-support/boost/boost.inc	2012-04-12 11:12:49.916786261 +0530
> +++ new/meta/recipes-support/boost/boost.inc	2012-04-12 11:30:32.535786134 +0530
> @@ -135,7 +135,11 @@ BJAM_OPTS    = '${BJAM_TOOLS} \
>   do_boostconfig() {
>   	cp -f boost/config/platform/linux.hpp boost/config/platform/linux-gnueabi.hpp
>
> -	echo 'using gcc : 4.3.1 : ${CXX} : compileflags -DBOOST_SP_USE_PTHREADS -I${includedir} linkflags -L${libdir} ;'>>  ${S}/tools/build/v2/user-config.jam
> +	# D2194:Fixing the failure of "error: duplicate initialization of gcc with the following parameters" during compilation.
> +	if ! grep -qe "^using gcc : 4.3.1" ${S}/tools/build/v2/user-config.jam
> +	then
> +		echo 'using gcc : 4.3.1 : ${CXX} : compileflags -DBOOST_SP_USE_PTHREADS -I${includedir} linkflags -L${libdir} ;'>>  ${S}/tools/build/v2/user-config.jam
> +	fi	
>   }
>
>   addtask do_boostconfig after do_patch before do_configure
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>