All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Arnaldo Carvalho de Melo <acme@infradead.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
	Jim Keniston <jkenisto@linux.vnet.ibm.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux-mm <linux-mm@kvack.org>, Oleg Nesterov <oleg@redhat.com>,
	Andi Kleen <andi@firstfloor.org>,
	Christoph Hellwig <hch@infradead.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Anton Arapov <anton@redhat.com>
Subject: Re: [PATCH] perf/probe: Provide perf interface for uprobes
Date: Fri, 13 Apr 2012 15:27:55 +0900	[thread overview]
Message-ID: <4F87C76B.10001@hitachi.com> (raw)
In-Reply-To: <20120412151037.GC21587@linux.vnet.ibm.com>

(2012/04/13 0:10), Srikar Dronamraju wrote:
>>  $ perf probe libc malloc
>>
>> 	Makes it even easier to use.
>>
>> 	Its just when one asks for something that has ambiguities that
>> the tool should ask the user to be a bit more precise to remove such
>> ambiguity.
>>
>> 	After all...
>>
> 
> Another case 
> perf probe do_fork clone_flags now looks for variable clone_flags in
> kernel function do_fork.
> 
> But if we allow to trace perf probe zsh zfree; then 
> 'perf probe do_fork clone_flags' should it check for do_fork executable
> or not? If it does check and finds one, and searches for clone_flags
> function and doesnt find, then should it continue with searching the
> kernel?
> 

Agree. I'd like to suggest you to start with only full path support,
and see, how we can handle abbreviations :)

Thank you,

-- 
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com

WARNING: multiple messages have this Message-ID (diff)
From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Arnaldo Carvalho de Melo <acme@infradead.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
	Jim Keniston <jkenisto@linux.vnet.ibm.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux-mm <linux-mm@kvack.org>, Oleg Nesterov <oleg@redhat.com>,
	Andi Kleen <andi@firstfloor.org>,
	Christoph Hellwig <hch@infradead.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Anton Arapov <anton@redhat.com>
Subject: Re: [PATCH] perf/probe: Provide perf interface for uprobes
Date: Fri, 13 Apr 2012 15:27:55 +0900	[thread overview]
Message-ID: <4F87C76B.10001@hitachi.com> (raw)
In-Reply-To: <20120412151037.GC21587@linux.vnet.ibm.com>

(2012/04/13 0:10), Srikar Dronamraju wrote:
>>  $ perf probe libc malloc
>>
>> 	Makes it even easier to use.
>>
>> 	Its just when one asks for something that has ambiguities that
>> the tool should ask the user to be a bit more precise to remove such
>> ambiguity.
>>
>> 	After all...
>>
> 
> Another case 
> perf probe do_fork clone_flags now looks for variable clone_flags in
> kernel function do_fork.
> 
> But if we allow to trace perf probe zsh zfree; then 
> 'perf probe do_fork clone_flags' should it check for do_fork executable
> or not? If it does check and finds one, and searches for clone_flags
> function and doesnt find, then should it continue with searching the
> kernel?
> 

Agree. I'd like to suggest you to start with only full path support,
and see, how we can handle abbreviations :)

Thank you,

-- 
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2012-04-13  6:28 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-11 13:57 [PATCH] perf/probe: Provide perf interface for uprobes Srikar Dronamraju
2012-04-11 13:57 ` Srikar Dronamraju
2012-04-11 14:49 ` Arnaldo Carvalho de Melo
2012-04-11 14:49   ` Arnaldo Carvalho de Melo
2012-04-11 17:12   ` Srikar Dronamraju
2012-04-11 17:12     ` Srikar Dronamraju
2012-04-11 18:17     ` Arnaldo Carvalho de Melo
2012-04-11 18:17       ` Arnaldo Carvalho de Melo
2012-04-12  3:27       ` Masami Hiramatsu
2012-04-12  3:27         ` Masami Hiramatsu
2012-04-12 14:07         ` Arnaldo Carvalho de Melo
2012-04-12 14:07           ` Arnaldo Carvalho de Melo
2012-04-12 14:41           ` Srikar Dronamraju
2012-04-12 14:41             ` Srikar Dronamraju
2012-04-12 15:56             ` Arnaldo Carvalho de Melo
2012-04-12 15:56               ` Arnaldo Carvalho de Melo
2012-04-12 15:10           ` Srikar Dronamraju
2012-04-12 15:10             ` Srikar Dronamraju
2012-04-13  6:27             ` Masami Hiramatsu [this message]
2012-04-13  6:27               ` Masami Hiramatsu
2012-04-14  1:13               ` Arnaldo Carvalho de Melo
2012-04-14  1:13                 ` Arnaldo Carvalho de Melo
2012-04-16 12:27                 ` Srikar Dronamraju
2012-04-16 12:27                   ` Srikar Dronamraju

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F87C76B.10001@hitachi.com \
    --to=masami.hiramatsu.pt@hitachi.com \
    --cc=acme@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=ananth@in.ibm.com \
    --cc=andi@firstfloor.org \
    --cc=anton@redhat.com \
    --cc=hch@infradead.org \
    --cc=jkenisto@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@elte.hu \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=srikar@linux.vnet.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.