* [PATCH] fix build error with seabios
@ 2012-04-13 14:23 Christoph Egger
2012-04-24 17:18 ` Ian Jackson
0 siblings, 1 reply; 13+ messages in thread
From: Christoph Egger @ 2012-04-13 14:23 UTC (permalink / raw)
To: xen-devel
[-- Attachment #1: Type: text/plain, Size: 180 bytes --]
Pass PYTHON down to seabios, so seabios will
use same python binary as whole xen tree does.
Fixes build error on NetBSD.
Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
[-- Attachment #2: xen_build_seabios.diff --]
[-- Type: text/plain, Size: 316 bytes --]
diff -r ab552da976a3 tools/firmware/Makefile
--- a/tools/firmware/Makefile Wed Apr 11 18:28:33 2012 +0200
+++ b/tools/firmware/Makefile Fri Apr 13 16:22:23 2012 +0200
@@ -32,7 +32,7 @@ ifeq ($(CONFIG_ROMBIOS),y)
false ; \
fi
endif
- $(MAKE) subdirs-$@
+ $(MAKE) PYTHON=$(PYTHON) subdirs-$@
.PHONY: install
[-- Attachment #3: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] fix build error with seabios
2012-04-13 14:23 [PATCH] fix build error with seabios Christoph Egger
@ 2012-04-24 17:18 ` Ian Jackson
2012-04-25 8:07 ` Ian Campbell
0 siblings, 1 reply; 13+ messages in thread
From: Ian Jackson @ 2012-04-24 17:18 UTC (permalink / raw)
To: Ian Campbell; +Cc: Christoph Egger, xen-devel
Christoph Egger writes ("[Xen-devel] [PATCH] fix build error with seabios"):
>
> Pass PYTHON down to seabios, so seabios will
> use same python binary as whole xen tree does.
> Fixes build error on NetBSD.
Ian, does this look sensible to you ?
> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
>
> ----------------------------------------------------------------------
> diff -r ab552da976a3 tools/firmware/Makefile
> --- a/tools/firmware/Makefile Wed Apr 11 18:28:33 2012 +0200
> +++ b/tools/firmware/Makefile Fri Apr 13 16:22:23 2012 +0200
> @@ -32,7 +32,7 @@ ifeq ($(CONFIG_ROMBIOS),y)
> false ; \
> fi
> endif
> - $(MAKE) subdirs-$@
> + $(MAKE) PYTHON=$(PYTHON) subdirs-$@
>
>
> .PHONY: install
>
> ----------------------------------------------------------------------
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] fix build error with seabios
2012-04-24 17:18 ` Ian Jackson
@ 2012-04-25 8:07 ` Ian Campbell
2012-04-25 8:43 ` Christoph Egger
2012-04-25 10:23 ` Ian Jackson
0 siblings, 2 replies; 13+ messages in thread
From: Ian Campbell @ 2012-04-25 8:07 UTC (permalink / raw)
To: Ian Jackson; +Cc: Christoph Egger, xen-devel
On Tue, 2012-04-24 at 18:18 +0100, Ian Jackson wrote:
> Christoph Egger writes ("[Xen-devel] [PATCH] fix build error with seabios"):
> >
> > Pass PYTHON down to seabios, so seabios will
> > use same python binary as whole xen tree does.
> > Fixes build error on NetBSD.
>
> Ian, does this look sensible to you ?
It exports $(PYTHON) to all subdirs of tools/firmware, but I guess that
is OK, so we might as well take this now.
Does
subdirs-seabios: PYTHON=$(PYTHON)
(or something similar) work? Might be a better option in the future
>
> > Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
> >
> > ----------------------------------------------------------------------
> > diff -r ab552da976a3 tools/firmware/Makefile
> > --- a/tools/firmware/Makefile Wed Apr 11 18:28:33 2012 +0200
> > +++ b/tools/firmware/Makefile Fri Apr 13 16:22:23 2012 +0200
> > @@ -32,7 +32,7 @@ ifeq ($(CONFIG_ROMBIOS),y)
> > false ; \
> > fi
> > endif
> > - $(MAKE) subdirs-$@
> > + $(MAKE) PYTHON=$(PYTHON) subdirs-$@
> >
> >
> > .PHONY: install
> >
> > ----------------------------------------------------------------------
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xen.org
> > http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] fix build error with seabios
2012-04-25 8:07 ` Ian Campbell
@ 2012-04-25 8:43 ` Christoph Egger
2012-04-25 8:52 ` Ian Campbell
2012-04-25 10:23 ` Ian Jackson
1 sibling, 1 reply; 13+ messages in thread
From: Christoph Egger @ 2012-04-25 8:43 UTC (permalink / raw)
To: Ian Campbell; +Cc: Ian Jackson, xen-devel
On 04/25/12 10:07, Ian Campbell wrote:
> On Tue, 2012-04-24 at 18:18 +0100, Ian Jackson wrote:
>> Christoph Egger writes ("[Xen-devel] [PATCH] fix build error with seabios"):
>>>
>>> Pass PYTHON down to seabios, so seabios will
>>> use same python binary as whole xen tree does.
>>> Fixes build error on NetBSD.
>>
>> Ian, does this look sensible to you ?
>
> It exports $(PYTHON) to all subdirs of tools/firmware, but I guess that
> is OK, so we might as well take this now.
Thanks.
> Does
> subdirs-seabios: PYTHON=$(PYTHON)
> (or something similar) work? Might be a better option in the future
No, this doesn't work.
>
>>
>>> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
>>>
>>> ----------------------------------------------------------------------
>>> diff -r ab552da976a3 tools/firmware/Makefile
>>> --- a/tools/firmware/Makefile Wed Apr 11 18:28:33 2012 +0200
>>> +++ b/tools/firmware/Makefile Fri Apr 13 16:22:23 2012 +0200
>>> @@ -32,7 +32,7 @@ ifeq ($(CONFIG_ROMBIOS),y)
>>> false ; \
>>> fi
>>> endif
>>> - $(MAKE) subdirs-$@
>>> + $(MAKE) PYTHON=$(PYTHON) subdirs-$@
>>>
>>>
>>> .PHONY: install
>>>
>>> ----------------------------------------------------------------------
>>> _______________________________________________
>>> Xen-devel mailing list
>>> Xen-devel@lists.xen.org
>>> http://lists.xen.org/xen-devel
>
>
>
--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] fix build error with seabios
2012-04-25 8:43 ` Christoph Egger
@ 2012-04-25 8:52 ` Ian Campbell
2012-04-25 9:10 ` Christoph Egger
0 siblings, 1 reply; 13+ messages in thread
From: Ian Campbell @ 2012-04-25 8:52 UTC (permalink / raw)
To: Christoph Egger; +Cc: Ian Jackson, xen-devel
On Wed, 2012-04-25 at 09:43 +0100, Christoph Egger wrote:
> On 04/25/12 10:07, Ian Campbell wrote:
>
> > On Tue, 2012-04-24 at 18:18 +0100, Ian Jackson wrote:
> >> Christoph Egger writes ("[Xen-devel] [PATCH] fix build error with seabios"):
> >>>
> >>> Pass PYTHON down to seabios, so seabios will
> >>> use same python binary as whole xen tree does.
> >>> Fixes build error on NetBSD.
> >>
> >> Ian, does this look sensible to you ?
> >
> > It exports $(PYTHON) to all subdirs of tools/firmware, but I guess that
> > is OK, so we might as well take this now.
>
>
> Thanks.
>
>
>
> > Does
> > subdirs-seabios: PYTHON=$(PYTHON)
> > (or something similar) work? Might be a better option in the future
>
>
> No, this doesn't work.
What about
subdir-all-seabios: PYTHON=...
?
>
> >
> >>
> >>> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
> >
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> >
> >>>
> >>> ----------------------------------------------------------------------
> >>> diff -r ab552da976a3 tools/firmware/Makefile
> >>> --- a/tools/firmware/Makefile Wed Apr 11 18:28:33 2012 +0200
> >>> +++ b/tools/firmware/Makefile Fri Apr 13 16:22:23 2012 +0200
> >>> @@ -32,7 +32,7 @@ ifeq ($(CONFIG_ROMBIOS),y)
> >>> false ; \
> >>> fi
> >>> endif
> >>> - $(MAKE) subdirs-$@
> >>> + $(MAKE) PYTHON=$(PYTHON) subdirs-$@
> >>>
> >>>
> >>> .PHONY: install
> >>>
> >>> ----------------------------------------------------------------------
> >>> _______________________________________________
> >>> Xen-devel mailing list
> >>> Xen-devel@lists.xen.org
> >>> http://lists.xen.org/xen-devel
> >
> >
> >
>
>
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] fix build error with seabios
2012-04-25 8:52 ` Ian Campbell
@ 2012-04-25 9:10 ` Christoph Egger
2012-04-25 9:13 ` Christoph Egger
2012-04-25 9:16 ` Ian Campbell
0 siblings, 2 replies; 13+ messages in thread
From: Christoph Egger @ 2012-04-25 9:10 UTC (permalink / raw)
To: Ian Campbell; +Cc: Ian Jackson, xen-devel
On 04/25/12 10:52, Ian Campbell wrote:
> On Wed, 2012-04-25 at 09:43 +0100, Christoph Egger wrote:
>> On 04/25/12 10:07, Ian Campbell wrote:
>>
>>> On Tue, 2012-04-24 at 18:18 +0100, Ian Jackson wrote:
>>>> Christoph Egger writes ("[Xen-devel] [PATCH] fix build error with seabios"):
>>>>>
>>>>> Pass PYTHON down to seabios, so seabios will
>>>>> use same python binary as whole xen tree does.
>>>>> Fixes build error on NetBSD.
>>>>
>>>> Ian, does this look sensible to you ?
>>>
>>> It exports $(PYTHON) to all subdirs of tools/firmware, but I guess that
>>> is OK, so we might as well take this now.
>>
>>
>> Thanks.
>>
>>> Does
>>> subdirs-seabios: PYTHON=$(PYTHON)
>>> (or something similar) work? Might be a better option in the future
>>
>> No, this doesn't work.
>
> What about
> subdir-all-seabios: PYTHON=...
> ?
No, doesn't work. I also tried without success:
subdirs-all-seabios
subdir-all-seabios-dir
subdirs-all-seabios-dir
seabios-dir
Christoph
>>>>
>>>>> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
>>>
>>> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>>>
>>>>>
>>>>> ----------------------------------------------------------------------
>>>>> diff -r ab552da976a3 tools/firmware/Makefile
>>>>> --- a/tools/firmware/Makefile Wed Apr 11 18:28:33 2012 +0200
>>>>> +++ b/tools/firmware/Makefile Fri Apr 13 16:22:23 2012 +0200
>>>>> @@ -32,7 +32,7 @@ ifeq ($(CONFIG_ROMBIOS),y)
>>>>> false ; \
>>>>> fi
>>>>> endif
>>>>> - $(MAKE) subdirs-$@
>>>>> + $(MAKE) PYTHON=$(PYTHON) subdirs-$@
>>>>>
>>>>>
>>>>> .PHONY: install
>>>>>
>>>>> ----------------------------------------------------------------------
--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] fix build error with seabios
2012-04-25 9:10 ` Christoph Egger
@ 2012-04-25 9:13 ` Christoph Egger
2012-04-25 9:18 ` Christoph Egger
2012-04-25 9:20 ` Ian Campbell
2012-04-25 9:16 ` Ian Campbell
1 sibling, 2 replies; 13+ messages in thread
From: Christoph Egger @ 2012-04-25 9:13 UTC (permalink / raw)
To: Ian Campbell; +Cc: Ian Jackson, xen-devel
On 04/25/12 11:10, Christoph Egger wrote:
> On 04/25/12 10:52, Ian Campbell wrote:
>
>> On Wed, 2012-04-25 at 09:43 +0100, Christoph Egger wrote:
>>> On 04/25/12 10:07, Ian Campbell wrote:
>>>
>>>> On Tue, 2012-04-24 at 18:18 +0100, Ian Jackson wrote:
>>>>> Christoph Egger writes ("[Xen-devel] [PATCH] fix build error with seabios"):
>>>>>>
>>>>>> Pass PYTHON down to seabios, so seabios will
>>>>>> use same python binary as whole xen tree does.
>>>>>> Fixes build error on NetBSD.
>>>>>
>>>>> Ian, does this look sensible to you ?
>>>>
>>>> It exports $(PYTHON) to all subdirs of tools/firmware, but I guess that
>>>> is OK, so we might as well take this now.
>>>
>>>
>>> Thanks.
>
>>>
>
>>>> Does
>>>> subdirs-seabios: PYTHON=$(PYTHON)
>>>> (or something similar) work? Might be a better option in the future
>>>
>>> No, this doesn't work.
>>
>> What about
>> subdir-all-seabios: PYTHON=...
>> ?
>
>
> No, doesn't work. I also tried without success:
>
> subdirs-all-seabios
> subdir-all-seabios-dir
> subdirs-all-seabios-dir
> seabios-dir
I found something that works:
subdir-all-seabios-dir:
export PYTHON=$(PYTHON)
Christoph
>
>>>>>
>>>>>> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
>>>>
>>>> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>>>>
>>>>>>
>>>>>> ----------------------------------------------------------------------
>>>>>> diff -r ab552da976a3 tools/firmware/Makefile
>>>>>> --- a/tools/firmware/Makefile Wed Apr 11 18:28:33 2012 +0200
>>>>>> +++ b/tools/firmware/Makefile Fri Apr 13 16:22:23 2012 +0200
>>>>>> @@ -32,7 +32,7 @@ ifeq ($(CONFIG_ROMBIOS),y)
>>>>>> false ; \
>>>>>> fi
>>>>>> endif
>>>>>> - $(MAKE) subdirs-$@
>>>>>> + $(MAKE) PYTHON=$(PYTHON) subdirs-$@
>>>>>>
>>>>>>
>>>>>> .PHONY: install
>>>>>>
>>>>>> ----------------------------------------------------------------------
>
>
--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] fix build error with seabios
2012-04-25 9:10 ` Christoph Egger
2012-04-25 9:13 ` Christoph Egger
@ 2012-04-25 9:16 ` Ian Campbell
2012-04-25 9:21 ` Christoph Egger
1 sibling, 1 reply; 13+ messages in thread
From: Ian Campbell @ 2012-04-25 9:16 UTC (permalink / raw)
To: Christoph Egger; +Cc: Ian Jackson, xen-devel
On Wed, 2012-04-25 at 10:10 +0100, Christoph Egger wrote:
> On 04/25/12 10:52, Ian Campbell wrote:
>
> > On Wed, 2012-04-25 at 09:43 +0100, Christoph Egger wrote:
> >> On 04/25/12 10:07, Ian Campbell wrote:
> >>
> >>> On Tue, 2012-04-24 at 18:18 +0100, Ian Jackson wrote:
> >>>> Christoph Egger writes ("[Xen-devel] [PATCH] fix build error with seabios"):
> >>>>>
> >>>>> Pass PYTHON down to seabios, so seabios will
> >>>>> use same python binary as whole xen tree does.
> >>>>> Fixes build error on NetBSD.
> >>>>
> >>>> Ian, does this look sensible to you ?
> >>>
> >>> It exports $(PYTHON) to all subdirs of tools/firmware, but I guess that
> >>> is OK, so we might as well take this now.
> >>
> >>
> >> Thanks.
>
> >>
>
> >>> Does
> >>> subdirs-seabios: PYTHON=$(PYTHON)
> >>> (or something similar) work? Might be a better option in the future
> >>
> >> No, this doesn't work.
> >
> > What about
> > subdir-all-seabios: PYTHON=...
> > ?
>
>
> No, doesn't work. I also tried without success:
>
> subdirs-all-seabios
> subdir-all-seabios-dir
> subdirs-all-seabios-dir
> seabios-dir
Strange. Oh well I guess the original patch does the job.
Ian.
>
> Christoph
>
> >>>>
> >>>>> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
> >>>
> >>> Acked-by: Ian Campbell <ian.campbell@citrix.com>
> >>>
> >>>>>
> >>>>> ----------------------------------------------------------------------
> >>>>> diff -r ab552da976a3 tools/firmware/Makefile
> >>>>> --- a/tools/firmware/Makefile Wed Apr 11 18:28:33 2012 +0200
> >>>>> +++ b/tools/firmware/Makefile Fri Apr 13 16:22:23 2012 +0200
> >>>>> @@ -32,7 +32,7 @@ ifeq ($(CONFIG_ROMBIOS),y)
> >>>>> false ; \
> >>>>> fi
> >>>>> endif
> >>>>> - $(MAKE) subdirs-$@
> >>>>> + $(MAKE) PYTHON=$(PYTHON) subdirs-$@
> >>>>>
> >>>>>
> >>>>> .PHONY: install
> >>>>>
> >>>>> ----------------------------------------------------------------------
>
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] fix build error with seabios
2012-04-25 9:13 ` Christoph Egger
@ 2012-04-25 9:18 ` Christoph Egger
2012-04-25 9:20 ` Ian Campbell
1 sibling, 0 replies; 13+ messages in thread
From: Christoph Egger @ 2012-04-25 9:18 UTC (permalink / raw)
To: Ian Campbell; +Cc: Ian Jackson, xen-devel
On 04/25/12 11:13, Christoph Egger wrote:
> On 04/25/12 11:10, Christoph Egger wrote:
>
>> On 04/25/12 10:52, Ian Campbell wrote:
>>
>>> On Wed, 2012-04-25 at 09:43 +0100, Christoph Egger wrote:
>>>> On 04/25/12 10:07, Ian Campbell wrote:
>>>>
>>>>> On Tue, 2012-04-24 at 18:18 +0100, Ian Jackson wrote:
>>>>>> Christoph Egger writes ("[Xen-devel] [PATCH] fix build error with seabios"):
>>>>>>>
>>>>>>> Pass PYTHON down to seabios, so seabios will
>>>>>>> use same python binary as whole xen tree does.
>>>>>>> Fixes build error on NetBSD.
>>>>>>
>>>>>> Ian, does this look sensible to you ?
>>>>>
>>>>> It exports $(PYTHON) to all subdirs of tools/firmware, but I guess that
>>>>> is OK, so we might as well take this now.
>>>>
>>>>
>>>> Thanks.
>>
>>>>
>>
>>>>> Does
>>>>> subdirs-seabios: PYTHON=$(PYTHON)
>>>>> (or something similar) work? Might be a better option in the future
>>>>
>>>> No, this doesn't work.
>>>
>>> What about
>>> subdir-all-seabios: PYTHON=...
>>> ?
>>
>>
>> No, doesn't work. I also tried without success:
>>
>> subdirs-all-seabios
>> subdir-all-seabios-dir
>> subdirs-all-seabios-dir
>> seabios-dir
>
> I found something that works:
>
> subdir-all-seabios-dir:
> export PYTHON=$(PYTHON)
Ah, no. This causes a subsequent seabios build error about a missing
build rule. I should have waited with sending the mail
till the build finished.
> Christoph
>>
>>>>>>
>>>>>>> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
>>>>>
>>>>> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>>>>>
>>>>>>>
>>>>>>> ----------------------------------------------------------------------
>>>>>>> diff -r ab552da976a3 tools/firmware/Makefile
>>>>>>> --- a/tools/firmware/Makefile Wed Apr 11 18:28:33 2012 +0200
>>>>>>> +++ b/tools/firmware/Makefile Fri Apr 13 16:22:23 2012 +0200
>>>>>>> @@ -32,7 +32,7 @@ ifeq ($(CONFIG_ROMBIOS),y)
>>>>>>> false ; \
>>>>>>> fi
>>>>>>> endif
>>>>>>> - $(MAKE) subdirs-$@
>>>>>>> + $(MAKE) PYTHON=$(PYTHON) subdirs-$@
>>>>>>>
>>>>>>>
>>>>>>> .PHONY: install
>>>>>>>
>>>>>>> ----------------------------------------------------------------------
--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] fix build error with seabios
2012-04-25 9:13 ` Christoph Egger
2012-04-25 9:18 ` Christoph Egger
@ 2012-04-25 9:20 ` Ian Campbell
2012-04-25 9:52 ` Christoph Egger
1 sibling, 1 reply; 13+ messages in thread
From: Ian Campbell @ 2012-04-25 9:20 UTC (permalink / raw)
To: Christoph Egger; +Cc: Ian Jackson, xen-devel
On Wed, 2012-04-25 at 10:13 +0100, Christoph Egger wrote:
> On 04/25/12 11:10, Christoph Egger wrote:
>
> > On 04/25/12 10:52, Ian Campbell wrote:
> >
> >> On Wed, 2012-04-25 at 09:43 +0100, Christoph Egger wrote:
> >>> On 04/25/12 10:07, Ian Campbell wrote:
> >>>
> >>>> On Tue, 2012-04-24 at 18:18 +0100, Ian Jackson wrote:
> >>>>> Christoph Egger writes ("[Xen-devel] [PATCH] fix build error with seabios"):
> >>>>>>
> >>>>>> Pass PYTHON down to seabios, so seabios will
> >>>>>> use same python binary as whole xen tree does.
> >>>>>> Fixes build error on NetBSD.
> >>>>>
> >>>>> Ian, does this look sensible to you ?
> >>>>
> >>>> It exports $(PYTHON) to all subdirs of tools/firmware, but I guess that
> >>>> is OK, so we might as well take this now.
> >>>
> >>>
> >>> Thanks.
> >
> >>>
> >
> >>>> Does
> >>>> subdirs-seabios: PYTHON=$(PYTHON)
> >>>> (or something similar) work? Might be a better option in the future
> >>>
> >>> No, this doesn't work.
> >>
> >> What about
> >> subdir-all-seabios: PYTHON=...
> >> ?
> >
> >
> > No, doesn't work. I also tried without success:
> >
> > subdirs-all-seabios
> > subdir-all-seabios-dir
> > subdirs-all-seabios-dir
> > seabios-dir
>
> I found something that works:
>
> subdir-all-seabios-dir:
> export PYTHON=$(PYTHON)
Really, that's not a syntax I've ever seen before, I've no idea how that
works, all on the same line, sure, but on the next line like that, odd!.
I would have thought that this would have caused "export PYTHON=
$(PYTHON)" to be run it its own new subshell which would immediately
exit.
Anyway, I guess if it works we might as well use this version...
Ian.
>
> Christoph
> >
> >>>>>
> >>>>>> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
> >>>>
> >>>> Acked-by: Ian Campbell <ian.campbell@citrix.com>
> >>>>
> >>>>>>
> >>>>>> ----------------------------------------------------------------------
> >>>>>> diff -r ab552da976a3 tools/firmware/Makefile
> >>>>>> --- a/tools/firmware/Makefile Wed Apr 11 18:28:33 2012 +0200
> >>>>>> +++ b/tools/firmware/Makefile Fri Apr 13 16:22:23 2012 +0200
> >>>>>> @@ -32,7 +32,7 @@ ifeq ($(CONFIG_ROMBIOS),y)
> >>>>>> false ; \
> >>>>>> fi
> >>>>>> endif
> >>>>>> - $(MAKE) subdirs-$@
> >>>>>> + $(MAKE) PYTHON=$(PYTHON) subdirs-$@
> >>>>>>
> >>>>>>
> >>>>>> .PHONY: install
> >>>>>>
> >>>>>> ----------------------------------------------------------------------
> >
> >
>
>
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] fix build error with seabios
2012-04-25 9:16 ` Ian Campbell
@ 2012-04-25 9:21 ` Christoph Egger
0 siblings, 0 replies; 13+ messages in thread
From: Christoph Egger @ 2012-04-25 9:21 UTC (permalink / raw)
To: Ian Campbell; +Cc: Ian Jackson, xen-devel
On 04/25/12 11:16, Ian Campbell wrote:
> On Wed, 2012-04-25 at 10:10 +0100, Christoph Egger wrote:
>> On 04/25/12 10:52, Ian Campbell wrote:
>>
>>> On Wed, 2012-04-25 at 09:43 +0100, Christoph Egger wrote:
>>>> On 04/25/12 10:07, Ian Campbell wrote:
>>>>
>>>>> On Tue, 2012-04-24 at 18:18 +0100, Ian Jackson wrote:
>>>>>> Christoph Egger writes ("[Xen-devel] [PATCH] fix build error with seabios"):
>>>>>>>
>>>>>>> Pass PYTHON down to seabios, so seabios will
>>>>>>> use same python binary as whole xen tree does.
>>>>>>> Fixes build error on NetBSD.
>>>>>>
>>>>>> Ian, does this look sensible to you ?
>>>>>
>>>>> It exports $(PYTHON) to all subdirs of tools/firmware, but I guess that
>>>>> is OK, so we might as well take this now.
>>>>
>>>>
>>>> Thanks.
>>
>>>>
>>
>>>>> Does
>>>>> subdirs-seabios: PYTHON=$(PYTHON)
>>>>> (or something similar) work? Might be a better option in the future
>>>>
>>>> No, this doesn't work.
>>>
>>> What about
>>> subdir-all-seabios: PYTHON=...
>>> ?
>>
>>
>> No, doesn't work. I also tried without success:
>>
>> subdirs-all-seabios
>> subdir-all-seabios-dir
>> subdirs-all-seabios-dir
>> seabios-dir
>
> Strange. Oh well I guess the original patch does the job.
Yes, that's right.
Christoph
>
> Ian.
>
>>
>> Christoph
>>
>>>>>>
>>>>>>> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
>>>>>
>>>>> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>>>>>
>>>>>>>
>>>>>>> ----------------------------------------------------------------------
>>>>>>> diff -r ab552da976a3 tools/firmware/Makefile
>>>>>>> --- a/tools/firmware/Makefile Wed Apr 11 18:28:33 2012 +0200
>>>>>>> +++ b/tools/firmware/Makefile Fri Apr 13 16:22:23 2012 +0200
>>>>>>> @@ -32,7 +32,7 @@ ifeq ($(CONFIG_ROMBIOS),y)
>>>>>>> false ; \
>>>>>>> fi
>>>>>>> endif
>>>>>>> - $(MAKE) subdirs-$@
>>>>>>> + $(MAKE) PYTHON=$(PYTHON) subdirs-$@
>>>>>>>
>>>>>>>
>>>>>>> .PHONY: install
>>>>>>>
>>>>>>> ----------------------------------------------------------------------
>>
>>
>
>
>
--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] fix build error with seabios
2012-04-25 9:20 ` Ian Campbell
@ 2012-04-25 9:52 ` Christoph Egger
0 siblings, 0 replies; 13+ messages in thread
From: Christoph Egger @ 2012-04-25 9:52 UTC (permalink / raw)
To: Ian Campbell; +Cc: Ian Jackson, xen-devel
On 04/25/12 11:20, Ian Campbell wrote:
> On Wed, 2012-04-25 at 10:13 +0100, Christoph Egger wrote:
>> On 04/25/12 11:10, Christoph Egger wrote:
>>
>>> On 04/25/12 10:52, Ian Campbell wrote:
>>>
>>>> On Wed, 2012-04-25 at 09:43 +0100, Christoph Egger wrote:
>>>>> On 04/25/12 10:07, Ian Campbell wrote:
>>>>>
>>>>>> On Tue, 2012-04-24 at 18:18 +0100, Ian Jackson wrote:
>>>>>>> Christoph Egger writes ("[Xen-devel] [PATCH] fix build error with seabios"):
>>>>>>>>
>>>>>>>> Pass PYTHON down to seabios, so seabios will
>>>>>>>> use same python binary as whole xen tree does.
>>>>>>>> Fixes build error on NetBSD.
>>>>>>>
>>>>>>> Ian, does this look sensible to you ?
>>>>>>
>>>>>> It exports $(PYTHON) to all subdirs of tools/firmware, but I guess that
>>>>>> is OK, so we might as well take this now.
>>>>>
>>>>>
>>>>> Thanks.
>>>
>>>>>
>>>
>>>>>> Does
>>>>>> subdirs-seabios: PYTHON=$(PYTHON)
>>>>>> (or something similar) work? Might be a better option in the future
>>>>>
>>>>> No, this doesn't work.
>>>>
>>>> What about
>>>> subdir-all-seabios: PYTHON=...
>>>> ?
>>>
>>>
>>> No, doesn't work. I also tried without success:
>>>
>>> subdirs-all-seabios
>>> subdir-all-seabios-dir
>>> subdirs-all-seabios-dir
>>> seabios-dir
>>
>> I found something that works:
>>
>> subdir-all-seabios-dir:
>> export PYTHON=$(PYTHON)
>
> Really, that's not a syntax I've ever seen before, I've no idea how that
> works, all on the same line, sure, but on the next line like that, odd!.
> I would have thought that this would have caused "export PYTHON=
> $(PYTHON)" to be run it its own new subshell which would immediately
> exit.
>
> Anyway, I guess if it works we might as well use this version...
No, it doesn't. It causes a subsequent seabios build error about
a missing build rule. I should have waited with reporting this
till the build finished.
Christoph
>
>
> Ian.
>
>>
>> Christoph
>>>
>>>>>>>
>>>>>>>> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
>>>>>>
>>>>>> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>>>>>>
>>>>>>>>
>>>>>>>> ----------------------------------------------------------------------
>>>>>>>> diff -r ab552da976a3 tools/firmware/Makefile
>>>>>>>> --- a/tools/firmware/Makefile Wed Apr 11 18:28:33 2012 +0200
>>>>>>>> +++ b/tools/firmware/Makefile Fri Apr 13 16:22:23 2012 +0200
>>>>>>>> @@ -32,7 +32,7 @@ ifeq ($(CONFIG_ROMBIOS),y)
>>>>>>>> false ; \
>>>>>>>> fi
>>>>>>>> endif
>>>>>>>> - $(MAKE) subdirs-$@
>>>>>>>> + $(MAKE) PYTHON=$(PYTHON) subdirs-$@
>>>>>>>>
>>>>>>>>
>>>>>>>> .PHONY: install
>>>>>>>>
>>>>>>>> ----------------------------------------------------------------------
>>>
>>>
>>
>>
>>
>
>
>
--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] fix build error with seabios
2012-04-25 8:07 ` Ian Campbell
2012-04-25 8:43 ` Christoph Egger
@ 2012-04-25 10:23 ` Ian Jackson
1 sibling, 0 replies; 13+ messages in thread
From: Ian Jackson @ 2012-04-25 10:23 UTC (permalink / raw)
To: Ian Campbell; +Cc: Christoph Egger, xen-devel
Ian Campbell writes ("Re: [Xen-devel] [PATCH] fix build error with seabios"):
> On Tue, 2012-04-24 at 18:18 +0100, Ian Jackson wrote:
> > Christoph Egger writes ("[Xen-devel] [PATCH] fix build error with seabios"):
> > >
> > > Pass PYTHON down to seabios, so seabios will
> > > use same python binary as whole xen tree does.
> > > Fixes build error on NetBSD.
> >
> > Ian, does this look sensible to you ?
>
> It exports $(PYTHON) to all subdirs of tools/firmware, but I guess that
> is OK, so we might as well take this now.
I wasn't sure about that. But OK.
> > > Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
I have applied it.
But I rewrote the commit message. Christoph, I often find I need to
rewrite or reword your commit messages; you might like to look at the
message for 25241:15f094c85c85 to see what would be a more
conventional style and set of information.
Thanks,
Ian.
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2012-04-25 10:23 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-13 14:23 [PATCH] fix build error with seabios Christoph Egger
2012-04-24 17:18 ` Ian Jackson
2012-04-25 8:07 ` Ian Campbell
2012-04-25 8:43 ` Christoph Egger
2012-04-25 8:52 ` Ian Campbell
2012-04-25 9:10 ` Christoph Egger
2012-04-25 9:13 ` Christoph Egger
2012-04-25 9:18 ` Christoph Egger
2012-04-25 9:20 ` Ian Campbell
2012-04-25 9:52 ` Christoph Egger
2012-04-25 9:16 ` Ian Campbell
2012-04-25 9:21 ` Christoph Egger
2012-04-25 10:23 ` Ian Jackson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.