* [Buildroot] [PATCH] Add libapr-package
@ 2012-04-17 13:16 Rico Bachmann
2012-04-17 13:20 ` Baruch Siach
` (2 more replies)
0 siblings, 3 replies; 23+ messages in thread
From: Rico Bachmann @ 2012-04-17 13:16 UTC (permalink / raw)
To: buildroot
Signed-off-by: Rico Bachmann <bachmann@tofwerk.com>
---
package/Config.in | 1 +
package/apr/Config.in | 7 +++++++
package/apr/apr.mk | 18 ++++++++++++++++++
3 files changed, 26 insertions(+), 0 deletions(-)
create mode 100644 package/apr/Config.in
create mode 100644 package/apr/apr.mk
diff --git a/package/Config.in b/package/Config.in
index 4c6d4d8..ceb5f6d 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -376,6 +376,7 @@ source "package/fftw/Config.in"
source "package/libargtable2/Config.in"
source "package/argp-standalone/Config.in"
source "package/boost/Config.in"
+source "package/libapr/Config.in"
source "package/libatomic_ops/Config.in"
source "package/libcap/Config.in"
source "package/libcap-ng/Config.in"
diff --git a/package/apr/Config.in b/package/apr/Config.in
new file mode 100644
index 0000000..d156909
--- /dev/null
+++ b/package/apr/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_LIBAPR
+ bool "apr"
+ help
+ The mission of the Apache Portable Runtime (APR) project is to create
+ and maintain software libraries that provide a predictable and
+ consistent interface to underlying platform-specific implementations
+ http://apr.apache.org/
diff --git a/package/apr/apr.mk b/package/apr/apr.mk
new file mode 100644
index 0000000..ae91eb1
--- /dev/null
+++ b/package/apr/apr.mk
@@ -0,0 +1,18 @@
+#############################################################
+#
+# apr
+#
+#############################################################
+APR_VERSION = 1.4.6
+APR_SITE = archive.apache.org/dist/apr
+APR_INSTALL_STAGING = YES
+APR_CONF_ENV = \
+ ac_cv_file__dev_zero=yes \
+ ac_cv_func_setpgrp_void=yes \
+ apr_cv_process_shared_works=yes \
+ apr_cv_mutex_robust_shared=no \
+ apr_cv_tcp_nodelay_with_cork=yes \
+ ac_cv_sizeof_struct_iovec=8 \
+ apr_cv_mutex_recursive=yes
+
+$(eval $(call AUTOTARGETS))
--
1.7.2.5
^ permalink raw reply related [flat|nested] 23+ messages in thread* [Buildroot] [PATCH] Add libapr-package
2012-04-17 13:16 [Buildroot] [PATCH] Add libapr-package Rico Bachmann
@ 2012-04-17 13:20 ` Baruch Siach
2012-04-17 13:26 ` Rico Bachmann
2012-04-17 13:22 ` Yegor Yefremov
2012-04-17 13:25 ` Maxime Ripard
2 siblings, 1 reply; 23+ messages in thread
From: Baruch Siach @ 2012-04-17 13:20 UTC (permalink / raw)
To: buildroot
Hi Rico,
On Tue, Apr 17, 2012 at 03:16:52PM +0200, Rico Bachmann wrote:
> Signed-off-by: Rico Bachmann <bachmann@tofwerk.com>
> ---
> package/Config.in | 1 +
> package/apr/Config.in | 7 +++++++
> package/apr/apr.mk | 18 ++++++++++++++++++
> 3 files changed, 26 insertions(+), 0 deletions(-)
> create mode 100644 package/apr/Config.in
> create mode 100644 package/apr/apr.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 4c6d4d8..ceb5f6d 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -376,6 +376,7 @@ source "package/fftw/Config.in"
> source "package/libargtable2/Config.in"
> source "package/argp-standalone/Config.in"
> source "package/boost/Config.in"
> +source "package/libapr/Config.in"
This doesn't match the location of Config.in below. Is this patch build
tested?
baruch
> source "package/libatomic_ops/Config.in"
> source "package/libcap/Config.in"
> source "package/libcap-ng/Config.in"
> diff --git a/package/apr/Config.in b/package/apr/Config.in
> new file mode 100644
> index 0000000..d156909
> --- /dev/null
> +++ b/package/apr/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_LIBAPR
> + bool "apr"
> + help
> + The mission of the Apache Portable Runtime (APR) project is to create
> + and maintain software libraries that provide a predictable and
> + consistent interface to underlying platform-specific implementations
> + http://apr.apache.org/
> diff --git a/package/apr/apr.mk b/package/apr/apr.mk
> new file mode 100644
> index 0000000..ae91eb1
> --- /dev/null
> +++ b/package/apr/apr.mk
> @@ -0,0 +1,18 @@
> +#############################################################
> +#
> +# apr
> +#
> +#############################################################
> +APR_VERSION = 1.4.6
> +APR_SITE = archive.apache.org/dist/apr
> +APR_INSTALL_STAGING = YES
> +APR_CONF_ENV = \
> + ac_cv_file__dev_zero=yes \
> + ac_cv_func_setpgrp_void=yes \
> + apr_cv_process_shared_works=yes \
> + apr_cv_mutex_robust_shared=no \
> + apr_cv_tcp_nodelay_with_cork=yes \
> + ac_cv_sizeof_struct_iovec=8 \
> + apr_cv_mutex_recursive=yes
> +
> +$(eval $(call AUTOTARGETS))
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 23+ messages in thread* [Buildroot] [PATCH] Add libapr-package
2012-04-17 13:20 ` Baruch Siach
@ 2012-04-17 13:26 ` Rico Bachmann
2012-04-17 13:29 ` Baruch Siach
0 siblings, 1 reply; 23+ messages in thread
From: Rico Bachmann @ 2012-04-17 13:26 UTC (permalink / raw)
To: buildroot
Am 17.04.2012, 15:20 Uhr, schrieb Baruch Siach
<baruch@tkos.co.il>:
> Hi Rico,
>
> On Tue, Apr 17, 2012 at 03:16:52PM +0200, Rico Bachmann wrote:
>> Signed-off-by: Rico Bachmann
>> <bachmann@tofwerk.com>
>> ---
>> package/Config.in | 1 +
>> package/apr/Config.in | 7 +++++++
>> package/apr/apr.mk | 18 ++++++++++++++++++
>> 3 files changed, 26 insertions(+), 0 deletions(-)
>> create mode 100644 package/apr/Config.in
>> create mode 100644 package/apr/apr.mk
>>
>> diff --git a/package/Config.in b/package/Config.in
>> index 4c6d4d8..ceb5f6d 100644
>> --- a/package/Config.in
>> +++ b/package/Config.in
>> @@ -376,6 +376,7 @@ source "package/fftw/Config.in"
>> source "package/libargtable2/Config.in"
>> source "package/argp-standalone/Config.in"
>> source "package/boost/Config.in"
>> +source "package/libapr/Config.in"
>
> This doesn't match the location of Config.in below. Is this patch build
> tested?
Ah i forgot about the package/Config.in
I correct the path
>
> baruch
>
>> source "package/libatomic_ops/Config.in"
>> source "package/libcap/Config.in"
>> source "package/libcap-ng/Config.in"
>> diff --git a/package/apr/Config.in b/package/apr/Config.in
>> new file mode 100644
>> index 0000000..d156909
>> --- /dev/null
>> +++ b/package/apr/Config.in
>> @@ -0,0 +1,7 @@
>> +config BR2_PACKAGE_LIBAPR
>> + bool "apr"
>> + help
>> + The mission of the Apache Portable Runtime (APR) project is to
>> create
>> + and maintain software libraries that provide a predictable and
>> + consistent interface to underlying platform-specific implementations
>> + http://apr.apache.org/
>> diff --git a/package/apr/apr.mk b/package/apr/apr.mk
>> new file mode 100644
>> index 0000000..ae91eb1
>> --- /dev/null
>> +++ b/package/apr/apr.mk
>> @@ -0,0 +1,18 @@
>> +#############################################################
>> +#
>> +# apr
>> +#
>> +#############################################################
>> +APR_VERSION = 1.4.6
>> +APR_SITE = archive.apache.org/dist/apr
>> +APR_INSTALL_STAGING = YES
>> +APR_CONF_ENV = \
>> + ac_cv_file__dev_zero=yes \
>> + ac_cv_func_setpgrp_void=yes \
>> + apr_cv_process_shared_works=yes \
>> + apr_cv_mutex_robust_shared=no \
>> + apr_cv_tcp_nodelay_with_cork=yes \
>> + ac_cv_sizeof_struct_iovec=8 \
>> + apr_cv_mutex_recursive=yes
>> +
>> +$(eval $(call AUTOTARGETS))
>
> baruch
>
--
Erstellt mit Operas revolution?rem E-Mail-Modul: http://www.opera.com/mail/
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Buildroot] [PATCH] Add libapr-package
2012-04-17 13:26 ` Rico Bachmann
@ 2012-04-17 13:29 ` Baruch Siach
0 siblings, 0 replies; 23+ messages in thread
From: Baruch Siach @ 2012-04-17 13:29 UTC (permalink / raw)
To: buildroot
Hi Rico,
On Tue, Apr 17, 2012 at 03:26:34PM +0200, Rico Bachmann wrote:
> Am 17.04.2012, 15:20 Uhr, schrieb Baruch Siach <baruch@tkos.co.il>:
> >On Tue, Apr 17, 2012 at 03:16:52PM +0200, Rico Bachmann wrote:
> >>Signed-off-by: Rico Bachmann <bachmann@tofwerk.com>
> >>---
> >> package/Config.in | 1 +
> >> package/apr/Config.in | 7 +++++++
> >> package/apr/apr.mk | 18 ++++++++++++++++++
> >> 3 files changed, 26 insertions(+), 0 deletions(-)
> >> create mode 100644 package/apr/Config.in
> >> create mode 100644 package/apr/apr.mk
> >>
> >>diff --git a/package/Config.in b/package/Config.in
> >>index 4c6d4d8..ceb5f6d 100644
> >>--- a/package/Config.in
> >>+++ b/package/Config.in
> >>@@ -376,6 +376,7 @@ source "package/fftw/Config.in"
> >> source "package/libargtable2/Config.in"
> >> source "package/argp-standalone/Config.in"
> >> source "package/boost/Config.in"
> >>+source "package/libapr/Config.in"
> >
> >This doesn't match the location of Config.in below. Is this patch build
> >tested?
>
> Ah i forgot about the package/Config.in
> I correct the path
The subject line of this patch should also change as well.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Buildroot] [PATCH] Add libapr-package
2012-04-17 13:16 [Buildroot] [PATCH] Add libapr-package Rico Bachmann
2012-04-17 13:20 ` Baruch Siach
@ 2012-04-17 13:22 ` Yegor Yefremov
2012-04-17 13:29 ` Rico Bachmann
2012-04-17 13:25 ` Maxime Ripard
2 siblings, 1 reply; 23+ messages in thread
From: Yegor Yefremov @ 2012-04-17 13:22 UTC (permalink / raw)
To: buildroot
On Tue, Apr 17, 2012 at 3:16 PM, Rico Bachmann <bachmann@tofwerk.com> wrote:
> Signed-off-by: Rico Bachmann <bachmann@tofwerk.com>
> ---
> ?package/Config.in ? ? | ? ?1 +
> ?package/apr/Config.in | ? ?7 +++++++
> ?package/apr/apr.mk ? ?| ? 18 ++++++++++++++++++
> ?3 files changed, 26 insertions(+), 0 deletions(-)
> ?create mode 100644 package/apr/Config.in
> ?create mode 100644 package/apr/apr.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 4c6d4d8..ceb5f6d 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -376,6 +376,7 @@ source "package/fftw/Config.in"
> ?source "package/libargtable2/Config.in"
> ?source "package/argp-standalone/Config.in"
> ?source "package/boost/Config.in"
> +source "package/libapr/Config.in"
> ?source "package/libatomic_ops/Config.in"
> ?source "package/libcap/Config.in"
> ?source "package/libcap-ng/Config.in"
> diff --git a/package/apr/Config.in b/package/apr/Config.in
> new file mode 100644
> index 0000000..d156909
> --- /dev/null
> +++ b/package/apr/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_LIBAPR
> + ? ? ? bool "apr"
> + ? ? ? help
> + ? ? ? ? The mission of the Apache Portable Runtime (APR) project is to create
> + ? ? ? ? and maintain software libraries that provide a predictable and
> + ? ? ? ? consistent interface to underlying platform-specific implementations
one blanc line between help text and project site
> + ? ? ? ? http://apr.apache.org/
> diff --git a/package/apr/apr.mk b/package/apr/apr.mk
> new file mode 100644
> index 0000000..ae91eb1
> --- /dev/null
> +++ b/package/apr/apr.mk
> @@ -0,0 +1,18 @@
> +#############################################################
> +#
> +# apr
> +#
> +#############################################################
> +APR_VERSION = 1.4.6
> +APR_SITE = archive.apache.org/dist/apr
> +APR_INSTALL_STAGING = YES
> +APR_CONF_ENV = \
> + ? ? ? ac_cv_file__dev_zero=yes \
> + ? ? ? ac_cv_func_setpgrp_void=yes \
> + ? ? ? apr_cv_process_shared_works=yes \
> + ? ? ? apr_cv_mutex_robust_shared=no \
> + ? ? ? apr_cv_tcp_nodelay_with_cork=yes \
> + ? ? ? ac_cv_sizeof_struct_iovec=8 \
> + ? ? ? apr_cv_mutex_recursive=yes
> +
> +$(eval $(call AUTOTARGETS))
> --
> 1.7.2.5
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Buildroot] [PATCH] Add libapr-package
2012-04-17 13:22 ` Yegor Yefremov
@ 2012-04-17 13:29 ` Rico Bachmann
0 siblings, 0 replies; 23+ messages in thread
From: Rico Bachmann @ 2012-04-17 13:29 UTC (permalink / raw)
To: buildroot
Am 17.04.2012, 15:22 Uhr, schrieb Yegor Yefremov
<yegorslists@googlemail.com>:
> On Tue, Apr 17, 2012 at 3:16 PM, Rico Bachmann <bachmann@tofwerk.com>
> wrote:
>> Signed-off-by: Rico Bachmann <bachmann@tofwerk.com>
>> ---
>> package/Config.in | 1 +
>> package/apr/Config.in | 7 +++++++
>> package/apr/apr.mk | 18 ++++++++++++++++++
>> 3 files changed, 26 insertions(+), 0 deletions(-)
>> create mode 100644 package/apr/Config.in
>> create mode 100644 package/apr/apr.mk
>>
>> diff --git a/package/Config.in b/package/Config.in
>> index 4c6d4d8..ceb5f6d 100644
>> --- a/package/Config.in
>> +++ b/package/Config.in
>> @@ -376,6 +376,7 @@ source "package/fftw/Config.in"
>> source "package/libargtable2/Config.in"
>> source "package/argp-standalone/Config.in"
>> source "package/boost/Config.in"
>> +source "package/libapr/Config.in"
>> source "package/libatomic_ops/Config.in"
>> source "package/libcap/Config.in"
>> source "package/libcap-ng/Config.in"
>> diff --git a/package/apr/Config.in b/package/apr/Config.in
>> new file mode 100644
>> index 0000000..d156909
>> --- /dev/null
>> +++ b/package/apr/Config.in
>> @@ -0,0 +1,7 @@
>> +config BR2_PACKAGE_LIBAPR
>> + bool "apr"
>> + help
>> + The mission of the Apache Portable Runtime (APR) project is
>> to create
>> + and maintain software libraries that provide a predictable and
>> + consistent interface to underlying platform-specific
>> implementations
>
> one blanc line between help text and project site
ok i'll do that
>
>> + http://apr.apache.org/
>> diff --git a/package/apr/apr.mk b/package/apr/apr.mk
>> new file mode 100644
>> index 0000000..ae91eb1
>> --- /dev/null
>> +++ b/package/apr/apr.mk
>> @@ -0,0 +1,18 @@
>> +#############################################################
>> +#
>> +# apr
>> +#
>> +#############################################################
>> +APR_VERSION = 1.4.6
>> +APR_SITE = archive.apache.org/dist/apr
>> +APR_INSTALL_STAGING = YES
>> +APR_CONF_ENV = \
>> + ac_cv_file__dev_zero=yes \
>> + ac_cv_func_setpgrp_void=yes \
>> + apr_cv_process_shared_works=yes \
>> + apr_cv_mutex_robust_shared=no \
>> + apr_cv_tcp_nodelay_with_cork=yes \
>> + ac_cv_sizeof_struct_iovec=8 \
>> + apr_cv_mutex_recursive=yes
>> +
>> +$(eval $(call AUTOTARGETS))
>> --
>> 1.7.2.5
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
Erstellt mit Operas revolution?rem E-Mail-Modul: http://www.opera.com/mail/
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Buildroot] [PATCH] Add libapr-package
2012-04-17 13:16 [Buildroot] [PATCH] Add libapr-package Rico Bachmann
2012-04-17 13:20 ` Baruch Siach
2012-04-17 13:22 ` Yegor Yefremov
@ 2012-04-17 13:25 ` Maxime Ripard
2012-04-17 13:35 ` Rico Bachmann
2 siblings, 1 reply; 23+ messages in thread
From: Maxime Ripard @ 2012-04-17 13:25 UTC (permalink / raw)
To: buildroot
Hi,
Le 17/04/2012 15:16, Rico Bachmann a ?crit :
> Signed-off-by: Rico Bachmann <bachmann@tofwerk.com>
> ---
> package/Config.in | 1 +
> package/apr/Config.in | 7 +++++++
> package/apr/apr.mk | 18 ++++++++++++++++++
> 3 files changed, 26 insertions(+), 0 deletions(-)
> create mode 100644 package/apr/Config.in
> create mode 100644 package/apr/apr.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 4c6d4d8..ceb5f6d 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -376,6 +376,7 @@ source "package/fftw/Config.in"
> source "package/libargtable2/Config.in"
> source "package/argp-standalone/Config.in"
> source "package/boost/Config.in"
> +source "package/libapr/Config.in"
You should change this to "package/apr/Config.in" now that you have
changed the location of this file. This won't even work.
> source "package/libatomic_ops/Config.in"
> source "package/libcap/Config.in"
> source "package/libcap-ng/Config.in"
> diff --git a/package/apr/Config.in b/package/apr/Config.in
> new file mode 100644
> index 0000000..d156909
> --- /dev/null
> +++ b/package/apr/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_LIBAPR
Same thing here, it should be called BR2_PACKAGE_APR.
> + bool "apr"
> + help
> + The mission of the Apache Portable Runtime (APR) project is to create
> + and maintain software libraries that provide a predictable and
> + consistent interface to underlying platform-specific implementations
Could you add an extra line here ?
> + http://apr.apache.org/
> diff --git a/package/apr/apr.mk b/package/apr/apr.mk
> new file mode 100644
> index 0000000..ae91eb1
> --- /dev/null
> +++ b/package/apr/apr.mk
> @@ -0,0 +1,18 @@
> +#############################################################
> +#
> +# apr
> +#
> +#############################################################
> +APR_VERSION = 1.4.6
> +APR_SITE = archive.apache.org/dist/apr
You should put http:// here. We use the URL's scheme to select the
appropriate downloading method. I guess it defaults to http if no scheme
is set, but hey, explicit is always better than implicit :)
> +APR_INSTALL_STAGING = YES
> +APR_CONF_ENV = \
> + ac_cv_file__dev_zero=yes \
> + ac_cv_func_setpgrp_void=yes \
> + apr_cv_process_shared_works=yes \
> + apr_cv_mutex_robust_shared=no \
> + apr_cv_tcp_nodelay_with_cork=yes \
> + ac_cv_sizeof_struct_iovec=8 \
> + apr_cv_mutex_recursive=yes
> +
> +$(eval $(call AUTOTARGETS))
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Buildroot] [PATCH] Add libapr-package
2012-04-17 13:25 ` Maxime Ripard
@ 2012-04-17 13:35 ` Rico Bachmann
0 siblings, 0 replies; 23+ messages in thread
From: Rico Bachmann @ 2012-04-17 13:35 UTC (permalink / raw)
To: buildroot
Am 17.04.2012, 15:25 Uhr, schrieb Maxime Ripard
<maxime.ripard@free-electrons.com>:
> Hi,
>
> Le 17/04/2012 15:16, Rico Bachmann a ?crit :
>> Signed-off-by: Rico Bachmann
>> <bachmann@tofwerk.com>
>> ---
>> package/Config.in | 1 +
>> package/apr/Config.in | 7 +++++++
>> package/apr/apr.mk | 18 ++++++++++++++++++
>> 3 files changed, 26 insertions(+), 0 deletions(-)
>> create mode 100644 package/apr/Config.in
>> create mode 100644 package/apr/apr.mk
>>
>> diff --git a/package/Config.in b/package/Config.in
>> index 4c6d4d8..ceb5f6d 100644
>> --- a/package/Config.in
>> +++ b/package/Config.in
>> @@ -376,6 +376,7 @@ source "package/fftw/Config.in"
>> source "package/libargtable2/Config.in"
>> source "package/argp-standalone/Config.in"
>> source "package/boost/Config.in"
>> +source "package/libapr/Config.in"
>
> You should change this to "package/apr/Config.in" now that you have
> changed the location of this file. This won't even work.
>
>> source "package/libatomic_ops/Config.in"
>> source "package/libcap/Config.in"
>> source "package/libcap-ng/Config.in"
>> diff --git a/package/apr/Config.in b/package/apr/Config.in
>> new file mode 100644
>> index 0000000..d156909
>> --- /dev/null
>> +++ b/package/apr/Config.in
>> @@ -0,0 +1,7 @@
>> +config BR2_PACKAGE_LIBAPR
>
> Same thing here, it should be called BR2_PACKAGE_APR.
yeah i should add the namechanges in all the places... I could have seen
this if i tested the latest version of my patch -.-
>
>> + bool "apr"
>> + help
>> + The mission of the Apache Portable Runtime (APR) project is to
>> create
>> + and maintain software libraries that provide a predictable and
>> + consistent interface to underlying platform-specific implementations
>
> Could you add an extra line here ?
>
>> + http://apr.apache.org/
>> diff --git a/package/apr/apr.mk b/package/apr/apr.mk
>> new file mode 100644
>> index 0000000..ae91eb1
>> --- /dev/null
>> +++ b/package/apr/apr.mk
>> @@ -0,0 +1,18 @@
>> +#############################################################
>> +#
>> +# apr
>> +#
>> +#############################################################
>> +APR_VERSION = 1.4.6
>> +APR_SITE = archive.apache.org/dist/apr
>
> You should put http:// here. We use the URL's scheme to select the
> appropriate downloading method. I guess it defaults to http if no scheme
> is set, but hey, explicit is always better than implicit :)
ok i will do that, i was to lazy befor because it worked ^^
>
>> +APR_INSTALL_STAGING = YES
>> +APR_CONF_ENV = \
>> + ac_cv_file__dev_zero=yes \
>> + ac_cv_func_setpgrp_void=yes \
>> + apr_cv_process_shared_works=yes \
>> + apr_cv_mutex_robust_shared=no \
>> + apr_cv_tcp_nodelay_with_cork=yes \
>> + ac_cv_sizeof_struct_iovec=8 \
>> + apr_cv_mutex_recursive=yes
>> +
>> +$(eval $(call AUTOTARGETS))
>
> Thanks,
> Maxime
>
--
Erstellt mit Operas revolution?rem E-Mail-Modul: http://www.opera.com/mail/
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Buildroot] [PATCH] Add libapr-package
@ 2012-04-17 14:35 Rico Bachmann
2012-04-21 12:58 ` Arnout Vandecappelle
0 siblings, 1 reply; 23+ messages in thread
From: Rico Bachmann @ 2012-04-17 14:35 UTC (permalink / raw)
To: buildroot
Add libapr-package
rename from libapr to apr
rename all values and arguments from libapr into apr
change package/Config.in from libapr to apr
add the other small changes from mailinglist
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Buildroot] [PATCH] Add libapr-package
2012-04-17 14:35 Rico Bachmann
@ 2012-04-21 12:58 ` Arnout Vandecappelle
2012-04-24 9:32 ` Rico Bachmann
0 siblings, 1 reply; 23+ messages in thread
From: Arnout Vandecappelle @ 2012-04-21 12:58 UTC (permalink / raw)
To: buildroot
On Tuesday 17 April 2012 16:35:15 Rico Bachmann wrote:
>
> Add libapr-package
> rename from libapr to apr
> rename all values and arguments from libapr into apr
> change package/Config.in from libapr to apr
> add the other small changes from mailinglist
Hoi Rico,
Thanks for your persistence in correcting your patch until it was perfect!
One last suggestion for next time you make a patch: you can add the log
of the history of your patch directly in the commit message, below a line
with three dashes, like this:
Signed-off-by: Rico Bachmann <bachmann@tofwerk.com>
---
v3: Rename from libapr to apr
v2: ...
When the patch is applied to git, the part below the --- will be
removed, so you can also add other random comments in there.
And also, you can add the version number when sending the patch
like this:
git send-email --subject-prefix='PATCH v2' ...
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Buildroot] [PATCH] Add libapr-package
2012-04-21 12:58 ` Arnout Vandecappelle
@ 2012-04-24 9:32 ` Rico Bachmann
2012-04-27 19:21 ` Arnout Vandecappelle
0 siblings, 1 reply; 23+ messages in thread
From: Rico Bachmann @ 2012-04-24 9:32 UTC (permalink / raw)
To: buildroot
> -----Urspr?ngliche Nachricht-----
> Von: Arnout Vandecappelle [mailto:arnout at mind.be]
> Gesendet: Samstag, 21. April 2012 14:58
> An: buildroot at busybox.net
> Cc: Rico Bachmann
> Betreff: Re: [Buildroot] [PATCH] Add libapr-package
>
> On Tuesday 17 April 2012 16:35:15 Rico Bachmann wrote:
> >
> > Add libapr-package
> > rename from libapr to apr
> > rename all values and arguments from libapr into apr change
> > package/Config.in from libapr to apr add the other small changes from
> > mailinglist
>
> Hoi Rico,
>
> Thanks for your persistence in correcting your patch until it was
> perfect!
>
> One last suggestion for next time you make a patch: you can add the
> log of the history of your patch directly in the commit message, below
> a line with three dashes, like this:
>
> Signed-off-by: Rico Bachmann <bachmann@tofwerk.com>
> ---
> v3: Rename from libapr to apr
> v2: ...
I'll try that with my new patch for apr-util.
How can I add my history when I have to do a git rebase -I master?
Because I can't see my history in the patch after a fixup with git rebase.
Do I have to add them manually?
>
>
> When the patch is applied to git, the part below the --- will be
> removed, so you can also add other random comments in there.
>
> And also, you can add the version number when sending the patch like
> this:
>
> git send-email --subject-prefix='PATCH v2' ...
I'll try that if I need a v2 from my next patch.
>
>
> Regards,
> Arnout
>
>
> --
> Arnout Vandecappelle arnout at mind be
> Senior Embedded Software Architect +32-16-286540
> Essensium/Mind http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR
> Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
Thanks for the hints!
Regards
Rico
Tofwerk AG, Rico Bachmann
+41 33 511 11 69
bachmann at tofwerk.com
http://www.tofwerk.com
Uttigenstrasse 22
CH - 3600 Thun
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Buildroot] [PATCH] Add libapr-package
2012-04-24 9:32 ` Rico Bachmann
@ 2012-04-27 19:21 ` Arnout Vandecappelle
0 siblings, 0 replies; 23+ messages in thread
From: Arnout Vandecappelle @ 2012-04-27 19:21 UTC (permalink / raw)
To: buildroot
On Tuesday 24 April 2012 11:32:52 Rico Bachmann wrote:
> > One last suggestion for next time you make a patch: you can add the
> > log of the history of your patch directly in the commit message, below
> > a line with three dashes, like this:
> >
> > Signed-off-by: Rico Bachmann <bachmann@tofwerk.com>
> > ---
> > v3: Rename from libapr to apr
> > v2: ...
>
> I'll try that with my new patch for apr-util.
> How can I add my history when I have to do a git rebase -I master?
>
> Because I can't see my history in the patch after a fixup with git rebase.
>
> Do I have to add them manually?
Indeed, git rebase is the same as applying the patch from a mail... You
can either fix up the commit message manually, or use something like
topgit to manage your patch queues.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 23+ messages in thread
[parent not found: <Re:[PATCH] Add libapr-package>]
* [Buildroot] [PATCH] Add libapr-package
[not found] <Re:[PATCH] Add libapr-package>
@ 2012-04-17 10:59 ` Rico Bachmann
2012-04-17 11:36 ` Maxime Ripard
2012-04-17 11:39 ` Thomas Petazzoni
0 siblings, 2 replies; 23+ messages in thread
From: Rico Bachmann @ 2012-04-17 10:59 UTC (permalink / raw)
To: buildroot
Signed-off-by: Rico Bachmann <bachmann@tofwerk.com>
---
package/Config.in | 1 +
package/libapr/Config.in | 7 +++++++
package/libapr/libapr.mk | 12 ++++++++++++
3 files changed, 20 insertions(+), 0 deletions(-)
create mode 100644 package/libapr/Config.in
create mode 100644 package/libapr/libapr.mk
diff --git a/package/Config.in b/package/Config.in
index 4c6d4d8..ceb5f6d 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -376,6 +376,7 @@ source "package/fftw/Config.in"
source "package/libargtable2/Config.in"
source "package/argp-standalone/Config.in"
source "package/boost/Config.in"
+source "package/libapr/Config.in"
source "package/libatomic_ops/Config.in"
source "package/libcap/Config.in"
source "package/libcap-ng/Config.in"
diff --git a/package/libapr/Config.in b/package/libapr/Config.in
new file mode 100644
index 0000000..51dea91
--- /dev/null
+++ b/package/libapr/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_LIBAPR
+
+ bool "libapr"
+ help
+ The mission of the Apache Portable Runtime (APR) project is to create and maintain software libraries that provide a predictable and consistent interface to underlying platform-specific implementations
+
+ http://apr.apache.org/
diff --git a/package/libapr/libapr.mk b/package/libapr/libapr.mk
new file mode 100644
index 0000000..57da8ef
--- /dev/null
+++ b/package/libapr/libapr.mk
@@ -0,0 +1,12 @@
+#############################################################
+#
+# libapr
+#
+#############################################################
+LIBAPR_VERSION = 1.4.6
+LIBAPR_SOURCE = apr-$(LIBAPR_VERSION).tar.gz
+LIBAPR_SITE = http://mirror.switch.ch/mirror/apache/dist/apr
+LIBAPR_INSTALL_STAGING = YES
+LIBAPR_CONF_OPT = ac_cv_file__dev_zero=yes ac_cv_func_setpgrp_void=yes apr_cv_process_shared_works=yes apr_cv_mutex_robust_shared=no apr_cv_tcp_nodelay_with_cork=yes ac_cv_sizeof_struct_iovec=8 apr_cv_mutex_recursive=yes --enable-shared
+
+$(eval $(call AUTOTARGETS))
--
1.7.2.5
^ permalink raw reply related [flat|nested] 23+ messages in thread* [Buildroot] [PATCH] Add libapr-package
2012-04-17 10:59 ` Rico Bachmann
@ 2012-04-17 11:36 ` Maxime Ripard
2012-04-17 12:18 ` Rico Bachmann
2012-04-17 11:39 ` Thomas Petazzoni
1 sibling, 1 reply; 23+ messages in thread
From: Maxime Ripard @ 2012-04-17 11:36 UTC (permalink / raw)
To: buildroot
Hi,
Thanks for your patch!
Le 17/04/2012 12:59, Rico Bachmann a ?crit :
> Signed-off-by: Rico Bachmann <bachmann@tofwerk.com>
> ---
> package/Config.in | 1 +
> package/libapr/Config.in | 7 +++++++
> package/libapr/libapr.mk | 12 ++++++++++++
> 3 files changed, 20 insertions(+), 0 deletions(-)
> create mode 100644 package/libapr/Config.in
> create mode 100644 package/libapr/libapr.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 4c6d4d8..ceb5f6d 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -376,6 +376,7 @@ source "package/fftw/Config.in"
> source "package/libargtable2/Config.in"
> source "package/argp-standalone/Config.in"
> source "package/boost/Config.in"
> +source "package/libapr/Config.in"
> source "package/libatomic_ops/Config.in"
> source "package/libcap/Config.in"
> source "package/libcap-ng/Config.in"
> diff --git a/package/libapr/Config.in b/package/libapr/Config.in
> new file mode 100644
> index 0000000..51dea91
> --- /dev/null
> +++ b/package/libapr/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_LIBAPR
> +
> + bool "libapr"
> + help
> + The mission of the Apache Portable Runtime (APR) project is to create and maintain software libraries that provide a predictable and consistent interface to underlying platform-specific implementations
Could you wrap this line to 80 characters ?
> + http://apr.apache.org/
> diff --git a/package/libapr/libapr.mk b/package/libapr/libapr.mk
> new file mode 100644
> index 0000000..57da8ef
> --- /dev/null
> +++ b/package/libapr/libapr.mk
> @@ -0,0 +1,12 @@
> +#############################################################
> +#
> +# libapr
> +#
> +#############################################################
> +LIBAPR_VERSION = 1.4.6
> +LIBAPR_SOURCE = apr-$(LIBAPR_VERSION).tar.gz
> +LIBAPR_SITE = http://mirror.switch.ch/mirror/apache/dist/apr
> +LIBAPR_INSTALL_STAGING = YES
> +LIBAPR_CONF_OPT = ac_cv_file__dev_zero=yes ac_cv_func_setpgrp_void=yes apr_cv_process_shared_works=yes apr_cv_mutex_robust_shared=no apr_cv_tcp_nodelay_with_cork=yes ac_cv_sizeof_struct_iovec=8 apr_cv_mutex_recursive=yes --enable-shared
All the ac_cv_* stuff should go into LIBAPR_CONF_ENV variable.
You should wrap the line to 80 characters also.
--enabled-shared is automatically set by buildroot if it needs to when
the package is built, so you don't need to set it here.
Otherwise, it looks good to me.
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Buildroot] [PATCH] Add libapr-package
2012-04-17 11:36 ` Maxime Ripard
@ 2012-04-17 12:18 ` Rico Bachmann
0 siblings, 0 replies; 23+ messages in thread
From: Rico Bachmann @ 2012-04-17 12:18 UTC (permalink / raw)
To: buildroot
Am 17.04.2012, 13:36 Uhr, schrieb Maxime Ripard
<maxime.ripard@free-electrons.com>:
> Hi,
>
> Thanks for your patch!
>
> Le 17/04/2012 12:59, Rico Bachmann a ?crit :
>> Signed-off-by: Rico Bachmann
>> <bachmann@tofwerk.com>
>> ---
>> package/Config.in | 1 +
>> package/libapr/Config.in | 7 +++++++
>> package/libapr/libapr.mk | 12 ++++++++++++
>> 3 files changed, 20 insertions(+), 0 deletions(-)
>> create mode 100644 package/libapr/Config.in
>> create mode 100644 package/libapr/libapr.mk
>>
>> diff --git a/package/Config.in b/package/Config.in
>> index 4c6d4d8..ceb5f6d 100644
>> --- a/package/Config.in
>> +++ b/package/Config.in
>> @@ -376,6 +376,7 @@ source "package/fftw/Config.in"
>> source "package/libargtable2/Config.in"
>> source "package/argp-standalone/Config.in"
>> source "package/boost/Config.in"
>> +source "package/libapr/Config.in"
>> source "package/libatomic_ops/Config.in"
>> source "package/libcap/Config.in"
>> source "package/libcap-ng/Config.in"
>> diff --git a/package/libapr/Config.in b/package/libapr/Config.in
>> new file mode 100644
>> index 0000000..51dea91
>> --- /dev/null
>> +++ b/package/libapr/Config.in
>> @@ -0,0 +1,7 @@
>> +config BR2_PACKAGE_LIBAPR
>> +
>> + bool "libapr"
>> + help
>> + The mission of the Apache Portable Runtime (APR) project is to
>> create and maintain software libraries that provide a predictable and
>> consistent interface to underlying platform-specific implementations
>
> Could you wrap this line to 80 characters ?
I will wrap this line in my next patch
>
>> + http://apr.apache.org/
>> diff --git a/package/libapr/libapr.mk b/package/libapr/libapr.mk
>> new file mode 100644
>> index 0000000..57da8ef
>> --- /dev/null
>> +++ b/package/libapr/libapr.mk
>> @@ -0,0 +1,12 @@
>> +#############################################################
>> +#
>> +# libapr
>> +#
>> +#############################################################
>> +LIBAPR_VERSION = 1.4.6
>> +LIBAPR_SOURCE = apr-$(LIBAPR_VERSION).tar.gz
>> +LIBAPR_SITE = http://mirror.switch.ch/mirror/apache/dist/apr
>> +LIBAPR_INSTALL_STAGING = YES
>> +LIBAPR_CONF_OPT = ac_cv_file__dev_zero=yes ac_cv_func_setpgrp_void=yes
>> apr_cv_process_shared_works=yes apr_cv_mutex_robust_shared=no
>> apr_cv_tcp_nodelay_with_cork=yes ac_cv_sizeof_struct_iovec=8
>> apr_cv_mutex_recursive=yes --enable-shared
>
> All the ac_cv_* stuff should go into LIBAPR_CONF_ENV variable.
> You should wrap the line to 80 characters also.
> --enabled-shared is automatically set by buildroot if it needs to when
> the package is built, so you don't need to set it here.
Ok i will add the apr_cv_* stuff to LIBAPR_CONF_ENV instead of
LIBAPR_CONF_OPT
and delete the --enable-shared argument
>
> Otherwise, it looks good to me.
>
> Thanks,
> Maxime
>
--
Erstellt mit Operas revolution?rem E-Mail-Modul: http://www.opera.com/mail/
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Buildroot] [PATCH] Add libapr-package
2012-04-17 10:59 ` Rico Bachmann
2012-04-17 11:36 ` Maxime Ripard
@ 2012-04-17 11:39 ` Thomas Petazzoni
2012-04-17 12:01 ` Peter Korsgaard
2012-04-17 12:18 ` Rico Bachmann
1 sibling, 2 replies; 23+ messages in thread
From: Thomas Petazzoni @ 2012-04-17 11:39 UTC (permalink / raw)
To: buildroot
Hello Rico,
Thanks for this contribution!
Le Tue, 17 Apr 2012 12:59:30 +0200,
Rico Bachmann <bachmann@tofwerk.com> a ?crit :
> +++ b/package/libapr/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_LIBAPR
> +
Remove this blank line.
> + bool "libapr"
> + help
> + The mission of the Apache Portable Runtime (APR) project is to create and maintain software libraries that provide a predictable and consistent interface to underlying platform-specific implementations
This text should be wrapped at ~80 columns.
> new file mode 100644
> index 0000000..57da8ef
> --- /dev/null
> +++ b/package/libapr/libapr.mk
> @@ -0,0 +1,12 @@
> +#############################################################
> +#
> +# libapr
> +#
> +#############################################################
> +LIBAPR_VERSION = 1.4.6
> +LIBAPR_SOURCE = apr-$(LIBAPR_VERSION).tar.gz
Yegor's suggestion didn't work because by default we download
<package-name>-<package-version>.tar.gz. However here you decided to
name the Buildroot package "libapr", while the upstream package is
"apr". Maybe we should use the "apr" name like upstream?
> +LIBAPR_SITE = http://mirror.switch.ch/mirror/apache/dist/apr
> +LIBAPR_INSTALL_STAGING = YES
> +LIBAPR_CONF_OPT = ac_cv_file__dev_zero=yes ac_cv_func_setpgrp_void=yes apr_cv_process_shared_works=yes apr_cv_mutex_robust_shared=no apr_cv_tcp_nodelay_with_cork=yes ac_cv_sizeof_struct_iovec=8 apr_cv_mutex_recursive=yes --enable-shared
Please wrap this this way:
LIBAPR_CONF_OPT = \
ac_cv_file__dev_zero=yes \
ac_cv_func_setgrp_void=yes \
...
And remove --enable-shared since it is already passed by default, and
tuned when BR2_PREFER_STATIC is used.
Regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Buildroot] [PATCH] Add libapr-package
2012-04-17 11:39 ` Thomas Petazzoni
@ 2012-04-17 12:01 ` Peter Korsgaard
2012-04-17 12:22 ` Rico Bachmann
2012-04-17 12:18 ` Rico Bachmann
1 sibling, 1 reply; 23+ messages in thread
From: Peter Korsgaard @ 2012-04-17 12:01 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
Hi,
>> + bool "libapr"
>> + help
>> + The mission of the Apache Portable Runtime (APR) project is to create and maintain software libraries that provide a predictable and consistent interface to underlying platform-specific implementations
Thomas> This text should be wrapped at ~80 columns.
And the upstream URL should be added below.
>> new file mode 100644
>> index 0000000..57da8ef
>> --- /dev/null
>> +++ b/package/libapr/libapr.mk
>> @@ -0,0 +1,12 @@
>> +#############################################################
>> +#
>> +# libapr
>> +#
>> +#############################################################
>> +LIBAPR_VERSION = 1.4.6
>> +LIBAPR_SOURCE = apr-$(LIBAPR_VERSION).tar.gz
Thomas> Yegor's suggestion didn't work because by default we download
Thomas> <package-name>-<package-version>.tar.gz. However here you decided to
Thomas> name the Buildroot package "libapr", while the upstream package is
Thomas> "apr". Maybe we should use the "apr" name like upstream?
Agreed.
>> +LIBAPR_SITE = http://mirror.switch.ch/mirror/apache/dist/apr
I know the apr website directs you to a local mirror, but perhaps it
would make more sense to use archive.apache.org/dist/apr instead of this
.ch mirror?
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Buildroot] [PATCH] Add libapr-package
2012-04-17 12:01 ` Peter Korsgaard
@ 2012-04-17 12:22 ` Rico Bachmann
0 siblings, 0 replies; 23+ messages in thread
From: Rico Bachmann @ 2012-04-17 12:22 UTC (permalink / raw)
To: buildroot
Am 17.04.2012, 14:01 Uhr, schrieb Peter Korsgaard
<jacmet@uclibc.org>:
>>>>>> "Thomas" == Thomas Petazzoni
>>>>>> <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
>>>>>> writes:
>
> Hi,
>
> >> + bool "libapr"
> >> + help
> >> + The mission of the Apache Portable Runtime (APR) project is to
> create and maintain software libraries that provide a predictable and
> consistent interface to underlying platform-specific implementations
>
> Thomas> This text should be wrapped at ~80 columns.
>
> And the upstream URL should be added below.
>
> >> new file mode 100644
> >> index 0000000..57da8ef
> >> --- /dev/null
> >> +++ b/package/libapr/libapr.mk
> >> @@ -0,0 +1,12 @@
> >> +#############################################################
> >> +#
> >> +# libapr
> >> +#
> >> +#############################################################
> >> +LIBAPR_VERSION = 1.4.6
> >> +LIBAPR_SOURCE = apr-$(LIBAPR_VERSION).tar.gz
>
> Thomas> Yegor's suggestion didn't work because by default we download
> Thomas> <package-name>-<package-version>.tar.gz. However here you
> decided to
> Thomas> name the Buildroot package "libapr", while the upstream package
> is
> Thomas> "apr". Maybe we should use the "apr" name like upstream?
>
> Agreed.
I'll do that change with my next patch
>
> >> +LIBAPR_SITE = http://mirror.switch.ch/mirror/apache/dist/apr
>
> I know the apr website directs you to a local mirror, but perhaps it
> would make more sense to use archive.apache.org/dist/apr instead of this
> .ch mirror?
>
ah i didn't saw that i used a local mirror, i'll change that to.
--
Erstellt mit Operas revolution?rem E-Mail-Modul: http://www.opera.com/mail/
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Buildroot] [PATCH] Add libapr-package
2012-04-17 11:39 ` Thomas Petazzoni
2012-04-17 12:01 ` Peter Korsgaard
@ 2012-04-17 12:18 ` Rico Bachmann
1 sibling, 0 replies; 23+ messages in thread
From: Rico Bachmann @ 2012-04-17 12:18 UTC (permalink / raw)
To: buildroot
Am 17.04.2012, 13:39 Uhr, schrieb Thomas Petazzoni
<thomas.petazzoni@free-electrons.com>:
> Hello Rico,
>
> Thanks for this contribution!
>
> Le Tue, 17 Apr 2012 12:59:30 +0200,
> Rico Bachmann <bachmann@tofwerk.com> a ?crit :
>
>> +++ b/package/libapr/Config.in
>> @@ -0,0 +1,7 @@
>> +config BR2_PACKAGE_LIBAPR
>> +
>
> Remove this blank line.
the line will be gone with my next patch :)
>
>> + bool "libapr"
>> + help
>> + The mission of the Apache Portable Runtime (APR) project is to
>> create and maintain software libraries that provide a predictable and
>> consistent interface to underlying platform-specific implementations
>
> This text should be wrapped at ~80 columns.
>
>> new file mode 100644
>> index 0000000..57da8ef
>> --- /dev/null
>> +++ b/package/libapr/libapr.mk
>> @@ -0,0 +1,12 @@
>> +#############################################################
>> +#
>> +# libapr
>> +#
>> +#############################################################
>> +LIBAPR_VERSION = 1.4.6
>> +LIBAPR_SOURCE = apr-$(LIBAPR_VERSION).tar.gz
>
> Yegor's suggestion didn't work because by default we download
> <package-name>-<package-version>.tar.gz. However here you decided to
> name the Buildroot package "libapr", while the upstream package is
> "apr". Maybe we should use the "apr" name like upstream?
if it is the preferred way I can change the name of the package to arp
and delete the LIBAPR_SOURCE line, that's no problem
>
>> +LIBAPR_SITE = http://mirror.switch.ch/mirror/apache/dist/apr
>> +LIBAPR_INSTALL_STAGING = YES
>> +LIBAPR_CONF_OPT = ac_cv_file__dev_zero=yes ac_cv_func_setpgrp_void=yes
>> apr_cv_process_shared_works=yes apr_cv_mutex_robust_shared=no
>> apr_cv_tcp_nodelay_with_cork=yes ac_cv_sizeof_struct_iovec=8
>> apr_cv_mutex_recursive=yes --enable-shared
>
> Please wrap this this way:
>
> LIBAPR_CONF_OPT = \
> ac_cv_file__dev_zero=yes \
> ac_cv_func_setgrp_void=yes \
> ...
>
> And remove --enable-shared since it is already passed by default, and
> tuned when BR2_PREFER_STATIC is used.
>
> Regards,
>
> Thomas
--
Erstellt mit Operas revolution?rem E-Mail-Modul: http://www.opera.com/mail/
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Buildroot] [PATCH] Add libapr-package
@ 2012-04-17 10:05 Rico Bachmann
2012-04-17 10:20 ` Yegor Yefremov
2012-04-17 10:25 ` Yegor Yefremov
0 siblings, 2 replies; 23+ messages in thread
From: Rico Bachmann @ 2012-04-17 10:05 UTC (permalink / raw)
To: buildroot
Signed-off-by: Rico Bachmann <bachmann@tofwerk.com>
---
package/Config.in | 1 +
package/libapr/Config.in | 7 +++++++
package/libapr/libapr.mk | 13 +++++++++++++
3 files changed, 21 insertions(+), 0 deletions(-)
create mode 100644 package/libapr/Config.in
create mode 100644 package/libapr/libapr.mk
diff --git a/package/Config.in b/package/Config.in
index 4c6d4d8..ceb5f6d 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -376,6 +376,7 @@ source "package/fftw/Config.in"
source "package/libargtable2/Config.in"
source "package/argp-standalone/Config.in"
source "package/boost/Config.in"
+source "package/libapr/Config.in"
source "package/libatomic_ops/Config.in"
source "package/libcap/Config.in"
source "package/libcap-ng/Config.in"
diff --git a/package/libapr/Config.in b/package/libapr/Config.in
new file mode 100644
index 0000000..51dea91
--- /dev/null
+++ b/package/libapr/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_LIBAPR
+
+ bool "libapr"
+ help
+ The mission of the Apache Portable Runtime (APR) project is to create and maintain software libraries that provide a predictable and consistent interface to underlying platform-specific implementations
+
+ http://apr.apache.org/
diff --git a/package/libapr/libapr.mk b/package/libapr/libapr.mk
new file mode 100644
index 0000000..3bd5eec
--- /dev/null
+++ b/package/libapr/libapr.mk
@@ -0,0 +1,13 @@
+#############################################################
+#
+# libapr
+#
+#############################################################
+LIBAPR_VERSION = 1.4.6
+LIBAPR_SOURCE = apr-$(LIBAPR_VERSION).tar.gz
+LIBAPR_SITE = http://mirror.switch.ch/mirror/apache/dist/apr/
+LIBAPR_INSTALL_STAGING = YES
+LIBAPR_INSTALL_TARGET = YES
+LIBAPR_CONF_OPT = ac_cv_file__dev_zero=yes ac_cv_func_setpgrp_void=yes apr_cv_process_shared_works=yes apr_cv_mutex_robust_shared=no apr_cv_tcp_nodelay_with_cork=yes ac_cv_sizeof_struct_iovec=8 apr_cv_mutex_recursive=yes --enable-shared
+
+$(eval $(call AUTOTARGETS,package,LIBAPR))
--
1.7.2.5
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [Buildroot] [PATCH] Add libapr-package
2012-04-17 10:05 Rico Bachmann
@ 2012-04-17 10:20 ` Yegor Yefremov
2012-04-17 10:25 ` Yegor Yefremov
1 sibling, 0 replies; 23+ messages in thread
From: Yegor Yefremov @ 2012-04-17 10:20 UTC (permalink / raw)
To: buildroot
On Tue, Apr 17, 2012 at 12:05 PM, Rico Bachmann <bachmann@tofwerk.com> wrote:
> Signed-off-by: Rico Bachmann <bachmann@tofwerk.com>
> ---
> ?package/Config.in ? ? ? ?| ? ?1 +
> ?package/libapr/Config.in | ? ?7 +++++++
> ?package/libapr/libapr.mk | ? 13 +++++++++++++
> ?3 files changed, 21 insertions(+), 0 deletions(-)
> ?create mode 100644 package/libapr/Config.in
> ?create mode 100644 package/libapr/libapr.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 4c6d4d8..ceb5f6d 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -376,6 +376,7 @@ source "package/fftw/Config.in"
> ?source "package/libargtable2/Config.in"
> ?source "package/argp-standalone/Config.in"
> ?source "package/boost/Config.in"
> +source "package/libapr/Config.in"
> ?source "package/libatomic_ops/Config.in"
> ?source "package/libcap/Config.in"
> ?source "package/libcap-ng/Config.in"
> diff --git a/package/libapr/Config.in b/package/libapr/Config.in
> new file mode 100644
> index 0000000..51dea91
> --- /dev/null
> +++ b/package/libapr/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_LIBAPR
> +
> + ? ? ? bool "libapr"
> + ? ? ? help
> + ? ? ? ? The mission of the Apache Portable Runtime (APR) project is to create and maintain software libraries that provide a predictable and consistent interface to underlying platform-specific implementations
> +
> + ? ? ? ? http://apr.apache.org/
> diff --git a/package/libapr/libapr.mk b/package/libapr/libapr.mk
> new file mode 100644
> index 0000000..3bd5eec
> --- /dev/null
> +++ b/package/libapr/libapr.mk
> @@ -0,0 +1,13 @@
> +#############################################################
> +#
> +# libapr
> +#
> +#############################################################
> +LIBAPR_VERSION = 1.4.6
> +LIBAPR_SOURCE = apr-$(LIBAPR_VERSION).tar.gz
> +LIBAPR_SITE = http://mirror.switch.ch/mirror/apache/dist/apr/
> +LIBAPR_INSTALL_STAGING = YES
> +LIBAPR_INSTALL_TARGET = YES
> +LIBAPR_CONF_OPT = ac_cv_file__dev_zero=yes ac_cv_func_setpgrp_void=yes apr_cv_process_shared_works=yes apr_cv_mutex_robust_shared=no apr_cv_tcp_nodelay_with_cork=yes ac_cv_sizeof_struct_iovec=8 apr_cv_mutex_recursive=yes --enable-shared
> +
> +$(eval $(call AUTOTARGETS,package,LIBAPR))
Please replace
$(eval $(call AUTOTARGETS,package,LIBAPR))
with $(eval $(call AUTOTARGETS))
Yegor
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Buildroot] [PATCH] Add libapr-package
2012-04-17 10:05 Rico Bachmann
2012-04-17 10:20 ` Yegor Yefremov
@ 2012-04-17 10:25 ` Yegor Yefremov
2012-04-17 10:31 ` Rico Bachmann
1 sibling, 1 reply; 23+ messages in thread
From: Yegor Yefremov @ 2012-04-17 10:25 UTC (permalink / raw)
To: buildroot
Hi Rico,
see comments below.
On Tue, Apr 17, 2012 at 12:05 PM, Rico Bachmann <bachmann@tofwerk.com> wrote:
> Signed-off-by: Rico Bachmann <bachmann@tofwerk.com>
> ---
> ?package/Config.in ? ? ? ?| ? ?1 +
> ?package/libapr/Config.in | ? ?7 +++++++
> ?package/libapr/libapr.mk | ? 13 +++++++++++++
> ?3 files changed, 21 insertions(+), 0 deletions(-)
> ?create mode 100644 package/libapr/Config.in
> ?create mode 100644 package/libapr/libapr.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 4c6d4d8..ceb5f6d 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -376,6 +376,7 @@ source "package/fftw/Config.in"
> ?source "package/libargtable2/Config.in"
> ?source "package/argp-standalone/Config.in"
> ?source "package/boost/Config.in"
> +source "package/libapr/Config.in"
> ?source "package/libatomic_ops/Config.in"
> ?source "package/libcap/Config.in"
> ?source "package/libcap-ng/Config.in"
> diff --git a/package/libapr/Config.in b/package/libapr/Config.in
> new file mode 100644
> index 0000000..51dea91
> --- /dev/null
> +++ b/package/libapr/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_LIBAPR
> +
> + ? ? ? bool "libapr"
> + ? ? ? help
> + ? ? ? ? The mission of the Apache Portable Runtime (APR) project is to create and maintain software libraries that provide a predictable and consistent interface to underlying platform-specific implementations
> +
> + ? ? ? ? http://apr.apache.org/
> diff --git a/package/libapr/libapr.mk b/package/libapr/libapr.mk
> new file mode 100644
> index 0000000..3bd5eec
> --- /dev/null
> +++ b/package/libapr/libapr.mk
> @@ -0,0 +1,13 @@
> +#############################################################
> +#
> +# libapr
> +#
> +#############################################################
> +LIBAPR_VERSION = 1.4.6
> +LIBAPR_SOURCE = apr-$(LIBAPR_VERSION).tar.gz
remove apr-1.4.6-tar.gz from dl folder and try without LIBAPR_SOURCE macro
> +LIBAPR_SITE = http://mirror.switch.ch/mirror/apache/dist/apr/
> +LIBAPR_INSTALL_STAGING = YES
> +LIBAPR_INSTALL_TARGET = YES
remove LIBAPR_INSTALL_TARGET
> +LIBAPR_CONF_OPT = ac_cv_file__dev_zero=yes ac_cv_func_setpgrp_void=yes apr_cv_process_shared_works=yes apr_cv_mutex_robust_shared=no apr_cv_tcp_nodelay_with_cork=yes ac_cv_sizeof_struct_iovec=8 apr_cv_mutex_recursive=yes --enable-shared
> +
> +$(eval $(call AUTOTARGETS,package,LIBAPR))
> --
> 1.7.2.5
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Buildroot] [PATCH] Add libapr-package
2012-04-17 10:25 ` Yegor Yefremov
@ 2012-04-17 10:31 ` Rico Bachmann
0 siblings, 0 replies; 23+ messages in thread
From: Rico Bachmann @ 2012-04-17 10:31 UTC (permalink / raw)
To: buildroot
Thank for the fast response
I'll implement your changes, and try it without LIBAPR_SOURCE
> -----Urspr?ngliche Nachricht-----
> Von: Yegor Yefremov [mailto:yegorslists at googlemail.com]
> Gesendet: Dienstag, 17. April 2012 12:25
> An: Rico Bachmann
> Cc: buildroot at uclibc.org
> Betreff: [**SPAM**] Re: [Buildroot] [PATCH] Add libapr-package
>
> Hi Rico,
>
> see comments below.
>
> On Tue, Apr 17, 2012 at 12:05 PM, Rico Bachmann <bachmann@tofwerk.com>
> wrote:
> > Signed-off-by: Rico Bachmann <bachmann@tofwerk.com>
> > ---
> > package/Config.in | 1 +
> > package/libapr/Config.in | 7 +++++++
> > package/libapr/libapr.mk | 13 +++++++++++++
> > 3 files changed, 21 insertions(+), 0 deletions(-)
> > create mode 100644 package/libapr/Config.in
> > create mode 100644 package/libapr/libapr.mk
> >
> > diff --git a/package/Config.in b/package/Config.in index
> > 4c6d4d8..ceb5f6d 100644
> > --- a/package/Config.in
> > +++ b/package/Config.in
> > @@ -376,6 +376,7 @@ source "package/fftw/Config.in"
> > source "package/libargtable2/Config.in"
> > source "package/argp-standalone/Config.in"
> > source "package/boost/Config.in"
> > +source "package/libapr/Config.in"
> > source "package/libatomic_ops/Config.in"
> > source "package/libcap/Config.in"
> > source "package/libcap-ng/Config.in"
> > diff --git a/package/libapr/Config.in b/package/libapr/Config.in new
> > file mode 100644 index 0000000..51dea91
> > --- /dev/null
> > +++ b/package/libapr/Config.in
> > @@ -0,0 +1,7 @@
> > +config BR2_PACKAGE_LIBAPR
> > +
> > + bool "libapr"
> > + help
> > + The mission of the Apache Portable Runtime (APR) project is
> > + to create and maintain software libraries that provide a
> predictable
> > + and consistent interface to underlying platform-specific
> > + implementations
> > +
> > + http://apr.apache.org/
> > diff --git a/package/libapr/libapr.mk b/package/libapr/libapr.mk new
> > file mode 100644 index 0000000..3bd5eec
> > --- /dev/null
> > +++ b/package/libapr/libapr.mk
> > @@ -0,0 +1,13 @@
> > +#############################################################
> > +#
> > +# libapr
> > +#
> > +#############################################################
> > +LIBAPR_VERSION = 1.4.6
> > +LIBAPR_SOURCE = apr-$(LIBAPR_VERSION).tar.gz
>
> remove apr-1.4.6-tar.gz from dl folder and try without LIBAPR_SOURCE
> macro
>
> > +LIBAPR_SITE = http://mirror.switch.ch/mirror/apache/dist/apr/
> > +LIBAPR_INSTALL_STAGING = YES
> > +LIBAPR_INSTALL_TARGET = YES
>
> remove LIBAPR_INSTALL_TARGET
>
> > +LIBAPR_CONF_OPT = ac_cv_file__dev_zero=yes
> > +ac_cv_func_setpgrp_void=yes apr_cv_process_shared_works=yes
> > +apr_cv_mutex_robust_shared=no apr_cv_tcp_nodelay_with_cork=yes
> > +ac_cv_sizeof_struct_iovec=8 apr_cv_mutex_recursive=yes
> > +--enable-shared
> > +
> > +$(eval $(call AUTOTARGETS,package,LIBAPR))
> > --
> > 1.7.2.5
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot at busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 23+ messages in thread
end of thread, other threads:[~2012-04-27 19:21 UTC | newest]
Thread overview: 23+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-17 13:16 [Buildroot] [PATCH] Add libapr-package Rico Bachmann
2012-04-17 13:20 ` Baruch Siach
2012-04-17 13:26 ` Rico Bachmann
2012-04-17 13:29 ` Baruch Siach
2012-04-17 13:22 ` Yegor Yefremov
2012-04-17 13:29 ` Rico Bachmann
2012-04-17 13:25 ` Maxime Ripard
2012-04-17 13:35 ` Rico Bachmann
-- strict thread matches above, loose matches on Subject: below --
2012-04-17 14:35 Rico Bachmann
2012-04-21 12:58 ` Arnout Vandecappelle
2012-04-24 9:32 ` Rico Bachmann
2012-04-27 19:21 ` Arnout Vandecappelle
[not found] <Re:[PATCH] Add libapr-package>
2012-04-17 10:59 ` Rico Bachmann
2012-04-17 11:36 ` Maxime Ripard
2012-04-17 12:18 ` Rico Bachmann
2012-04-17 11:39 ` Thomas Petazzoni
2012-04-17 12:01 ` Peter Korsgaard
2012-04-17 12:22 ` Rico Bachmann
2012-04-17 12:18 ` Rico Bachmann
2012-04-17 10:05 Rico Bachmann
2012-04-17 10:20 ` Yegor Yefremov
2012-04-17 10:25 ` Yegor Yefremov
2012-04-17 10:31 ` Rico Bachmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.