[PATCH] sfdisk (out_partition_header): improve F_MEGABYTE header [WAS: [PATCH 5/8] sfdisk: fix silly mbyte typo]

[PATCH] sfdisk (out_partition_header): improve F_MEGABYTE header [WAS: [PATCH 5/8] sfdisk: fix silly mbyte typo]

[Bernhard Voelker]

Karel Zak wrote:

> On Mon, Apr 16, 2012 at 12:22:12PM +0200, Voelker, Bernhard wrote:
> > Maybe this is better?
> > 
> > -	printf(_("Units = mebibytes of 1048576 bytes, blocks of 1024 bytes"
> > +	printf(_("Units = 1MiB, blocks of 1024*1024 bytes"
> 
>  +1


>From d54cd212b7ac410669ed61e75717acdb67de2fa3 Mon Sep 17 00:00:00 2001
From: Bernhard Voelker <mail@bernhard-voelker.de>
Date: Tue, 17 Apr 2012 10:37:21 +0200
Subject: [PATCH] sfdisk (out_partition_header): improve F_MEGABYTE header

Signed-off-by: Bernhard Voelker <mail@bernhard-voelker.de>
---
 fdisk/sfdisk.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fdisk/sfdisk.c b/fdisk/sfdisk.c
index 95e5828..a2684fb 100644
--- a/fdisk/sfdisk.c
+++ b/fdisk/sfdisk.c
@@ -929,7 +929,7 @@ out_partition_header(char *dev, int format, struct geometry G) {
 	printf(_("   Device Boot   Start       End    #blocks   Id  System\n"));
 	break;
     case F_MEGABYTE:
-	printf(_("Units = mebibytes of 1048576 bytes, blocks of 1024 bytes"
+	printf(_("Units = 1MiB, blocks of 1024*1024 bytes"
 		 ", counting from %d\n\n"), increment);
 	printf(_("   Device Boot Start   End    MiB    #blocks   Id  System\n"));
 	break;
-- 
1.7.7

Re: [PATCH 5/8] sfdisk: fix silly mbyte typo

[Pádraig Brady]

On 04/17/2012 09:42 AM, Bernhard Voelker wrote:
> Karel Zak wrote:
> 
>> On Mon, Apr 16, 2012 at 12:22:12PM +0200, Voelker, Bernhard wrote:
>>> Maybe this is better?
>>>
>>> -	printf(_("Units = mebibytes of 1048576 bytes, blocks of 1024 bytes"
>>> +	printf(_("Units = 1MiB, blocks of 1024*1024 bytes"

Blocks are 1024 bytes in this mode, as confirmed with:
sfdisk -uM -l /dev/sda

cheers,
Pádraig.

Re: [PATCH 5/8] sfdisk: fix silly mbyte typo

[Bernhard Voelker]

On 04/17/2012 03:56 PM, Pádraig Brady wrote:
> On 04/17/2012 09:42 AM, Bernhard Voelker wrote:
>> Karel Zak wrote:
>>
>>> On Mon, Apr 16, 2012 at 12:22:12PM +0200, Voelker, Bernhard wrote:
>>>> Maybe this is better?
>>>>
>>>> -	printf(_("Units = mebibytes of 1048576 bytes, blocks of 1024 bytes"
>>>> +	printf(_("Units = 1MiB, blocks of 1024*1024 bytes"
> 
> Blocks are 1024 bytes in this mode, as confirmed with:
> sfdisk -uM -l /dev/sda

I don't understand. What's wrong?

$ wc -c </dev/sda1
12582912000

$ echo '12582912000 / (1024*1024)' | bc
12000

$ ./sfdisk -uM -l /dev/sda | egrep 'sda1|MiB'
Units = 1MiB, blocks of 1024*1024 bytes, counting from 0
   Device Boot Start   End    MiB    #blocks   Id  System
/dev/sda1   *     1  12000  12000   12288000   83  Linux

Have a nice day,
Berny

Re: [PATCH 5/8] sfdisk: fix silly mbyte typo

[Pádraig Brady]

On 04/17/2012 03:14 PM, Bernhard Voelker wrote:
> On 04/17/2012 03:56 PM, Pádraig Brady wrote:
>> On 04/17/2012 09:42 AM, Bernhard Voelker wrote:
>>> Karel Zak wrote:
>>>
>>>> On Mon, Apr 16, 2012 at 12:22:12PM +0200, Voelker, Bernhard wrote:
>>>>> Maybe this is better?
>>>>>
>>>>> -	printf(_("Units = mebibytes of 1048576 bytes, blocks of 1024 bytes"
>>>>> +	printf(_("Units = 1MiB, blocks of 1024*1024 bytes"
>>
>> Blocks are 1024 bytes in this mode, as confirmed with:
>> sfdisk -uM -l /dev/sda
> 
> I don't understand. What's wrong?
> 
> $ wc -c </dev/sda1
> 12582912000
> 
> $ echo '12582912000 / (1024*1024)' | bc
> 12000
> 
> $ ./sfdisk -uM -l /dev/sda | egrep 'sda1|MiB'
> Units = 1MiB, blocks of 1024*1024 bytes, counting from 0
>    Device Boot Start   End    MiB    #blocks   Id  System
> /dev/sda1   *     1  12000  12000   12288000   83  Linux

Well I thought the "blocks of" was referring to the blocks column,
rather than the units?

$ echo $((12582912000 / 1024))
12288000

cheers,
Pádraig.

Re: [PATCH 5/8] sfdisk: fix silly mbyte typo

[Karel Zak]

On Tue, Apr 17, 2012 at 03:32:15PM +0100, Pádraig Brady wrote:
> On 04/17/2012 03:14 PM, Bernhard Voelker wrote:
> > On 04/17/2012 03:56 PM, Pádraig Brady wrote:
> >> On 04/17/2012 09:42 AM, Bernhard Voelker wrote:
> >>> Karel Zak wrote:
> >>>
> >>>> On Mon, Apr 16, 2012 at 12:22:12PM +0200, Voelker, Bernhard wrote:
> >>>>> Maybe this is better?
> >>>>>
> >>>>> -	printf(_("Units = mebibytes of 1048576 bytes, blocks of 1024 bytes"
> >>>>> +	printf(_("Units = 1MiB, blocks of 1024*1024 bytes"
> >>
> >> Blocks are 1024 bytes in this mode, as confirmed with:
> >> sfdisk -uM -l /dev/sda
> > 
> > I don't understand. What's wrong?
> > 
> > $ wc -c </dev/sda1
> > 12582912000
> > 
> > $ echo '12582912000 / (1024*1024)' | bc
> > 12000
> > 
> > $ ./sfdisk -uM -l /dev/sda | egrep 'sda1|MiB'
> > Units = 1MiB, blocks of 1024*1024 bytes, counting from 0
> >    Device Boot Start   End    MiB    #blocks   Id  System
> > /dev/sda1   *     1  12000  12000   12288000   83  Linux
> 
> Well I thought the "blocks of" was referring to the blocks column,
> rather than the units?
> 
> $ echo $((12582912000 / 1024))
> 12288000

 yep, my +1 was about s/mebibytes/MiB/, I have overlooked the
 1024*1024 math in the patch. Pádraig is right, (s)fdisk uses 1024
 byte blocks in output (probably too keep things more confusing ;-)

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

Re: [PATCH 5/8] sfdisk: fix silly mbyte typo

[Bernhard Voelker]

On 04/17/2012 04:48 PM, Karel Zak wrote:
>  yep, my +1 was about s/mebibytes/MiB/, I have overlooked the
>  1024*1024 math in the patch. Pádraig is right, (s)fdisk uses 1024
>  byte blocks in output 

so KiB would be right?

>  (probably too keep things more confusing ;-)

mission accomplished ...

Bye,
Berny

Re: [PATCH 5/8] sfdisk: fix silly mbyte typo

[Bernhard Voelker]

On 04/17/2012 04:59 PM, Bernhard Voelker wrote:
> 
> 
> On 04/17/2012 04:48 PM, Karel Zak wrote:
>>  yep, my +1 was about s/mebibytes/MiB/, I have overlooked the
>>  1024*1024 math in the patch. Pádraig is right, (s)fdisk uses 1024
>>  byte blocks in output 
> 
> so KiB would be right?
> 
>>  (probably too keep things more confusing ;-)
> 
> mission accomplished ...
> 
> Bye,
> Berny
> 

ah, that part refers to the "#blocks" column!

The problem starts with the "=" after "Units". A colon would
maybe be more appropriate: then we could use the equal sign
like in the following.

What do you think?

Have a nice day,
Berny


>From 1c59d9ca4d18d795de354003d0059dc593c6a99b Mon Sep 17 00:00:00 2001
From: Bernhard Voelker <mail@bernhard-voelker.de>
Date: Wed, 18 Apr 2012 08:47:29 +0200
Subject: [PATCH] sfdisk (out_partition_header): improve F_MEGABYTE header

Signed-off-by: Bernhard Voelker <mail@bernhard-voelker.de>
---
 fdisk/sfdisk.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/fdisk/sfdisk.c b/fdisk/sfdisk.c
index 95e5828..c14d127 100644
--- a/fdisk/sfdisk.c
+++ b/fdisk/sfdisk.c
@@ -912,24 +912,24 @@ out_partition_header(char *dev, int format, struct geometry G) {
 		G.cylindersize ? _("cylinders") : _("sectors"));
     case F_CYLINDER:
 	if (G.cylindersize) {
-	    printf(_("Units = cylinders of %lu bytes, blocks of 1024 bytes"
+	    printf(_("Units: cylinders of %lu bytes, blocks of 1024 bytes"
 		     ", counting from %d\n\n"), G.cylindersize << 9, increment);
 	    printf(_("   Device Boot Start     End   #cyls    #blocks   Id  System\n"));
 	    break;
 	}
 	/* fall through */
     case F_SECTOR:
-	printf(_("Units = sectors of 512 bytes, counting from %d\n\n"),
+	printf(_("Units: sectors of 512 bytes, counting from %d\n\n"),
 	       increment);
 	printf(_("   Device Boot    Start       End   #sectors  Id  System\n"));
 	break;
     case F_BLOCK:
-	printf(_("Units = blocks of 1024 bytes, counting from %d\n\n"),
+	printf(_("Units: blocks of 1024 bytes, counting from %d\n\n"),
 	       increment);
 	printf(_("   Device Boot   Start       End    #blocks   Id  System\n"));
 	break;
     case F_MEGABYTE:
-	printf(_("Units = mebibytes of 1048576 bytes, blocks of 1024 bytes"
+	printf(_("Units: 1MiB = 1024*1024 bytes, blocks of 1024 bytes"
 		 ", counting from %d\n\n"), increment);
 	printf(_("   Device Boot Start   End    MiB    #blocks   Id  System\n"));
 	break;
-- 
1.7.7

Re: [PATCH 5/8] sfdisk: fix silly mbyte typo

[Pádraig Brady]

On 04/18/2012 07:50 AM, Bernhard Voelker wrote:
> 
> 
> On 04/17/2012 04:59 PM, Bernhard Voelker wrote:
>>
>>
>> On 04/17/2012 04:48 PM, Karel Zak wrote:
>>>  yep, my +1 was about s/mebibytes/MiB/, I have overlooked the
>>>  1024*1024 math in the patch. Pádraig is right, (s)fdisk uses 1024
>>>  byte blocks in output 
>>
>> so KiB would be right?
>>
>>>  (probably too keep things more confusing ;-)
>>
>> mission accomplished ...
>>
>> Bye,
>> Berny
>>
> 
> ah, that part refers to the "#blocks" column!
> 
> The problem starts with the "=" after "Units". A colon would
> maybe be more appropriate: then we could use the equal sign
> like in the following.
> 
> What do you think?
> 
> Have a nice day,
> Berny
> 
> 
>>From 1c59d9ca4d18d795de354003d0059dc593c6a99b Mon Sep 17 00:00:00 2001
> From: Bernhard Voelker <mail@bernhard-voelker.de>
> Date: Wed, 18 Apr 2012 08:47:29 +0200
> Subject: [PATCH] sfdisk (out_partition_header): improve F_MEGABYTE header
> 
> Signed-off-by: Bernhard Voelker <mail@bernhard-voelker.de>
> ---
>  fdisk/sfdisk.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/fdisk/sfdisk.c b/fdisk/sfdisk.c
> index 95e5828..c14d127 100644
> --- a/fdisk/sfdisk.c
> +++ b/fdisk/sfdisk.c
> @@ -912,24 +912,24 @@ out_partition_header(char *dev, int format, struct geometry G) {
>  		G.cylindersize ? _("cylinders") : _("sectors"));
>      case F_CYLINDER:
>  	if (G.cylindersize) {
> -	    printf(_("Units = cylinders of %lu bytes, blocks of 1024 bytes"
> +	    printf(_("Units: cylinders of %lu bytes, blocks of 1024 bytes"
>  		     ", counting from %d\n\n"), G.cylindersize << 9, increment);
>  	    printf(_("   Device Boot Start     End   #cyls    #blocks   Id  System\n"));
>  	    break;
>  	}
>  	/* fall through */
>      case F_SECTOR:
> -	printf(_("Units = sectors of 512 bytes, counting from %d\n\n"),
> +	printf(_("Units: sectors of 512 bytes, counting from %d\n\n"),
>  	       increment);
>  	printf(_("   Device Boot    Start       End   #sectors  Id  System\n"));
>  	break;
>      case F_BLOCK:
> -	printf(_("Units = blocks of 1024 bytes, counting from %d\n\n"),
> +	printf(_("Units: blocks of 1024 bytes, counting from %d\n\n"),
>  	       increment);
>  	printf(_("   Device Boot   Start       End    #blocks   Id  System\n"));
>  	break;
>      case F_MEGABYTE:
> -	printf(_("Units = mebibytes of 1048576 bytes, blocks of 1024 bytes"
> +	printf(_("Units: 1MiB = 1024*1024 bytes, blocks of 1024 bytes"
>  		 ", counting from %d\n\n"), increment);
>  	printf(_("   Device Boot Start   End    MiB    #blocks   Id  System\n"));
>  	break;

+1

Re: [PATCH 5/8] sfdisk: fix silly mbyte typo

[Karel Zak]

On Wed, Apr 18, 2012 at 08:50:17AM +0200, Bernhard Voelker wrote:
>  fdisk/sfdisk.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)

 Applied, thanks.

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

[PATCH 5/8] sfdisk: fix silly mbyte typo

[Davidlohr Bueso]

From: Davidlohr Bueso <dave@gnu.org>

Signed-off-by: Davidlohr Bueso <dave@gnu.org>

---
 fdisk/sfdisk.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fdisk/sfdisk.c b/fdisk/sfdisk.c
index 8bd27da..f81a7fa 100644
--- a/fdisk/sfdisk.c
+++ b/fdisk/sfdisk.c
@@ -930,7 +930,7 @@ out_partition_header(char *dev, int format, struct geometry G) {
 	printf(_("   Device Boot   Start       End    #blocks   Id  System\n"));
 	break;
     case F_MEGABYTE:
-	printf(_("Units = mebibytes of 1048576 bytes, blocks of 1024 bytes"
+	printf(_("Units = megabytes of 1048576 bytes, blocks of 1024 bytes"
 		 ", counting from %d\n\n"), increment);
 	printf(_("   Device Boot Start   End    MiB    #blocks   Id  System\n"));
 	break;
-- 
1.7.4.1

RE: [PATCH 5/8] sfdisk: fix silly mbyte typo

[Voelker, Bernhard]

Davidlohr Bueso wrote:

> Subject: [PATCH 5/8] sfdisk: fix silly mbyte typo
>=20
> From: Davidlohr Bueso <dave@gnu.org>
>=20
> Signed-off-by: Davidlohr Bueso <dave@gnu.org>
>=20
> ---
>  fdisk/sfdisk.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>=20
> diff --git a/fdisk/sfdisk.c b/fdisk/sfdisk.c
> index 8bd27da..f81a7fa 100644
> --- a/fdisk/sfdisk.c
> +++ b/fdisk/sfdisk.c
> @@ -930,7 +930,7 @@ out_partition_header(char *dev, int format, struct ge=
ometry G) {
>  	printf(_("   Device Boot   Start       End    #blocks   Id  System\n"))=
;
>  	break;
>      case F_MEGABYTE:
> -	printf(_("Units =3D mebibytes of 1048576 bytes, blocks of 1024 bytes"
> +	printf(_("Units =3D megabytes of 1048576 bytes, blocks of 1024 bytes"
>  		 ", counting from %d\n\n"), increment);
>  	printf(_("   Device Boot Start   End    MiB    #blocks   Id  System\n")=
);
>  	break;
> --=20
> 1.7.4.1

not silly:
http://en.wikipedia.org/wiki/Mebibyte

Have a nice day,
Berny

RE: [PATCH 5/8] sfdisk: fix silly mbyte typo

[Davidlohr Bueso]

On Mon, 2012-04-16 at 11:53 +0200, Voelker, Bernhard wrote:
> Davidlohr Bueso wrote:
> 
> > Subject: [PATCH 5/8] sfdisk: fix silly mbyte typo
> > 
> > From: Davidlohr Bueso <dave@gnu.org>
> > 
> > Signed-off-by: Davidlohr Bueso <dave@gnu.org>
> > 
> > ---
> >  fdisk/sfdisk.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/fdisk/sfdisk.c b/fdisk/sfdisk.c
> > index 8bd27da..f81a7fa 100644
> > --- a/fdisk/sfdisk.c
> > +++ b/fdisk/sfdisk.c
> > @@ -930,7 +930,7 @@ out_partition_header(char *dev, int format, struct geometry G) {
> >  	printf(_("   Device Boot   Start       End    #blocks   Id  System\n"));
> >  	break;
> >      case F_MEGABYTE:
> > -	printf(_("Units = mebibytes of 1048576 bytes, blocks of 1024 bytes"
> > +	printf(_("Units = megabytes of 1048576 bytes, blocks of 1024 bytes"
> >  		 ", counting from %d\n\n"), increment);
> >  	printf(_("   Device Boot Start   End    MiB    #blocks   Id  System\n"));
> >  	break;
> > -- 
> > 1.7.4.1
> 
> not silly:
> http://en.wikipedia.org/wiki/Mebibyte

hehe, silly me then.

> 
> Have a nice day,
> Berny
> 

RE: [PATCH 5/8] sfdisk: fix silly mbyte typo

[Voelker, Bernhard]

Davidlohr Bueso wrote:

On Mon, 2012-04-16 at 11:53 +0200, Voelker, Bernhard wrote:
> Davidlohr Bueso wrote:
> > -	printf(_("Units = mebibytes of 1048576 bytes, blocks of 1024 bytes"
> > +	printf(_("Units = megabytes of 1048576 bytes, blocks of 1024 bytes"
...
> > 
> > not silly:
> > http://en.wikipedia.org/wiki/Mebibyte
> 
> hehe, silly me then.

no worries ;-)

Maybe this is better?

-	printf(_("Units = mebibytes of 1048576 bytes, blocks of 1024 bytes"
+	printf(_("Units = 1MiB, blocks of 1024*1024 bytes"

Berny

Re: [PATCH 5/8] sfdisk: fix silly mbyte typo

[Karel Zak]

On Mon, Apr 16, 2012 at 12:22:12PM +0200, Voelker, Bernhard wrote:
> Maybe this is better?
> 
> -	printf(_("Units = mebibytes of 1048576 bytes, blocks of 1024 bytes"
> +	printf(_("Units = 1MiB, blocks of 1024*1024 bytes"

 +1


-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com