From: Shubhrajyoti <shubhrajyoti@ti.com>
To: Kevin Hilman <khilman@ti.com>
Cc: linux-serial@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org,
"Govindraj.R" <govindraj.raja@ti.com>
Subject: Re: [PATCH 2/7] UART: OMAP: Cut the clock in the error cases
Date: Wed, 18 Apr 2012 20:43:40 +0530 [thread overview]
Message-ID: <4F8EDA24.5020209@ti.com> (raw)
In-Reply-To: <87bompp2bk.fsf@ti.com>
On Wednesday 18 April 2012 07:30 PM, Kevin Hilman wrote:
>>>> >>> if (ret < 0) {
>>>> >>> serial_omap_enable_ier_thri(up);
>>>> >>> + pm_runtime_mark_last_busy(&up->pdev->dev);
>>>> >>> + pm_runtime_put_autosuspend(&up->pdev->dev);
>>> >> Why the autosuspend version here?
>>> >>
>>> >> Kevin
>>> >>
>>> >>
>> > In case the request_dma fails we enable the thri( effectively like intr
>> > mode) so
>> > I thought of using the autosuspend version here .
>> >
>> > Do you prefer put version instead ?
> Not necessarily, it should just be well described in the changelog.
>
> Kevin
Yes agree completely. Will describe that in the changelog.
WARNING: multiple messages have this Message-ID (diff)
From: shubhrajyoti@ti.com (Shubhrajyoti)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/7] UART: OMAP: Cut the clock in the error cases
Date: Wed, 18 Apr 2012 20:43:40 +0530 [thread overview]
Message-ID: <4F8EDA24.5020209@ti.com> (raw)
In-Reply-To: <87bompp2bk.fsf@ti.com>
On Wednesday 18 April 2012 07:30 PM, Kevin Hilman wrote:
>>>> >>> if (ret < 0) {
>>>> >>> serial_omap_enable_ier_thri(up);
>>>> >>> + pm_runtime_mark_last_busy(&up->pdev->dev);
>>>> >>> + pm_runtime_put_autosuspend(&up->pdev->dev);
>>> >> Why the autosuspend version here?
>>> >>
>>> >> Kevin
>>> >>
>>> >>
>> > In case the request_dma fails we enable the thri( effectively like intr
>> > mode) so
>> > I thought of using the autosuspend version here .
>> >
>> > Do you prefer put version instead ?
> Not necessarily, it should just be well described in the changelog.
>
> Kevin
Yes agree completely. Will describe that in the changelog.
next prev parent reply other threads:[~2012-04-18 15:13 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 15:06 [PATCH 0/7] UART: OMAP: Updates Shubhrajyoti D
2012-04-16 15:06 ` Shubhrajyoti D
2012-04-16 15:06 ` [PATCH 1/7] ARM: OMAP: UART: Make context_loss_cnt signed Shubhrajyoti D
2012-04-16 15:06 ` Shubhrajyoti D
2012-04-16 15:06 ` [PATCH 2/7] UART: OMAP: Cut the clock in the error cases Shubhrajyoti D
2012-04-16 15:06 ` Shubhrajyoti D
2012-04-18 0:06 ` Kevin Hilman
2012-04-18 0:06 ` Kevin Hilman
2012-04-18 6:44 ` Shubhrajyoti
2012-04-18 6:44 ` Shubhrajyoti
2012-04-18 14:00 ` Kevin Hilman
2012-04-18 14:00 ` Kevin Hilman
2012-04-18 15:13 ` Shubhrajyoti [this message]
2012-04-18 15:13 ` Shubhrajyoti
2012-04-20 13:20 ` Shubhrajyoti Datta
2012-04-20 13:20 ` Shubhrajyoti Datta
2012-04-20 13:46 ` Kevin Hilman
2012-04-20 13:46 ` Kevin Hilman
2012-04-16 15:06 ` [PATCH 3/7] UART: OMAP: fix software flow control Shubhrajyoti D
2012-04-16 15:06 ` Shubhrajyoti D
2012-04-16 15:06 ` [PATCH 4/7] UART: OMAP: Remove the default setting of special character Shubhrajyoti D
2012-04-16 15:06 ` Shubhrajyoti D
2012-04-16 15:06 ` [PATCH 5/7] UART: OMAP: Prevent cutting of clocks if put_sync immediately follows Shubhrajyoti D
2012-04-16 15:06 ` Shubhrajyoti D
2012-04-16 15:07 ` [PATCH 6/7] UART: OMAP: Remove the hardcode serial_omap_console_ports array Shubhrajyoti D
2012-04-16 15:07 ` Shubhrajyoti D
2012-04-16 15:07 ` [PATCH 7/7] UART: OMAP: Trivial optimisation of the probe and remove Shubhrajyoti D
2012-04-16 15:07 ` Shubhrajyoti D
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8EDA24.5020209@ti.com \
--to=shubhrajyoti@ti.com \
--cc=govindraj.raja@ti.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.