* [PATCH 3.4.0-rc3] sh:pfc: include sh_pfc.h header file.
@ 2012-04-19 10:06 Srinivas KANDAGATLA
2012-04-19 10:23 ` Srinivas KANDAGATLA
0 siblings, 1 reply; 2+ messages in thread
From: Srinivas KANDAGATLA @ 2012-04-19 10:06 UTC (permalink / raw)
To: linux-sh
This patch includes sh_pfc.h in pfc.c file, without this include kernel
build with CONFIG_GENERIC_GPIO will throw below errors.
drivers/sh/pfc.c:25:32: warning: ‘struct pinmux_info’ declared inside
parameter list [enabled by default]
drivers/sh/pfc.c:25:32: warning: its scope is only this definition or
declaration, which is probably not what you want [enabled by default]
drivers/sh/pfc.c: In function ‘pfc_iounmap’:
drivers/sh/pfc.c:29:21: error: dereferencing pointer to incomplete type
drivers/sh/pfc.c:30:10:error: dereferencing pointer to incomplete type
drivers/sh/pfc.c:31:15:error: dereferencing pointer to incomplete type
drivers/sh/pfc.c:33:11: error: dereferencing pointer to incomplete type
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
---
Hi All,
This patch fixes a compilation error in the sh kernel build if CONFIG_GENERIC_GPIO is enabled.
--srini
drivers/sh/pfc.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/sh/pfc.c b/drivers/sh/pfc.c
index 522c6c4..505d7cf 100644
--- a/drivers/sh/pfc.c
+++ b/drivers/sh/pfc.c
@@ -21,6 +21,7 @@
#include <linux/gpio.h>
#include <linux/slab.h>
#include <linux/ioport.h>
+#include <linux/sh_pfc.h>
static void pfc_iounmap(struct pinmux_info *pip)
{
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 3.4.0-rc3] sh:pfc: include sh_pfc.h header file.
2012-04-19 10:06 [PATCH 3.4.0-rc3] sh:pfc: include sh_pfc.h header file Srinivas KANDAGATLA
@ 2012-04-19 10:23 ` Srinivas KANDAGATLA
0 siblings, 0 replies; 2+ messages in thread
From: Srinivas KANDAGATLA @ 2012-04-19 10:23 UTC (permalink / raw)
To: linux-sh
Hi All,
Pl. ignore this patch, I think I found the root-cause.
Sorry for the BUzz.
--srini
On 19/04/12 11:06, Srinivas KANDAGATLA wrote:
> This patch includes sh_pfc.h in pfc.c file, without this include kernel
> build with CONFIG_GENERIC_GPIO will throw below errors.
>
> drivers/sh/pfc.c:25:32: warning: ‘struct pinmux_info’ declared inside
> parameter list [enabled by default]
> drivers/sh/pfc.c:25:32: warning: its scope is only this definition or
> declaration, which is probably not what you want [enabled by default]
> drivers/sh/pfc.c: In function ‘pfc_iounmap’:
> drivers/sh/pfc.c:29:21: error: dereferencing pointer to incomplete type
> drivers/sh/pfc.c:30:10:error: dereferencing pointer to incomplete type
> drivers/sh/pfc.c:31:15:error: dereferencing pointer to incomplete type
> drivers/sh/pfc.c:33:11: error: dereferencing pointer to incomplete type
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
> ---
> Hi All,
> This patch fixes a compilation error in the sh kernel build if CONFIG_GENERIC_GPIO is enabled.
>
> --srini
>
> drivers/sh/pfc.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/sh/pfc.c b/drivers/sh/pfc.c
> index 522c6c4..505d7cf 100644
> --- a/drivers/sh/pfc.c
> +++ b/drivers/sh/pfc.c
> @@ -21,6 +21,7 @@
> #include <linux/gpio.h>
> #include <linux/slab.h>
> #include <linux/ioport.h>
> +#include <linux/sh_pfc.h>
>
> static void pfc_iounmap(struct pinmux_info *pip)
> {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-19 10:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-19 10:06 [PATCH 3.4.0-rc3] sh:pfc: include sh_pfc.h header file Srinivas KANDAGATLA
2012-04-19 10:23 ` Srinivas KANDAGATLA
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.