* [patch] USB: bcma: suspend() only takes one argument now
@ 2012-04-19 10:46 Dan Carpenter
2012-04-19 21:03 ` Hauke Mehrtens
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2012-04-19 10:46 UTC (permalink / raw)
To: kernel-janitors
We changed the API here a couple months ago. It suspend() only takes
one argument now. GCC complains about this:
drivers/usb/host/bcma-hcd.c:320:2: warning: initialization from
incompatible pointer type [enabled by default]
drivers/usb/host/bcma-hcd.c:320:2: warning: (near initialization
for ‘bcma_hcd_driver.suspend’) [enabled by default]
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/usb/host/bcma-hcd.c b/drivers/usb/host/bcma-hcd.c
index afec047..0b35d42 100644
--- a/drivers/usb/host/bcma-hcd.c
+++ b/drivers/usb/host/bcma-hcd.c
@@ -286,7 +286,7 @@ static void bcma_hcd_shutdown(struct bcma_device *dev)
#ifdef CONFIG_PM
-static int bcma_hcd_suspend(struct bcma_device *dev, pm_message_t state)
+static int bcma_hcd_suspend(struct bcma_device *dev)
{
bcma_core_disable(dev, 0);
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [patch] USB: bcma: suspend() only takes one argument now
2012-04-19 10:46 [patch] USB: bcma: suspend() only takes one argument now Dan Carpenter
@ 2012-04-19 21:03 ` Hauke Mehrtens
0 siblings, 0 replies; 2+ messages in thread
From: Hauke Mehrtens @ 2012-04-19 21:03 UTC (permalink / raw)
To: kernel-janitors
On 04/19/2012 12:46 PM, Dan Carpenter wrote:
> We changed the API here a couple months ago. It suspend() only takes
> one argument now. GCC complains about this:
>
> drivers/usb/host/bcma-hcd.c:320:2: warning: initialization from
> incompatible pointer type [enabled by default]
> drivers/usb/host/bcma-hcd.c:320:2: warning: (near initialization
> for ‘bcma_hcd_driver.suspend’) [enabled by default]
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Hauke Mehrtens <hauke@hauke-m.de>
Thanks for the patch.
Hauke
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-19 21:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-19 10:46 [patch] USB: bcma: suspend() only takes one argument now Dan Carpenter
2012-04-19 21:03 ` Hauke Mehrtens
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.