[RESEND PATCH V2] ACPI, APEI: Add validation check before GHES error is recorded

[RESEND PATCH V2] ACPI, APEI: Add validation check before GHES error is recorded

[Chen Gong]

When GHES error record is logged into mcelog kernel buffer,
a validation check for physical address is necessary, which prevents
invalid physical address is happened in error record.

v2->v1:
  Only report error to mcelog kernel buffer when physical address is valid.

Signed-off-by: Chen Gong <gong.chen@linux.intel.com>
Acked-by: Tony Luck <tony.luck@intel.com>
---
 arch/x86/kernel/cpu/mcheck/mce-apei.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/x86/kernel/cpu/mcheck/mce-apei.c b/arch/x86/kernel/cpu/mcheck/mce-apei.c
index 507ea58..cd8b166 100644
--- a/arch/x86/kernel/cpu/mcheck/mce-apei.c
+++ b/arch/x86/kernel/cpu/mcheck/mce-apei.c
@@ -42,7 +42,8 @@ void apei_mce_report_mem_error(int corrected, struct cper_sec_mem_err *mem_err)
 	struct mce m;
 
 	/* Only corrected MC is reported */
-	if (!corrected)
+	if (!corrected || !(mem_err->validation_bits &
+				CPER_MEM_VALID_PHYSICAL_ADDRESS))
 		return;
 
 	mce_setup(&m);
-- 
1.7.10.rc2.27.g59012

RE: [RESEND PATCH V2] ACPI, APEI: Add validation check before GHES error is recorded

[Luck, Tony]

arch/x86/kernel/cpu/mcheck/mce-apei.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

This patch seems to be in cross-over territory between ACPI and MCE

... I just applied it to the RAS tree.

-Tony

Re: [RESEND PATCH V2] ACPI, APEI: Add validation check before GHES error is recorded

[Chen Gong]

于 2012/4/21 7:13, Luck, Tony 写道:
> arch/x86/kernel/cpu/mcheck/mce-apei.c |    3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> This patch seems to be in cross-over territory between ACPI and MCE
>
> ... I just applied it to the RAS tree.
>
> -Tony
>
OK, thx a lot, Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html