From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH,HURD] Fix grub-probe with userland partition support
Date: Tue, 24 Apr 2012 10:55:21 +0200 [thread overview]
Message-ID: <4F966A79.8050700@gmail.com> (raw)
In-Reply-To: <20120423233423.GC4755@type.famille.thibault.fr>
[-- Attachment #1: Type: text/plain, Size: 417 bytes --]
On 24.04.2012 01:34, Samuel Thibault wrote:
> + if (errno == ENOENT && part >= 5)
> + {
This introduces an assumption that if part >=5 is missing then there are
no additional partitions. While this is true for msdos, it's false for
GPT, where such config is common after deleting a partition. Moreover,
APM (apple) partitions often start at 8.
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
next prev parent reply other threads:[~2012-04-24 8:56 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-22 18:24 [PATCH,HURD] Fix grub-probe with userland partition support Samuel Thibault
2012-04-23 8:52 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-04-23 9:40 ` Samuel Thibault
2012-04-23 10:45 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-04-23 11:06 ` Samuel Thibault
2012-04-23 11:17 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-04-23 21:26 ` Samuel Thibault
2012-04-23 23:34 ` Samuel Thibault
2012-04-24 8:55 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2012-04-24 9:00 ` Samuel Thibault
2012-04-24 9:12 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-04-24 9:16 ` Samuel Thibault
2012-04-24 9:26 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-04-24 9:36 ` Samuel Thibault
2012-04-24 9:38 ` Samuel Thibault
2012-04-24 9:44 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-04-24 9:49 ` Samuel Thibault
2012-04-24 9:04 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-04-24 9:19 ` Samuel Thibault
2012-04-24 9:55 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-04-24 12:42 ` Samuel Thibault
2012-04-24 13:19 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-04-24 17:13 ` Samuel Thibault
2012-04-24 20:14 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-04-24 22:21 ` Samuel Thibault
2012-04-24 22:31 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-04-24 22:39 ` Samuel Thibault
2012-04-24 22:46 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-04-24 23:52 ` Samuel Thibault
2012-04-24 23:57 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-04-25 0:27 ` Samuel Thibault
2012-04-25 8:36 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-04-25 9:37 ` Samuel Thibault
2012-04-27 18:45 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-04-30 18:58 ` Samuel Thibault
2012-05-01 13:12 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-05-03 21:42 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-04-23 9:07 ` Vladimir 'φ-coder/phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F966A79.8050700@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.