Re: [PATCH,HURD] Fix grub-probe with userland partition support - Vladimir 'φ-coder/phcoder' Serbinenko

From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH,HURD] Fix grub-probe with userland partition support
Date: Wed, 25 Apr 2012 10:36:59 +0200	[thread overview]
Message-ID: <4F97B7AB.90400@gmail.com> (raw)
In-Reply-To: <20120425002736.GB29782@type.famille.thibault.fr>

[-- Attachment #1: Type: text/plain, Size: 806 bytes --]

On 25.04.2012 02:27, Samuel Thibault wrote:
> Vladimir 'φ-coder/phcoder' Serbinenko, le Wed 25 Apr 2012 01:57:54 +0200, a écrit :
>> On 25.04.2012 01:52, Samuel Thibault wrote:
>>> +    grub_util_error (_("Could not open path `%s'"), path);
>> This one should be unified with other similar messages.
> Err, in the file I can see various ways: "Unable to", "cannot", "failed
> to", "couldn't", "can't".  Which one should be used.
Where? For open we always use:
msgid "cannot open `%s': %s"

>
>> It would also have advantage of giving strerror.
> Oops, indeed.
>
> Samuel
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]