* [PATCH v2 01/22] m68knommu: introduce macros to simplify ColdFire GPIO table initialization
@ 2012-04-26 13:14 gerg
2012-04-26 13:29 ` Ezequiel García
2012-04-26 14:39 ` Philippe De Muyter
0 siblings, 2 replies; 4+ messages in thread
From: gerg @ 2012-04-26 13:14 UTC (permalink / raw)
To: linux-m68k, uclinux-dev; +Cc: Greg Ungerer
From: Greg Ungerer <gerg@uclinux.org>
We have very large tables in the ColdFire CPU GPIO setup code that essentially
boil down to 2 distinct types of GPIO pin initiaization. Using 2 macros we can
reduce these large tables to at most a dozen lines of setup code, and in quite
a few cases a single table entry.
Introduce these 2 macros into the existing mcfgpio.h header.
Signed-off-by: Greg Ungerer <gerg@uclinux.org>
Acked-by: Steven King <sfking@fdwdc.com>
---
arch/m68k/include/asm/mcfgpio.h | 54 +++++++++++++++++++++++++++++++++++++++
1 files changed, 54 insertions(+), 0 deletions(-)
diff --git a/arch/m68k/include/asm/mcfgpio.h b/arch/m68k/include/asm/mcfgpio.h
index ee5e4cc..cd28830 100644
--- a/arch/m68k/include/asm/mcfgpio.h
+++ b/arch/m68k/include/asm/mcfgpio.h
@@ -37,4 +37,58 @@ void mcf_gpio_set_value_fast(struct gpio_chip *, unsigned, int);
int mcf_gpio_request(struct gpio_chip *, unsigned);
void mcf_gpio_free(struct gpio_chip *, unsigned);
+/*
+ * Define macros to ease the pain of setting up the GPIO tables. There
+ * is two cases we need to deal with here, they cover all currently
+ * available ColdFire GPIO hardware. There is of course minor differences
+ * in the layout and number of bits in each ColdFire part, but the macros
+ * take all that in.
+ *
+ * Firstly is the conventional GPIO registers where we toggle individual
+ * bits in a register, preserving the other bits in the register. For
+ * lack of a better term I have called this the slow method.
+ */
+#define MCFGPS(mlabel, mbase, mngpio, mpddr, mpodr, mppdr) \
+ { \
+ .gpio_chip = { \
+ .label = #mlabel, \
+ .request = mcf_gpio_request, \
+ .free = mcf_gpio_free, \
+ .direction_input = mcf_gpio_direction_input, \
+ .direction_output = mcf_gpio_direction_output,\
+ .get = mcf_gpio_get_value, \
+ .set = mcf_gpio_set_value, \
+ .base = mbase, \
+ .ngpio = mngpio, \
+ }, \
+ .pddr = (void __iomem *) mpddr, \
+ .podr = (void __iomem *) mpodr, \
+ .ppdr = (void __iomem *) mppdr, \
+ }
+
+/*
+ * Secondly is the faster case, where we have set and clear registers
+ * that allow us to set or clear a bit with a single write, not having
+ * to worry about preserving other bits.
+ */
+#define MCFGPF(mlabel, mbase, mngpio) \
+ { \
+ .gpio_chip = { \
+ .label = #mlabel, \
+ .request = mcf_gpio_request, \
+ .free = mcf_gpio_free, \
+ .direction_input = mcf_gpio_direction_input, \
+ .direction_output = mcf_gpio_direction_output,\
+ .get = mcf_gpio_get_value, \
+ .set = mcf_gpio_set_value_fast, \
+ .base = mbase, \
+ .ngpio = mngpio, \
+ }, \
+ .pddr = (void __iomem *) MCFGPIO_PDDR_##mlabel, \
+ .podr = (void __iomem *) MCFGPIO_PODR_##mlabel, \
+ .ppdr = (void __iomem *) MCFGPIO_PPDSDR_##mlabel, \
+ .setr = (void __iomem *) MCFGPIO_PPDSDR_##mlabel, \
+ .clrr = (void __iomem *) MCFGPIO_PCLRR_##mlabel, \
+ }
+
#endif
--
1.7.0.4
_______________________________________________
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 01/22] m68knommu: introduce macros to simplify ColdFire GPIO table initialization
2012-04-26 13:14 [PATCH v2 01/22] m68knommu: introduce macros to simplify ColdFire GPIO table initialization gerg
@ 2012-04-26 13:29 ` Ezequiel García
2012-04-26 13:48 ` Greg Ungerer
2012-04-26 14:39 ` Philippe De Muyter
1 sibling, 1 reply; 4+ messages in thread
From: Ezequiel García @ 2012-04-26 13:29 UTC (permalink / raw)
To: gerg; +Cc: linux-m68k, uclinux-dev, Greg Ungerer
Hi Greg,
Just some very minor typos....
On Thu, Apr 26, 2012 at 10:14 AM, <gerg@snapgear.com> wrote:
>
> +/*
> + * Define macros to ease the pain of setting up the GPIO tables. There
> + * is two cases we need to deal with here, they cover all currently
There *are* two cases?
> + * available ColdFire GPIO hardware. There is of course minor differences
There *are* of course minor differences?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 01/22] m68knommu: introduce macros to simplify ColdFire GPIO table initialization
2012-04-26 13:29 ` Ezequiel García
@ 2012-04-26 13:48 ` Greg Ungerer
0 siblings, 0 replies; 4+ messages in thread
From: Greg Ungerer @ 2012-04-26 13:48 UTC (permalink / raw)
To: Ezequiel García; +Cc: linux-m68k, uclinux-dev, Greg Ungerer
Hi Ezequiel,
On 04/26/2012 11:29 PM, Ezequiel García wrote:
> Hi Greg,
>
> Just some very minor typos....
>
> On Thu, Apr 26, 2012 at 10:14 AM,<gerg@snapgear.com> wrote:
>>
>> +/*
>> + * á á Define macros to ease the pain of setting up the GPIO tables. There
>> + * á á is two cases we need to deal with here, they cover all currently
>
> There *are* two cases?
>
>> + * á á available ColdFire GPIO hardware. There is of course minor differences
>
> There *are* of course minor differences?
Thanks, I'll fix those.
Regards
Greg
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close, FAX: +61 7 3891 3630
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
_______________________________________________
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 01/22] m68knommu: introduce macros to simplify ColdFire GPIO table initialization
2012-04-26 13:14 [PATCH v2 01/22] m68knommu: introduce macros to simplify ColdFire GPIO table initialization gerg
2012-04-26 13:29 ` Ezequiel García
@ 2012-04-26 14:39 ` Philippe De Muyter
1 sibling, 0 replies; 4+ messages in thread
From: Philippe De Muyter @ 2012-04-26 14:39 UTC (permalink / raw)
To: gerg; +Cc: linux-m68k, uclinux-dev, Greg Ungerer
Hello Greg,
On Thu, Apr 26, 2012 at 11:14:51PM +1000, gerg@snapgear.com wrote:
> From: Greg Ungerer <gerg@uclinux.org>
>
...
>
> +/*
> + * Define macros to ease the pain of setting up the GPIO tables. There
> + * is two cases we need to deal with here, they cover all currently
> + * available ColdFire GPIO hardware. There is of course minor differences
> + * in the layout and number of bits in each ColdFire part, but the macros
> + * take all that in.
> + *
> + * Firstly is the conventional GPIO registers where we toggle individual
> + * bits in a register, preserving the other bits in the register. For
> + * lack of a better term I have called this the slow method.
> + */
> +#define MCFGPS(mlabel, mbase, mngpio, mpddr, mpodr, mppdr) \
...
> +/*
> + * Secondly is the faster case, where we have set and clear registers
> + * that allow us to set or clear a bit with a single write, not having
> + * to worry about preserving other bits.
> + */
> +#define MCFGPF(mlabel, mbase, mngpio) \
That's perfectly clear.
Thanks
Philippe
--
Philippe De Muyter +32 2 6101532 Macq SA rue de l'Aeronef 2 B-1140 Bruxelles
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-04-26 17:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-26 13:14 [PATCH v2 01/22] m68knommu: introduce macros to simplify ColdFire GPIO table initialization gerg
2012-04-26 13:29 ` Ezequiel García
2012-04-26 13:48 ` Greg Ungerer
2012-04-26 14:39 ` Philippe De Muyter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.