[PATCH] Fix bug where kfree is called twice.

[PATCH] Fix bug where kfree is called twice.

[Rupesh Gujare]

Signed-off-by: Rupesh Gujare <rgujare@ozmodevices.com>
Signed-off-by: Chris Kelly <ckelly@ozmodevices.com>
---
 drivers/staging/ozwpan/ozpd.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/ozwpan/ozpd.c b/drivers/staging/ozwpan/ozpd.c
index 2b45d3d..04cd57f 100644
--- a/drivers/staging/ozwpan/ozpd.c
+++ b/drivers/staging/ozwpan/ozpd.c
@@ -383,8 +383,6 @@ static void oz_tx_frame_free(struct oz_pd *pd, struct oz_tx_frame *f)
 		pd->tx_pool = &f->link;
 		pd->tx_pool_count++;
 		f = 0;
-	} else {
-		kfree(f);
 	}
 	spin_unlock_bh(&pd->tx_frame_lock);
 	if (f)
-- 
1.7.5.4

Re: [PATCH] Fix bug where kfree is called twice.

[Dan Carpenter]

It's a good patch and it fixes a bug, but could you resend with
the subject:

[PATCH] Staging: ozwpan: Fix bug where kfree is called twice.

We don't like to put a lot of bureaucracy infront of people
submitting actual bugfixes.  But you guys are the new maintainers
and you're going to need to know all this stuff eventually.  Also
could you give us a hint how likely the users are to hit this?
Should this go into 3.4 or only 3.5?

regards,
dan carpenter

Re: [PATCH] Fix bug where kfree is called twice.

[Rupesh Gujare]

Hi Dan,
> It's a good patch and it fixes a bug, but could you resend with
> the subject:
>
> [PATCH] Staging: ozwpan: Fix bug where kfree is called twice.
Sorry about subject line. I should have spend a bit more time in 
formatting subject line.
However it looks like Greg have already pulled this patch in 
staging-next branch.
(Thanks Greg, for modifying subject line. I will be more careful next time.)

However, I will be happy if you still want me to resend this patch with 
correct subject line.

> We don't like to put a lot of bureaucracy infront of people
> submitting actual bugfixes.  But you guys are the new maintainers
> and you're going to need to know all this stuff eventually.  Also
> could you give us a hint how likely the users are to hit this?
> Should this go into 3.4 or only 3.5?
I would have loved to get this patch in 3.4 as I am observing occasional 
crashes.
However looks like Greg have queued it up for 3.5.
-- 
Regards,
Rupesh Guajre

Re: [PATCH] Fix bug where kfree is called twice.

[Dan Carpenter]

On Thu, Apr 26, 2012 at 09:44:16AM +0100, Rupesh Gujare wrote:
> Hi Dan,
> >It's a good patch and it fixes a bug, but could you resend with
> >the subject:
> >
> >[PATCH] Staging: ozwpan: Fix bug where kfree is called twice.
> Sorry about subject line. I should have spend a bit more time in
> formatting subject line.
> However it looks like Greg have already pulled this patch in
> staging-next branch.
> (Thanks Greg, for modifying subject line. I will be more careful next time.)
> 
> However, I will be happy if you still want me to resend this patch
> with correct subject line.
> 

Obviously don't resend.  *eyeroll*  I'll never ask you to resend
stuff just because I'm on a power trip.

> >We don't like to put a lot of bureaucracy infront of people
> >submitting actual bugfixes.  But you guys are the new maintainers
> >and you're going to need to know all this stuff eventually.  Also
> >could you give us a hint how likely the users are to hit this?
> >Should this go into 3.4 or only 3.5?
> I would have loved to get this patch in 3.4 as I am observing
> occasional crashes.
> However looks like Greg have queued it up for 3.5.

Everything goes into linux-next first.  That should have been put
in the changelog.  "We are seeing occasional crashes under load" or
whatever...  It's Greg's call and all, but generally it can't hurt
to ask nicely if you want stuff merged it into 3.4 as well.  ;)

regards,
dan carpenter

Re: [PATCH] Fix bug where kfree is called twice.

[Rupesh Gujare]

Hi Greg,

> Everything goes into linux-next first. That should have been put in 
> the changelog. "We are seeing occasional crashes under load" or 
> whatever... It's Greg's call and all, but generally it can't hurt to 
> ask nicely if you want stuff merged it into 3.4 as well. ;) 

Is it possible to queue it up for 3.4 as well ?

-- 
Regards,
Rupesh Gujare

Re: [PATCH] Fix bug where kfree is called twice.

[Greg KH]

On Thu, Apr 26, 2012 at 06:09:15PM +0100, Rupesh Gujare wrote:
> Hi Greg,
> 
> >Everything goes into linux-next first. That should have been put
> >in the changelog. "We are seeing occasional crashes under load" or
> >whatever... It's Greg's call and all, but generally it can't hurt
> >to ask nicely if you want stuff merged it into 3.4 as well. ;)
> 
> Is it possible to queue it up for 3.4 as well ?

Yes, now done so.

Re: [PATCH] Fix bug where kfree is called twice.

[Rupesh Gujare]

> Is it possible to queue it up for 3.4 as well ?
> Yes, now done so.
>
>

Thanks a lot Greg.  :-)

-- 
Regards,
Rupesh Gujare