From: Rik van Riel <riel@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
linux-mm@kvack.org, Andrea Arcangeli <aarcange@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Mel Gorman <mgorman@suse.de>, Minchan Kim <minchan.kim@gmail.com>,
Hugh Dickins <hughd@google.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 2/5] mm + fs: prepare for non-page entries in page cache
Date: Tue, 01 May 2012 17:14:57 -0400 [thread overview]
Message-ID: <4FA05251.5060105@redhat.com> (raw)
In-Reply-To: <20120501132449.30485966.akpm@linux-foundation.org>
On 05/01/2012 04:24 PM, Andrew Morton wrote:
> That's a pretty significant alteration in the meaning of ->nrpages.
> Did this not have any other effects?
From what I see (though it's been a long day), ->nrpages
stays the same it is now.
The non-page entries are simply not counted in ->nrpages.
> What does truncate do? I assume it invalidates shadow page entries in
> the radix tree? And frees the radix-tree nodes?
Indeed, truncate will get rid of the non-page entries
in the radix tree. That is why it needs to be called
even if ->nrpages==0.
--
All rights reversed
WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
linux-mm@kvack.org, Andrea Arcangeli <aarcange@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Mel Gorman <mgorman@suse.de>, Minchan Kim <minchan.kim@gmail.com>,
Hugh Dickins <hughd@google.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 2/5] mm + fs: prepare for non-page entries in page cache
Date: Tue, 01 May 2012 17:14:57 -0400 [thread overview]
Message-ID: <4FA05251.5060105@redhat.com> (raw)
In-Reply-To: <20120501132449.30485966.akpm@linux-foundation.org>
On 05/01/2012 04:24 PM, Andrew Morton wrote:
> That's a pretty significant alteration in the meaning of ->nrpages.
> Did this not have any other effects?
From what I see (though it's been a long day), ->nrpages
stays the same it is now.
The non-page entries are simply not counted in ->nrpages.
> What does truncate do? I assume it invalidates shadow page entries in
> the radix tree? And frees the radix-tree nodes?
Indeed, truncate will get rid of the non-page entries
in the radix tree. That is why it needs to be called
even if ->nrpages==0.
--
All rights reversed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-05-01 21:15 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-01 8:41 [patch 0/5] refault distance-based file cache sizing Johannes Weiner
2012-05-01 8:41 ` Johannes Weiner
2012-05-01 8:41 ` [patch 1/5] mm: readahead: move radix tree hole searching here Johannes Weiner
2012-05-01 8:41 ` Johannes Weiner
2012-05-01 21:06 ` Rik van Riel
2012-05-01 21:06 ` Rik van Riel
2012-05-01 8:41 ` [patch 2/5] mm + fs: prepare for non-page entries in page cache Johannes Weiner
2012-05-01 8:41 ` Johannes Weiner
2012-05-01 19:02 ` Andrew Morton
2012-05-01 19:02 ` Andrew Morton
2012-05-01 20:15 ` Johannes Weiner
2012-05-01 20:15 ` Johannes Weiner
2012-05-01 20:24 ` Andrew Morton
2012-05-01 20:24 ` Andrew Morton
2012-05-01 21:14 ` Rik van Riel [this message]
2012-05-01 21:14 ` Rik van Riel
2012-05-01 21:29 ` Johannes Weiner
2012-05-01 21:29 ` Johannes Weiner
2012-05-01 8:41 ` [patch 3/5] mm + fs: store shadow pages " Johannes Weiner
2012-05-01 8:41 ` Johannes Weiner
2012-05-01 8:41 ` [patch 4/5] mm + fs: provide refault distance to page cache instantiations Johannes Weiner
2012-05-01 8:41 ` Johannes Weiner
2012-05-01 9:30 ` Peter Zijlstra
2012-05-01 9:30 ` Peter Zijlstra
2012-05-01 9:30 ` Peter Zijlstra
2012-05-01 9:55 ` Johannes Weiner
2012-05-01 9:55 ` Johannes Weiner
2012-05-01 9:58 ` Peter Zijlstra
2012-05-01 9:58 ` Peter Zijlstra
2012-05-01 9:58 ` Peter Zijlstra
2012-05-01 8:41 ` [patch 5/5] mm: refault distance-based file cache sizing Johannes Weiner
2012-05-01 8:41 ` Johannes Weiner
2012-05-01 14:13 ` Minchan Kim
2012-05-01 14:13 ` Minchan Kim
2012-05-01 15:38 ` Johannes Weiner
2012-05-01 15:38 ` Johannes Weiner
2012-05-02 5:21 ` Minchan Kim
2012-05-02 5:21 ` Minchan Kim
2012-05-02 1:57 ` Andrea Arcangeli
2012-05-02 1:57 ` Andrea Arcangeli
2012-05-02 6:23 ` Johannes Weiner
2012-05-02 6:23 ` Johannes Weiner
2012-05-02 15:11 ` Andrea Arcangeli
2012-05-02 15:11 ` Andrea Arcangeli
2012-05-01 19:08 ` [patch 0/5] " Andrew Morton
2012-05-01 19:08 ` Andrew Morton
2012-05-01 21:19 ` Rik van Riel
2012-05-01 21:19 ` Rik van Riel
2012-05-01 21:26 ` Andrew Morton
2012-05-01 21:26 ` Andrew Morton
2012-05-02 1:10 ` Andrea Arcangeli
2012-05-02 1:10 ` Andrea Arcangeli
2012-05-03 13:15 ` Johannes Weiner
2012-05-03 13:15 ` Johannes Weiner
2012-05-16 5:25 ` nai.xia
2012-05-16 5:25 ` nai.xia
2012-05-16 6:51 ` Johannes Weiner
2012-05-16 6:51 ` Johannes Weiner
2012-05-16 12:56 ` nai.xia
2012-05-16 12:56 ` nai.xia
2012-05-17 21:08 ` Johannes Weiner
2012-05-17 21:08 ` Johannes Weiner
2012-05-18 3:44 ` Nai Xia
2012-05-18 3:44 ` Nai Xia
2012-05-18 15:07 ` Rik van Riel
2012-05-18 15:07 ` Rik van Riel
2012-05-18 15:30 ` Nai Xia
2012-05-18 15:30 ` Nai Xia
2012-05-18 15:30 ` Nai Xia
2012-05-17 13:11 ` Rik van Riel
2012-05-17 13:11 ` Rik van Riel
2012-05-18 5:03 ` Nai Xia
2012-05-18 5:03 ` Nai Xia
2012-05-18 5:03 ` Nai Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA05251.5060105@redhat.com \
--to=riel@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=minchan.kim@gmail.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.