* [GIT PULL] Please pull NFS client fixes
@ 2013-01-31 19:47 Myklebust, Trond
0 siblings, 0 replies; 22+ messages in thread
From: Myklebust, Trond @ 2013-01-31 19:47 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Linux NFS mailing list, linux-kernel
Hi Linus,
The following changes since commit 949db153b6466c6f7cad5a427ecea94985927311:
Linux 3.8-rc5 (2013-01-25 11:57:28 -0800)
are available in the git repository at:
git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.8-4
for you to fetch changes up to c489ee290bdbbace6bb63ebe6ebd4dd605819495:
NFSv4.1: Handle NFS4ERR_DELAY when resetting the NFSv4.1 session (2013-01-30 17:45:15 -0500)
----------------------------------------------------------------
NFS client bugfixe for Linux 3.8
- Error reporting in nfs_xdev_mount incorrectly maps all errors to ENOMEM
- Fix an NFSv4 refcounting issue
- Fix a mount failure when the server reboots during NFSv4 trunking discovery
- NFSv4.1 mounts may need to run the lease recovery thread.
- Don't silently fail setattr() requests on mountpoints
- Fix a SUNRPC socket/transport livelock and priority queue issue
- We must handle NFS4ERR_DELAY when resetting the NFSv4.1 session.
----------------------------------------------------------------
Trond Myklebust (7):
NFS: Fix error reporting in nfs_xdev_mount
NFSv4: Fix NFSv4 reference counting for trunked sessions
NFSv4: Fix NFSv4 trunking discovery
NFSv4.1: Ensure that nfs41_walk_client_list() does start lease recovery
NFS: Don't silently fail setattr() requests on mountpoints
SUNRPC: When changing the queue priority, ensure that we change the owner
NFSv4.1: Handle NFS4ERR_DELAY when resetting the NFSv4.1 session
fs/nfs/namespace.c | 20 +++++++++++++++++
fs/nfs/nfs4client.c | 62 ++++++++++++++++++++++-------------------------------
fs/nfs/nfs4state.c | 22 ++++++++++++-------
fs/nfs/super.c | 22 ++++++++-----------
net/sunrpc/sched.c | 18 +++++++++++++++-
5 files changed, 86 insertions(+), 58 deletions(-)
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@netapp.com
www.netapp.com
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [GIT PULL] Please pull NFS client fixes
2019-03-26 20:12 Trond Myklebust
@ 2019-03-26 22:25 ` pr-tracker-bot
0 siblings, 0 replies; 22+ messages in thread
From: pr-tracker-bot @ 2019-03-26 22:25 UTC (permalink / raw)
To: Trond Myklebust; +Cc: torvalds, linux-kernel, linux-nfs
The pull request you sent on Tue, 26 Mar 2019 20:12:07 +0000:
> git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-5.1-3
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/14c741de93861749dfb60b4964028541f5c506ca
Thank you!
--
Deet-doot-dot, I am a bot.
https://korg.wiki.kernel.org/userdoc/prtracker
^ permalink raw reply [flat|nested] 22+ messages in thread
* [GIT PULL] Please pull NFS client fixes
@ 2019-03-26 20:12 Trond Myklebust
2019-03-26 22:25 ` pr-tracker-bot
0 siblings, 1 reply; 22+ messages in thread
From: Trond Myklebust @ 2019-03-26 20:12 UTC (permalink / raw)
To: torvalds; +Cc: linux-kernel, linux-nfs
Hi Linus,
The following changes since commit 9e98c678c2d6ae3a17cb2de55d17f69dddaa231b:
Linux 5.1-rc1 (2019-03-17 14:22:26 -0700)
are available in the Git repository at:
git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-5.1-3
for you to fetch changes up to 01f2f5b82a2b523ae76af53f2ff43c48dde10a00:
SUNRPC: fix uninitialized variable warning (2019-03-26 13:04:32 -0700)
----------------------------------------------------------------
NFS client bugfixes for Linux 5.1
Highlights include:
Stable fixes:
- Fix nfs4_lock_state refcounting in nfs4_alloc_{lock,unlock}data()
- fix mount/umount race in nlmclnt.
- NFSv4.1 don't free interrupted slot on open
Bugfixes:
- Don't let RPC_SOFTCONN tasks time out if the transport is connected
- Fix a typo in nfs_init_timeout_values()
- Fix layoutstats handling during read failovers
- fix uninitialized variable warning
----------------------------------------------------------------
Alakesh Haloi (1):
SUNRPC: fix uninitialized variable warning
Catalin Marinas (1):
NFS: Fix nfs4_lock_state refcounting in nfs4_alloc_{lock,unlock}data()
NeilBrown (1):
NFS: fix mount/umount race in nlmclnt.
Olga Kornievskaia (1):
NFSv4.1 don't free interrupted slot on open
Trond Myklebust (3):
SUNRPC: Don't let RPC_SOFTCONN tasks time out if the transport is connected
NFS: Fix a typo in nfs_init_timeout_values()
pNFS/flexfiles: Fix layoutstats handling during read failovers
fs/lockd/host.c | 3 +--
fs/nfs/client.c | 2 +-
fs/nfs/flexfilelayout/flexfilelayout.c | 5 ++++-
fs/nfs/nfs4proc.c | 5 ++---
net/sunrpc/clnt.c | 12 +++++++++++-
net/sunrpc/xprtsock.c | 4 ++--
6 files changed, 21 insertions(+), 10 deletions(-)
--
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@hammerspace.com
^ permalink raw reply [flat|nested] 22+ messages in thread
* [GIT PULL] Please pull NFS client fixes
@ 2017-10-24 22:56 ` Trond Myklebust
0 siblings, 0 replies; 22+ messages in thread
From: Trond Myklebust @ 2017-10-24 22:56 UTC (permalink / raw)
To: torvalds; +Cc: linux-kernel, linux-nfs
Hi Linus,
The following changes since commit 33d930e59a98fa10a0db9f56c7fa2f21a4aef9b9:
Linux 4.14-rc5 (2017-10-15 21:01:12 -0400)
are available in the git repository at:
git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-4.14-4
for you to fetch changes up to 528fd3547bad0bdd31c8f987e5bd00c83df8af39:
SUNRPC: Destroy transport from the system workqueue (2017-10-19 12:17:56 -0400)
----------------------------------------------------------------
NFS client bugfixes for Linux 4.14
Hightlights include:
- Fix a list corruption in xprt_release()
- Fix a workqueue lockdep warning due to unsafe use of cancel_work_sync()
----------------------------------------------------------------
Trond Myklebust (2):
SUNRPC: fix a list corruption issue in xprt_release()
SUNRPC: Destroy transport from the system workqueue
net/sunrpc/xprt.c | 36 +++++++++++++++++++++++++-----------
1 file changed, 25 insertions(+), 11 deletions(-)
--
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@primarydata.com
^ permalink raw reply [flat|nested] 22+ messages in thread
* [GIT PULL] Please pull NFS client fixes
@ 2017-10-24 22:56 ` Trond Myklebust
0 siblings, 0 replies; 22+ messages in thread
From: Trond Myklebust @ 2017-10-24 22:56 UTC (permalink / raw)
To: torvalds; +Cc: linux-kernel, linux-nfs
SGkgTGludXMsDQoNClRoZSBmb2xsb3dpbmcgY2hhbmdlcyBzaW5jZSBjb21taXQgMzNkOTMwZTU5
YTk4ZmExMGEwZGI5ZjU2YzdmYTJmMjFhNGFlZjliOToNCg0KICBMaW51eCA0LjE0LXJjNSAoMjAx
Ny0xMC0xNSAyMTowMToxMiAtMDQwMCkNCg0KYXJlIGF2YWlsYWJsZSBpbiB0aGUgZ2l0IHJlcG9z
aXRvcnkgYXQ6DQoNCiAgZ2l0Oi8vZ2l0LmxpbnV4LW5mcy5vcmcvcHJvamVjdHMvdHJvbmRteS9s
aW51eC1uZnMuZ2l0IHRhZ3MvbmZzLWZvci00LjE0LTQNCg0KZm9yIHlvdSB0byBmZXRjaCBjaGFu
Z2VzIHVwIHRvIDUyOGZkMzU0N2JhZDBiZGQzMWM4Zjk4N2U1YmQwMGM4M2RmOGFmMzk6DQoNCiAg
U1VOUlBDOiBEZXN0cm95IHRyYW5zcG9ydCBmcm9tIHRoZSBzeXN0ZW0gd29ya3F1ZXVlICgyMDE3
LTEwLTE5IDEyOjE3OjU2IC0wNDAwKQ0KDQotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tDQpORlMgY2xpZW50IGJ1Z2ZpeGVzIGZv
ciBMaW51eCA0LjE0DQoNCkhpZ2h0bGlnaHRzIGluY2x1ZGU6DQoNCi0gRml4IGEgbGlzdCBjb3Jy
dXB0aW9uIGluIHhwcnRfcmVsZWFzZSgpDQotIEZpeCBhIHdvcmtxdWV1ZSBsb2NrZGVwIHdhcm5p
bmcgZHVlIHRvIHVuc2FmZSB1c2Ugb2YgY2FuY2VsX3dvcmtfc3luYygpDQoNCi0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0NClRy
b25kIE15a2xlYnVzdCAoMik6DQogICAgICBTVU5SUEM6IGZpeCBhIGxpc3QgY29ycnVwdGlvbiBp
c3N1ZSBpbiB4cHJ0X3JlbGVhc2UoKQ0KICAgICAgU1VOUlBDOiBEZXN0cm95IHRyYW5zcG9ydCBm
cm9tIHRoZSBzeXN0ZW0gd29ya3F1ZXVlDQoNCiBuZXQvc3VucnBjL3hwcnQuYyB8IDM2ICsrKysr
KysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLQ0KIDEgZmlsZSBjaGFuZ2VkLCAyNSBpbnNl
cnRpb25zKCspLCAxMSBkZWxldGlvbnMoLSkNCi0tIA0KVHJvbmQgTXlrbGVidXN0DQpMaW51eCBO
RlMgY2xpZW50IG1haW50YWluZXIsIFByaW1hcnlEYXRhDQp0cm9uZC5teWtsZWJ1c3RAcHJpbWFy
eWRhdGEuY29tDQo=
^ permalink raw reply [flat|nested] 22+ messages in thread
* [GIT PULL] Please pull NFS client fixes
@ 2016-09-12 19:28 ` Trond Myklebust
0 siblings, 0 replies; 22+ messages in thread
From: Trond Myklebust @ 2016-09-12 19:28 UTC (permalink / raw)
To: torvalds; +Cc: linux-kernel, linux-nfs
Hi Linus,
The following changes since commit 98b0f80c2396224bbbed81792b526e6c72ba9efa:
NFSv4.x: Fix a refcount leak in nfs_callback_up_net (2016-08-30 09:26:57 -0400)
are available in the git repository at:
git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-4.8-4
for you to fetch changes up to b519d408ea32040b1c7e10b155a3ee9a36660947:
NFSv4.1: Fix the CREATE_SESSION slot number accounting (2016-09-11 14:56:44 -0400)
Cheers
Trond
----------------------------------------------------------------
NFS client bugfixes for 4.8
Highlights include:
Stable patches:
- We must serialise LAYOUTGET and LAYOUTRETURN to ensure correct state
accounting
- Fix the CREATE_SESSION slot number
Bugfixes:
- sunrpc: fix a UDP memory accounting regression
- NFS: Fix an error reporting regression in nfs_file_write()
- pNFS: Fix further layout stateid issues
- RPC/rdma: Revert 3d4cf35bd4fa ("xprtrdma: Reply buffer exhaustion...")
- RPC/rdma: Fix receive buffer accounting
----------------------------------------------------------------
Chuck Lever (2):
xprtrdma: Revert 3d4cf35bd4fa ("xprtrdma: Reply buffer exhaustion...")
xprtrdma: Fix receive buffer accounting
Paolo Abeni (1):
sunrpc: fix UDP memory accounting
Trond Myklebust (6):
NFS: Fix error reporting in nfs_file_write()
pNFS: Ensure LAYOUTGET and LAYOUTRETURN are properly serialised
pNFS: Fix pnfs_set_layout_stateid() to clear NFS_LAYOUT_INVALID_STID
pNFS: Clear out all layout segments if the server unsets lrp->res.lrs_present
pNFS: Don't forget the layout stateid if there are outstanding LAYOUTGETs
NFSv4.1: Fix the CREATE_SESSION slot number accounting
fs/nfs/file.c | 5 ++++-
fs/nfs/nfs4proc.c | 21 ++++++++++++++-----
fs/nfs/pnfs.c | 42 +++++++++++++++++++++-----------------
net/sunrpc/xprtrdma/verbs.c | 45 +++++++++++++++++++++++++++++------------
net/sunrpc/xprtrdma/xprt_rdma.h | 1 +
net/sunrpc/xprtsock.c | 2 +-
6 files changed, 78 insertions(+), 38 deletions(-)
--
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@primarydata.com
^ permalink raw reply [flat|nested] 22+ messages in thread
* [GIT PULL] Please pull NFS client fixes
@ 2016-09-12 19:28 ` Trond Myklebust
0 siblings, 0 replies; 22+ messages in thread
From: Trond Myklebust @ 2016-09-12 19:28 UTC (permalink / raw)
To: torvalds; +Cc: linux-kernel, linux-nfs
SGkgTGludXMsDQoNClRoZSBmb2xsb3dpbmcgY2hhbmdlcyBzaW5jZSBjb21taXQgOThiMGY4MGMy
Mzk2MjI0YmJiZWQ4MTc5MmI1MjZlNmM3MmJhOWVmYToNCg0KICBORlN2NC54OiBGaXggYSByZWZj
b3VudCBsZWFrIGluIG5mc19jYWxsYmFja191cF9uZXQgKDIwMTYtMDgtMzAgMDk6MjY6NTcgLTA0
MDApDQoNCmFyZSBhdmFpbGFibGUgaW4gdGhlIGdpdCByZXBvc2l0b3J5IGF0Og0KDQogIGdpdDov
L2dpdC5saW51eC1uZnMub3JnL3Byb2plY3RzL3Ryb25kbXkvbGludXgtbmZzLmdpdCB0YWdzL25m
cy1mb3ItNC44LTQNCg0KZm9yIHlvdSB0byBmZXRjaCBjaGFuZ2VzIHVwIHRvIGI1MTlkNDA4ZWEz
MjA0MGIxYzdlMTBiMTU1YTNlZTlhMzY2NjA5NDc6DQoNCiAgTkZTdjQuMTogRml4IHRoZSBDUkVB
VEVfU0VTU0lPTiBzbG90IG51bWJlciBhY2NvdW50aW5nICgyMDE2LTA5LTExIDE0OjU2OjQ0IC0w
NDAwKQ0KDQpDaGVlcnMNCiAgVHJvbmQNCg0KLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KTkZTIGNsaWVudCBidWdmaXhlcyBm
b3IgNC44DQoNCkhpZ2hsaWdodHMgaW5jbHVkZToNCg0KU3RhYmxlIHBhdGNoZXM6DQotIFdlIG11
c3Qgc2VyaWFsaXNlIExBWU9VVEdFVCBhbmQgTEFZT1VUUkVUVVJOIHRvIGVuc3VyZSBjb3JyZWN0
IHN0YXRlDQogIGFjY291bnRpbmcNCi0gRml4IHRoZSBDUkVBVEVfU0VTU0lPTiBzbG90IG51bWJl
cg0KDQpCdWdmaXhlczoNCi0gc3VucnBjOiBmaXggYSBVRFAgbWVtb3J5IGFjY291bnRpbmcgcmVn
cmVzc2lvbg0KLSBORlM6IEZpeCBhbiBlcnJvciByZXBvcnRpbmcgcmVncmVzc2lvbiBpbiBuZnNf
ZmlsZV93cml0ZSgpDQotIHBORlM6IEZpeCBmdXJ0aGVyIGxheW91dCBzdGF0ZWlkIGlzc3Vlcw0K
LSBSUEMvcmRtYTogUmV2ZXJ0IDNkNGNmMzViZDRmYSAoInhwcnRyZG1hOiBSZXBseSBidWZmZXIg
ZXhoYXVzdGlvbi4uLiIpDQotIFJQQy9yZG1hOiBGaXggcmVjZWl2ZSBidWZmZXIgYWNjb3VudGlu
Zw0KDQotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tDQpDaHVjayBMZXZlciAoMik6DQogICAgICB4cHJ0cmRtYTogUmV2ZXJ0IDNk
NGNmMzViZDRmYSAoInhwcnRyZG1hOiBSZXBseSBidWZmZXIgZXhoYXVzdGlvbi4uLiIpDQogICAg
ICB4cHJ0cmRtYTogRml4IHJlY2VpdmUgYnVmZmVyIGFjY291bnRpbmcNCg0KUGFvbG8gQWJlbmkg
KDEpOg0KICAgICAgc3VucnBjOiBmaXggVURQIG1lbW9yeSBhY2NvdW50aW5nDQoNClRyb25kIE15
a2xlYnVzdCAoNik6DQogICAgICBORlM6IEZpeCBlcnJvciByZXBvcnRpbmcgaW4gbmZzX2ZpbGVf
d3JpdGUoKQ0KICAgICAgcE5GUzogRW5zdXJlIExBWU9VVEdFVCBhbmQgTEFZT1VUUkVUVVJOIGFy
ZSBwcm9wZXJseSBzZXJpYWxpc2VkDQogICAgICBwTkZTOiBGaXggcG5mc19zZXRfbGF5b3V0X3N0
YXRlaWQoKSB0byBjbGVhciBORlNfTEFZT1VUX0lOVkFMSURfU1RJRA0KICAgICAgcE5GUzogQ2xl
YXIgb3V0IGFsbCBsYXlvdXQgc2VnbWVudHMgaWYgdGhlIHNlcnZlciB1bnNldHMgbHJwLT5yZXMu
bHJzX3ByZXNlbnQNCiAgICAgIHBORlM6IERvbid0IGZvcmdldCB0aGUgbGF5b3V0IHN0YXRlaWQg
aWYgdGhlcmUgYXJlIG91dHN0YW5kaW5nIExBWU9VVEdFVHMNCiAgICAgIE5GU3Y0LjE6IEZpeCB0
aGUgQ1JFQVRFX1NFU1NJT04gc2xvdCBudW1iZXIgYWNjb3VudGluZw0KDQogZnMvbmZzL2ZpbGUu
YyAgICAgICAgICAgICAgICAgICB8ICA1ICsrKystDQogZnMvbmZzL25mczRwcm9jLmMgICAgICAg
ICAgICAgICB8IDIxICsrKysrKysrKysrKysrLS0tLS0NCiBmcy9uZnMvcG5mcy5jICAgICAgICAg
ICAgICAgICAgIHwgNDIgKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0NCiBu
ZXQvc3VucnBjL3hwcnRyZG1hL3ZlcmJzLmMgICAgIHwgNDUgKysrKysrKysrKysrKysrKysrKysr
KysrKysrKystLS0tLS0tLS0tLS0NCiBuZXQvc3VucnBjL3hwcnRyZG1hL3hwcnRfcmRtYS5oIHwg
IDEgKw0KIG5ldC9zdW5ycGMveHBydHNvY2suYyAgICAgICAgICAgfCAgMiArLQ0KIDYgZmlsZXMg
Y2hhbmdlZCwgNzggaW5zZXJ0aW9ucygrKSwgMzggZGVsZXRpb25zKC0pDQotLSANClRyb25kIE15
a2xlYnVzdA0KTGludXggTkZTIGNsaWVudCBtYWludGFpbmVyLCBQcmltYXJ5RGF0YQ0KdHJvbmQu
bXlrbGVidXN0QHByaW1hcnlkYXRhLmNvbQ0K
^ permalink raw reply [flat|nested] 22+ messages in thread
* [GIT PULL] Please pull NFS client fixes
@ 2016-02-23 18:33 Trond Myklebust
0 siblings, 0 replies; 22+ messages in thread
From: Trond Myklebust @ 2016-02-23 18:33 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Linux NFS Mailing List, Linux Kernel Mailing List
Hi Linus,
The following changes since commit 388f7b1d6e8ca06762e2454d28d6c3c55ad0fe95:
Linux 4.5-rc3 (2016-02-07 15:38:30 -0800)
are available in the git repository at:
git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-4.5-4
for you to fetch changes up to 9fd4b9fc7695a4da1363a0b439853f88fb6a034f:
NFSv4.x/pnfs: Fix a race between layoutget and bulk recalls (2016-02-22 17:46:34 -0500)
----------------------------------------------------------------
NFS client bugfixes for Linux 4.5
Stable bugfixes:
- Fix nfs_size_to_loff_t
- NFSv4: Fix a dentry leak on alias use
Other bugfixes:
- Don't schedule a layoutreturn if the layout segment can be freed immediately.
- Always set NFS_LAYOUT_RETURN_REQUESTED with lo->plh_return_iomode
- rpcrdma_bc_receive_call() should init rq_private_buf.len
- fix stateid handling for the NFS v4.2 operations
- pnfs/blocklayout: fix a memeory leak when using,vmalloc_to_page
- fix panic in gss_pipe_downcall() in fips mode
- Fix a race between layoutget and pnfs_destroy_layout
- Fix a race between layoutget and bulk recalls
----------------------------------------------------------------
Benjamin Coddington (1):
NFSv4: Fix a dentry leak on alias use
Christoph Hellwig (2):
nfs: fix nfs_size_to_loff_t
nfs4: fix stateid handling for the NFS v4.2 operations
Chuck Lever (1):
xprtrdma: rpcrdma_bc_receive_call() should init rq_private_buf.len
Kinglong Mee (1):
pnfs/blocklayout: fix a memeory leak when using,vmalloc_to_page
Scott Mayhew (1):
auth_gss: fix panic in gss_pipe_downcall() in fips mode
Trond Myklebust (5):
pNFS: Fix pnfs_mark_matching_lsegs_return()
pNFS: Always set NFS_LAYOUT_RETURN_REQUESTED with lo->plh_return_iomode
Merge tag 'nfs-rdma-4.5-1' of git://git.linux-nfs.org/projects/anna/nfs-rdma
NFSv4.x/pnfs: Fix a race between layoutget and pnfs_destroy_layout
NFSv4.x/pnfs: Fix a race between layoutget and bulk recalls
fs/nfs/blocklayout/extent_tree.c | 10 +++-
fs/nfs/nfs42proc.c | 119 ++++++++++++++++++++++++--------------
fs/nfs/nfs4proc.c | 4 +-
fs/nfs/pnfs.c | 55 +++++++++++++-----
include/linux/nfs_fs.h | 4 +-
include/linux/nfs_xdr.h | 1 +
net/sunrpc/auth_gss/auth_gss.c | 2 +-
net/sunrpc/xprtrdma/backchannel.c | 2 +
8 files changed, 131 insertions(+), 66 deletions(-)
--
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@primarydata.com
^ permalink raw reply [flat|nested] 22+ messages in thread
* [GIT PULL] Please pull NFS client fixes
@ 2014-09-12 17:04 Trond Myklebust
0 siblings, 0 replies; 22+ messages in thread
From: Trond Myklebust @ 2014-09-12 17:04 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Linux NFS Mailing List, Linux Kernel mailing list
Hi Linus,
The following changes since commit 2ce7598c9a453e0acd0e07be7be3f5eb39608ebd:
Linux 3.17-rc4 (2014-09-07 16:09:43 -0700)
are available in the git repository at:
git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.17-4
for you to fetch changes up to 224ecbf5a674ec7da3a3b3ea21ca62e2853653fa:
pnfs: fix filelayout_retry_commit when idx > 0 (2014-09-10 12:43:45 -0700)
----------------------------------------------------------------
NFS client fixes for 3.17
Highlights:
- Fix a kernel warning when removing /proc/net/nfsfs
- Revert commit 49a4bda22e18 due to Oopses
- Fix a typo in the pNFS file layout commit code
----------------------------------------------------------------
Cong Wang (1):
nfs: fix kernel warning when removing proc entry
Jeff Layton (1):
nfs: revert "nfs4: queue free_lock_state job submission to nfsiod"
Weston Andros Adamson (1):
pnfs: fix filelayout_retry_commit when idx > 0
fs/nfs/client.c | 12 +++---------
fs/nfs/filelayout/filelayout.c | 5 +++--
fs/nfs/nfs4_fs.h | 13 ++++++-------
fs/nfs/nfs4state.c | 24 ++++++------------------
4 files changed, 18 insertions(+), 36 deletions(-)
^ permalink raw reply [flat|nested] 22+ messages in thread
* [GIT PULL] Please pull NFS client fixes
@ 2014-08-29 19:35 Trond Myklebust
0 siblings, 0 replies; 22+ messages in thread
From: Trond Myklebust @ 2014-08-29 19:35 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Linux NFS Mailing List, Linux Kernel mailing list
Hi Linus,
The following changes since commit 52addcf9d6669fa439387610bc65c92fa0980cef:
Linux 3.17-rc2 (2014-08-25 15:36:20 -0700)
are available in the git repository at:
git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.17-3
for you to fetch changes up to f87d928f6d98644d39809a013a22f981d39017cf:
NFSv3: Fix another acl regression (2014-08-26 16:17:48 -0400)
----------------------------------------------------------------
NFS client fixes for 3.17
Highlights:
- NFSv3 stable fix for another POSIX ACL regression
- NFSv4 stable fix for a regression with OPEN_DOWNGRADE
- NFSv4 stable fix for bad close() behaviour when holding a delegation
----------------------------------------------------------------
Trond Myklebust (3):
NFSv4: Fix problems with close in the presence of a delegation
NFSv4: Don't clear the open state when we just did an OPEN_DOWNGRADE
NFSv3: Fix another acl regression
fs/nfs/nfs3acl.c | 5 ++++-
fs/nfs/nfs4proc.c | 26 +++++++++++++++++---------
2 files changed, 21 insertions(+), 10 deletions(-)
^ permalink raw reply [flat|nested] 22+ messages in thread
* [GIT PULL] Please pull NFS client fixes
@ 2014-08-25 14:55 Trond Myklebust
0 siblings, 0 replies; 22+ messages in thread
From: Trond Myklebust @ 2014-08-25 14:55 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Linux NFS mailing list, Linux Kernel mailing list
Hi Linus,
The following changes since commit 451fd72219dd6f3355e2d036c598544c760ee532:
Merge tag 'pwm/for-3.17-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/thierry.reding/linux-pwm (2014-08-22 14:50:21 -0700)
are available in the git repository at:
git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.17-2
for you to fetch changes up to 92a56555bd576c61b27a5cab9f38a33a1e9a1df5:
nfs: Don't busy-wait on SIGKILL in __nfs_iocounter_wait (2014-08-22 18:04:44 -0400)
----------------------------------------------------------------
NFS client fixes for 3.17
Highlights:
- More fixes for read/write codepath regressions
- Sleeping while holding the inode lock
- Stricter enforcement of page contiguity when coalescing requests
- Fix up error handling in the page coalescing code
- Don't busy wait on SIGKILL in the file locking code
----------------------------------------------------------------
David Jeffery (1):
nfs: Don't busy-wait on SIGKILL in __nfs_iocounter_wait
Weston Andros Adamson (7):
nfs: change nfs_page_group_lock argument
nfs: fix nonblocking calls to nfs_page_group_lock
nfs: use blocking page_group_lock in add_request
nfs: fix error handling in lock_and_join_requests
nfs: don't sleep with inode lock in lock_and_join_requests
nfs: disallow duplicate pages in pgio page vectors
nfs: can_coalesce_requests must enforce contiguity
fs/nfs/pagelist.c | 84 ++++++++++++++++++++++++++++++++++--------------
fs/nfs/write.c | 21 +++++++++---
include/linux/nfs_page.h | 1 +
3 files changed, 77 insertions(+), 29 deletions(-)
--
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@primarydata.com
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [GIT PULL] Please pull NFS client fixes
2014-02-19 14:13 Trond Myklebust
@ 2014-02-19 14:40 ` Trond Myklebust
0 siblings, 0 replies; 22+ messages in thread
From: Trond Myklebust @ 2014-02-19 14:40 UTC (permalink / raw)
To: Torvalds Linus; +Cc: Linux Kernel mailing list, Linux NFS Mailing List
On Feb 19, 2014, at 9:13, Trond Myklebust <trond.myklebust@primarydata.com> wrote:
> Hi Linus,
>
> The following changes since commit b28a960c42fcd9cfc987441fa6d1c1a471f0f9ed:
>
> Linux 3.14-rc2 (2014-02-09 18:15:47 -0800)
>
> are available in the git repository at:
>
> git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.14-4
>
> for you to fetch changes up to 2564f0dc58962a08abc960fca820e344f61981ed:
Doh… The very last patch in the series was misapplied. I’ve fixed it up and pushed out a new tag using —force. It being 6:40 am in Oregon, hopefully you still haven’t applied the bad patch…
nfs-for-3.14-4 should now point to commit 146d70caaa1b87f64597743429d7da4b8073d0c9, which has Andy’s patch applied correctly.
Apologies…
Trond
>
> NFS fix error return in nfs4_select_rw_stateid (2014-02-18 11:33:03 -0500)
>
> ----------------------------------------------------------------
> NFS client bugfixes for Linux 3.14
>
> Highlights include stable fixes for the following bugs:
>
> - General performance regression due to NFS_INO_INVALID_LABEL being set
> when the server doesn't support labeled NFS
> - Hang in the RPC code due to a socket out-of-buffer race
> - Infinite loop when trying to establish the NFSv4 lease
> - Use-after-free bug in the RPCSEC gss code.
> - nfs4_select_rw_stateid is returning with a non-zero error value on success
>
> Other bug fixes:
>
> - Potential memory scribble in the RPC bi-directional RPC code
> - Pipe version reference leak
> - Use the correct net namespace in the new NFSv4 migration code
>
> ----------------------------------------------------------------
> Andy Adamson (1):
> NFS fix error return in nfs4_select_rw_stateid
>
> Trond Myklebust (7):
> NFS: Do not set NFS_INO_INVALID_LABEL unless server supports labeled NFS
> SUNRPC: Don't create a gss auth cache unless rpc.gssd is running
> SUNRPC: Fix races in xs_nospace()
> SUNRPC: Fix potential memory scribble in xprt_free_bc_request()
> SUNRPC: Ensure that gss_auth isn't freed before its upcall messages
> SUNRPC: Fix a pipe_version reference leak
> NFSv4: Use the correct net namespace in nfs4_update_server
>
> fs/nfs/inode.c | 14 ++++++++++----
> fs/nfs/internal.h | 12 +++++++++++-
> fs/nfs/nfs4client.c | 7 ++++---
> fs/nfs/nfs4namespace.c | 12 ++++++------
> fs/nfs/nfs4state.c | 1 +
> net/sunrpc/auth_gss/auth_gss.c | 19 ++++++++++++++++---
> net/sunrpc/backchannel_rqst.c | 6 ++++--
> net/sunrpc/xprtsock.c | 6 +++++-
> 8 files changed, 57 insertions(+), 20 deletions(-)
>
> --
> Trond Myklebust
> Linux NFS client maintainer, PrimaryData
> trond.myklebust@primarydata.com
>
_________________________________
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@primarydata.com
^ permalink raw reply [flat|nested] 22+ messages in thread
* [GIT PULL] Please pull NFS client fixes
@ 2014-02-19 14:13 Trond Myklebust
2014-02-19 14:40 ` Trond Myklebust
0 siblings, 1 reply; 22+ messages in thread
From: Trond Myklebust @ 2014-02-19 14:13 UTC (permalink / raw)
To: Torvalds Linus; +Cc: Linux Kernel mailing list, Linux NFS Mailing List
[-- Attachment #1: Type: text/plain, Size: 2290 bytes --]
Hi Linus,
The following changes since commit b28a960c42fcd9cfc987441fa6d1c1a471f0f9ed:
Linux 3.14-rc2 (2014-02-09 18:15:47 -0800)
are available in the git repository at:
git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.14-4
for you to fetch changes up to 2564f0dc58962a08abc960fca820e344f61981ed:
NFS fix error return in nfs4_select_rw_stateid (2014-02-18 11:33:03 -0500)
----------------------------------------------------------------
NFS client bugfixes for Linux 3.14
Highlights include stable fixes for the following bugs:
- General performance regression due to NFS_INO_INVALID_LABEL being set
when the server doesn't support labeled NFS
- Hang in the RPC code due to a socket out-of-buffer race
- Infinite loop when trying to establish the NFSv4 lease
- Use-after-free bug in the RPCSEC gss code.
- nfs4_select_rw_stateid is returning with a non-zero error value on success
Other bug fixes:
- Potential memory scribble in the RPC bi-directional RPC code
- Pipe version reference leak
- Use the correct net namespace in the new NFSv4 migration code
----------------------------------------------------------------
Andy Adamson (1):
NFS fix error return in nfs4_select_rw_stateid
Trond Myklebust (7):
NFS: Do not set NFS_INO_INVALID_LABEL unless server supports labeled NFS
SUNRPC: Don't create a gss auth cache unless rpc.gssd is running
SUNRPC: Fix races in xs_nospace()
SUNRPC: Fix potential memory scribble in xprt_free_bc_request()
SUNRPC: Ensure that gss_auth isn't freed before its upcall messages
SUNRPC: Fix a pipe_version reference leak
NFSv4: Use the correct net namespace in nfs4_update_server
fs/nfs/inode.c | 14 ++++++++++----
fs/nfs/internal.h | 12 +++++++++++-
fs/nfs/nfs4client.c | 7 ++++---
fs/nfs/nfs4namespace.c | 12 ++++++------
fs/nfs/nfs4state.c | 1 +
net/sunrpc/auth_gss/auth_gss.c | 19 ++++++++++++++++---
net/sunrpc/backchannel_rqst.c | 6 ++++--
net/sunrpc/xprtsock.c | 6 +++++-
8 files changed, 57 insertions(+), 20 deletions(-)
--
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@primarydata.com
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread
* [GIT PULL] Please pull NFS client fixes
@ 2014-02-04 16:52 Trond Myklebust
0 siblings, 0 replies; 22+ messages in thread
From: Trond Myklebust @ 2014-02-04 16:52 UTC (permalink / raw)
To: Torvalds Linus; +Cc: Linux NFS Mailing List, Linux Kernel mailing list
Hi Linus,
The following changes since commit 8a1f006ad302ea178aefb1f8c67e679c696289e9:
Merge tag 'nfs-for-3.14-2' of git://git.linux-nfs.org/projects/trondmy/linux-nfs (2014-01-31 15:39:07 -0800)
are available in the git repository at:
git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.14-3
for you to fetch changes up to 88a78a912ee059467ae6db7429a6efe4654620a5:
Merge branch 'acl_fixes' into linux-next (2014-02-03 17:13:45 -0500)
----------------------------------------------------------------
NFS client bugfixes for Linux 3.14
Highlights:
- Fix NFSv3 acl regressions
- Fix NFSv4 memory corruption due to slot table abuse in nfs4_proc_open_confirm
- nfs4_destroy_session must call rpc_destroy_waitqueue
----------------------------------------------------------------
Noah Massey (1):
nfs: fix setting of ACLs on file creation.
Trond Myklebust (6):
NFSv4: Fix memory corruption in nfs4_proc_open_confirm
NFSv4.1: nfs4_destroy_session must call rpc_destroy_waitqueue
NFSv3: Remove unused function nfs3_proc_set_default_acl
NFSv3: Fix return value of nfs3_proc_setacls
fs: get_acl() must be allowed to return EOPNOTSUPP
Merge branch 'acl_fixes' into linux-next
fs/nfs/nfs3acl.c | 34 ++++++++++++----------------------
fs/nfs/nfs4client.c | 2 +-
fs/nfs/nfs4proc.c | 8 ++++----
fs/nfs/nfs4session.c | 25 ++++++++++++++++++++-----
fs/nfs/nfs4session.h | 2 +-
fs/posix_acl.c | 18 ++++++++++++------
include/linux/nfs_xdr.h | 2 ++
7 files changed, 52 insertions(+), 39 deletions(-)
--
Trond Myklebust
Linux NFS client maintainer
^ permalink raw reply [flat|nested] 22+ messages in thread
* [GIT PULL] Please pull NFS client fixes
@ 2013-07-19 19:27 ` Myklebust, Trond
0 siblings, 0 replies; 22+ messages in thread
From: Myklebust, Trond @ 2013-07-19 19:27 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Linux NFS mailing list, Linux linux-kernel
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1215 bytes --]
Hi Linus,
The following changes since commit ad81f0545ef01ea651886dddac4bef6cec930092:
Linux 3.11-rc1 (2013-07-14 15:18:27 -0700)
are available in the git repository at:
git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.11-3
for you to fetch changes up to b4a2cf76ab7c08628c62b2062dacefa496b59dfd:
NFSv4: Fix a regression against the FreeBSD server (2013-07-17 16:54:46 -0400)
----------------------------------------------------------------
NFS client bugfixes for 3.11
- Fix a regression against NFSv4 FreeBSD servers when creating a new file
- Fix another regression in rpc_client_register()
----------------------------------------------------------------
Trond Myklebust (2):
SUNRPC: Fix another issue with rpc_client_register()
NFSv4: Fix a regression against the FreeBSD server
fs/nfs/nfs4xdr.c | 21 ++++++++++++++-------
net/sunrpc/clnt.c | 1 +
2 files changed, 15 insertions(+), 7 deletions(-)
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@netapp.com
www.netapp.com
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
^ permalink raw reply [flat|nested] 22+ messages in thread
* [GIT PULL] Please pull NFS client fixes
@ 2013-07-19 19:27 ` Myklebust, Trond
0 siblings, 0 replies; 22+ messages in thread
From: Myklebust, Trond @ 2013-07-19 19:27 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Linux NFS mailing list, Linux linux-kernel
SGkgTGludXMsDQoNClRoZSBmb2xsb3dpbmcgY2hhbmdlcyBzaW5jZSBjb21taXQgYWQ4MWYwNTQ1
ZWYwMWVhNjUxODg2ZGRkYWM0YmVmNmNlYzkzMDA5MjoNCg0KICBMaW51eCAzLjExLXJjMSAoMjAx
My0wNy0xNCAxNToxODoyNyAtMDcwMCkNCg0KYXJlIGF2YWlsYWJsZSBpbiB0aGUgZ2l0IHJlcG9z
aXRvcnkgYXQ6DQoNCiAgZ2l0Oi8vZ2l0LmxpbnV4LW5mcy5vcmcvcHJvamVjdHMvdHJvbmRteS9s
aW51eC1uZnMuZ2l0IHRhZ3MvbmZzLWZvci0zLjExLTMNCg0KZm9yIHlvdSB0byBmZXRjaCBjaGFu
Z2VzIHVwIHRvIGI0YTJjZjc2YWI3YzA4NjI4YzYyYjIwNjJkYWNlZmE0OTZiNTlkZmQ6DQoNCiAg
TkZTdjQ6IEZpeCBhIHJlZ3Jlc3Npb24gYWdhaW5zdCB0aGUgRnJlZUJTRCBzZXJ2ZXIgKDIwMTMt
MDctMTcgMTY6NTQ6NDYgLTA0MDApDQoNCi0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0NCk5GUyBjbGllbnQgYnVnZml4ZXMgZm9y
IDMuMTENCg0KLSBGaXggYSByZWdyZXNzaW9uIGFnYWluc3QgTkZTdjQgRnJlZUJTRCBzZXJ2ZXJz
IHdoZW4gY3JlYXRpbmcgYSBuZXcgZmlsZQ0KLSBGaXggYW5vdGhlciByZWdyZXNzaW9uIGluIHJw
Y19jbGllbnRfcmVnaXN0ZXIoKQ0KDQotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tDQpUcm9uZCBNeWtsZWJ1c3QgKDIpOg0KICAg
ICAgU1VOUlBDOiBGaXggYW5vdGhlciBpc3N1ZSB3aXRoIHJwY19jbGllbnRfcmVnaXN0ZXIoKQ0K
ICAgICAgTkZTdjQ6IEZpeCBhIHJlZ3Jlc3Npb24gYWdhaW5zdCB0aGUgRnJlZUJTRCBzZXJ2ZXIN
Cg0KIGZzL25mcy9uZnM0eGRyLmMgIHwgMjEgKysrKysrKysrKysrKystLS0tLS0tDQogbmV0L3N1
bnJwYy9jbG50LmMgfCAgMSArDQogMiBmaWxlcyBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCA3
IGRlbGV0aW9ucygtKQ0KDQotLSANClRyb25kIE15a2xlYnVzdA0KTGludXggTkZTIGNsaWVudCBt
YWludGFpbmVyDQoNCk5ldEFwcA0KVHJvbmQuTXlrbGVidXN0QG5ldGFwcC5jb20NCnd3dy5uZXRh
cHAuY29tDQo=
^ permalink raw reply [flat|nested] 22+ messages in thread
* [GIT PULL] Please pull NFS client fixes
@ 2013-04-10 15:59 Myklebust, Trond
0 siblings, 0 replies; 22+ messages in thread
From: Myklebust, Trond @ 2013-04-10 15:59 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Mailing List Linux NFS, Linux linux-kernel
Hi Linus,
The following changes since commit 1166fde6a923c30f4351515b6a9a1efc513e7d00:
SUNRPC: Add barriers to ensure read ordering in rpc_wake_up_task_queue_locked (2013-03-25 11:23:40 -0400)
are available in the git repository at:
git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.9-4
for you to fetch changes up to fa332941c0c7c00e3420078268b7558d0ef792b5:
NFSv4: Fix another potential state manager deadlock (2013-04-09 13:19:35 -0400)
----------------------------------------------------------------
NFS client bugfixes for Linux 3.9
- Stable fix for memory corruption issues in nfs4[01]_walk_client_list
- Stable fix for an Oopsable bug in rpc_clone_client
- Another state manager deadlock in the NFSv4 open code
- Memory leaks in nfs4_discover_server_trunking and rpc_new_client
----------------------------------------------------------------
Chuck Lever (1):
SUNRPC: Remove extra xprt_put()
Trond Myklebust (4):
NFSv4: Fix a memory leak in nfs4_discover_server_trunking
NFSv4/4.1: Fix bugs in nfs4[01]_walk_client_list
SUNRPC: Fix a potential memory leak in rpc_new_client
NFSv4: Fix another potential state manager deadlock
fs/nfs/nfs4client.c | 44 ++++++++++++++++++++++++++++----------------
fs/nfs/nfs4proc.c | 1 +
fs/nfs/nfs4state.c | 8 +++++++-
net/sunrpc/clnt.c | 11 +++--------
4 files changed, 39 insertions(+), 25 deletions(-)
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@netapp.com
www.netapp.com
^ permalink raw reply [flat|nested] 22+ messages in thread
* [GIT PULL] Please pull NFS client fixes
@ 2012-08-22 15:41 Myklebust, Trond
0 siblings, 0 replies; 22+ messages in thread
From: Myklebust, Trond @ 2012-08-22 15:41 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Linux NFS mailing list, Linux Kernel mailing list
[-- Attachment #1: Type: text/plain, Size: 3081 bytes --]
Hi Linus,
The following changes since commit 2d534926205db9ffce4bbbde67cb9b2cee4b835c:
Merge tag 'irqdomain-for-linus' of git://git.secretlab.ca/git/linux-2.6 (2012-07-31 20:44:03 -0700)
are available in the git repository at:
git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.6-3
for you to fetch changes up to 086600430493e04b802bee6e5b3ce0458e4eb77f:
NFSv3: Ensure that do_proc_get_root() reports errors correctly (2012-08-20 12:52:42 -0400)
----------------------------------------------------------------
NFS client bugfixes for Linux 3.6
- NFSv3 mounts need to fail if the FSINFO rpc call fails
- Ensure that the NFS commit cache gets torn down when we unload the
NFS module.
- Fix memory scribble issues when interrupting a LAYOUTGET rpc call
- Fix NFSv4 legacy idmapper regressions
- Fix issues with the NFSv4 getacl command
- Fix a regression when using the legacy "mount -t nfs4"
----------------------------------------------------------------
Boaz Harrosh (1):
pnfs-obj: Better IO pattern in case of unaligned offset
Bryan Schumaker (2):
NFS: Clear key construction data if the idmap upcall fails
NFS: return -ENOKEY when the upcall fails to map the name
Idan Kedar (2):
pnfs: defer release of pages in layoutget
pnfs: nfs4_proc_layoutget returns void
Jeff Layton (1):
nfs: tear down caches in nfs_init_writepagecache when allocation fails
Peng Tao (1):
NFS41: add pg_layout_private to nfs_pageio_descriptor
Trond Myklebust (6):
NFSv4.1: Remove a bogus BUG_ON() in nfs4_layoutreturn_done
NFSv4: Fix pointer arithmetic in decode_getacl
NFSv4: Fix the acl cache size calculation
NFSv4: Don't use private xdr_stream fields in decode_getacl
NFSv4: Ensure that nfs4_alloc_client cleans up on error.
NFSv3: Ensure that do_proc_get_root() reports errors correctly
bjschuma@gmail.com (2):
NFS: Fix a regression when loading the NFS v4 module
NFS: Alias the nfs module to nfs4
fs/nfs/Makefile | 18 +++++------
fs/nfs/client.c | 2 +-
fs/nfs/idmap.c | 62 +++++++++++++++++++++++++-----------
fs/nfs/nfs3proc.c | 2 +-
fs/nfs/nfs4_fs.h | 3 ++
fs/nfs/nfs4client.c | 2 +-
fs/nfs/nfs4proc.c | 76 +++++++++++++++++++++++++++++++++++++-------
fs/nfs/nfs4super.c | 15 ---------
fs/nfs/nfs4xdr.c | 26 ++++++---------
fs/nfs/objlayout/objio_osd.c | 55 ++++++++++++++++++++++++++++++--
fs/nfs/pagelist.c | 2 ++
fs/nfs/pnfs.c | 39 +----------------------
fs/nfs/pnfs.h | 2 +-
fs/nfs/super.c | 39 ++++++++++++++++++++++-
fs/nfs/write.c | 15 +++++++--
include/linux/nfs_page.h | 1 +
include/linux/nfs_xdr.h | 1 +
17 files changed, 241 insertions(+), 119 deletions(-)
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@netapp.com
www.netapp.com
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread
* [GIT PULL] Please pull NFS client fixes
@ 2011-06-21 18:36 Trond Myklebust
0 siblings, 0 replies; 22+ messages in thread
From: Trond Myklebust @ 2011-06-21 18:36 UTC (permalink / raw)
To: Linus Torvalds
Hi Linus,
Bakeathon testing in Ann Arbor last week uncovered a number of bugs
in the existing NFS code (mainly in NFSv4.1).
Please pull from the "bugfixes" branch of the repository at
git pull git://git.linux-nfs.org/projects/trondmy/nfs-2.6.git bugfixes
This will update the following files through the appended changesets.
Cheers,
Trond
----
fs/lockd/clntproc.c | 8 ++++++-
fs/nfs/inode.c | 6 +++-
fs/nfs/internal.h | 11 +++++++++
fs/nfs/nfs4filelayout.c | 21 ++++++++++++------
fs/nfs/nfs4proc.c | 45 ++++++++++++++++++++++++----------------
fs/nfs/nfs4xdr.c | 26 ++++++++++++----------
fs/nfs/objlayout/objio_osd.c | 4 ++-
fs/nfs/objlayout/objlayout.c | 2 +-
fs/nfs/pagelist.c | 3 +-
fs/nfs/pnfs.c | 44 +++++++++++++++++++++++++++-----------
fs/nfs/pnfs.h | 1 +
fs/nfs/pnfs_dev.c | 17 ++++++++++----
include/linux/nfs_page.h | 3 ++
include/linux/nfs_xdr.h | 1 -
include/linux/sunrpc/sched.h | 3 +-
net/sunrpc/auth_gss/auth_gss.c | 4 +-
net/sunrpc/clnt.c | 5 +++-
net/sunrpc/sched.c | 1 +
18 files changed, 139 insertions(+), 66 deletions(-)
commit 1650add23578b5ca35c1f1e863987180a8c03779
Author: Bryan Schumaker <bjschuma@netapp.com>
Date: Thu Jun 2 15:07:35 2011 -0400
NFS: Fix decode_secinfo_maxsz
I initially did the calculation in bytes, and not words
Signed-off-by: Bryan Schumaker <bjschuma@netapp.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
commit 19982ba8562e33083cb5bbb59a74855d8a9624ea
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date: Fri Jun 10 13:30:23 2011 -0400
NFSv4.1: Fix an off-by-one error in pnfs_generic_pg_test
And document what is going on there...
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
commit 8f7d5efbef8718a774ac5e347b4ec069f17fd9b4
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date: Fri Jun 10 13:30:22 2011 -0400
NFSv4.1: Fix some issues with pnfs_generic_pg_test
1. If the intention is to coalesce requests 'prev' and 'req' then we
have to ensure at least that we have a layout starting at
req_offset(prev).
2. If we're only requesting a minimal layout of length desc->pg_count,
we need to test the length actually returned by the server before
we allow the coalescing to occur.
3. We need to deal correctly with (pgio->lseg == NULL)
4. Fixup the test guarding the pnfs_update_layout.
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
commit 19345cb299e8234006c5125151ab723e851a1d24
Author: Benny Halevy <benny@tonian.com>
Date: Sun Jun 19 18:33:46 2011 -0400
NFSv4.1: file layout must consider pg_bsize for coalescing
Otherwise we end up overflowing the rpc buffer size on the receive end.
Signed-off-by: Benny Halevy <benny@tonian.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
commit df18d127f4fed7a0284bcfa8d2843800cdb63b72
Author: Boaz Harrosh <bharrosh@panasas.com>
Date: Fri Jun 17 16:25:51 2011 -0400
pnfs-obj: No longer needed to take an extra ref at add_device
Andy's last device_cache patches, already take an extra
reference on the newly inserted device_id. So we can remove it
from obj-io.
Without this patch the device_ids are leaked.
Andy's patches are not in Linus tree yet. So I'm not sure if they are
scheduled for this Kernel or the next. This patch should be added as
part of these.
CC: Andy Adamson <andros@netapp.com>
Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
commit 5afa9133cfe67f1bfead6049a9640c9262a7101c
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date: Fri Jun 17 10:14:59 2011 -0400
SUNRPC: Ensure the RPC client only quits on fatal signals
Fix a couple of instances where we were exiting the RPC client on
arbitrary signals. We should only do so on fatal signals.
Cc: stable@kernel.org
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
commit ee7b75fc4f3ae49e1f25bf56219bb5de3c29afaf
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date: Thu Jun 16 13:15:41 2011 -0400
NFSv4: Fix a readdir regression
Commit 7ebb9315 (NFS: use secinfo when crossing mountpoints) introduces
a regression when decoding an NFSv4 readdir entry that sets the
rdattr_error field.
By treating the resulting value as if it is a decoding error, the current
code may cause us to skip valid readdir entries.
Reported-by: Andy Adamson <andros@netapp.com>
Cc: stable@kernel.org [2.6.39]
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
commit 9e2dfdb3081edfae66a49013517e80dd8a0469fa
Author: Fred Isaman <iisaman@netapp.com>
Date: Wed Jun 15 14:32:02 2011 -0400
nfs4.1: mark layout as bad on error path in _pnfs_return_layout
Signed-off-by: Fred Isaman <iisaman@netapp.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
commit ea0ded748bdea78f9e2fefb571f7d6ce9edb4f89
Author: Fred Isaman <iisaman@netapp.com>
Date: Wed Jun 15 12:31:02 2011 -0400
nfs4.1: prevent race that allowed use of freed layout in _pnfs_return_layout
mark_matching_lsegs_invalid could put the last ref to the layout, so
the get_layout_hdr needs to be called first.
Signed-off-by: Fred Isaman <iisaman@netapp.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
commit 1ed3a8539af7b36aa5c977f304e80f7fc8d27bfc
Author: Benny Halevy <benny@tonian.com>
Date: Wed Jun 15 11:39:57 2011 -0400
NFSv4.1: need to put_layout_hdr on _pnfs_return_layout error path
We always get a reference on the layout header and we rely on
nfs4_layoutreturn_release to put it. If we hit an allocation error
before starting the rpc proc we bail out early without dereferncing
the layout header properly.
Signed-off-by: Benny Halevy <benny@tonian.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
commit c7fd06228b994190d8369a2a0acf5224e4e13d1a
Author: David Howells <dhowells@redhat.com>
Date: Wed Jun 15 00:55:44 2011 +0100
NFS: (d)printks should use %zd for ssize_t arguments
(d)printks should use %zd for ssize_t arguments not %ld, otherwise they might
get a warning. I see the following with MN10300.
fs/nfs/objlayout/objlayout.c: In function 'objlayout_read_done':
fs/nfs/objlayout/objlayout.c:294: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t'
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Trond Myklebust <Trond.Myklebust@netapp.com>
cc: linux-nfs@vger.kernel.org
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
commit d771e3a43e23a37398b7e05a9d1b1036d698263c
Author: Benny Halevy <benny@tonian.com>
Date: Tue Jun 14 16:30:16 2011 -0400
NFSv4.1: fix break condition in pnfs_find_lseg
The break condition to skip out of the loop got broken when cmp_layout
was change. Essentially, we want to stop looking once we know no layout
on the remainder of the list can match the first byte of the looked-up
range.
Reported-by: Peng Tao <peng_tao@emc.com>
Signed-off-by: Benny Halevy <benny@tonian.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
commit a2e1d4f2e5ed83850de92a491ef225824cb457bd
Author: Fred Isaman <iisaman@netapp.com>
Date: Mon Jun 13 18:54:53 2011 -0400
nfs4.1: fix several problems with _pnfs_return_layout
_pnfs_return_layout had the following problems:
- it did not call pnfs_free_lseg_list on all paths
- it unintentionally did a forgetful return when there was no outstanding io
- it raced with concurrent LAYOUTGETS
Signed-off-by: Fred Isaman <iisaman@netapp.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
commit cec765cf5891c7fc3d905832b481bfb6fd55825d
Author: Andy Adamson <andros@netapp.com>
Date: Mon Jun 13 18:36:17 2011 -0400
NFSv4.1: allow zero fh array in filelayout decode layout
Signed-off-by: Andy Adamson <andros@netapp.com>
cc:stable@kernel.org [2.6.39]
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
commit 533eb4611c9eea53072eb6a61d5a6393b6a77ed7
Author: Andy Adamson <andros@netapp.com>
Date: Mon Jun 13 18:25:56 2011 -0400
NFSv4.1: allow nfs_fhget to succeed with mounted on fileid
Commit 28331a46d88459788c8fca72dbb0415cd7f514c9 "Ensure we request the
ordinary fileid when doing readdirplus"
changed the meaning of NFS_ATTR_FATTR_FILEID which used to be set when
FATTR4_WORD1_MOUNTED_ON_FILED was requested.
Allow nfs_fhget to succeed with only a mounted on fileid when crossing
a mountpoint or a referral.
Ask for the fileid of the absent file system if mounted_on_fileid is not
supported.
Signed-off-by: Andy Adamson <andros@netapp.com>
cc:stable@kernel.org [2.6.39]
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
commit 1d92a08da23848a38eece4df7eaa4e8ec0e6c699
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date: Tue Jun 14 12:07:38 2011 -0400
NFSv4.1: Fix a refcounting issue in the pNFS device id cache
When we add something to the global device id cache, we need to bump the
reference count, so that the cache itself holds a reference.
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
commit c9c30dd5f73dccaa326a54dfcf490316946aea87
Author: Benny Halevy <benny@tonian.com>
Date: Sat Jun 11 17:08:39 2011 -0400
NFSv4.1: deprecate headerpadsz in CREATE_SESSION
We don't support header padding yet so better off ditching it
Reported-by: Sid Moore <learnmost@gmail.com>
Signed-off-by: Benny Halevy <benny@tonian.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
commit 0f66b5984df2fe1617c05900a39a7ef493ca9de9
Author: Peng Tao <bergwolf@gmail.com>
Date: Sat Oct 16 22:07:46 2010 -0700
NFS41: do not update isize if inode needs layoutcommit
nfs_update_inode will update isize if there is no queued pages. For pNFS,
layoutcommit is supposed to change file size on server, the same effect as queued
pages. nfs_update_inode may be called when dirty pages are written back (nfsi->npages==0)
but layoutcommit is not sent, and it will change client file size according to server
file size. Then client ends up losing what it just writes back in pNFS path.
So we should skip updating client file size if file needs layoutcommit.
Signed-off-by: Peng Tao <peng_tao@emc.com>
Cc: stable@kernel.org [2.6.39]
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
commit 0b760113a3a155269a3fba93a409c640031dd68f
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date: Tue May 31 15:15:34 2011 -0400
NLM: Don't hang forever on NLM unlock requests
If the NLM daemon is killed on the NFS server, we can currently end up
hanging forever on an 'unlock' request, instead of aborting. Basically,
if the rpcbind request fails, or the server keeps returning garbage, we
really want to quit instead of retrying.
Tested-by: Vasily Averin <vvs@sw.ru>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: stable@kernel.org
commit 9e3bd4e24e94d60d2e0762e919aab6c9a7fc0c5b
Author: Weston Andros Adamson <dros@netapp.com>
Date: Tue May 31 21:46:50 2011 -0400
NFS: fix umount of pnfs filesystems
Unmounting a pnfs filesystem hangs using filelayout and possibly others.
This fixes the use of the rcu protected node by making use of a new 'tmpnode'
for the temporary purge list. Also, the spinlock shouldn't be held when calling
synchronize_rcu().
Signed-off-by: Weston Andros Adamson <dros@netapp.com>
Signed-off-by: Andy Adamson <andros@netapp.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@netapp.com
www.netapp.com
^ permalink raw reply [flat|nested] 22+ messages in thread
* [GIT PULL] Please pull NFS client fixes
@ 2010-12-10 18:05 Trond Myklebust
0 siblings, 0 replies; 22+ messages in thread
From: Trond Myklebust @ 2010-12-10 18:05 UTC (permalink / raw)
To: Linus Torvalds; +Cc: linux-kernel, linux-nfs
Resending pull request after appending Chuck's fix for the nfs_umount() panic.
-----------------------------------------------------------------------------
Hi Linus,
Please pull from the "bugfixes" branch of the repository at
git pull git://git.linux-nfs.org/projects/trondmy/nfs-2.6.git bugfixes
This will update the following files through the appended changesets.
Cheers,
Trond
----
Documentation/filesystems/Locking | 7 +++-
Documentation/filesystems/vfs.txt | 7 +++
fs/nfs/dir.c | 76 +++++++++++++++++--------------------
fs/nfs/file.c | 2 +
fs/nfs/inode.c | 1 +
fs/nfs/mount_clnt.c | 4 +-
fs/nfs/nfs4proc.c | 9 ++++
fs/nfs/pagelist.c | 4 +-
fs/nfs/read.c | 1 -
fs/nfs/super.c | 4 --
fs/nfs/write.c | 3 +-
include/linux/fs.h | 1 +
include/linux/nfs_fs.h | 1 +
include/linux/nfs_page.h | 1 +
mm/filemap.c | 5 ++
mm/truncate.c | 4 ++
mm/vmscan.c | 7 +++
17 files changed, 85 insertions(+), 52 deletions(-)
commit 5b362ac3799ff4225c40935500f520cad4d7ed66
Author: Chuck Lever <chuck.lever@oracle.com>
Date: Fri Dec 10 12:31:14 2010 -0500
NFS: Fix panic after nfs_umount()
After a few unsuccessful NFS mount attempts in which the client and
server cannot agree on an authentication flavor both support, the
client panics. nfs_umount() is invoked in the kernel in this case.
Turns out nfs_umount()'s UMNT RPC invocation causes the RPC client to
write off the end of the rpc_clnt's iostat array. This is because the
mount client's nrprocs field is initialized with the count of defined
procedures (two: MNT and UMNT), rather than the size of the client's
proc array (four).
The fix is to use the same initialization technique used by most other
upper layer clients in the kernel.
Introduced by commit 0b524123, which failed to update nrprocs when
support was added for UMNT in the kernel.
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=24302
BugLink: http://bugs.launchpad.net/bugs/683938
Reported-by: Stefan Bader <stefan.bader@canonical.com>
Tested-by: Stefan Bader <stefan.bader@canonical.com>
Cc: stable@kernel.org # >= 2.6.32
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
commit 2df485a774ba59c3f43bfe84107672c1d9b731a0
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date: Tue Dec 7 22:39:17 2010 -0500
nfs: remove extraneous and problematic calls to nfs_clear_request
When a nfs_page is freed, nfs_free_request is called which also calls
nfs_clear_request to clean out the lock and open contexts and free the
pagecache page.
However, a couple of places in the nfs code call nfs_clear_request
themselves. What happens here if the refcount on the request is still high?
We'll be releasing contexts and freeing pointers while the request is
possibly still in use.
Remove those bare calls to nfs_clear_context. That should only be done when
the request is being freed.
Note that when doing this, we need to watch out for tests of req->wb_page.
Previously, nfs_set_page_tag_locked() and nfs_clear_page_tag_locked()
would check the value of req->wb_page to figure out if the page is mapped
into the nfsi->nfs_page_tree. We now indicate the page is mapped using
the new bit PG_MAPPED in req->wb_flags .
Reported-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
commit 0de1b7e800188782973598158e0acbb9e08e6c99
Author: Mi Jinlong <mijinlong@cn.fujitsu.com>
Date: Sat Oct 30 10:19:33 2010 +0800
nfs: kernel should return EPROTONOSUPPORT when not support NFSv4
When nfs client(kernel) don't support NFSv4, maybe user build
kernel without NFSv4, there is a problem.
Using command "mount SERVER-IP:/nfsv3 /mnt/" to mount NFSv3
filesystem, mount should should success, but fail and get error:
"mount.nfs: an incorrect mount option was specified"
System call mount "nfs"(not "nfs4") with "vers=4",
if CONFIG_NFS_V4 is not defined, the "vers=4" will be parsed
as invalid argument and kernel return EINVAL to nfs-utils.
About that, we really want get EPROTONOSUPPORT rather than
EINVAL. This path make sure kernel parses argument success,
and return EPROTONOSUPPORT at nfs_validate_mount_data().
Signed-off-by: Mi Jinlong <mijinlong@cn.fujitsu.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
commit 21ac19d484a8ffb66f64487846c8d53afef04d2b
Author: Sergey Vlasov <vsu@altlinux.ru>
Date: Sun Nov 28 21:04:05 2010 +0000
NFS: Fix fcntl F_GETLK not reporting some conflicts
The commit 129a84de2347002f09721cda3155ccfd19fade40 (locks: fix F_GETLK
regression (failure to find conflicts)) fixed the posix_test_lock()
function by itself, however, its usage in NFS changed by the commit
9d6a8c5c213e34c475e72b245a8eb709258e968c (locks: give posix_test_lock
same interface as ->lock) remained broken - subsequent NFS-specific
locking code received F_UNLCK instead of the user-specified lock type.
To fix the problem, fl->fl_type needs to be saved before the
posix_test_lock() call and restored if no local conflicts were reported.
Reference: https://bugzilla.kernel.org/show_bug.cgi?id=23892
Tested-by: Alexander Morozov <amorozov@etersoft.ru>
Signed-off-by: Sergey Vlasov <vsu@altlinux.ru>
Cc: <stable@kernel.org>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
commit 08a22b392a141c201d7ed4d435de942aa853acd3
Author: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Date: Wed Dec 1 10:42:16 2010 +0000
nfs: Discard ACL cache on mode update
An update of mode bits can result in ACL value being changed. We need
to mark the acl cache invalid when we update mode. Similarly we need
to update file attribute when we change ACL value
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
commit 47c716cbf638a16583441d78be3fc24345eab636
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date: Tue Dec 7 12:44:56 2010 -0500
NFS: Readdir cleanups
No functional changes, but clarify the code.
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
commit 18fb5fe40ce7f789b5cfc3aa81ff1e6175b0a5be
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date: Tue Dec 7 12:41:58 2010 -0500
NFS: nfs_readdir_search_for_cookie() don't mark as eof if cookie not found
If we're searching for a specific cookie, and it isn't found in the page
cache, we should try an uncached_readdir(). To do so, we return EBADCOOKIE,
but we don't set desc->eof.
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
commit 11de3b11e08cac26d59e88efaf4e316701883552
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date: Wed Dec 1 14:17:06 2010 -0500
NFS: Fix a memory leak in nfs_readdir
We need to ensure that the entries in the nfs_cache_array get cleared
when the page is removed from the page cache. To do so, we use the
freepage address_space operation.
Change nfs_readdir_clear_array to use kmap_atomic(), so that the
function can be safely called from all contexts.
Finally, modify the cache_page_release helper to call
nfs_readdir_clear_array directly, when dealing with an anonymous
page from 'uncached_readdir'.
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
commit 6072d13c429373c5d63b69dadbbef40a9b035552
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date: Wed Dec 1 13:35:19 2010 -0500
Call the filesystem back whenever a page is removed from the page cache
NFS needs to be able to release objects that are stored in the page
cache once the page itself is no longer visible from the page cache.
This patch adds a callback to the address space operations that allows
filesystems to perform page cleanups once the page has been removed
from the page cache.
Original patch by: Linus Torvalds <torvalds@linux-foundation.org>
[trondmy: cover the cases of invalidate_inode_pages2() and
truncate_inode_pages()]
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
commit 0aded708d125a3ff7e5abaea9c2d9c6d7ebbfdcd
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date: Tue Nov 30 21:56:32 2010 -0500
NFS: Ensure we use the correct cookie in nfs_readdir_xdr_filler
We need to use the cookie from the previous array entry, not the
actual cookie that we are searching for (except for the case of
uncached_readdir).
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@netapp.com
www.netapp.com
^ permalink raw reply [flat|nested] 22+ messages in thread
* [GIT PULL] Please pull NFS client fixes
@ 2010-12-09 3:11 Trond Myklebust
0 siblings, 0 replies; 22+ messages in thread
From: Trond Myklebust @ 2010-12-09 3:11 UTC (permalink / raw)
To: Linus Torvalds; +Cc: linux-kernel, linux-nfs
Hi Linus,
Please pull from the "bugfixes" branch of the repository at
git pull git://git.linux-nfs.org/projects/trondmy/nfs-2.6.git bugfixes
This will update the following files through the appended changesets.
Cheers,
Trond
----
Documentation/filesystems/Locking | 7 +++-
Documentation/filesystems/vfs.txt | 7 +++
fs/nfs/dir.c | 76 +++++++++++++++++--------------------
fs/nfs/file.c | 2 +
fs/nfs/inode.c | 1 +
fs/nfs/nfs4proc.c | 9 ++++
fs/nfs/pagelist.c | 4 +-
fs/nfs/read.c | 1 -
fs/nfs/super.c | 4 --
fs/nfs/write.c | 3 +-
include/linux/fs.h | 1 +
include/linux/nfs_fs.h | 1 +
include/linux/nfs_page.h | 1 +
mm/filemap.c | 5 ++
mm/truncate.c | 4 ++
mm/vmscan.c | 7 +++
16 files changed, 83 insertions(+), 50 deletions(-)
commit 2df485a774ba59c3f43bfe84107672c1d9b731a0
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date: Tue Dec 7 22:39:17 2010 -0500
nfs: remove extraneous and problematic calls to nfs_clear_request
When a nfs_page is freed, nfs_free_request is called which also calls
nfs_clear_request to clean out the lock and open contexts and free the
pagecache page.
However, a couple of places in the nfs code call nfs_clear_request
themselves. What happens here if the refcount on the request is still high?
We'll be releasing contexts and freeing pointers while the request is
possibly still in use.
Remove those bare calls to nfs_clear_context. That should only be done when
the request is being freed.
Note that when doing this, we need to watch out for tests of req->wb_page.
Previously, nfs_set_page_tag_locked() and nfs_clear_page_tag_locked()
would check the value of req->wb_page to figure out if the page is mapped
into the nfsi->nfs_page_tree. We now indicate the page is mapped using
the new bit PG_MAPPED in req->wb_flags .
Reported-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
commit 0de1b7e800188782973598158e0acbb9e08e6c99
Author: Mi Jinlong <mijinlong@cn.fujitsu.com>
Date: Sat Oct 30 10:19:33 2010 +0800
nfs: kernel should return EPROTONOSUPPORT when not support NFSv4
When nfs client(kernel) don't support NFSv4, maybe user build
kernel without NFSv4, there is a problem.
Using command "mount SERVER-IP:/nfsv3 /mnt/" to mount NFSv3
filesystem, mount should should success, but fail and get error:
"mount.nfs: an incorrect mount option was specified"
System call mount "nfs"(not "nfs4") with "vers=4",
if CONFIG_NFS_V4 is not defined, the "vers=4" will be parsed
as invalid argument and kernel return EINVAL to nfs-utils.
About that, we really want get EPROTONOSUPPORT rather than
EINVAL. This path make sure kernel parses argument success,
and return EPROTONOSUPPORT at nfs_validate_mount_data().
Signed-off-by: Mi Jinlong <mijinlong@cn.fujitsu.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
commit 21ac19d484a8ffb66f64487846c8d53afef04d2b
Author: Sergey Vlasov <vsu@altlinux.ru>
Date: Sun Nov 28 21:04:05 2010 +0000
NFS: Fix fcntl F_GETLK not reporting some conflicts
The commit 129a84de2347002f09721cda3155ccfd19fade40 (locks: fix F_GETLK
regression (failure to find conflicts)) fixed the posix_test_lock()
function by itself, however, its usage in NFS changed by the commit
9d6a8c5c213e34c475e72b245a8eb709258e968c (locks: give posix_test_lock
same interface as ->lock) remained broken - subsequent NFS-specific
locking code received F_UNLCK instead of the user-specified lock type.
To fix the problem, fl->fl_type needs to be saved before the
posix_test_lock() call and restored if no local conflicts were reported.
Reference: https://bugzilla.kernel.org/show_bug.cgi?id=23892
Tested-by: Alexander Morozov <amorozov@etersoft.ru>
Signed-off-by: Sergey Vlasov <vsu@altlinux.ru>
Cc: <stable@kernel.org>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
commit 08a22b392a141c201d7ed4d435de942aa853acd3
Author: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Date: Wed Dec 1 10:42:16 2010 +0000
nfs: Discard ACL cache on mode update
An update of mode bits can result in ACL value being changed. We need
to mark the acl cache invalid when we update mode. Similarly we need
to update file attribute when we change ACL value
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
commit 47c716cbf638a16583441d78be3fc24345eab636
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date: Tue Dec 7 12:44:56 2010 -0500
NFS: Readdir cleanups
No functional changes, but clarify the code.
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
commit 18fb5fe40ce7f789b5cfc3aa81ff1e6175b0a5be
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date: Tue Dec 7 12:41:58 2010 -0500
NFS: nfs_readdir_search_for_cookie() don't mark as eof if cookie not found
If we're searching for a specific cookie, and it isn't found in the page
cache, we should try an uncached_readdir(). To do so, we return EBADCOOKIE,
but we don't set desc->eof.
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
commit 11de3b11e08cac26d59e88efaf4e316701883552
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date: Wed Dec 1 14:17:06 2010 -0500
NFS: Fix a memory leak in nfs_readdir
We need to ensure that the entries in the nfs_cache_array get cleared
when the page is removed from the page cache. To do so, we use the
freepage address_space operation.
Change nfs_readdir_clear_array to use kmap_atomic(), so that the
function can be safely called from all contexts.
Finally, modify the cache_page_release helper to call
nfs_readdir_clear_array directly, when dealing with an anonymous
page from 'uncached_readdir'.
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
commit 6072d13c429373c5d63b69dadbbef40a9b035552
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date: Wed Dec 1 13:35:19 2010 -0500
Call the filesystem back whenever a page is removed from the page cache
NFS needs to be able to release objects that are stored in the page
cache once the page itself is no longer visible from the page cache.
This patch adds a callback to the address space operations that allows
filesystems to perform page cleanups once the page has been removed
from the page cache.
Original patch by: Linus Torvalds <torvalds@linux-foundation.org>
[trondmy: cover the cases of invalidate_inode_pages2() and
truncate_inode_pages()]
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
commit 0aded708d125a3ff7e5abaea9c2d9c6d7ebbfdcd
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date: Tue Nov 30 21:56:32 2010 -0500
NFS: Ensure we use the correct cookie in nfs_readdir_xdr_filler
We need to use the cookie from the previous array entry, not the
actual cookie that we are searching for (except for the case of
uncached_readdir).
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@netapp.com
www.netapp.com
^ permalink raw reply [flat|nested] 22+ messages in thread
* [GIT PULL] Please pull NFS client fixes
@ 2010-04-13 21:54 Trond Myklebust
0 siblings, 0 replies; 22+ messages in thread
From: Trond Myklebust @ 2010-04-13 21:54 UTC (permalink / raw)
To: Linus Torvalds; +Cc: linux-nfs, linux-kernel
Hi Linus,
Please pull from the "bugfixes" branch of the repository at
git pull git://git.linux-nfs.org/projects/trondmy/nfs-2.6.git bugfixes
This will update the following files through the appended changesets.
Cheers,
Trond
----
fs/nfs/client.c | 3 ++-
fs/nfs/dir.c | 2 +-
fs/nfs/inode.c | 8 ++++----
fs/nfs/nfs4proc.c | 4 +++-
fs/nfs/write.c | 44 ++++++++++++++++++++++++++++----------------
include/linux/nfs_fs_sb.h | 1 +
6 files changed, 39 insertions(+), 23 deletions(-)
commit 0df5dd4aae211edeeeb84f7f84f6d093406d7c22
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date: Sun Apr 11 16:48:44 2010 -0400
NFSv4: fix delegated locking
Arnaud Giersch reports that NFSv4 locking is broken when we hold a
delegation since commit 8e469ebd6dc32cbaf620e134d79f740bf0ebab79 (NFSv4:
Don't allow posix locking against servers that don't support it).
According to Arnaud, the lock succeeds the first time he opens the file
(since we cannot do a delegated open) but then fails after we start using
delegated opens.
The following patch fixes it by ensuring that locking behaviour is
governed by a per-filesystem capability flag that is initially set, but
gets cleared if the server ever returns an OPEN without the
NFS4_OPEN_RESULT_LOCKTYPE_POSIX flag being set.
Reported-by: Arnaud Giersch <arnaud.giersch@iut-bm.univ-fcomte.fr>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: stable@kernel.org
commit 2c61be0a9478258f77b66208a0c4b1f5f8161c3c
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date: Fri Apr 9 19:54:50 2010 -0400
NFS: Ensure that the WRITE and COMMIT RPC calls are always uninterruptible
We always want to ensure that WRITE and COMMIT completes, whether or not
the user presses ^C. Do this by making the call asynchronous, and allowing
the user to do an interruptible wait for rpc_task completion.
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
commit a6305ddb080fb483ca41ca56cacb6f96089f0c8e
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date: Fri Apr 9 19:07:08 2010 -0400
NFS: Fix a race with the new commit code
This patch fixes a race which occurs due to the fact that we release the
PG_writeback flag while still holding the nfs_page locked.
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
commit b80c3cb628f0ebc241b02e38dd028969fb8026a2
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date: Fri Apr 9 19:07:07 2010 -0400
NFS: Ensure that writeback_single_inode() calls write_inode() when syncing
Since writeback_single_inode() checks the inode->i_state flags _before_ it
flushes out the data, we need to ensure that the I_DIRTY_DATASYNC flag is
already set. Otherwise we risk not seeing a call to write_inode(), which
again means that we break fsync() et al...
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
commit 1544fa0f7a46241582abc48f07b74f3d846379e4
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date: Thu Mar 25 13:54:49 2010 -0400
NFS: Fix the mode calculation in nfs_find_open_context
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
commit 80e60639f1b7c121a7fea53920c5a4b94009361a
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date: Thu Mar 25 13:51:05 2010 -0400
NFSv4: Fall back to ordinary lookup if nfs4_atomic_open() returns EISDIR
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: stable@kernel.org
^ permalink raw reply [flat|nested] 22+ messages in thread
end of thread, other threads:[~2019-03-26 22:25 UTC | newest]
Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-31 19:47 [GIT PULL] Please pull NFS client fixes Myklebust, Trond
-- strict thread matches above, loose matches on Subject: below --
2019-03-26 20:12 Trond Myklebust
2019-03-26 22:25 ` pr-tracker-bot
2017-10-24 22:56 Trond Myklebust
2017-10-24 22:56 ` Trond Myklebust
2016-09-12 19:28 Trond Myklebust
2016-09-12 19:28 ` Trond Myklebust
2016-02-23 18:33 Trond Myklebust
2014-09-12 17:04 Trond Myklebust
2014-08-29 19:35 Trond Myklebust
2014-08-25 14:55 Trond Myklebust
2014-02-19 14:13 Trond Myklebust
2014-02-19 14:40 ` Trond Myklebust
2014-02-04 16:52 Trond Myklebust
2013-07-19 19:27 Myklebust, Trond
2013-07-19 19:27 ` Myklebust, Trond
2013-04-10 15:59 Myklebust, Trond
2012-08-22 15:41 Myklebust, Trond
2011-06-21 18:36 Trond Myklebust
2010-12-10 18:05 Trond Myklebust
2010-12-09 3:11 Trond Myklebust
2010-04-13 21:54 Trond Myklebust
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.