[PATCH 01/10] meta: add ROOT_HUB_TT config option to the usb/ehci-hcd feature

[PATCH 01/10] meta: add ROOT_HUB_TT config option to the usb/ehci-hcd feature

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@intel.com>

Add root hub transaction translator support for supporting companion
ohci/uhci controllers , which is safe even if the ehci controller
doesn't have companion controllers.

Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
---
 meta/cfg/kernel-cache/features/usb/ehci-hcd.cfg |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/meta/cfg/kernel-cache/features/usb/ehci-hcd.cfg b/meta/cfg/kernel-cache/features/usb/ehci-hcd.cfg
index 7322dc2..b977248 100644
--- a/meta/cfg/kernel-cache/features/usb/ehci-hcd.cfg
+++ b/meta/cfg/kernel-cache/features/usb/ehci-hcd.cfg
@@ -1 +1,2 @@
 CONFIG_USB_EHCI_HCD=y
+CONFIG_USB_EHCI_ROOT_HUB_TT=y
-- 
1.7.0.4

[PATCH 02/10] meta/common-pc: use usb features

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@intel.com>

Use the available ehci and uhci usb features and remove the associated
config settings from the top-level common-pc feature.

Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
---
 meta/cfg/kernel-cache/bsp/common-pc/common-pc.cfg |    5 -----
 meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc |    2 ++
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/meta/cfg/kernel-cache/bsp/common-pc/common-pc.cfg b/meta/cfg/kernel-cache/bsp/common-pc/common-pc.cfg
index d3dac93..db6ffb1 100644
--- a/meta/cfg/kernel-cache/bsp/common-pc/common-pc.cfg
+++ b/meta/cfg/kernel-cache/bsp/common-pc/common-pc.cfg
@@ -73,12 +73,7 @@ CONFIG_SERIAL_8250_CONSOLE=y
 CONFIG_VT=y
 CONFIG_VGA_CONSOLE=y
 
-CONFIG_USB_SUPPORT=y
-CONFIG_USB=y
 CONFIG_USB_DEVICEFS=y
-CONFIG_USB_EHCI_HCD=y
-CONFIG_USB_EHCI_ROOT_HUB_TT=y
-CONFIG_USB_UHCI_HCD=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_HID=y
 CONFIG_USB_HIDDEV=y
diff --git a/meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc b/meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc
index bab45e6..2338ea6 100644
--- a/meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc
+++ b/meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc
@@ -2,6 +2,8 @@ kconf hardware common-pc.cfg
 kconf hardware common-pc-gfx.cfg
 
 include cfg/boot-live.scc
+include features/usb/ehci-hcd.scc
+include features/usb/uhci-hcd.scc
 include features/intel-e1xxxx/intel-e100.scc
 include features/intel-e1xxxx/intel-e1xxxx.scc
 include features/latencytop/latencytop.scc
-- 
1.7.0.4

[PATCH 03/10] meta/common-pc-64: use usb features

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@intel.com>

Use the available ehci and uhci usb features and remove the associated
config settings from the top-level common-pc feature.

Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
---
 .../kernel-cache/bsp/common-pc-64/common-pc-64.cfg |    3 ---
 .../kernel-cache/bsp/common-pc-64/common-pc-64.scc |    2 ++
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/meta/cfg/kernel-cache/bsp/common-pc-64/common-pc-64.cfg b/meta/cfg/kernel-cache/bsp/common-pc-64/common-pc-64.cfg
index 3b2621e..8d35931 100644
--- a/meta/cfg/kernel-cache/bsp/common-pc-64/common-pc-64.cfg
+++ b/meta/cfg/kernel-cache/bsp/common-pc-64/common-pc-64.cfg
@@ -59,9 +59,6 @@ CONFIG_SERIAL_8250_CONSOLE=y
 CONFIG_SERIAL_8250_PCI=y
 CONFIG_SERIAL_8250_PNP=y
 
-CONFIG_USB=y
-CONFIG_USB_EHCI_HCD=y
-CONFIG_USB_UHCI_HCD=y
 CONFIG_USB_STORAGE=y
 # For /proc/bus/usb and lsusb.
 CONFIG_USB_DEVICEFS=y
diff --git a/meta/cfg/kernel-cache/bsp/common-pc-64/common-pc-64.scc b/meta/cfg/kernel-cache/bsp/common-pc-64/common-pc-64.scc
index b27e793..d0327c5 100644
--- a/meta/cfg/kernel-cache/bsp/common-pc-64/common-pc-64.scc
+++ b/meta/cfg/kernel-cache/bsp/common-pc-64/common-pc-64.scc
@@ -4,6 +4,8 @@ kconf hardware common-pc-64-graphics.cfg
 include cfg/boot-live.scc
 
 include features/hpet/hpet.scc
+include features/usb/ehci-hcd.scc
+include features/usb/uhci-hcd.scc
 include features/intel-e1xxxx/intel-e100.scc
 include features/intel-e1xxxx/intel-e1xxxx.scc
 
-- 
1.7.0.4

[PATCH 04/10] meta/common-pc: factor out policy-related options

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@intel.com>

Refactor bsp/common-pc/common-pc* to keep hardware-related options in
the base common-pc.scc while moving the more 'policy'-related options
into the files that include the base common-pc.scc fragment.

This allows the different kernel types to make use of the basic
machine support without dragging along possibly unwanted options that
fall under the heading of 'policy' for a specific kernel type.

Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
---
 .../bsp/common-pc/common-pc-preempt-rt.scc         |    7 +++++++
 .../bsp/common-pc/common-pc-standard.scc           |    6 ++++++
 .../kernel-cache/bsp/common-pc/common-pc-tiny.scc  |    5 +----
 meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc  |    4 ----
 4 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/meta/cfg/kernel-cache/bsp/common-pc/common-pc-preempt-rt.scc b/meta/cfg/kernel-cache/bsp/common-pc/common-pc-preempt-rt.scc
index f8716ee..706f669 100644
--- a/meta/cfg/kernel-cache/bsp/common-pc/common-pc-preempt-rt.scc
+++ b/meta/cfg/kernel-cache/bsp/common-pc/common-pc-preempt-rt.scc
@@ -4,4 +4,11 @@ define KARCH i386
 
 # no new branch required, re-use the ktypes/preempt-rt branch
 include ktypes/preempt-rt
+
 include bsp/common-pc/common-pc.scc
+
+# default policy for preempt-rt kernels
+include cfg/boot-live.scc
+include features/latencytop/latencytop.scc
+include features/profiling/profiling.scc
+include cfg/virtio.scc
diff --git a/meta/cfg/kernel-cache/bsp/common-pc/common-pc-standard.scc b/meta/cfg/kernel-cache/bsp/common-pc/common-pc-standard.scc
index f5baf52..83d49fd 100644
--- a/meta/cfg/kernel-cache/bsp/common-pc/common-pc-standard.scc
+++ b/meta/cfg/kernel-cache/bsp/common-pc/common-pc-standard.scc
@@ -6,3 +6,9 @@ include ktypes/standard
 branch common-pc
 
 include common-pc.scc
+
+# default policy for standard kernels
+include cfg/boot-live.scc
+include features/latencytop/latencytop.scc
+include features/profiling/profiling.scc
+include cfg/virtio.scc
diff --git a/meta/cfg/kernel-cache/bsp/common-pc/common-pc-tiny.scc b/meta/cfg/kernel-cache/bsp/common-pc/common-pc-tiny.scc
index 8d7a498..900eb27 100644
--- a/meta/cfg/kernel-cache/bsp/common-pc/common-pc-tiny.scc
+++ b/meta/cfg/kernel-cache/bsp/common-pc/common-pc-tiny.scc
@@ -5,8 +5,5 @@ define KARCH i386
 include ktypes/tiny
 branch common-pc
 
-# Don't include common-pc.scc directly,
-# it pulls in too many non-hardware options
-kconf hardware common-pc.cfg
-kconf hardware common-pc-gfx.cfg
+include common-pc.scc
 
diff --git a/meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc b/meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc
index 2338ea6..9bd72c1 100644
--- a/meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc
+++ b/meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc
@@ -1,11 +1,7 @@
 kconf hardware common-pc.cfg
 kconf hardware common-pc-gfx.cfg
 
-include cfg/boot-live.scc
 include features/usb/ehci-hcd.scc
 include features/usb/uhci-hcd.scc
 include features/intel-e1xxxx/intel-e100.scc
 include features/intel-e1xxxx/intel-e1xxxx.scc
-include features/latencytop/latencytop.scc
-include features/profiling/profiling.scc
-include cfg/virtio.scc
-- 
1.7.0.4

[PATCH 05/10] meta/common-pc: factor out policy-related options

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@intel.com>

Refactor bsp/common-pc/common-pc* to keep hardware-related options in
the base common-pc-64.scc while moving the more 'policy'-related
options into the files that include the base common-pc-64.scc
fragment.

This allows the different kernel types to make use of the basic
machine support without dragging along possibly unwanted options that
fall under the heading of 'policy' for a specific kernel type.

Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
---
 .../bsp/common-pc-64/common-pc-64-preempt-rt.scc   |    6 ++++++
 .../bsp/common-pc-64/common-pc-64-standard.scc     |    6 ++++++
 .../kernel-cache/bsp/common-pc-64/common-pc-64.scc |    6 ------
 3 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/meta/cfg/kernel-cache/bsp/common-pc-64/common-pc-64-preempt-rt.scc b/meta/cfg/kernel-cache/bsp/common-pc-64/common-pc-64-preempt-rt.scc
index ea13b44..8a79dd1 100644
--- a/meta/cfg/kernel-cache/bsp/common-pc-64/common-pc-64-preempt-rt.scc
+++ b/meta/cfg/kernel-cache/bsp/common-pc-64/common-pc-64-preempt-rt.scc
@@ -4,5 +4,11 @@ define KARCH x86_64
 
 # no new branch required, re-use the ktypes/preempt-rt branch
 include ktypes/preempt-rt
+
 include bsp/common-pc-64/common-pc-64.scc
 
+# default policy for preempt-rt kernels
+include cfg/boot-live.scc
+include features/latencytop/latencytop.scc
+include features/profiling/profiling.scc
+include cfg/virtio.scc
diff --git a/meta/cfg/kernel-cache/bsp/common-pc-64/common-pc-64-standard.scc b/meta/cfg/kernel-cache/bsp/common-pc-64/common-pc-64-standard.scc
index aa690cd..dcb1949 100644
--- a/meta/cfg/kernel-cache/bsp/common-pc-64/common-pc-64-standard.scc
+++ b/meta/cfg/kernel-cache/bsp/common-pc-64/common-pc-64-standard.scc
@@ -6,3 +6,9 @@ include ktypes/standard
 branch common-pc-64
 
 include common-pc-64.scc
+
+# default policy for standard kernels
+include cfg/boot-live.scc
+include features/latencytop/latencytop.scc
+include features/profiling/profiling.scc
+include cfg/virtio.scc
diff --git a/meta/cfg/kernel-cache/bsp/common-pc-64/common-pc-64.scc b/meta/cfg/kernel-cache/bsp/common-pc-64/common-pc-64.scc
index d0327c5..c2efc88 100644
--- a/meta/cfg/kernel-cache/bsp/common-pc-64/common-pc-64.scc
+++ b/meta/cfg/kernel-cache/bsp/common-pc-64/common-pc-64.scc
@@ -1,14 +1,8 @@
 kconf hardware common-pc-64.cfg
 kconf hardware common-pc-64-graphics.cfg
 
-include cfg/boot-live.scc
-
 include features/hpet/hpet.scc
 include features/usb/ehci-hcd.scc
 include features/usb/uhci-hcd.scc
 include features/intel-e1xxxx/intel-e100.scc
 include features/intel-e1xxxx/intel-e1xxxx.scc
-
-include features/latencytop/latencytop.scc
-include features/profiling/profiling.scc
-include cfg/virtio.scc
-- 
1.7.0.4

[PATCH 06/10] meta/crownbay: factor out policy-related options

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@intel.com>

Refactor bsp/common-pc/common-pc* to keep hardware-related options in
the base crownbay.scc while moving the more 'policy'-related options
into the files that include the base crownbay.scc fragment.

This allows the different kernel types to make use of the basic
machine support without dragging along possibly unwanted options that
fall under the heading of 'policy' for a specific kernel type.

Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
---
 .../bsp/crownbay/crownbay-preempt-rt.scc           |    8 ++++++++
 .../bsp/crownbay/crownbay-standard.scc             |    7 +++++++
 meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc    |    7 -------
 3 files changed, 15 insertions(+), 7 deletions(-)

diff --git a/meta/cfg/kernel-cache/bsp/crownbay/crownbay-preempt-rt.scc b/meta/cfg/kernel-cache/bsp/crownbay/crownbay-preempt-rt.scc
index d58b4be..11067ef 100644
--- a/meta/cfg/kernel-cache/bsp/crownbay/crownbay-preempt-rt.scc
+++ b/meta/cfg/kernel-cache/bsp/crownbay/crownbay-preempt-rt.scc
@@ -4,4 +4,12 @@ define KARCH i386
 
 # no new branch required, re-use the ktypes/preempt-rt branch
 include ktypes/preempt-rt
+
 include crownbay.scc
+
+# default policy for preempt-rt kernels
+include cfg/usb-mass-storage.scc
+include cfg/boot-live.scc
+include features/logbuf/size-normal.scc
+include features/latencytop/latencytop.scc
+include features/profiling/profiling.scc
diff --git a/meta/cfg/kernel-cache/bsp/crownbay/crownbay-standard.scc b/meta/cfg/kernel-cache/bsp/crownbay/crownbay-standard.scc
index d6036f7..dd9dbc7 100644
--- a/meta/cfg/kernel-cache/bsp/crownbay/crownbay-standard.scc
+++ b/meta/cfg/kernel-cache/bsp/crownbay/crownbay-standard.scc
@@ -9,3 +9,10 @@ include features/emgd/emgd-1.10.scc
 git merge emgd-1.10
 
 include crownbay.scc
+
+# default policy for standard kernels
+include cfg/usb-mass-storage.scc
+include cfg/boot-live.scc
+include features/logbuf/size-normal.scc
+include features/latencytop/latencytop.scc
+include features/profiling/profiling.scc
diff --git a/meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc b/meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc
index c4bc1a5..82ed6f3 100644
--- a/meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc
+++ b/meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc
@@ -8,16 +8,9 @@ include cfg/dmaengine.scc
 include features/serial/8250.scc
 include features/hpet/hpet.scc
 include cfg/vesafb.scc
-include cfg/usb-mass-storage.scc
-include cfg/boot-live.scc
 include cfg/smp.scc
 include features/power/intel.scc
 
-include features/logbuf/size-normal.scc
-
-include features/latencytop/latencytop.scc
-include features/profiling/profiling.scc
-
 include features/usb/ehci-hcd.scc
 include features/usb/ohci-hcd.scc
 include features/usb/uhci-hcd.scc
-- 
1.7.0.4

[PATCH 00/10][KERNEL][RFC] policy cleanup patches

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@intel.com>

This set of patches factors out the policy vs hardware-related config
of the common-pc and common-pc-64 along with some meta-intel BSPs.

There are also a couple usb cleanups as well.

This is an RFC patchset because it's completely untested at this
point so shouldn't be pulled in - I wanted to get this pre-NAKed
at least once before actually going through the trouble of testing.  ;-)

Tom

The following changes since commit 1dfd60fa1250259eed38ae5b2840eb37e3758a1b:
  Tom Zanussi (1):
        meta/fishriver: move smp options from recipe-space

are available in the git repository at:

  git://git.yoctoproject.org/linux-yocto-2.6.37-contrib.git tzanussi/policy-cleanup
  http://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto-2.6.37-contrib/log/?h=tzanussi/policy-cleanup

Tom Zanussi (10):
  meta: add ROOT_HUB_TT config option to the usb/ehci-hcd feature
  meta/common-pc: use usb features
  meta/common-pc-64: use usb features
  meta/common-pc: factor out policy-related options
  meta/common-pc: factor out policy-related options
  meta/crownbay: factor out policy-related options
  meta/emenlow: factor out policy-related options
  meta/emenlow: factor out policy-related options
  meta/jasperforest: factor out policy-related options
  meta/sugarbay: factor out policy-related options

 .../bsp/common-pc-64/common-pc-64-preempt-rt.scc   |    6 ++++++
 .../bsp/common-pc-64/common-pc-64-standard.scc     |    6 ++++++
 .../kernel-cache/bsp/common-pc-64/common-pc-64.cfg |    3 ---
 .../kernel-cache/bsp/common-pc-64/common-pc-64.scc |    8 ++------
 .../bsp/common-pc/common-pc-preempt-rt.scc         |    7 +++++++
 .../bsp/common-pc/common-pc-standard.scc           |    6 ++++++
 .../kernel-cache/bsp/common-pc/common-pc-tiny.scc  |    5 +----
 meta/cfg/kernel-cache/bsp/common-pc/common-pc.cfg  |    5 -----
 meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc  |    6 ++----
 .../bsp/crownbay/crownbay-preempt-rt.scc           |    8 ++++++++
 .../bsp/crownbay/crownbay-standard.scc             |    7 +++++++
 meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc    |    7 -------
 .../bsp/emenlow/emenlow-preempt-rt.scc             |    8 ++++++++
 .../kernel-cache/bsp/emenlow/emenlow-standard.scc  |    8 ++++++++
 meta/cfg/kernel-cache/bsp/emenlow/emenlow.scc      |    7 -------
 .../bsp/fishriver/fishriver-preempt-rt.scc         |    8 ++++++++
 .../bsp/fishriver/fishriver-standard.scc           |    8 ++++++++
 meta/cfg/kernel-cache/bsp/fishriver/fishriver.scc  |    7 -------
 .../bsp/jasperforest/jasperforest-preempt-rt.scc   |    7 +++++++
 .../bsp/jasperforest/jasperforest-standard.scc     |    6 ++++++
 .../kernel-cache/bsp/jasperforest/jasperforest.scc |    6 ------
 .../bsp/sugarbay/sugarbay-preempt-rt.scc           |    7 +++++++
 .../bsp/sugarbay/sugarbay-standard.scc             |    6 ++++++
 meta/cfg/kernel-cache/bsp/sugarbay/sugarbay.scc    |    6 ------
 meta/cfg/kernel-cache/features/usb/ehci-hcd.cfg    |    1 +
 25 files changed, 104 insertions(+), 55 deletions(-)

[PATCH 07/10] meta/emenlow: factor out policy-related options

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@intel.com>

Refactor bsp/common-pc/common-pc* to keep hardware-related options in
the base emenlow.scc while moving the more 'policy'-related options
into the files that include the base emenlow.scc fragment.

This allows the different kernel types to make use of the basic
machine support without dragging along possibly unwanted options that
fall under the heading of 'policy' for a specific kernel type.

Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
---
 .../bsp/emenlow/emenlow-preempt-rt.scc             |    8 ++++++++
 .../kernel-cache/bsp/emenlow/emenlow-standard.scc  |    8 ++++++++
 meta/cfg/kernel-cache/bsp/emenlow/emenlow.scc      |    7 -------
 3 files changed, 16 insertions(+), 7 deletions(-)

diff --git a/meta/cfg/kernel-cache/bsp/emenlow/emenlow-preempt-rt.scc b/meta/cfg/kernel-cache/bsp/emenlow/emenlow-preempt-rt.scc
index 156e4c6..85d8367 100644
--- a/meta/cfg/kernel-cache/bsp/emenlow/emenlow-preempt-rt.scc
+++ b/meta/cfg/kernel-cache/bsp/emenlow/emenlow-preempt-rt.scc
@@ -4,4 +4,12 @@ define KARCH i386
 
 # no new branch required, re-use the ktypes/preempt-rt branch
 include ktypes/preempt-rt
+
 include emenlow.scc
+
+# default policy for preempt-rt kernels
+include cfg/usb-mass-storage.scc
+include cfg/boot-live.scc
+include features/logbuf/size-normal.scc
+include features/latencytop/latencytop.scc
+include features/profiling/profiling.scc
diff --git a/meta/cfg/kernel-cache/bsp/emenlow/emenlow-standard.scc b/meta/cfg/kernel-cache/bsp/emenlow/emenlow-standard.scc
index 804b36e..aac1b09 100644
--- a/meta/cfg/kernel-cache/bsp/emenlow/emenlow-standard.scc
+++ b/meta/cfg/kernel-cache/bsp/emenlow/emenlow-standard.scc
@@ -6,3 +6,11 @@ include ktypes/standard
 branch emenlow
 
 include emenlow.scc
+
+# default policy for standard kernels
+include cfg/usb-mass-storage.scc
+include cfg/boot-live.scc
+include features/logbuf/size-normal.scc
+include features/latencytop/latencytop.scc
+include features/profiling/profiling.scc
+
diff --git a/meta/cfg/kernel-cache/bsp/emenlow/emenlow.scc b/meta/cfg/kernel-cache/bsp/emenlow/emenlow.scc
index 2967d93..9296ddb 100644
--- a/meta/cfg/kernel-cache/bsp/emenlow/emenlow.scc
+++ b/meta/cfg/kernel-cache/bsp/emenlow/emenlow.scc
@@ -6,15 +6,8 @@ include features/intel-e1xxxx/intel-e1xxxx.scc
 include features/drm-psb/drm-psb.scc
 include features/serial/8250.scc
 include cfg/vesafb.scc
-include cfg/usb-mass-storage.scc
-include cfg/boot-live.scc
 include cfg/smp.scc
 
-include features/logbuf/size-normal.scc
-
-include features/latencytop/latencytop.scc
-include features/profiling/profiling.scc
-
 include features/usb/ehci-hcd.scc
 include features/usb/ohci-hcd.scc
 include features/usb/uhci-hcd.scc
-- 
1.7.0.4

[PATCH 08/10] meta/emenlow: factor out policy-related options

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@intel.com>

Refactor bsp/common-pc/common-pc* to keep hardware-related options in
the base fishriver.scc while moving the more 'policy'-related options
into the files that include the base fishriver.scc fragment.

This allows the different kernel types to make use of the basic
machine support without dragging along possibly unwanted options that
fall under the heading of 'policy' for a specific kernel type.

Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
---
 .../bsp/fishriver/fishriver-preempt-rt.scc         |    8 ++++++++
 .../bsp/fishriver/fishriver-standard.scc           |    8 ++++++++
 meta/cfg/kernel-cache/bsp/fishriver/fishriver.scc  |    7 -------
 3 files changed, 16 insertions(+), 7 deletions(-)

diff --git a/meta/cfg/kernel-cache/bsp/fishriver/fishriver-preempt-rt.scc b/meta/cfg/kernel-cache/bsp/fishriver/fishriver-preempt-rt.scc
index 1a5e46a..f37e1c6 100644
--- a/meta/cfg/kernel-cache/bsp/fishriver/fishriver-preempt-rt.scc
+++ b/meta/cfg/kernel-cache/bsp/fishriver/fishriver-preempt-rt.scc
@@ -4,4 +4,12 @@ define KARCH i386
 
 # no new branch required, re-use the ktypes/preempt-rt branch
 include ktypes/preempt-rt
+
 include fishriver.scc
+
+# default policy for preempt-rt kernels
+include cfg/usb-mass-storage.scc
+include cfg/boot-live.scc
+include features/logbuf/size-normal.scc
+include features/latencytop/latencytop.scc
+include features/profiling/profiling.scc
diff --git a/meta/cfg/kernel-cache/bsp/fishriver/fishriver-standard.scc b/meta/cfg/kernel-cache/bsp/fishriver/fishriver-standard.scc
index e697d7e..fb2dc25 100644
--- a/meta/cfg/kernel-cache/bsp/fishriver/fishriver-standard.scc
+++ b/meta/cfg/kernel-cache/bsp/fishriver/fishriver-standard.scc
@@ -9,3 +9,11 @@ include features/emgd/emgd.scc
 git merge emgd
 
 include fishriver.scc
+
+# default policy for standard kernels
+include cfg/usb-mass-storage.scc
+include cfg/boot-live.scc
+include features/logbuf/size-normal.scc
+include features/latencytop/latencytop.scc
+include features/profiling/profiling.scc
+
diff --git a/meta/cfg/kernel-cache/bsp/fishriver/fishriver.scc b/meta/cfg/kernel-cache/bsp/fishriver/fishriver.scc
index e401274..6ae93f9 100644
--- a/meta/cfg/kernel-cache/bsp/fishriver/fishriver.scc
+++ b/meta/cfg/kernel-cache/bsp/fishriver/fishriver.scc
@@ -8,16 +8,9 @@ include features/serial/8250.scc
 include features/hpet/hpet.scc
 include features/ericsson-3g/f5521gw.scc
 include cfg/vesafb.scc
-include cfg/usb-mass-storage.scc
-include cfg/boot-live.scc
 include cfg/smp.scc
 include features/power/intel.scc
 
-include features/logbuf/size-normal.scc
-
-include features/latencytop/latencytop.scc
-include features/profiling/profiling.scc
-
 include features/usb/ehci-hcd.scc
 include features/usb/ohci-hcd.scc
 include features/usb/uhci-hcd.scc
-- 
1.7.0.4

[PATCH 09/10] meta/jasperforest: factor out policy-related options

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@intel.com>

Refactor bsp/common-pc/common-pc* to keep hardware-related options in
the base jasperforest.scc while moving the more 'policy'-related
options into the files that include the base jasperforest.scc
fragment.

This allows the different kernel types to make use of the basic
machine support without dragging along possibly unwanted options that
fall under the heading of 'policy' for a specific kernel type.

Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
---
 .../bsp/jasperforest/jasperforest-preempt-rt.scc   |    7 +++++++
 .../bsp/jasperforest/jasperforest-standard.scc     |    6 ++++++
 .../kernel-cache/bsp/jasperforest/jasperforest.scc |    6 ------
 3 files changed, 13 insertions(+), 6 deletions(-)

diff --git a/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest-preempt-rt.scc b/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest-preempt-rt.scc
index 4b5c2ca..b3a6370 100644
--- a/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest-preempt-rt.scc
+++ b/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest-preempt-rt.scc
@@ -5,4 +5,11 @@ define KARCH x86_64
 # no new branch required, re-use the ktypes/preempt-rt branch
 include ktypes/preempt-rt
 include bsp/common-pc-64/common-pc-64.scc
+
 include jasperforest.scc
+
+# default policy for preempt-rt kernels
+include cfg/usb-mass-storage.scc
+include features/logbuf/size-normal.scc
+include features/latencytop/latencytop.scc
+include features/profiling/profiling.scc
diff --git a/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest-standard.scc b/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest-standard.scc
index baf66d8..ec7a10a 100644
--- a/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest-standard.scc
+++ b/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest-standard.scc
@@ -6,3 +6,9 @@ include bsp/common-pc-64/common-pc-64-standard
 branch jasperforest
 
 include jasperforest.scc
+
+# default policy for standard kernels
+include cfg/usb-mass-storage.scc
+include features/logbuf/size-normal.scc
+include features/latencytop/latencytop.scc
+include features/profiling/profiling.scc
diff --git a/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest.scc b/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest.scc
index 82f0f52..68afd4a 100644
--- a/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest.scc
+++ b/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest.scc
@@ -2,14 +2,8 @@ kconf hardware jasperforest.cfg
 
 include features/serial/8250.scc
 include cfg/vesafb.scc
-include cfg/usb-mass-storage.scc
 include features/power/intel.scc
 
-include features/logbuf/size-normal.scc
-
-include features/latencytop/latencytop.scc
-include features/profiling/profiling.scc
-
 include features/usb/ehci-hcd.scc
 include features/usb/ohci-hcd.scc
 include features/usb/uhci-hcd.scc
-- 
1.7.0.4

[PATCH 10/10] meta/sugarbay: factor out policy-related options

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@intel.com>

Refactor bsp/common-pc/common-pc* to keep hardware-related options in
the base sugarbay.scc while moving the more 'policy'-related options
into the files that include the base sugarbay.scc fragment.

This allows the different kernel types to make use of the basic
machine support without dragging along possibly unwanted options that
fall under the heading of 'policy' for a specific kernel type.

Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
---
 .../bsp/sugarbay/sugarbay-preempt-rt.scc           |    7 +++++++
 .../bsp/sugarbay/sugarbay-standard.scc             |    6 ++++++
 meta/cfg/kernel-cache/bsp/sugarbay/sugarbay.scc    |    6 ------
 3 files changed, 13 insertions(+), 6 deletions(-)

diff --git a/meta/cfg/kernel-cache/bsp/sugarbay/sugarbay-preempt-rt.scc b/meta/cfg/kernel-cache/bsp/sugarbay/sugarbay-preempt-rt.scc
index e824f6f..d9df73b 100644
--- a/meta/cfg/kernel-cache/bsp/sugarbay/sugarbay-preempt-rt.scc
+++ b/meta/cfg/kernel-cache/bsp/sugarbay/sugarbay-preempt-rt.scc
@@ -5,4 +5,11 @@ define KARCH x86_64
 # no new branch required, re-use the ktypes/preempt-rt branch
 include ktypes/preempt-rt
 include bsp/common-pc-64/common-pc-64.scc
+
 include sugarbay.scc
+
+# default policy for preempt-rt kernels
+include cfg/usb-mass-storage.scc
+include features/logbuf/size-normal.scc
+include features/latencytop/latencytop.scc
+include features/profiling/profiling.scc
diff --git a/meta/cfg/kernel-cache/bsp/sugarbay/sugarbay-standard.scc b/meta/cfg/kernel-cache/bsp/sugarbay/sugarbay-standard.scc
index 8c2a19b..421364e 100644
--- a/meta/cfg/kernel-cache/bsp/sugarbay/sugarbay-standard.scc
+++ b/meta/cfg/kernel-cache/bsp/sugarbay/sugarbay-standard.scc
@@ -6,3 +6,9 @@ include bsp/common-pc-64/common-pc-64-standard
 branch sugarbay
 
 include sugarbay.scc
+
+# default policy for standard kernels
+include cfg/usb-mass-storage.scc
+include features/logbuf/size-normal.scc
+include features/latencytop/latencytop.scc
+include features/profiling/profiling.scc
diff --git a/meta/cfg/kernel-cache/bsp/sugarbay/sugarbay.scc b/meta/cfg/kernel-cache/bsp/sugarbay/sugarbay.scc
index 128efd3..d8144f0 100644
--- a/meta/cfg/kernel-cache/bsp/sugarbay/sugarbay.scc
+++ b/meta/cfg/kernel-cache/bsp/sugarbay/sugarbay.scc
@@ -2,14 +2,8 @@ kconf hardware sugarbay.cfg
 
 include features/i915/i915.scc
 include features/serial/8250.scc
-include cfg/usb-mass-storage.scc
 include features/power/intel.scc
 
-include features/logbuf/size-normal.scc
-
-include features/latencytop/latencytop.scc
-include features/profiling/profiling.scc
-
 include features/usb/ehci-hcd.scc
 include features/usb/ohci-hcd.scc
 include features/usb/uhci-hcd.scc
-- 
1.7.0.4

Re: [PATCH 01/10] meta: add ROOT_HUB_TT config option to the usb/ehci-hcd feature

[Darren Hart]

On 05/10/2012 05:59 PM, tom.zanussi@intel.com wrote:
> From: Tom Zanussi <tom.zanussi@intel.com>
> 
> Add root hub transaction translator support for supporting companion
> ohci/uhci controllers , which is safe even if the ehci controller
> doesn't have companion controllers.
> 
> Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>

Acked-by: Darren Hart <dvhart@linux.intel.com>

> ---
>  meta/cfg/kernel-cache/features/usb/ehci-hcd.cfg |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/meta/cfg/kernel-cache/features/usb/ehci-hcd.cfg b/meta/cfg/kernel-cache/features/usb/ehci-hcd.cfg
> index 7322dc2..b977248 100644
> --- a/meta/cfg/kernel-cache/features/usb/ehci-hcd.cfg
> +++ b/meta/cfg/kernel-cache/features/usb/ehci-hcd.cfg
> @@ -1 +1,2 @@
>  CONFIG_USB_EHCI_HCD=y
> +CONFIG_USB_EHCI_ROOT_HUB_TT=y

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

Re: [PATCH 02/10] meta/common-pc: use usb features

[Darren Hart]

On 05/10/2012 05:59 PM, tom.zanussi@intel.com wrote:
> From: Tom Zanussi <tom.zanussi@intel.com>
> 
> Use the available ehci and uhci usb features and remove the associated
> config settings from the top-level common-pc feature.
> 
> Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>

For what this does:

Acked-by: Darren Hart <dvhart@linux.intel.com>

Further thoughts:

I wonder why common-pc does not include OHCI HCDs?

>  CONFIG_USB_STORAGE=y

This should really be pulled out as well and added to the standard and
preempt-rt bsp-ktype.scc files.


>  CONFIG_USB_HID=y
>  CONFIG_USB_HIDDEV=y
> diff --git a/meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc b/meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc
> index bab45e6..2338ea6 100644
> --- a/meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc
> +++ b/meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc
> @@ -2,6 +2,8 @@ kconf hardware common-pc.cfg
>  kconf hardware common-pc-gfx.cfg
>  
>  include cfg/boot-live.scc

This should be moved to the standard and preempt-rt bsp-ktype.scc files
as well.

> +include features/usb/ehci-hcd.scc
> +include features/usb/uhci-hcd.scc
>  include features/intel-e1xxxx/intel-e100.scc
>  include features/intel-e1xxxx/intel-e1xxxx.scc
>  include features/latencytop/latencytop.scc

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

Re: [PATCH 04/10] meta/common-pc: factor out policy-related options

[Darren Hart]

On 05/10/2012 06:00 PM, tom.zanussi@intel.com wrote:
> From: Tom Zanussi <tom.zanussi@intel.com>
> 
> Refactor bsp/common-pc/common-pc* to keep hardware-related options in
> the base common-pc.scc while moving the more 'policy'-related options
> into the files that include the base common-pc.scc fragment.
> 
> This allows the different kernel types to make use of the basic
> machine support without dragging along possibly unwanted options that
> fall under the heading of 'policy' for a specific kernel type.
> 
> Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
> ---
>  .../bsp/common-pc/common-pc-preempt-rt.scc         |    7 +++++++
>  .../bsp/common-pc/common-pc-standard.scc           |    6 ++++++
>  .../kernel-cache/bsp/common-pc/common-pc-tiny.scc  |    5 +----
>  meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc  |    4 ----
>  4 files changed, 14 insertions(+), 8 deletions(-)
> 
> diff --git a/meta/cfg/kernel-cache/bsp/common-pc/common-pc-preempt-rt.scc b/meta/cfg/kernel-cache/bsp/common-pc/common-pc-preempt-rt.scc
> index f8716ee..706f669 100644
> --- a/meta/cfg/kernel-cache/bsp/common-pc/common-pc-preempt-rt.scc
> +++ b/meta/cfg/kernel-cache/bsp/common-pc/common-pc-preempt-rt.scc
> @@ -4,4 +4,11 @@ define KARCH i386
>  
>  # no new branch required, re-use the ktypes/preempt-rt branch
>  include ktypes/preempt-rt
> +
>  include bsp/common-pc/common-pc.scc
> +
> +# default policy for preempt-rt kernels


needs  usb-mass-storage here

> +include cfg/boot-live.scc
> +include features/latencytop/latencytop.scc
> +include features/profiling/profiling.scc
> +include cfg/virtio.scc
> diff --git a/meta/cfg/kernel-cache/bsp/common-pc/common-pc-standard.scc b/meta/cfg/kernel-cache/bsp/common-pc/common-pc-standard.scc
> index f5baf52..83d49fd 100644
> --- a/meta/cfg/kernel-cache/bsp/common-pc/common-pc-standard.scc
> +++ b/meta/cfg/kernel-cache/bsp/common-pc/common-pc-standard.scc
> @@ -6,3 +6,9 @@ include ktypes/standard
>  branch common-pc
>  
>  include common-pc.scc
> +
> +# default policy for standard kernels

needs  usb-mass-storage here and the config removed from common-pc.cfg

> +include cfg/boot-live.scc
> +include features/latencytop/latencytop.scc
> +include features/profiling/profiling.scc
> +include cfg/virtio.scc
> diff --git a/meta/cfg/kernel-cache/bsp/common-pc/common-pc-tiny.scc b/meta/cfg/kernel-cache/bsp/common-pc/common-pc-tiny.scc
> index 8d7a498..900eb27 100644
> --- a/meta/cfg/kernel-cache/bsp/common-pc/common-pc-tiny.scc
> +++ b/meta/cfg/kernel-cache/bsp/common-pc/common-pc-tiny.scc
> @@ -5,8 +5,5 @@ define KARCH i386
>  include ktypes/tiny
>  branch common-pc
>  
> -# Don't include common-pc.scc directly,
> -# it pulls in too many non-hardware options
> -kconf hardware common-pc.cfg
> -kconf hardware common-pc-gfx.cfg
> +include common-pc.scc

Nice!

> diff --git a/meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc b/meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc
> index 2338ea6..9bd72c1 100644
> --- a/meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc
> +++ b/meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc
> @@ -1,11 +1,7 @@
>  kconf hardware common-pc.cfg
>  kconf hardware common-pc-gfx.cfg
>  
> -include cfg/boot-live.scc
>  include features/usb/ehci-hcd.scc
>  include features/usb/uhci-hcd.scc
>  include features/intel-e1xxxx/intel-e100.scc
>  include features/intel-e1xxxx/intel-e1xxxx.scc
> -include features/latencytop/latencytop.scc
> -include features/profiling/profiling.scc
> -include cfg/virtio.scc

Nice.

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

Re: [PATCH 05/10] meta/common-pc: factor out policy-related options

[Darren Hart]

On 05/10/2012 06:00 PM, tom.zanussi@intel.com wrote:
> From: Tom Zanussi <tom.zanussi@intel.com>
> 
> Refactor bsp/common-pc/common-pc* to keep hardware-related options in
> the base common-pc-64.scc while moving the more 'policy'-related
> options into the files that include the base common-pc-64.scc
> fragment.
> 
> This allows the different kernel types to make use of the basic
> machine support without dragging along possibly unwanted options that
> fall under the heading of 'policy' for a specific kernel type.
> 
> Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>

Same comments as for common-pc (5/10)

> ---
>  .../bsp/common-pc-64/common-pc-64-preempt-rt.scc   |    6 ++++++
>  .../bsp/common-pc-64/common-pc-64-standard.scc     |    6 ++++++
>  .../kernel-cache/bsp/common-pc-64/common-pc-64.scc |    6 ------
>  3 files changed, 12 insertions(+), 6 deletions(-)
> 
> diff --git a/meta/cfg/kernel-cache/bsp/common-pc-64/common-pc-64-preempt-rt.scc b/meta/cfg/kernel-cache/bsp/common-pc-64/common-pc-64-preempt-rt.scc
> index ea13b44..8a79dd1 100644
> --- a/meta/cfg/kernel-cache/bsp/common-pc-64/common-pc-64-preempt-rt.scc
> +++ b/meta/cfg/kernel-cache/bsp/common-pc-64/common-pc-64-preempt-rt.scc
> @@ -4,5 +4,11 @@ define KARCH x86_64
>  
>  # no new branch required, re-use the ktypes/preempt-rt branch
>  include ktypes/preempt-rt
> +
>  include bsp/common-pc-64/common-pc-64.scc
>  
> +# default policy for preempt-rt kernels
> +include cfg/boot-live.scc
> +include features/latencytop/latencytop.scc
> +include features/profiling/profiling.scc
> +include cfg/virtio.scc
> diff --git a/meta/cfg/kernel-cache/bsp/common-pc-64/common-pc-64-standard.scc b/meta/cfg/kernel-cache/bsp/common-pc-64/common-pc-64-standard.scc
> index aa690cd..dcb1949 100644
> --- a/meta/cfg/kernel-cache/bsp/common-pc-64/common-pc-64-standard.scc
> +++ b/meta/cfg/kernel-cache/bsp/common-pc-64/common-pc-64-standard.scc
> @@ -6,3 +6,9 @@ include ktypes/standard
>  branch common-pc-64
>  
>  include common-pc-64.scc
> +
> +# default policy for standard kernels
> +include cfg/boot-live.scc
> +include features/latencytop/latencytop.scc
> +include features/profiling/profiling.scc
> +include cfg/virtio.scc
> diff --git a/meta/cfg/kernel-cache/bsp/common-pc-64/common-pc-64.scc b/meta/cfg/kernel-cache/bsp/common-pc-64/common-pc-64.scc
> index d0327c5..c2efc88 100644
> --- a/meta/cfg/kernel-cache/bsp/common-pc-64/common-pc-64.scc
> +++ b/meta/cfg/kernel-cache/bsp/common-pc-64/common-pc-64.scc
> @@ -1,14 +1,8 @@
>  kconf hardware common-pc-64.cfg
>  kconf hardware common-pc-64-graphics.cfg
>  
> -include cfg/boot-live.scc
> -
>  include features/hpet/hpet.scc
>  include features/usb/ehci-hcd.scc
>  include features/usb/uhci-hcd.scc
>  include features/intel-e1xxxx/intel-e100.scc
>  include features/intel-e1xxxx/intel-e1xxxx.scc
> -
> -include features/latencytop/latencytop.scc
> -include features/profiling/profiling.scc
> -include cfg/virtio.scc

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

Re: [PATCH 00/10][KERNEL][RFC] policy cleanup patches

[Bruce Ashfield]

On 12-05-10 09:00 PM, tom.zanussi@intel.com wrote:
> From: Tom Zanussi<tom.zanussi@intel.com>
>
> This set of patches factors out the policy vs hardware-related config
> of the common-pc and common-pc-64 along with some meta-intel BSPs.
>
> There are also a couple usb cleanups as well.
>
> This is an RFC patchset because it's completely untested at this
> point so shouldn't be pulled in - I wanted to get this pre-NAKed
> at least once before actually going through the trouble of testing.  ;-)

I see Darren's around and adding some comments. I'll have a look at this
later today, and provide some feedback.

Just wanted to let you know that I've seen it, and plan to have a detailed
look at it shortly.

Bruce

>
> Tom
>
> The following changes since commit 1dfd60fa1250259eed38ae5b2840eb37e3758a1b:
>    Tom Zanussi (1):
>          meta/fishriver: move smp options from recipe-space
>
> are available in the git repository at:
>
>    git://git.yoctoproject.org/linux-yocto-2.6.37-contrib.git tzanussi/policy-cleanup
>    http://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto-2.6.37-contrib/log/?h=tzanussi/policy-cleanup
>
> Tom Zanussi (10):
>    meta: add ROOT_HUB_TT config option to the usb/ehci-hcd feature
>    meta/common-pc: use usb features
>    meta/common-pc-64: use usb features
>    meta/common-pc: factor out policy-related options
>    meta/common-pc: factor out policy-related options
>    meta/crownbay: factor out policy-related options
>    meta/emenlow: factor out policy-related options
>    meta/emenlow: factor out policy-related options
>    meta/jasperforest: factor out policy-related options
>    meta/sugarbay: factor out policy-related options
>
>   .../bsp/common-pc-64/common-pc-64-preempt-rt.scc   |    6 ++++++
>   .../bsp/common-pc-64/common-pc-64-standard.scc     |    6 ++++++
>   .../kernel-cache/bsp/common-pc-64/common-pc-64.cfg |    3 ---
>   .../kernel-cache/bsp/common-pc-64/common-pc-64.scc |    8 ++------
>   .../bsp/common-pc/common-pc-preempt-rt.scc         |    7 +++++++
>   .../bsp/common-pc/common-pc-standard.scc           |    6 ++++++
>   .../kernel-cache/bsp/common-pc/common-pc-tiny.scc  |    5 +----
>   meta/cfg/kernel-cache/bsp/common-pc/common-pc.cfg  |    5 -----
>   meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc  |    6 ++----
>   .../bsp/crownbay/crownbay-preempt-rt.scc           |    8 ++++++++
>   .../bsp/crownbay/crownbay-standard.scc             |    7 +++++++
>   meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc    |    7 -------
>   .../bsp/emenlow/emenlow-preempt-rt.scc             |    8 ++++++++
>   .../kernel-cache/bsp/emenlow/emenlow-standard.scc  |    8 ++++++++
>   meta/cfg/kernel-cache/bsp/emenlow/emenlow.scc      |    7 -------
>   .../bsp/fishriver/fishriver-preempt-rt.scc         |    8 ++++++++
>   .../bsp/fishriver/fishriver-standard.scc           |    8 ++++++++
>   meta/cfg/kernel-cache/bsp/fishriver/fishriver.scc  |    7 -------
>   .../bsp/jasperforest/jasperforest-preempt-rt.scc   |    7 +++++++
>   .../bsp/jasperforest/jasperforest-standard.scc     |    6 ++++++
>   .../kernel-cache/bsp/jasperforest/jasperforest.scc |    6 ------
>   .../bsp/sugarbay/sugarbay-preempt-rt.scc           |    7 +++++++
>   .../bsp/sugarbay/sugarbay-standard.scc             |    6 ++++++
>   meta/cfg/kernel-cache/bsp/sugarbay/sugarbay.scc    |    6 ------
>   meta/cfg/kernel-cache/features/usb/ehci-hcd.cfg    |    1 +
>   25 files changed, 104 insertions(+), 55 deletions(-)
>

Re: [PATCH 06/10] meta/crownbay: factor out policy-related options

[Darren Hart]

On 05/10/2012 06:00 PM, tom.zanussi@intel.com wrote:
> From: Tom Zanussi <tom.zanussi@intel.com>
> 
> Refactor bsp/common-pc/common-pc* to keep hardware-related options in

oops                   ^

> the base crownbay.scc while moving the more 'policy'-related options
> into the files that include the base crownbay.scc fragment.
> 
> This allows the different kernel types to make use of the basic
> machine support without dragging along possibly unwanted options that
> fall under the heading of 'policy' for a specific kernel type.
> 
> Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>


With minor comment tweak above:

Acked-by-by: Darren Hart <dvhart@linux.intel.com>

> ---
>  .../bsp/crownbay/crownbay-preempt-rt.scc           |    8 ++++++++
>  .../bsp/crownbay/crownbay-standard.scc             |    7 +++++++
>  meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc    |    7 -------
>  3 files changed, 15 insertions(+), 7 deletions(-)
> 
> diff --git a/meta/cfg/kernel-cache/bsp/crownbay/crownbay-preempt-rt.scc b/meta/cfg/kernel-cache/bsp/crownbay/crownbay-preempt-rt.scc
> index d58b4be..11067ef 100644
> --- a/meta/cfg/kernel-cache/bsp/crownbay/crownbay-preempt-rt.scc
> +++ b/meta/cfg/kernel-cache/bsp/crownbay/crownbay-preempt-rt.scc
> @@ -4,4 +4,12 @@ define KARCH i386
>  
>  # no new branch required, re-use the ktypes/preempt-rt branch
>  include ktypes/preempt-rt
> +
>  include crownbay.scc
> +
> +# default policy for preempt-rt kernels
> +include cfg/usb-mass-storage.scc
> +include cfg/boot-live.scc
> +include features/logbuf/size-normal.scc
> +include features/latencytop/latencytop.scc
> +include features/profiling/profiling.scc
> diff --git a/meta/cfg/kernel-cache/bsp/crownbay/crownbay-standard.scc b/meta/cfg/kernel-cache/bsp/crownbay/crownbay-standard.scc
> index d6036f7..dd9dbc7 100644
> --- a/meta/cfg/kernel-cache/bsp/crownbay/crownbay-standard.scc
> +++ b/meta/cfg/kernel-cache/bsp/crownbay/crownbay-standard.scc
> @@ -9,3 +9,10 @@ include features/emgd/emgd-1.10.scc
>  git merge emgd-1.10
>  
>  include crownbay.scc
> +
> +# default policy for standard kernels
> +include cfg/usb-mass-storage.scc
> +include cfg/boot-live.scc
> +include features/logbuf/size-normal.scc
> +include features/latencytop/latencytop.scc
> +include features/profiling/profiling.scc
> diff --git a/meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc b/meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc
> index c4bc1a5..82ed6f3 100644
> --- a/meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc
> +++ b/meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc
> @@ -8,16 +8,9 @@ include cfg/dmaengine.scc
>  include features/serial/8250.scc
>  include features/hpet/hpet.scc
>  include cfg/vesafb.scc
> -include cfg/usb-mass-storage.scc
> -include cfg/boot-live.scc
>  include cfg/smp.scc
>  include features/power/intel.scc
>  
> -include features/logbuf/size-normal.scc
> -
> -include features/latencytop/latencytop.scc
> -include features/profiling/profiling.scc
> -
>  include features/usb/ehci-hcd.scc
>  include features/usb/ohci-hcd.scc
>  include features/usb/uhci-hcd.scc

Independent from this patch, but does crownbay have all three? ehci and
ohci seems a lot more likely to me.

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

Re: [PATCH 07/10] meta/emenlow: factor out policy-related options

[Darren Hart]

Same comments as for crownbay...

On 05/10/2012 06:00 PM, tom.zanussi@intel.com wrote:
> From: Tom Zanussi <tom.zanussi@intel.com>
> 
> Refactor bsp/common-pc/common-pc* to keep hardware-related options in

oops                  ^

> the base emenlow.scc while moving the more 'policy'-related options
> into the files that include the base emenlow.scc fragment.
> 
> This allows the different kernel types to make use of the basic
> machine support without dragging along possibly unwanted options that
> fall under the heading of 'policy' for a specific kernel type.
> 
> Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>



Acked-by: Darren Hart <dvhart@linux.intel.com>

> ---
>  .../bsp/emenlow/emenlow-preempt-rt.scc             |    8 ++++++++
>  .../kernel-cache/bsp/emenlow/emenlow-standard.scc  |    8 ++++++++
>  meta/cfg/kernel-cache/bsp/emenlow/emenlow.scc      |    7 -------
>  3 files changed, 16 insertions(+), 7 deletions(-)
> 
> diff --git a/meta/cfg/kernel-cache/bsp/emenlow/emenlow-preempt-rt.scc b/meta/cfg/kernel-cache/bsp/emenlow/emenlow-preempt-rt.scc
> index 156e4c6..85d8367 100644
> --- a/meta/cfg/kernel-cache/bsp/emenlow/emenlow-preempt-rt.scc
> +++ b/meta/cfg/kernel-cache/bsp/emenlow/emenlow-preempt-rt.scc
> @@ -4,4 +4,12 @@ define KARCH i386
>  
>  # no new branch required, re-use the ktypes/preempt-rt branch
>  include ktypes/preempt-rt
> +
>  include emenlow.scc
> +
> +# default policy for preempt-rt kernels
> +include cfg/usb-mass-storage.scc
> +include cfg/boot-live.scc
> +include features/logbuf/size-normal.scc
> +include features/latencytop/latencytop.scc
> +include features/profiling/profiling.scc
> diff --git a/meta/cfg/kernel-cache/bsp/emenlow/emenlow-standard.scc b/meta/cfg/kernel-cache/bsp/emenlow/emenlow-standard.scc
> index 804b36e..aac1b09 100644
> --- a/meta/cfg/kernel-cache/bsp/emenlow/emenlow-standard.scc
> +++ b/meta/cfg/kernel-cache/bsp/emenlow/emenlow-standard.scc
> @@ -6,3 +6,11 @@ include ktypes/standard
>  branch emenlow
>  
>  include emenlow.scc
> +
> +# default policy for standard kernels
> +include cfg/usb-mass-storage.scc
> +include cfg/boot-live.scc
> +include features/logbuf/size-normal.scc
> +include features/latencytop/latencytop.scc
> +include features/profiling/profiling.scc
> +
> diff --git a/meta/cfg/kernel-cache/bsp/emenlow/emenlow.scc b/meta/cfg/kernel-cache/bsp/emenlow/emenlow.scc
> index 2967d93..9296ddb 100644
> --- a/meta/cfg/kernel-cache/bsp/emenlow/emenlow.scc
> +++ b/meta/cfg/kernel-cache/bsp/emenlow/emenlow.scc
> @@ -6,15 +6,8 @@ include features/intel-e1xxxx/intel-e1xxxx.scc
>  include features/drm-psb/drm-psb.scc
>  include features/serial/8250.scc
>  include cfg/vesafb.scc
> -include cfg/usb-mass-storage.scc
> -include cfg/boot-live.scc
>  include cfg/smp.scc
>  
> -include features/logbuf/size-normal.scc
> -
> -include features/latencytop/latencytop.scc
> -include features/profiling/profiling.scc
> -
>  include features/usb/ehci-hcd.scc
>  include features/usb/ohci-hcd.scc
>  include features/usb/uhci-hcd.scc

minus uhci?

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

Re: [PATCH 08/10] meta/emenlow: factor out policy-related options

[Darren Hart]

Same comments as for crownbay

On 05/10/2012 06:00 PM, tom.zanussi@intel.com wrote:
> From: Tom Zanussi <tom.zanussi@intel.com>
> 
> Refactor bsp/common-pc/common-pc* to keep hardware-related options in

oops                       ^

> the base fishriver.scc while moving the more 'policy'-related options
> into the files that include the base fishriver.scc fragment.
> 
> This allows the different kernel types to make use of the basic
> machine support without dragging along possibly unwanted options that
> fall under the heading of 'policy' for a specific kernel type.
> 
> Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>

Acked-by: Darren Hart <dvhart@linux.intel.com>

> ---
>  .../bsp/fishriver/fishriver-preempt-rt.scc         |    8 ++++++++
>  .../bsp/fishriver/fishriver-standard.scc           |    8 ++++++++
>  meta/cfg/kernel-cache/bsp/fishriver/fishriver.scc  |    7 -------
>  3 files changed, 16 insertions(+), 7 deletions(-)
> 
> diff --git a/meta/cfg/kernel-cache/bsp/fishriver/fishriver-preempt-rt.scc b/meta/cfg/kernel-cache/bsp/fishriver/fishriver-preempt-rt.scc
> index 1a5e46a..f37e1c6 100644
> --- a/meta/cfg/kernel-cache/bsp/fishriver/fishriver-preempt-rt.scc
> +++ b/meta/cfg/kernel-cache/bsp/fishriver/fishriver-preempt-rt.scc
> @@ -4,4 +4,12 @@ define KARCH i386
>  
>  # no new branch required, re-use the ktypes/preempt-rt branch
>  include ktypes/preempt-rt
> +
>  include fishriver.scc
> +
> +# default policy for preempt-rt kernels
> +include cfg/usb-mass-storage.scc
> +include cfg/boot-live.scc
> +include features/logbuf/size-normal.scc
> +include features/latencytop/latencytop.scc
> +include features/profiling/profiling.scc
> diff --git a/meta/cfg/kernel-cache/bsp/fishriver/fishriver-standard.scc b/meta/cfg/kernel-cache/bsp/fishriver/fishriver-standard.scc
> index e697d7e..fb2dc25 100644
> --- a/meta/cfg/kernel-cache/bsp/fishriver/fishriver-standard.scc
> +++ b/meta/cfg/kernel-cache/bsp/fishriver/fishriver-standard.scc
> @@ -9,3 +9,11 @@ include features/emgd/emgd.scc
>  git merge emgd
>  
>  include fishriver.scc
> +
> +# default policy for standard kernels
> +include cfg/usb-mass-storage.scc
> +include cfg/boot-live.scc
> +include features/logbuf/size-normal.scc
> +include features/latencytop/latencytop.scc
> +include features/profiling/profiling.scc
> +
> diff --git a/meta/cfg/kernel-cache/bsp/fishriver/fishriver.scc b/meta/cfg/kernel-cache/bsp/fishriver/fishriver.scc
> index e401274..6ae93f9 100644
> --- a/meta/cfg/kernel-cache/bsp/fishriver/fishriver.scc
> +++ b/meta/cfg/kernel-cache/bsp/fishriver/fishriver.scc
> @@ -8,16 +8,9 @@ include features/serial/8250.scc
>  include features/hpet/hpet.scc
>  include features/ericsson-3g/f5521gw.scc
>  include cfg/vesafb.scc
> -include cfg/usb-mass-storage.scc
> -include cfg/boot-live.scc
>  include cfg/smp.scc
>  include features/power/intel.scc
>  
> -include features/logbuf/size-normal.scc
> -
> -include features/latencytop/latencytop.scc
> -include features/profiling/profiling.scc
> -
>  include features/usb/ehci-hcd.scc
>  include features/usb/ohci-hcd.scc
>  include features/usb/uhci-hcd.scc

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

Re: [PATCH 09/10] meta/jasperforest: factor out policy-related options

[Darren Hart]

You know the drill, same as last three

On 05/10/2012 06:00 PM, tom.zanussi@intel.com wrote:
> From: Tom Zanussi <tom.zanussi@intel.com>
> 
> Refactor bsp/common-pc/common-pc* to keep hardware-related options in
> the base jasperforest.scc while moving the more 'policy'-related
> options into the files that include the base jasperforest.scc
> fragment.
> 
> This allows the different kernel types to make use of the basic
> machine support without dragging along possibly unwanted options that
> fall under the heading of 'policy' for a specific kernel type.
> 
> Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>

Acked-by: Darren Hart <dvhart@linux.intel.com>

> ---
>  .../bsp/jasperforest/jasperforest-preempt-rt.scc   |    7 +++++++
>  .../bsp/jasperforest/jasperforest-standard.scc     |    6 ++++++
>  .../kernel-cache/bsp/jasperforest/jasperforest.scc |    6 ------
>  3 files changed, 13 insertions(+), 6 deletions(-)
> 
> diff --git a/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest-preempt-rt.scc b/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest-preempt-rt.scc
> index 4b5c2ca..b3a6370 100644
> --- a/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest-preempt-rt.scc
> +++ b/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest-preempt-rt.scc
> @@ -5,4 +5,11 @@ define KARCH x86_64
>  # no new branch required, re-use the ktypes/preempt-rt branch
>  include ktypes/preempt-rt
>  include bsp/common-pc-64/common-pc-64.scc
> +
>  include jasperforest.scc
> +
> +# default policy for preempt-rt kernels
> +include cfg/usb-mass-storage.scc
> +include features/logbuf/size-normal.scc
> +include features/latencytop/latencytop.scc
> +include features/profiling/profiling.scc
> diff --git a/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest-standard.scc b/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest-standard.scc
> index baf66d8..ec7a10a 100644
> --- a/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest-standard.scc
> +++ b/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest-standard.scc
> @@ -6,3 +6,9 @@ include bsp/common-pc-64/common-pc-64-standard
>  branch jasperforest
>  
>  include jasperforest.scc
> +
> +# default policy for standard kernels
> +include cfg/usb-mass-storage.scc
> +include features/logbuf/size-normal.scc
> +include features/latencytop/latencytop.scc
> +include features/profiling/profiling.scc
> diff --git a/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest.scc b/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest.scc
> index 82f0f52..68afd4a 100644
> --- a/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest.scc
> +++ b/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest.scc
> @@ -2,14 +2,8 @@ kconf hardware jasperforest.cfg
>  
>  include features/serial/8250.scc
>  include cfg/vesafb.scc
> -include cfg/usb-mass-storage.scc
>  include features/power/intel.scc
>  
> -include features/logbuf/size-normal.scc
> -
> -include features/latencytop/latencytop.scc
> -include features/profiling/profiling.scc
> -
>  include features/usb/ehci-hcd.scc
>  include features/usb/ohci-hcd.scc
>  include features/usb/uhci-hcd.scc

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

Re: [PATCH 10/10] meta/sugarbay: factor out policy-related options

[Darren Hart]

ditto

On 05/10/2012 06:00 PM, tom.zanussi@intel.com wrote:
> From: Tom Zanussi <tom.zanussi@intel.com>
> 
> Refactor bsp/common-pc/common-pc* to keep hardware-related options in
> the base sugarbay.scc while moving the more 'policy'-related options
> into the files that include the base sugarbay.scc fragment.
> 
> This allows the different kernel types to make use of the basic
> machine support without dragging along possibly unwanted options that
> fall under the heading of 'policy' for a specific kernel type.
> 
> Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>

Acked-by: Darren Hart <dvhart@linux.intel.com>

> ---
>  .../bsp/sugarbay/sugarbay-preempt-rt.scc           |    7 +++++++
>  .../bsp/sugarbay/sugarbay-standard.scc             |    6 ++++++
>  meta/cfg/kernel-cache/bsp/sugarbay/sugarbay.scc    |    6 ------
>  3 files changed, 13 insertions(+), 6 deletions(-)
> 
> diff --git a/meta/cfg/kernel-cache/bsp/sugarbay/sugarbay-preempt-rt.scc b/meta/cfg/kernel-cache/bsp/sugarbay/sugarbay-preempt-rt.scc
> index e824f6f..d9df73b 100644
> --- a/meta/cfg/kernel-cache/bsp/sugarbay/sugarbay-preempt-rt.scc
> +++ b/meta/cfg/kernel-cache/bsp/sugarbay/sugarbay-preempt-rt.scc
> @@ -5,4 +5,11 @@ define KARCH x86_64
>  # no new branch required, re-use the ktypes/preempt-rt branch
>  include ktypes/preempt-rt
>  include bsp/common-pc-64/common-pc-64.scc
> +
>  include sugarbay.scc
> +
> +# default policy for preempt-rt kernels
> +include cfg/usb-mass-storage.scc
> +include features/logbuf/size-normal.scc
> +include features/latencytop/latencytop.scc
> +include features/profiling/profiling.scc
> diff --git a/meta/cfg/kernel-cache/bsp/sugarbay/sugarbay-standard.scc b/meta/cfg/kernel-cache/bsp/sugarbay/sugarbay-standard.scc
> index 8c2a19b..421364e 100644
> --- a/meta/cfg/kernel-cache/bsp/sugarbay/sugarbay-standard.scc
> +++ b/meta/cfg/kernel-cache/bsp/sugarbay/sugarbay-standard.scc
> @@ -6,3 +6,9 @@ include bsp/common-pc-64/common-pc-64-standard
>  branch sugarbay
>  
>  include sugarbay.scc
> +
> +# default policy for standard kernels
> +include cfg/usb-mass-storage.scc
> +include features/logbuf/size-normal.scc
> +include features/latencytop/latencytop.scc
> +include features/profiling/profiling.scc
> diff --git a/meta/cfg/kernel-cache/bsp/sugarbay/sugarbay.scc b/meta/cfg/kernel-cache/bsp/sugarbay/sugarbay.scc
> index 128efd3..d8144f0 100644
> --- a/meta/cfg/kernel-cache/bsp/sugarbay/sugarbay.scc
> +++ b/meta/cfg/kernel-cache/bsp/sugarbay/sugarbay.scc
> @@ -2,14 +2,8 @@ kconf hardware sugarbay.cfg
>  
>  include features/i915/i915.scc
>  include features/serial/8250.scc
> -include cfg/usb-mass-storage.scc
>  include features/power/intel.scc
>  
> -include features/logbuf/size-normal.scc
> -
> -include features/latencytop/latencytop.scc
> -include features/profiling/profiling.scc
> -
>  include features/usb/ehci-hcd.scc
>  include features/usb/ohci-hcd.scc
>  include features/usb/uhci-hcd.scc

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

Re: [PATCH 02/10] meta/common-pc: use usb features

[Tom Zanussi]

On Fri, 2012-05-11 at 09:12 -0700, Darren Hart wrote:
> 
> On 05/10/2012 05:59 PM, tom.zanussi@intel.com wrote:
> > From: Tom Zanussi <tom.zanussi@intel.com>
> > 
> > Use the available ehci and uhci usb features and remove the associated
> > config settings from the top-level common-pc feature.
> > 
> > Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
> 
> For what this does:
> 
> Acked-by: Darren Hart <dvhart@linux.intel.com>
> 
> Further thoughts:
> 
> I wonder why common-pc does not include OHCI HCDs?
> 
> >  CONFIG_USB_STORAGE=y
> 
> This should really be pulled out as well and added to the standard and
> preempt-rt bsp-ktype.scc files.
> 

The CONFIG_USB_STORAGE setting here is standalone, and the common-pc*
don't have the other options contained in the usb-mass-storage feature,
so that's why this was left behind.  Perhaps they should also include
the usb-mass-storage feature as well, but that would be adding more than
cleanup at this point.

Anyway, note that the later patches do add the usb-mass-storage to the
standard and preempt-rt files for the other non-common-pc* BSPs in the
patchset. 

> 
> >  CONFIG_USB_HID=y
> >  CONFIG_USB_HIDDEV=y
> > diff --git a/meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc b/meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc
> > index bab45e6..2338ea6 100644
> > --- a/meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc
> > +++ b/meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc
> > @@ -2,6 +2,8 @@ kconf hardware common-pc.cfg
> >  kconf hardware common-pc-gfx.cfg
> >  
> >  include cfg/boot-live.scc
> 
> This should be moved to the standard and preempt-rt bsp-ktype.scc files
> as well.
> 

The later patches do this for the boot-live feature.

Tom

> > +include features/usb/ehci-hcd.scc
> > +include features/usb/uhci-hcd.scc
> >  include features/intel-e1xxxx/intel-e100.scc
> >  include features/intel-e1xxxx/intel-e1xxxx.scc
> >  include features/latencytop/latencytop.scc
> 

Re: [PATCH 04/10] meta/common-pc: factor out policy-related options

[Tom Zanussi]

On Fri, 2012-05-11 at 09:15 -0700, Darren Hart wrote:
> 
> On 05/10/2012 06:00 PM, tom.zanussi@intel.com wrote:
> > From: Tom Zanussi <tom.zanussi@intel.com>
> > 
> > Refactor bsp/common-pc/common-pc* to keep hardware-related options in
> > the base common-pc.scc while moving the more 'policy'-related options
> > into the files that include the base common-pc.scc fragment.
> > 
> > This allows the different kernel types to make use of the basic
> > machine support without dragging along possibly unwanted options that
> > fall under the heading of 'policy' for a specific kernel type.
> > 
> > Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
> > ---
> >  .../bsp/common-pc/common-pc-preempt-rt.scc         |    7 +++++++
> >  .../bsp/common-pc/common-pc-standard.scc           |    6 ++++++
> >  .../kernel-cache/bsp/common-pc/common-pc-tiny.scc  |    5 +----
> >  meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc  |    4 ----
> >  4 files changed, 14 insertions(+), 8 deletions(-)
> > 
> > diff --git a/meta/cfg/kernel-cache/bsp/common-pc/common-pc-preempt-rt.scc b/meta/cfg/kernel-cache/bsp/common-pc/common-pc-preempt-rt.scc
> > index f8716ee..706f669 100644
> > --- a/meta/cfg/kernel-cache/bsp/common-pc/common-pc-preempt-rt.scc
> > +++ b/meta/cfg/kernel-cache/bsp/common-pc/common-pc-preempt-rt.scc
> > @@ -4,4 +4,11 @@ define KARCH i386
> >  
> >  # no new branch required, re-use the ktypes/preempt-rt branch
> >  include ktypes/preempt-rt
> > +
> >  include bsp/common-pc/common-pc.scc
> > +
> > +# default policy for preempt-rt kernels
> 
> 
> needs  usb-mass-storage here
> 

Again, note that the original common-pc* doesn't have these options
other than CONFIG_USB_STORAGE and CONFIG_SCSI.

> > +include cfg/boot-live.scc
> > +include features/latencytop/latencytop.scc
> > +include features/profiling/profiling.scc
> > +include cfg/virtio.scc
> > diff --git a/meta/cfg/kernel-cache/bsp/common-pc/common-pc-standard.scc b/meta/cfg/kernel-cache/bsp/common-pc/common-pc-standard.scc
> > index f5baf52..83d49fd 100644
> > --- a/meta/cfg/kernel-cache/bsp/common-pc/common-pc-standard.scc
> > +++ b/meta/cfg/kernel-cache/bsp/common-pc/common-pc-standard.scc
> > @@ -6,3 +6,9 @@ include ktypes/standard
> >  branch common-pc
> >  
> >  include common-pc.scc
> > +
> > +# default policy for standard kernels
> 
> needs  usb-mass-storage here and the config removed from common-pc.cfg
> 

Same here...

Tom

> > +include cfg/boot-live.scc
> > +include features/latencytop/latencytop.scc
> > +include features/profiling/profiling.scc
> > +include cfg/virtio.scc
> > diff --git a/meta/cfg/kernel-cache/bsp/common-pc/common-pc-tiny.scc b/meta/cfg/kernel-cache/bsp/common-pc/common-pc-tiny.scc
> > index 8d7a498..900eb27 100644
> > --- a/meta/cfg/kernel-cache/bsp/common-pc/common-pc-tiny.scc
> > +++ b/meta/cfg/kernel-cache/bsp/common-pc/common-pc-tiny.scc
> > @@ -5,8 +5,5 @@ define KARCH i386
> >  include ktypes/tiny
> >  branch common-pc
> >  
> > -# Don't include common-pc.scc directly,
> > -# it pulls in too many non-hardware options
> > -kconf hardware common-pc.cfg
> > -kconf hardware common-pc-gfx.cfg
> > +include common-pc.scc
> 
> Nice!
> 
> > diff --git a/meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc b/meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc
> > index 2338ea6..9bd72c1 100644
> > --- a/meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc
> > +++ b/meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc
> > @@ -1,11 +1,7 @@
> >  kconf hardware common-pc.cfg
> >  kconf hardware common-pc-gfx.cfg
> >  
> > -include cfg/boot-live.scc
> >  include features/usb/ehci-hcd.scc
> >  include features/usb/uhci-hcd.scc
> >  include features/intel-e1xxxx/intel-e100.scc
> >  include features/intel-e1xxxx/intel-e1xxxx.scc
> > -include features/latencytop/latencytop.scc
> > -include features/profiling/profiling.scc
> > -include cfg/virtio.scc
> 
> Nice.
> 

Re: [PATCH 02/10] meta/common-pc: use usb features

[Bruce Ashfield]

On 12-05-11 03:26 PM, Tom Zanussi wrote:
> On Fri, 2012-05-11 at 09:12 -0700, Darren Hart wrote:
>>
>> On 05/10/2012 05:59 PM, tom.zanussi@intel.com wrote:
>>> From: Tom Zanussi<tom.zanussi@intel.com>
>>>
>>> Use the available ehci and uhci usb features and remove the associated
>>> config settings from the top-level common-pc feature.
>>>
>>> Signed-off-by: Tom Zanussi<tom.zanussi@intel.com>
>>
>> For what this does:
>>
>> Acked-by: Darren Hart<dvhart@linux.intel.com>
>>
>> Further thoughts:
>>
>> I wonder why common-pc does not include OHCI HCDs?
>>
>>>   CONFIG_USB_STORAGE=y
>>
>> This should really be pulled out as well and added to the standard and
>> preempt-rt bsp-ktype.scc files.
>>
>
> The CONFIG_USB_STORAGE setting here is standalone, and the common-pc*
> don't have the other options contained in the usb-mass-storage feature,
> so that's why this was left behind.  Perhaps they should also include
> the usb-mass-storage feature as well, but that would be adding more than
> cleanup at this point.

Agreed. We can address that later, but for the cleanup, I can see why
it's orphaned.

This all change looks fine to me.

Bruce

>
> Anyway, note that the later patches do add the usb-mass-storage to the
> standard and preempt-rt files for the other non-common-pc* BSPs in the
> patchset.
>
>>
>>>   CONFIG_USB_HID=y
>>>   CONFIG_USB_HIDDEV=y
>>> diff --git a/meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc b/meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc
>>> index bab45e6..2338ea6 100644
>>> --- a/meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc
>>> +++ b/meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc
>>> @@ -2,6 +2,8 @@ kconf hardware common-pc.cfg
>>>   kconf hardware common-pc-gfx.cfg
>>>
>>>   include cfg/boot-live.scc
>>
>> This should be moved to the standard and preempt-rt bsp-ktype.scc files
>> as well.
>>
>
> The later patches do this for the boot-live feature.
>
> Tom
>
>>> +include features/usb/ehci-hcd.scc
>>> +include features/usb/uhci-hcd.scc
>>>   include features/intel-e1xxxx/intel-e100.scc
>>>   include features/intel-e1xxxx/intel-e1xxxx.scc
>>>   include features/latencytop/latencytop.scc
>>
>
>

Re: [PATCH 00/10][KERNEL][RFC] policy cleanup patches

[Bruce Ashfield]

On 12-05-10 09:00 PM, tom.zanussi@intel.com wrote:
> From: Tom Zanussi<tom.zanussi@intel.com>
>
> This set of patches factors out the policy vs hardware-related config
> of the common-pc and common-pc-64 along with some meta-intel BSPs.
>
> There are also a couple usb cleanups as well.
>
> This is an RFC patchset because it's completely untested at this
> point so shouldn't be pulled in - I wanted to get this pre-NAKed
> at least once before actually going through the trouble of testing.  ;-)

No NAK here. This looks fine to me. I only commented once, for everything
that I didn't say anything, that means no problems here.

Bruce

>
> Tom
>
> The following changes since commit 1dfd60fa1250259eed38ae5b2840eb37e3758a1b:
>    Tom Zanussi (1):
>          meta/fishriver: move smp options from recipe-space
>
> are available in the git repository at:
>
>    git://git.yoctoproject.org/linux-yocto-2.6.37-contrib.git tzanussi/policy-cleanup
>    http://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto-2.6.37-contrib/log/?h=tzanussi/policy-cleanup
>
> Tom Zanussi (10):
>    meta: add ROOT_HUB_TT config option to the usb/ehci-hcd feature
>    meta/common-pc: use usb features
>    meta/common-pc-64: use usb features
>    meta/common-pc: factor out policy-related options
>    meta/common-pc: factor out policy-related options
>    meta/crownbay: factor out policy-related options
>    meta/emenlow: factor out policy-related options
>    meta/emenlow: factor out policy-related options
>    meta/jasperforest: factor out policy-related options
>    meta/sugarbay: factor out policy-related options
>
>   .../bsp/common-pc-64/common-pc-64-preempt-rt.scc   |    6 ++++++
>   .../bsp/common-pc-64/common-pc-64-standard.scc     |    6 ++++++
>   .../kernel-cache/bsp/common-pc-64/common-pc-64.cfg |    3 ---
>   .../kernel-cache/bsp/common-pc-64/common-pc-64.scc |    8 ++------
>   .../bsp/common-pc/common-pc-preempt-rt.scc         |    7 +++++++
>   .../bsp/common-pc/common-pc-standard.scc           |    6 ++++++
>   .../kernel-cache/bsp/common-pc/common-pc-tiny.scc  |    5 +----
>   meta/cfg/kernel-cache/bsp/common-pc/common-pc.cfg  |    5 -----
>   meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc  |    6 ++----
>   .../bsp/crownbay/crownbay-preempt-rt.scc           |    8 ++++++++
>   .../bsp/crownbay/crownbay-standard.scc             |    7 +++++++
>   meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc    |    7 -------
>   .../bsp/emenlow/emenlow-preempt-rt.scc             |    8 ++++++++
>   .../kernel-cache/bsp/emenlow/emenlow-standard.scc  |    8 ++++++++
>   meta/cfg/kernel-cache/bsp/emenlow/emenlow.scc      |    7 -------
>   .../bsp/fishriver/fishriver-preempt-rt.scc         |    8 ++++++++
>   .../bsp/fishriver/fishriver-standard.scc           |    8 ++++++++
>   meta/cfg/kernel-cache/bsp/fishriver/fishriver.scc  |    7 -------
>   .../bsp/jasperforest/jasperforest-preempt-rt.scc   |    7 +++++++
>   .../bsp/jasperforest/jasperforest-standard.scc     |    6 ++++++
>   .../kernel-cache/bsp/jasperforest/jasperforest.scc |    6 ------
>   .../bsp/sugarbay/sugarbay-preempt-rt.scc           |    7 +++++++
>   .../bsp/sugarbay/sugarbay-standard.scc             |    6 ++++++
>   meta/cfg/kernel-cache/bsp/sugarbay/sugarbay.scc    |    6 ------
>   meta/cfg/kernel-cache/features/usb/ehci-hcd.cfg    |    1 +
>   25 files changed, 104 insertions(+), 55 deletions(-)
>

Re: [PATCH 00/10][KERNEL][RFC] policy cleanup patches

[Tom Zanussi]

On Fri, 2012-05-11 at 16:17 -0400, Bruce Ashfield wrote:
> On 12-05-10 09:00 PM, tom.zanussi@intel.com wrote:
> > From: Tom Zanussi<tom.zanussi@intel.com>
> >
> > This set of patches factors out the policy vs hardware-related config
> > of the common-pc and common-pc-64 along with some meta-intel BSPs.
> >
> > There are also a couple usb cleanups as well.
> >
> > This is an RFC patchset because it's completely untested at this
> > point so shouldn't be pulled in - I wanted to get this pre-NAKed
> > at least once before actually going through the trouble of testing.  ;-)
> 
> No NAK here. This looks fine to me. I only commented once, for everything
> that I didn't say anything, that means no problems here.
> 

OK, thanks, Bruce.  I'll fix the few things up that Darren mentioned and
start testing, then...

Tom

> Bruce
> 
> >
> > Tom
> >
> > The following changes since commit 1dfd60fa1250259eed38ae5b2840eb37e3758a1b:
> >    Tom Zanussi (1):
> >          meta/fishriver: move smp options from recipe-space
> >
> > are available in the git repository at:
> >
> >    git://git.yoctoproject.org/linux-yocto-2.6.37-contrib.git tzanussi/policy-cleanup
> >    http://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto-2.6.37-contrib/log/?h=tzanussi/policy-cleanup
> >
> > Tom Zanussi (10):
> >    meta: add ROOT_HUB_TT config option to the usb/ehci-hcd feature
> >    meta/common-pc: use usb features
> >    meta/common-pc-64: use usb features
> >    meta/common-pc: factor out policy-related options
> >    meta/common-pc: factor out policy-related options
> >    meta/crownbay: factor out policy-related options
> >    meta/emenlow: factor out policy-related options
> >    meta/emenlow: factor out policy-related options
> >    meta/jasperforest: factor out policy-related options
> >    meta/sugarbay: factor out policy-related options
> >
> >   .../bsp/common-pc-64/common-pc-64-preempt-rt.scc   |    6 ++++++
> >   .../bsp/common-pc-64/common-pc-64-standard.scc     |    6 ++++++
> >   .../kernel-cache/bsp/common-pc-64/common-pc-64.cfg |    3 ---
> >   .../kernel-cache/bsp/common-pc-64/common-pc-64.scc |    8 ++------
> >   .../bsp/common-pc/common-pc-preempt-rt.scc         |    7 +++++++
> >   .../bsp/common-pc/common-pc-standard.scc           |    6 ++++++
> >   .../kernel-cache/bsp/common-pc/common-pc-tiny.scc  |    5 +----
> >   meta/cfg/kernel-cache/bsp/common-pc/common-pc.cfg  |    5 -----
> >   meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc  |    6 ++----
> >   .../bsp/crownbay/crownbay-preempt-rt.scc           |    8 ++++++++
> >   .../bsp/crownbay/crownbay-standard.scc             |    7 +++++++
> >   meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc    |    7 -------
> >   .../bsp/emenlow/emenlow-preempt-rt.scc             |    8 ++++++++
> >   .../kernel-cache/bsp/emenlow/emenlow-standard.scc  |    8 ++++++++
> >   meta/cfg/kernel-cache/bsp/emenlow/emenlow.scc      |    7 -------
> >   .../bsp/fishriver/fishriver-preempt-rt.scc         |    8 ++++++++
> >   .../bsp/fishriver/fishriver-standard.scc           |    8 ++++++++
> >   meta/cfg/kernel-cache/bsp/fishriver/fishriver.scc  |    7 -------
> >   .../bsp/jasperforest/jasperforest-preempt-rt.scc   |    7 +++++++
> >   .../bsp/jasperforest/jasperforest-standard.scc     |    6 ++++++
> >   .../kernel-cache/bsp/jasperforest/jasperforest.scc |    6 ------
> >   .../bsp/sugarbay/sugarbay-preempt-rt.scc           |    7 +++++++
> >   .../bsp/sugarbay/sugarbay-standard.scc             |    6 ++++++
> >   meta/cfg/kernel-cache/bsp/sugarbay/sugarbay.scc    |    6 ------
> >   meta/cfg/kernel-cache/features/usb/ehci-hcd.cfg    |    1 +
> >   25 files changed, 104 insertions(+), 55 deletions(-)
> >
> 

Re: [PATCH 06/10] meta/crownbay: factor out policy-related options

[Tom Zanussi]

On Fri, 2012-05-11 at 09:18 -0700, Darren Hart wrote:
> 
> On 05/10/2012 06:00 PM, tom.zanussi@intel.com wrote:
> > From: Tom Zanussi <tom.zanussi@intel.com>
> > 
> > Refactor bsp/common-pc/common-pc* to keep hardware-related options in
> 
> oops                   ^
> 
> > the base crownbay.scc while moving the more 'policy'-related options
> > into the files that include the base crownbay.scc fragment.
> > 
> > This allows the different kernel types to make use of the basic
> > machine support without dragging along possibly unwanted options that
> > fall under the heading of 'policy' for a specific kernel type.
> > 
> > Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
> 
> 
> With minor comment tweak above:
> 
> Acked-by-by: Darren Hart <dvhart@linux.intel.com>
> 
> > ---
> >  .../bsp/crownbay/crownbay-preempt-rt.scc           |    8 ++++++++
> >  .../bsp/crownbay/crownbay-standard.scc             |    7 +++++++
> >  meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc    |    7 -------
> >  3 files changed, 15 insertions(+), 7 deletions(-)
> > 
> > diff --git a/meta/cfg/kernel-cache/bsp/crownbay/crownbay-preempt-rt.scc b/meta/cfg/kernel-cache/bsp/crownbay/crownbay-preempt-rt.scc
> > index d58b4be..11067ef 100644
> > --- a/meta/cfg/kernel-cache/bsp/crownbay/crownbay-preempt-rt.scc
> > +++ b/meta/cfg/kernel-cache/bsp/crownbay/crownbay-preempt-rt.scc
> > @@ -4,4 +4,12 @@ define KARCH i386
> >  
> >  # no new branch required, re-use the ktypes/preempt-rt branch
> >  include ktypes/preempt-rt
> > +
> >  include crownbay.scc
> > +
> > +# default policy for preempt-rt kernels
> > +include cfg/usb-mass-storage.scc
> > +include cfg/boot-live.scc
> > +include features/logbuf/size-normal.scc
> > +include features/latencytop/latencytop.scc
> > +include features/profiling/profiling.scc
> > diff --git a/meta/cfg/kernel-cache/bsp/crownbay/crownbay-standard.scc b/meta/cfg/kernel-cache/bsp/crownbay/crownbay-standard.scc
> > index d6036f7..dd9dbc7 100644
> > --- a/meta/cfg/kernel-cache/bsp/crownbay/crownbay-standard.scc
> > +++ b/meta/cfg/kernel-cache/bsp/crownbay/crownbay-standard.scc
> > @@ -9,3 +9,10 @@ include features/emgd/emgd-1.10.scc
> >  git merge emgd-1.10
> >  
> >  include crownbay.scc
> > +
> > +# default policy for standard kernels
> > +include cfg/usb-mass-storage.scc
> > +include cfg/boot-live.scc
> > +include features/logbuf/size-normal.scc
> > +include features/latencytop/latencytop.scc
> > +include features/profiling/profiling.scc
> > diff --git a/meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc b/meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc
> > index c4bc1a5..82ed6f3 100644
> > --- a/meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc
> > +++ b/meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc
> > @@ -8,16 +8,9 @@ include cfg/dmaengine.scc
> >  include features/serial/8250.scc
> >  include features/hpet/hpet.scc
> >  include cfg/vesafb.scc
> > -include cfg/usb-mass-storage.scc
> > -include cfg/boot-live.scc
> >  include cfg/smp.scc
> >  include features/power/intel.scc
> >  
> > -include features/logbuf/size-normal.scc
> > -
> > -include features/latencytop/latencytop.scc
> > -include features/profiling/profiling.scc
> > -
> >  include features/usb/ehci-hcd.scc
> >  include features/usb/ohci-hcd.scc
> >  include features/usb/uhci-hcd.scc
> 
> Independent from this patch, but does crownbay have all three? ehci and
> ohci seems a lot more likely to me.
> 

lsusb shows ehci and ohci, but why did you think ohci would be more
likely?

Tom

Re: [PATCH 06/10] meta/crownbay: factor out policy-related options

[Tom Zanussi]

On Fri, 2012-05-11 at 17:08 -0500, Tom Zanussi wrote:
> On Fri, 2012-05-11 at 09:18 -0700, Darren Hart wrote:
> > 
> > On 05/10/2012 06:00 PM, tom.zanussi@intel.com wrote:
> > > From: Tom Zanussi <tom.zanussi@intel.com>
> > > 
> > > Refactor bsp/common-pc/common-pc* to keep hardware-related options in
> > 
> > oops                   ^
> > 
> > > the base crownbay.scc while moving the more 'policy'-related options
> > > into the files that include the base crownbay.scc fragment.
> > > 
> > > This allows the different kernel types to make use of the basic
> > > machine support without dragging along possibly unwanted options that
> > > fall under the heading of 'policy' for a specific kernel type.
> > > 
> > > Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
> > 
> > 
> > With minor comment tweak above:
> > 
> > Acked-by-by: Darren Hart <dvhart@linux.intel.com>
> > 
> > > ---
> > >  .../bsp/crownbay/crownbay-preempt-rt.scc           |    8 ++++++++
> > >  .../bsp/crownbay/crownbay-standard.scc             |    7 +++++++
> > >  meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc    |    7 -------
> > >  3 files changed, 15 insertions(+), 7 deletions(-)
> > > 
> > > diff --git a/meta/cfg/kernel-cache/bsp/crownbay/crownbay-preempt-rt.scc b/meta/cfg/kernel-cache/bsp/crownbay/crownbay-preempt-rt.scc
> > > index d58b4be..11067ef 100644
> > > --- a/meta/cfg/kernel-cache/bsp/crownbay/crownbay-preempt-rt.scc
> > > +++ b/meta/cfg/kernel-cache/bsp/crownbay/crownbay-preempt-rt.scc
> > > @@ -4,4 +4,12 @@ define KARCH i386
> > >  
> > >  # no new branch required, re-use the ktypes/preempt-rt branch
> > >  include ktypes/preempt-rt
> > > +
> > >  include crownbay.scc
> > > +
> > > +# default policy for preempt-rt kernels
> > > +include cfg/usb-mass-storage.scc
> > > +include cfg/boot-live.scc
> > > +include features/logbuf/size-normal.scc
> > > +include features/latencytop/latencytop.scc
> > > +include features/profiling/profiling.scc
> > > diff --git a/meta/cfg/kernel-cache/bsp/crownbay/crownbay-standard.scc b/meta/cfg/kernel-cache/bsp/crownbay/crownbay-standard.scc
> > > index d6036f7..dd9dbc7 100644
> > > --- a/meta/cfg/kernel-cache/bsp/crownbay/crownbay-standard.scc
> > > +++ b/meta/cfg/kernel-cache/bsp/crownbay/crownbay-standard.scc
> > > @@ -9,3 +9,10 @@ include features/emgd/emgd-1.10.scc
> > >  git merge emgd-1.10
> > >  
> > >  include crownbay.scc
> > > +
> > > +# default policy for standard kernels
> > > +include cfg/usb-mass-storage.scc
> > > +include cfg/boot-live.scc
> > > +include features/logbuf/size-normal.scc
> > > +include features/latencytop/latencytop.scc
> > > +include features/profiling/profiling.scc
> > > diff --git a/meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc b/meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc
> > > index c4bc1a5..82ed6f3 100644
> > > --- a/meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc
> > > +++ b/meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc
> > > @@ -8,16 +8,9 @@ include cfg/dmaengine.scc
> > >  include features/serial/8250.scc
> > >  include features/hpet/hpet.scc
> > >  include cfg/vesafb.scc
> > > -include cfg/usb-mass-storage.scc
> > > -include cfg/boot-live.scc
> > >  include cfg/smp.scc
> > >  include features/power/intel.scc
> > >  
> > > -include features/logbuf/size-normal.scc
> > > -
> > > -include features/latencytop/latencytop.scc
> > > -include features/profiling/profiling.scc
> > > -
> > >  include features/usb/ehci-hcd.scc
> > >  include features/usb/ohci-hcd.scc
> > >  include features/usb/uhci-hcd.scc
> > 
> > Independent from this patch, but does crownbay have all three? ehci and
> > ohci seems a lot more likely to me.
> > 
> 
> lsusb shows ehci and ohci, but why did you think ohci would be more
> likely?
> 

Never mind, yeah, that's what the eg20t data sheet says as well, somehow
thought it would be uhci...

Tom

> Tom
> 
> 
> 
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto

Re: [PATCH 06/10] meta/crownbay: factor out policy-related options

[Darren Hart]

On 05/11/2012 03:08 PM, Tom Zanussi wrote:
> On Fri, 2012-05-11 at 09:18 -0700, Darren Hart wrote:

>> Independent from this patch, but does crownbay have all three? ehci and
>> ohci seems a lot more likely to me.
>>
> 
> lsusb shows ehci and ohci, but why did you think ohci would be more
> likely?
> 
> Tom


I believe UHCI is only seen on non-intel platforms, primarily AMD and
maybe VIA systems... just something I had a vague recollection of.

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

Re: [PATCH 06/10] meta/crownbay: factor out policy-related options

[Tom Zanussi]

On Fri, 2012-05-11 at 15:35 -0700, Darren Hart wrote:
> 
> On 05/11/2012 03:08 PM, Tom Zanussi wrote:
> > On Fri, 2012-05-11 at 09:18 -0700, Darren Hart wrote:
> 
> >> Independent from this patch, but does crownbay have all three? ehci and
> >> ohci seems a lot more likely to me.
> >>
> > 
> > lsusb shows ehci and ohci, but why did you think ohci would be more
> > likely?
> > 
> > Tom
> 
> 
> I believe UHCI is only seen on non-intel platforms, primarily AMD and
> maybe VIA systems... just something I had a vague recollection of.
> 

I thought it was the opposite, but was probably thrown off by emenlow
which has UHCI...

Tom

Re: [PATCH 06/10] meta/crownbay: factor out policy-related options

[Darren Hart]

On 05/11/2012 03:42 PM, Tom Zanussi wrote:
> On Fri, 2012-05-11 at 15:35 -0700, Darren Hart wrote:
>>
>> On 05/11/2012 03:08 PM, Tom Zanussi wrote:
>>> On Fri, 2012-05-11 at 09:18 -0700, Darren Hart wrote:
>>
>>>> Independent from this patch, but does crownbay have all three? ehci and
>>>> ohci seems a lot more likely to me.
>>>>
>>>
>>> lsusb shows ehci and ohci, but why did you think ohci would be more
>>> likely?
>>>
>>> Tom
>>
>>
>> I believe UHCI is only seen on non-intel platforms, primarily AMD and
>> maybe VIA systems... just something I had a vague recollection of.
>>
> 
> I thought it was the opposite, but was probably thrown off by emenlow
> which has UHCI...

  │ Symbol: USB_UHCI_HCD [=y]                                                  │  
  │ Type  : tristate                                                           │  
  │ Prompt: UHCI HCD (most Intel and VIA) support                              │  
  │   Defined at drivers/usb/host/Kconfig:444                                  │  
  │   Depends on: USB_SUPPORT [=y] && USB [=y] && (PCI [=y] || SPARC_LEON)     │  
  │   Location:                                                                │  
  │     -> Device Drivers                                                      │  
  │       -> USB support (USB_SUPPORT [=y]) 


And I see lots of ARM OHCI bits... so maybe you're right. But for the EG20T, as
you pointed out, it seems to be EHCI and OHCI for whatever reason.


-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel