All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] au0828: Add USB ID used by many dongles
@ 2012-05-11  6:14 Ismael Luceno
  2012-05-11  6:14 ` [PATCH 2/2] au0828: Move under dvb Ismael Luceno
  0 siblings, 1 reply; 7+ messages in thread
From: Ismael Luceno @ 2012-05-11  6:14 UTC (permalink / raw)
  To: linux-media; +Cc: Ismael Luceno

Tested with Yfeng 680 ATV dongle.

Signed-off-by: Ismael Luceno <ismael.luceno@gmail.com>
---
 drivers/media/video/au0828/au0828-cards.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/media/video/au0828/au0828-cards.c b/drivers/media/video/au0828/au0828-cards.c
index 1c6015a..e3fe9a6 100644
--- a/drivers/media/video/au0828/au0828-cards.c
+++ b/drivers/media/video/au0828/au0828-cards.c
@@ -325,6 +325,8 @@ struct usb_device_id au0828_usb_id_table[] = {
 		.driver_info = AU0828_BOARD_HAUPPAUGE_HVR950Q_MXL },
 	{ USB_DEVICE(0x2040, 0x7281),
 		.driver_info = AU0828_BOARD_HAUPPAUGE_HVR950Q_MXL },
+	{ USB_DEVICE(0x05e1, 0x0480),
+		.driver_info = AU0828_BOARD_HAUPPAUGE_WOODBURY },
 	{ USB_DEVICE(0x2040, 0x8200),
 		.driver_info = AU0828_BOARD_HAUPPAUGE_WOODBURY },
 	{ USB_DEVICE(0x2040, 0x7260),
-- 
1.7.10


^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH 2/2] au0828: Move under dvb
  2012-05-11  6:14 [PATCH 1/2] au0828: Add USB ID used by many dongles Ismael Luceno
@ 2012-05-11  6:14 ` Ismael Luceno
  2012-05-11 12:04   ` Devin Heitmueller
  0 siblings, 1 reply; 7+ messages in thread
From: Ismael Luceno @ 2012-05-11  6:14 UTC (permalink / raw)
  To: linux-media; +Cc: Ismael Luceno

Signed-off-by: Ismael Luceno <ismael.luceno@gmail.com>
---
 drivers/media/dvb/Kconfig                          |    1 +
 drivers/media/dvb/Makefile                         |    1 +
 drivers/media/{video => dvb}/au0828/Kconfig        |    0
 drivers/media/{video => dvb}/au0828/Makefile       |    0
 drivers/media/{video => dvb}/au0828/au0828-cards.c |    0
 drivers/media/{video => dvb}/au0828/au0828-cards.h |    0
 drivers/media/{video => dvb}/au0828/au0828-core.c  |    0
 drivers/media/{video => dvb}/au0828/au0828-dvb.c   |    0
 drivers/media/{video => dvb}/au0828/au0828-i2c.c   |    0
 drivers/media/{video => dvb}/au0828/au0828-reg.h   |    0
 drivers/media/{video => dvb}/au0828/au0828-vbi.c   |    0
 drivers/media/{video => dvb}/au0828/au0828-video.c |    0
 drivers/media/{video => dvb}/au0828/au0828.h       |    0
 drivers/media/video/Kconfig                        |    2 --
 drivers/media/video/Makefile                       |    2 --
 15 files changed, 2 insertions(+), 4 deletions(-)
 rename drivers/media/{video => dvb}/au0828/Kconfig (100%)
 rename drivers/media/{video => dvb}/au0828/Makefile (100%)
 rename drivers/media/{video => dvb}/au0828/au0828-cards.c (100%)
 rename drivers/media/{video => dvb}/au0828/au0828-cards.h (100%)
 rename drivers/media/{video => dvb}/au0828/au0828-core.c (100%)
 rename drivers/media/{video => dvb}/au0828/au0828-dvb.c (100%)
 rename drivers/media/{video => dvb}/au0828/au0828-i2c.c (100%)
 rename drivers/media/{video => dvb}/au0828/au0828-reg.h (100%)
 rename drivers/media/{video => dvb}/au0828/au0828-vbi.c (100%)
 rename drivers/media/{video => dvb}/au0828/au0828-video.c (100%)
 rename drivers/media/{video => dvb}/au0828/au0828.h (100%)

diff --git a/drivers/media/dvb/Kconfig b/drivers/media/dvb/Kconfig
index f6e40b3..1cbb061 100644
--- a/drivers/media/dvb/Kconfig
+++ b/drivers/media/dvb/Kconfig
@@ -43,6 +43,7 @@ source "drivers/media/dvb/ttpci/Kconfig"
 
 comment "Supported USB Adapters"
 	depends on DVB_CORE && USB && I2C
+source "drivers/media/dvb/au0828/Kconfig"
 source "drivers/media/dvb/dvb-usb/Kconfig"
 source "drivers/media/dvb/ttusb-budget/Kconfig"
 source "drivers/media/dvb/ttusb-dec/Kconfig"
diff --git a/drivers/media/dvb/Makefile b/drivers/media/dvb/Makefile
index b2cefe6..3f28163 100644
--- a/drivers/media/dvb/Makefile
+++ b/drivers/media/dvb/Makefile
@@ -19,3 +19,4 @@ obj-y        := dvb-core/	\
 		ddbridge/
 
 obj-$(CONFIG_DVB_FIREDTV)	+= firewire/
+obj-$(CONFIG_VIDEO_AU0828)	+= au0828/
diff --git a/drivers/media/video/au0828/Kconfig b/drivers/media/dvb/au0828/Kconfig
similarity index 100%
rename from drivers/media/video/au0828/Kconfig
rename to drivers/media/dvb/au0828/Kconfig
diff --git a/drivers/media/video/au0828/Makefile b/drivers/media/dvb/au0828/Makefile
similarity index 100%
rename from drivers/media/video/au0828/Makefile
rename to drivers/media/dvb/au0828/Makefile
diff --git a/drivers/media/video/au0828/au0828-cards.c b/drivers/media/dvb/au0828/au0828-cards.c
similarity index 100%
rename from drivers/media/video/au0828/au0828-cards.c
rename to drivers/media/dvb/au0828/au0828-cards.c
diff --git a/drivers/media/video/au0828/au0828-cards.h b/drivers/media/dvb/au0828/au0828-cards.h
similarity index 100%
rename from drivers/media/video/au0828/au0828-cards.h
rename to drivers/media/dvb/au0828/au0828-cards.h
diff --git a/drivers/media/video/au0828/au0828-core.c b/drivers/media/dvb/au0828/au0828-core.c
similarity index 100%
rename from drivers/media/video/au0828/au0828-core.c
rename to drivers/media/dvb/au0828/au0828-core.c
diff --git a/drivers/media/video/au0828/au0828-dvb.c b/drivers/media/dvb/au0828/au0828-dvb.c
similarity index 100%
rename from drivers/media/video/au0828/au0828-dvb.c
rename to drivers/media/dvb/au0828/au0828-dvb.c
diff --git a/drivers/media/video/au0828/au0828-i2c.c b/drivers/media/dvb/au0828/au0828-i2c.c
similarity index 100%
rename from drivers/media/video/au0828/au0828-i2c.c
rename to drivers/media/dvb/au0828/au0828-i2c.c
diff --git a/drivers/media/video/au0828/au0828-reg.h b/drivers/media/dvb/au0828/au0828-reg.h
similarity index 100%
rename from drivers/media/video/au0828/au0828-reg.h
rename to drivers/media/dvb/au0828/au0828-reg.h
diff --git a/drivers/media/video/au0828/au0828-vbi.c b/drivers/media/dvb/au0828/au0828-vbi.c
similarity index 100%
rename from drivers/media/video/au0828/au0828-vbi.c
rename to drivers/media/dvb/au0828/au0828-vbi.c
diff --git a/drivers/media/video/au0828/au0828-video.c b/drivers/media/dvb/au0828/au0828-video.c
similarity index 100%
rename from drivers/media/video/au0828/au0828-video.c
rename to drivers/media/dvb/au0828/au0828-video.c
diff --git a/drivers/media/video/au0828/au0828.h b/drivers/media/dvb/au0828/au0828.h
similarity index 100%
rename from drivers/media/video/au0828/au0828.h
rename to drivers/media/dvb/au0828/au0828.h
diff --git a/drivers/media/video/Kconfig b/drivers/media/video/Kconfig
index ce1e7ba..5a717eb 100644
--- a/drivers/media/video/Kconfig
+++ b/drivers/media/video/Kconfig
@@ -721,8 +721,6 @@ menuconfig V4L_PCI_DRIVERS
 
 if V4L_PCI_DRIVERS
 
-source "drivers/media/video/au0828/Kconfig"
-
 source "drivers/media/video/bt8xx/Kconfig"
 
 source "drivers/media/video/cx18/Kconfig"
diff --git a/drivers/media/video/Makefile b/drivers/media/video/Makefile
index a6282a3..90602a9 100644
--- a/drivers/media/video/Makefile
+++ b/drivers/media/video/Makefile
@@ -198,8 +198,6 @@ obj-$(CONFIG_ARCH_DAVINCI)		+= davinci/
 
 obj-$(CONFIG_VIDEO_SH_VOU)		+= sh_vou.o
 
-obj-$(CONFIG_VIDEO_AU0828) += au0828/
-
 obj-$(CONFIG_USB_VIDEO_CLASS)	+= uvc/
 obj-$(CONFIG_VIDEO_SAA7164)     += saa7164/
 
-- 
1.7.10


^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] au0828: Move under dvb
  2012-05-11  6:14 ` [PATCH 2/2] au0828: Move under dvb Ismael Luceno
@ 2012-05-11 12:04   ` Devin Heitmueller
  2012-05-12  3:08     ` Ismael Luceno
  0 siblings, 1 reply; 7+ messages in thread
From: Devin Heitmueller @ 2012-05-11 12:04 UTC (permalink / raw)
  To: Ismael Luceno; +Cc: linux-media

On Fri, May 11, 2012 at 2:14 AM, Ismael Luceno <ismael.luceno@gmail.com> wrote:
> Signed-off-by: Ismael Luceno <ismael.luceno@gmail.com>
> ---
>  drivers/media/dvb/Kconfig                          |    1 +
>  drivers/media/dvb/Makefile                         |    1 +
>  drivers/media/{video => dvb}/au0828/Kconfig        |    0
>  drivers/media/{video => dvb}/au0828/Makefile       |    0
>  drivers/media/{video => dvb}/au0828/au0828-cards.c |    0
>  drivers/media/{video => dvb}/au0828/au0828-cards.h |    0
>  drivers/media/{video => dvb}/au0828/au0828-core.c  |    0
>  drivers/media/{video => dvb}/au0828/au0828-dvb.c   |    0
>  drivers/media/{video => dvb}/au0828/au0828-i2c.c   |    0
>  drivers/media/{video => dvb}/au0828/au0828-reg.h   |    0
>  drivers/media/{video => dvb}/au0828/au0828-vbi.c   |    0
>  drivers/media/{video => dvb}/au0828/au0828-video.c |    0
>  drivers/media/{video => dvb}/au0828/au0828.h       |    0
>  drivers/media/video/Kconfig                        |    2 --
>  drivers/media/video/Makefile                       |    2 --
>  15 files changed, 2 insertions(+), 4 deletions(-)
>  rename drivers/media/{video => dvb}/au0828/Kconfig (100%)
>  rename drivers/media/{video => dvb}/au0828/Makefile (100%)
>  rename drivers/media/{video => dvb}/au0828/au0828-cards.c (100%)
>  rename drivers/media/{video => dvb}/au0828/au0828-cards.h (100%)
>  rename drivers/media/{video => dvb}/au0828/au0828-core.c (100%)
>  rename drivers/media/{video => dvb}/au0828/au0828-dvb.c (100%)
>  rename drivers/media/{video => dvb}/au0828/au0828-i2c.c (100%)
>  rename drivers/media/{video => dvb}/au0828/au0828-reg.h (100%)
>  rename drivers/media/{video => dvb}/au0828/au0828-vbi.c (100%)
>  rename drivers/media/{video => dvb}/au0828/au0828-video.c (100%)
>  rename drivers/media/{video => dvb}/au0828/au0828.h (100%)

What is the motivation for moving these files?  The au0828 is a hybrid
bridge, and every other hybrid bridge is under video?

NACK unless somebody can provide a good reason for doing this.

Devin

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] au0828: Move under dvb
  2012-05-11 12:04   ` Devin Heitmueller
@ 2012-05-12  3:08     ` Ismael Luceno
  2012-05-12 10:21       ` Devin Heitmueller
  0 siblings, 1 reply; 7+ messages in thread
From: Ismael Luceno @ 2012-05-12  3:08 UTC (permalink / raw)
  To: Devin Heitmueller; +Cc: linux-media

[-- Attachment #1: Type: text/plain, Size: 572 bytes --]

On Fri, 11 May 2012 08:04:59 -0400
Devin Heitmueller <dheitmueller@kernellabs.com> wrote:
... 
> What is the motivation for moving these files?

Well, the device was on the wrong Kconfig section, and while thinking
about changing that, I just thought to move it under DVB.

> The au0828 is a hybrid bridge, and every other hybrid bridge is
> under video?

Sorry, the devices I got don't support analog, so I didn't thought
about it that much...

I guess it's arbitrary... isn't it? wouldn't it be better to have an
hybrid section? (just thinking out loud)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] au0828: Move under dvb
  2012-05-12  3:08     ` Ismael Luceno
@ 2012-05-12 10:21       ` Devin Heitmueller
  2012-05-20 13:32         ` Mauro Carvalho Chehab
  0 siblings, 1 reply; 7+ messages in thread
From: Devin Heitmueller @ 2012-05-12 10:21 UTC (permalink / raw)
  To: Ismael Luceno; +Cc: linux-media

On Fri, May 11, 2012 at 11:08 PM, Ismael Luceno <ismael.luceno@gmail.com> wrote:
> On Fri, 11 May 2012 08:04:59 -0400
> Devin Heitmueller <dheitmueller@kernellabs.com> wrote:
> ...
>> What is the motivation for moving these files?
>
> Well, the device was on the wrong Kconfig section, and while thinking
> about changing that, I just thought to move it under DVB.
>
>> The au0828 is a hybrid bridge, and every other hybrid bridge is
>> under video?
>
> Sorry, the devices I got don't support analog, so I didn't thought
> about it that much...
>
> I guess it's arbitrary... isn't it? wouldn't it be better to have an
> hybrid section? (just thinking out loud)

Yeah, in this case it's largely historical (a product from before the
V4L and DVB subsystems were merged).  At this point I don't see any
real advantage to arbitrarily moving the stuff around.  And in fact in
some areas it's even more ambiguous because some drivers are hybrid
drivers but support both hybrid chips as well as analog-only (the
em28xx driver is one such example).

Anyway, Mauro is welcome to offer his opinion if it differs, but as
far as I'm concerned this patch shouldn't get applied.

Cheers,

Devin

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] au0828: Move under dvb
  2012-05-12 10:21       ` Devin Heitmueller
@ 2012-05-20 13:32         ` Mauro Carvalho Chehab
  2012-05-20 13:40           ` Mauro Carvalho Chehab
  0 siblings, 1 reply; 7+ messages in thread
From: Mauro Carvalho Chehab @ 2012-05-20 13:32 UTC (permalink / raw)
  To: Devin Heitmueller; +Cc: Ismael Luceno, linux-media

Em 12-05-2012 07:21, Devin Heitmueller escreveu:
> On Fri, May 11, 2012 at 11:08 PM, Ismael Luceno <ismael.luceno@gmail.com> wrote:
>> On Fri, 11 May 2012 08:04:59 -0400
>> Devin Heitmueller <dheitmueller@kernellabs.com> wrote:
>> ...
>>> What is the motivation for moving these files?
>>
>> Well, the device was on the wrong Kconfig section, and while thinking
>> about changing that, I just thought to move it under DVB.
>>
>>> The au0828 is a hybrid bridge, and every other hybrid bridge is
>>> under video?
>>
>> Sorry, the devices I got don't support analog, so I didn't thought
>> about it that much...
>>
>> I guess it's arbitrary... isn't it? wouldn't it be better to have an
>> hybrid section? (just thinking out loud)
> 
> Yeah, in this case it's largely historical (a product from before the
> V4L and DVB subsystems were merged).  At this point I don't see any
> real advantage to arbitrarily moving the stuff around.  And in fact in
> some areas it's even more ambiguous because some drivers are hybrid
> drivers but support both hybrid chips as well as analog-only (the
> em28xx driver is one such example).
> 
> Anyway, Mauro is welcome to offer his opinion if it differs, but as
> far as I'm concerned this patch shouldn't get applied.

I won't apply this patch.

If the Kconfig menus are confusing, then we should fix it, instead of moving
things from one place to another ;)

> 
> Cheers,
> 
> Devin
> 


^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] au0828: Move under dvb
  2012-05-20 13:32         ` Mauro Carvalho Chehab
@ 2012-05-20 13:40           ` Mauro Carvalho Chehab
  0 siblings, 0 replies; 7+ messages in thread
From: Mauro Carvalho Chehab @ 2012-05-20 13:40 UTC (permalink / raw)
  To: Devin Heitmueller; +Cc: Ismael Luceno, linux-media

Em 20-05-2012 10:32, Mauro Carvalho Chehab escreveu:
> Em 12-05-2012 07:21, Devin Heitmueller escreveu:
>> On Fri, May 11, 2012 at 11:08 PM, Ismael Luceno <ismael.luceno@gmail.com> wrote:
>>> On Fri, 11 May 2012 08:04:59 -0400
>>> Devin Heitmueller <dheitmueller@kernellabs.com> wrote:
>>> ...
>>>> What is the motivation for moving these files?
>>>
>>> Well, the device was on the wrong Kconfig section, and while thinking
>>> about changing that, I just thought to move it under DVB.
>>>
>>>> The au0828 is a hybrid bridge, and every other hybrid bridge is
>>>> under video?
>>>
>>> Sorry, the devices I got don't support analog, so I didn't thought
>>> about it that much...
>>>
>>> I guess it's arbitrary... isn't it? wouldn't it be better to have an
>>> hybrid section? (just thinking out loud)
>>
>> Yeah, in this case it's largely historical (a product from before the
>> V4L and DVB subsystems were merged).  At this point I don't see any
>> real advantage to arbitrarily moving the stuff around.  And in fact in
>> some areas it's even more ambiguous because some drivers are hybrid
>> drivers but support both hybrid chips as well as analog-only (the
>> em28xx driver is one such example).
>>
>> Anyway, Mauro is welcome to offer his opinion if it differs, but as
>> far as I'm concerned this patch shouldn't get applied.
> 
> I won't apply this patch.
> 
> If the Kconfig menus are confusing, then we should fix it, instead of moving
> things from one place to another ;)

Hmm...

menuconfig VIDEO_CAPTURE_DRIVERS
        bool "Video capture adapters"
        depends on VIDEO_V4L2
        default y
        ---help---
          Say Y here to enable selecting the video adapters for
          webcams, analog TV, and hybrid analog/digital TV.
          Some of those devices also supports FM radio.

The help explanation is OK. Maybe we could change the description:

comment at the bool description. What about the change below?

Regards,
Mauro

-
[media] video: Improve Kconfig menu description

The menu description can mislead to indicate that only capture devices
are there.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

diff --git a/drivers/media/dvb/Kconfig b/drivers/media/dvb/Kconfig
index f6e40b3..8efa494 100644
--- a/drivers/media/dvb/Kconfig
+++ b/drivers/media/dvb/Kconfig
@@ -29,11 +29,12 @@ config DVB_DYNAMIC_MINORS
 	  If you are unsure about this, say N here.
 
 menuconfig DVB_CAPTURE_DRIVERS
-	bool "DVB/ATSC adapters"
+	bool "Digital TV adapters"
 	depends on DVB_CORE
 	default y
 	---help---
-	  Say Y to select Digital TV adapters
+	  Say Y to select Digital TV adapters. Hybrid devices
+	  with both analog TV and digital TVs are not there.
 
 if DVB_CAPTURE_DRIVERS && DVB_CORE
 
diff --git a/drivers/media/video/Kconfig b/drivers/media/video/Kconfig
index 268b36d..a5a0ef2 100644
--- a/drivers/media/video/Kconfig
+++ b/drivers/media/video/Kconfig
@@ -71,12 +71,13 @@ config VIDEOBUF2_DMA_SG
 #
 
 menuconfig VIDEO_CAPTURE_DRIVERS
-	bool "Video capture adapters"
+	bool "Video adapters (capture, webcams, analog TV, hybrid TV)"
 	depends on VIDEO_V4L2
 	default y
 	---help---
 	  Say Y here to enable selecting the video adapters for
-	  webcams, analog TV, and hybrid analog/digital TV.
+	  webcams, video capture, analog TV, and hybrid
+	  analog/digital TV.
 	  Some of those devices also supports FM radio.
 
 if VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2

^ permalink raw reply related	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-05-20 13:40 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-11  6:14 [PATCH 1/2] au0828: Add USB ID used by many dongles Ismael Luceno
2012-05-11  6:14 ` [PATCH 2/2] au0828: Move under dvb Ismael Luceno
2012-05-11 12:04   ` Devin Heitmueller
2012-05-12  3:08     ` Ismael Luceno
2012-05-12 10:21       ` Devin Heitmueller
2012-05-20 13:32         ` Mauro Carvalho Chehab
2012-05-20 13:40           ` Mauro Carvalho Chehab

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.