From: Rogan Dawes <rogan@dawes.za.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fix IDE_BUS(dev) macro
Date: Sun, 03 Jun 2012 22:23:15 +0200 [thread overview]
Message-ID: <4FCBC7B3.7040200@dawes.za.net> (raw)
In-Reply-To: <4F8FB2DB.5090502@aribaud.net>
On 19/04/2012 08:38, Albert ARIBAUD wrote:
> Hi Dave,
>
> Le 18/04/2012 23:37, David Purdy a ?crit :
>> On Tue, Apr 17, 2012 at 2:06 PM, Luka Perkov<uboot@lukaperkov.net> wrote:
>>> IDE_BUS assumes that each bus has two devices and thus returns the first
>>> bus even when the second one should be probed.
>>>
>>> Signed-off-by: Simon Baatz<gmbnomis@gmail.com>
>>> Tested-by: Luka Perkov<uboot@lukaperkov.net>
>>> ---
>>>
>>> Simon discovered this while adding support for new board IB NAS6210.
>>>
>>> More info can be found here:
>>>
>>> http://lists.denx.de/pipermail/u-boot/2012-April/122525.html
>>>
>>> When this is commited I will do a coding style cleanup. There are tabs
>>> after few "#define" parts in include/ide.h.
>>>
>>> include/ide.h | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/include/ide.h b/include/ide.h
>>> index 8ecc9dd..385e909 100644
>>> --- a/include/ide.h
>>> +++ b/include/ide.h
>>> @@ -24,7 +24,7 @@
>>> #ifndef _IDE_H
>>
>> Simon, Luka, Prafulla, etal,
>>
>> I've tested this out on the Seagate GoFlex Net (Kirkwood) device,
>> which also has dual SATA ports, and it resolved the long-standing (and
>> irritating) bug/unwanted-feature that required us to boot from _only_
>> the right side port.
>>
>> I would guess that other Kirkwood dual-SATA-port boxes would be
>> happier because of this, as well.
>>
>> Nice catch, Simon.
>
> Not my main area of expertise here, but I am not sure how this plays on
> Marvell non-kirkwood platforms (e.g., orion5x).
>
> ISTR it is not the first time we deal with the whole IDE number of bus /
> number of ports [ / useable ports ] issue, and we may be running in
> circles here, fixing one platform and breaking another.
>
> I'll try this on EDMiniV2 in the coming days, and let people know the
> results in this thread.
>
>> regards,
>>
>> Dave
>
> Amicalement,
I had something similar for my DNS323 port (orion5x-based), which other
people may be remembering.
http://lists.denx.de/pipermail/u-boot/2010-August/075589.html
I seem to recall Wolfgang was not terribly enthused about it for some
reason, though.
Rogan
next prev parent reply other threads:[~2012-06-03 20:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 19:06 [U-Boot] [PATCH] fix IDE_BUS(dev) macro Luka Perkov
2012-04-18 21:37 ` David Purdy
2012-04-19 6:38 ` Albert ARIBAUD
2012-04-21 19:38 ` David Purdy
2012-04-29 20:19 ` Luka Perkov
2012-05-14 19:29 ` Luka Perkov
2012-05-15 19:42 ` Albert ARIBAUD
2012-05-15 20:44 ` Luka Perkov
2012-06-07 13:30 ` Luka Perkov
2012-06-20 8:05 ` Albert ARIBAUD
2012-08-09 20:36 ` Wolfgang Denk
2012-08-13 12:27 ` Albert ARIBAUD
2012-08-14 8:30 ` Albert ARIBAUD
2012-08-14 12:33 ` DrEagle
2012-10-08 18:46 ` [U-Boot] " Tom Rini
2012-06-03 20:23 ` Rogan Dawes [this message]
2012-06-03 21:25 ` [U-Boot] [PATCH] " Luka Perkov
2012-04-20 5:17 ` Prafulla Wadaskar
2012-06-03 15:03 ` Vágó Tibor
2012-06-03 15:03 ` Vágó Tibor
2012-06-03 21:24 ` Luka Perkov
2012-10-07 7:15 ` uboot at lukaperkov.net
2012-10-07 9:28 ` Albert ARIBAUD
2012-10-07 14:40 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCBC7B3.7040200@dawes.za.net \
--to=rogan@dawes.za.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.