From: Prafulla Wadaskar <prafulla@marvell.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fix IDE_BUS(dev) macro
Date: Thu, 19 Apr 2012 22:17:49 -0700 [thread overview]
Message-ID: <F766E4F80769BD478052FB6533FA745D1A2F8E7F95@SC-VEXCH4.marvell.com> (raw)
In-Reply-To: <20120417190649.GA22913@w500.iskon.local>
> -----Original Message-----
> From: u-boot-bounces at lists.denx.de [mailto:u-boot-
> bounces at lists.denx.de] On Behalf Of Luka Perkov
> Sent: 18 April 2012 00:37
> To: u-boot at lists.denx.de
> Subject: [U-Boot] [PATCH] fix IDE_BUS(dev) macro
>
> IDE_BUS assumes that each bus has two devices and thus returns the
> first
> bus even when the second one should be probed.
>
> Signed-off-by: Simon Baatz <gmbnomis@gmail.com>
> Tested-by: Luka Perkov <uboot@lukaperkov.net>
> ---
>
> Simon discovered this while adding support for new board IB NAS6210.
>
> More info can be found here:
>
> http://lists.denx.de/pipermail/u-boot/2012-April/122525.html
>
> When this is commited I will do a coding style cleanup. There are tabs
> after few "#define" parts in include/ide.h.
>
> include/ide.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/ide.h b/include/ide.h
> index 8ecc9dd..385e909 100644
> --- a/include/ide.h
> +++ b/include/ide.h
> @@ -24,7 +24,7 @@
> #ifndef _IDE_H
> #define _IDE_H
>
> -#define IDE_BUS(dev) (dev >> 1)
> +#define IDE_BUS(dev) (dev / (CONFIG_SYS_IDE_MAXDEVICE /
> CONFIG_SYS_IDE_MAXBUS))
>
> #define ATA_CURR_BASE(dev)
> (CONFIG_SYS_ATA_BASE_ADDR+ide_bus_offset[IDE_BUS(dev)])
>
Dear Wolfgang
This is generic patch to IDE framework, this patch is dependency for (being pulled) Kirkwood based boards.
Will you please kindly pull it? OR I should do the needful?
Regards..
Prafulla . . .
next prev parent reply other threads:[~2012-04-20 5:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 19:06 [U-Boot] [PATCH] fix IDE_BUS(dev) macro Luka Perkov
2012-04-18 21:37 ` David Purdy
2012-04-19 6:38 ` Albert ARIBAUD
2012-04-21 19:38 ` David Purdy
2012-04-29 20:19 ` Luka Perkov
2012-05-14 19:29 ` Luka Perkov
2012-05-15 19:42 ` Albert ARIBAUD
2012-05-15 20:44 ` Luka Perkov
2012-06-07 13:30 ` Luka Perkov
2012-06-20 8:05 ` Albert ARIBAUD
2012-08-09 20:36 ` Wolfgang Denk
2012-08-13 12:27 ` Albert ARIBAUD
2012-08-14 8:30 ` Albert ARIBAUD
2012-08-14 12:33 ` DrEagle
2012-10-08 18:46 ` [U-Boot] " Tom Rini
2012-06-03 20:23 ` [U-Boot] [PATCH] " Rogan Dawes
2012-06-03 21:25 ` Luka Perkov
2012-04-20 5:17 ` Prafulla Wadaskar [this message]
2012-06-03 15:03 ` Vágó Tibor
2012-06-03 15:03 ` Vágó Tibor
2012-06-03 21:24 ` Luka Perkov
2012-10-07 7:15 ` uboot at lukaperkov.net
2012-10-07 9:28 ` Albert ARIBAUD
2012-10-07 14:40 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F766E4F80769BD478052FB6533FA745D1A2F8E7F95@SC-VEXCH4.marvell.com \
--to=prafulla@marvell.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.