socketcan: license issues

socketcan: license issues

[yegorslists]

During my effort bringing SocketCAN to Android I encountered following issue: Android devs found out that SocketCAN headers are not licensed as GPL2. See discussion here https://android-review.googlesource.com/#/c/34510/

I added GPL2 notion to the headers. Is it O.K. the way I made it or should we make this consistent for all SocketCAN files including the drivers?

Yegor

[PATCH] socketcan: provide GPL2 notion for the headers

[yegorslists]

From: Yegor Yefremov <yegorslists@googlemail.com>

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
 include/linux/can.h         |   15 +++++++++++++--
 include/linux/can/bcm.h     |   15 +++++++++++++--
 include/linux/can/core.h    |   15 +++++++++++++--
 include/linux/can/dev.h     |   12 ++++++++++++
 include/linux/can/error.h   |   15 +++++++++++++--
 include/linux/can/gw.h      |   15 +++++++++++++--
 include/linux/can/netlink.h |   12 ++++++++++++
 include/linux/can/raw.h     |   15 +++++++++++++--
 8 files changed, 102 insertions(+), 12 deletions(-)

diff --git a/include/linux/can.h b/include/linux/can.h
index 9a19bcb..4e6b853 100644
--- a/include/linux/can.h
+++ b/include/linux/can.h
@@ -3,11 +3,22 @@
  *
  * Definitions for CAN network layer (socket addr / CAN frame / CAN filter)
  *
+ * Copyright (c) 2002-2007 Volkswagen Group Electronic Research
  * Authors: Oliver Hartkopp <oliver.hartkopp@volkswagen.de>
  *          Urs Thuermann   <urs.thuermann@volkswagen.de>
- * Copyright (c) 2002-2007 Volkswagen Group Electronic Research
- * All rights reserved.
  *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
  */
 
 #ifndef CAN_H
diff --git a/include/linux/can/bcm.h b/include/linux/can/bcm.h
index 3ebe387..e4352b0 100644
--- a/include/linux/can/bcm.h
+++ b/include/linux/can/bcm.h
@@ -3,10 +3,21 @@
  *
  * Definitions for CAN Broadcast Manager (BCM)
  *
- * Author: Oliver Hartkopp <oliver.hartkopp@volkswagen.de>
  * Copyright (c) 2002-2007 Volkswagen Group Electronic Research
- * All rights reserved.
+ * Author: Oliver Hartkopp <oliver.hartkopp@volkswagen.de>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
  *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
  */
 
 #ifndef CAN_BCM_H
diff --git a/include/linux/can/core.h b/include/linux/can/core.h
index 0ccc1cd..bb34f8f 100644
--- a/include/linux/can/core.h
+++ b/include/linux/can/core.h
@@ -3,11 +3,22 @@
  *
  * Protoypes and definitions for CAN protocol modules using the PF_CAN core
  *
+ * Copyright (c) 2002-2007 Volkswagen Group Electronic Research
  * Authors: Oliver Hartkopp <oliver.hartkopp@volkswagen.de>
  *          Urs Thuermann   <urs.thuermann@volkswagen.de>
- * Copyright (c) 2002-2007 Volkswagen Group Electronic Research
- * All rights reserved.
  *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
  */
 
 #ifndef CAN_CORE_H
diff --git a/include/linux/can/dev.h b/include/linux/can/dev.h
index 5d2efe7..81320d5 100644
--- a/include/linux/can/dev.h
+++ b/include/linux/can/dev.h
@@ -8,6 +8,18 @@
  *
  * Copyright (C) 2008 Wolfgang Grandegger <wg@grandegger.com>
  *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
  */
 
 #ifndef CAN_DEV_H
diff --git a/include/linux/can/error.h b/include/linux/can/error.h
index 63e855e..2149f93 100644
--- a/include/linux/can/error.h
+++ b/include/linux/can/error.h
@@ -3,10 +3,21 @@
  *
  * Definitions of the CAN error frame to be filtered and passed to the user.
  *
- * Author: Oliver Hartkopp <oliver.hartkopp@volkswagen.de>
  * Copyright (c) 2002-2007 Volkswagen Group Electronic Research
- * All rights reserved.
+ * Author: Oliver Hartkopp <oliver.hartkopp@volkswagen.de>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
  *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
  */
 
 #ifndef CAN_ERROR_H
diff --git a/include/linux/can/gw.h b/include/linux/can/gw.h
index 8e1db18..b394af5 100644
--- a/include/linux/can/gw.h
+++ b/include/linux/can/gw.h
@@ -3,10 +3,21 @@
  *
  * Definitions for CAN frame Gateway/Router/Bridge
  *
- * Author: Oliver Hartkopp <oliver.hartkopp@volkswagen.de>
  * Copyright (c) 2011 Volkswagen Group Electronic Research
- * All rights reserved.
+ * Author: Oliver Hartkopp <oliver.hartkopp@volkswagen.de>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
  *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
  */
 
 #ifndef CAN_GW_H
diff --git a/include/linux/can/netlink.h b/include/linux/can/netlink.h
index 14966dd..ecf22b4 100644
--- a/include/linux/can/netlink.h
+++ b/include/linux/can/netlink.h
@@ -5,6 +5,18 @@
  *
  * Copyright (c) 2009 Wolfgang Grandegger <wg@grandegger.com>
  *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
  */
 
 #ifndef CAN_NETLINK_H
diff --git a/include/linux/can/raw.h b/include/linux/can/raw.h
index 781f3a3..a85c69e 100644
--- a/include/linux/can/raw.h
+++ b/include/linux/can/raw.h
@@ -3,11 +3,22 @@
  *
  * Definitions for raw CAN sockets
  *
+ * Copyright (c) 2002-2007 Volkswagen Group Electronic Research
  * Authors: Oliver Hartkopp <oliver.hartkopp@volkswagen.de>
  *          Urs Thuermann   <urs.thuermann@volkswagen.de>
- * Copyright (c) 2002-2007 Volkswagen Group Electronic Research
- * All rights reserved.
  *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
  */
 
 #ifndef CAN_RAW_H
-- 
1.7.7

Re: [PATCH] socketcan: provide GPL2 notion for the headers

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 1615 bytes --]

On 06/12/2012 08:58 AM, yegorslists@googlemail.com wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>

Please don't add the FSF's address.

> --- a/include/linux/can.h
> +++ b/include/linux/can.h
> @@ -3,11 +3,22 @@
>   *
>   * Definitions for CAN network layer (socket addr / CAN frame / CAN filter)
>   *
> + * Copyright (c) 2002-2007 Volkswagen Group Electronic Research
>   * Authors: Oliver Hartkopp <oliver.hartkopp@volkswagen.de>
>   *          Urs Thuermann   <urs.thuermann@volkswagen.de>
> - * Copyright (c) 2002-2007 Volkswagen Group Electronic Research
> - * All rights reserved.
>   *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
>   */
>  

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

Re: socketcan: license issues

[Oliver Hartkopp]

On 12.06.2012 08:58, yegorslists@googlemail.com wrote:

> During my effort bringing SocketCAN to Android I encountered following issue: Android devs found out that SocketCAN headers are not licensed as GPL2. See discussion here https://android-review.googlesource.com/#/c/34510/
> 
> I added GPL2 notion to the headers. Is it O.K. the way I made it or should we make this consistent for all SocketCAN files including the drivers?


Hello Yegor,

the stuff which is inside the kernel is GPL source.

No need to put any effort to change copyright notices in Kernel headers.

The Android guys can pick the headers as-is. They did it with xattr.h too:

See

https://github.com/android/platform_bionic/blob/master/libc/kernel/common/linux/xattr.h

and the original header starts with

/*
  File: linux/xattr.h

  Extended attributes handling.

  Copyright (C) 2001 by Andreas Gruenbacher <a.gruenbacher@computer.org>
  Copyright (c) 2001-2002 Silicon Graphics, Inc.  All Rights Reserved.
  Copyright (c) 2004 Red Hat, Inc., James Morris <jmorris@redhat.com>
*/

http://lxr.linux.no/#linux+v3.4.2/include/linux/xattr.h

which also includes a copyright and "All rights reserved" message from SGI.

So why is there any problem with can.h when there was no problem with xattr.h?

The CAN subsystem is licensed by Volkswagen under GPL/BSD - the Android guys
are hereby invited to pick the headers for their libs - even when i personally
think, that their header cleaning process is a bad message for contributing
developers. 

Regards,
Oliver