From: Wen Congyang <wency@cn.fujitsu.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: kvm list <kvm@vger.kernel.org>,
qemu-devel <qemu-devel@nongnu.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Avi Kivity <avi@redhat.com>,
"Daniel P. Berrange" <berrange@redhat.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
Gleb Natapov <gleb@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] start vm after reseting it
Date: Wed, 13 Jun 2012 14:54:28 +0800 [thread overview]
Message-ID: <4FD83924.8020208@cn.fujitsu.com> (raw)
In-Reply-To: <20120530161720.7c9b88b9@doriath.home>
At 05/31/2012 03:17 AM, Luiz Capitulino Wrote:
> On Mon, 21 May 2012 14:49:32 +0800
> Wen Congyang <wency@cn.fujitsu.com> wrote:
>
>> The guest should run after reseting it, but it does not
>> run if its old state is RUN_STATE_INTERNAL_ERROR or RUN_STATE_PAUSED.
>>
>> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
>> ---
>> vl.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/vl.c b/vl.c
>> index 23ab3a3..7f5fed8 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -1539,6 +1539,7 @@ static bool main_loop_should_exit(void)
>> if (runstate_check(RUN_STATE_INTERNAL_ERROR) ||
>> runstate_check(RUN_STATE_SHUTDOWN)) {
>> runstate_set(RUN_STATE_PAUSED);
>> + vm_start();
>
> Please, drop the runstate_set() call. I think you also have to
> to call bdrv_iostatus_reset(), as qmp_cont() does.
Hmm, if we drop the runstate_set() call here, we should update
runstate_transitions_def too.
Thanks
Wen Congyang
>
>> }
>> }
>> if (qemu_powerdown_requested()) {
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
WARNING: multiple messages have this Message-ID (diff)
From: Wen Congyang <wency@cn.fujitsu.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>, kvm list <kvm@vger.kernel.org>,
Jan Kiszka <jan.kiszka@siemens.com>,
qemu-devel <qemu-devel@nongnu.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Avi Kivity <avi@redhat.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH 1/3] start vm after reseting it
Date: Wed, 13 Jun 2012 14:54:28 +0800 [thread overview]
Message-ID: <4FD83924.8020208@cn.fujitsu.com> (raw)
In-Reply-To: <20120530161720.7c9b88b9@doriath.home>
At 05/31/2012 03:17 AM, Luiz Capitulino Wrote:
> On Mon, 21 May 2012 14:49:32 +0800
> Wen Congyang <wency@cn.fujitsu.com> wrote:
>
>> The guest should run after reseting it, but it does not
>> run if its old state is RUN_STATE_INTERNAL_ERROR or RUN_STATE_PAUSED.
>>
>> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
>> ---
>> vl.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/vl.c b/vl.c
>> index 23ab3a3..7f5fed8 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -1539,6 +1539,7 @@ static bool main_loop_should_exit(void)
>> if (runstate_check(RUN_STATE_INTERNAL_ERROR) ||
>> runstate_check(RUN_STATE_SHUTDOWN)) {
>> runstate_set(RUN_STATE_PAUSED);
>> + vm_start();
>
> Please, drop the runstate_set() call. I think you also have to
> to call bdrv_iostatus_reset(), as qmp_cont() does.
Hmm, if we drop the runstate_set() call here, we should update
runstate_transitions_def too.
Thanks
Wen Congyang
>
>> }
>> }
>> if (qemu_powerdown_requested()) {
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
WARNING: multiple messages have this Message-ID (diff)
From: Wen Congyang <wency@cn.fujitsu.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>, kvm list <kvm@vger.kernel.org>,
Jan Kiszka <jan.kiszka@siemens.com>,
qemu-devel <qemu-devel@nongnu.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Avi Kivity <avi@redhat.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] start vm after reseting it
Date: Wed, 13 Jun 2012 14:54:28 +0800 [thread overview]
Message-ID: <4FD83924.8020208@cn.fujitsu.com> (raw)
In-Reply-To: <20120530161720.7c9b88b9@doriath.home>
At 05/31/2012 03:17 AM, Luiz Capitulino Wrote:
> On Mon, 21 May 2012 14:49:32 +0800
> Wen Congyang <wency@cn.fujitsu.com> wrote:
>
>> The guest should run after reseting it, but it does not
>> run if its old state is RUN_STATE_INTERNAL_ERROR or RUN_STATE_PAUSED.
>>
>> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
>> ---
>> vl.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/vl.c b/vl.c
>> index 23ab3a3..7f5fed8 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -1539,6 +1539,7 @@ static bool main_loop_should_exit(void)
>> if (runstate_check(RUN_STATE_INTERNAL_ERROR) ||
>> runstate_check(RUN_STATE_SHUTDOWN)) {
>> runstate_set(RUN_STATE_PAUSED);
>> + vm_start();
>
> Please, drop the runstate_set() call. I think you also have to
> to call bdrv_iostatus_reset(), as qmp_cont() does.
Hmm, if we drop the runstate_set() call here, we should update
runstate_transitions_def too.
Thanks
Wen Congyang
>
>> }
>> }
>> if (qemu_powerdown_requested()) {
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
next prev parent reply other threads:[~2012-06-13 6:50 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 6:46 [PATCH] kvm: notify host when guest panicked Wen Congyang
2012-05-21 6:46 ` [Qemu-devel] " Wen Congyang
2012-05-21 6:49 ` [PATCH 1/3] start vm after reseting it Wen Congyang
2012-05-21 6:49 ` [Qemu-devel] " Wen Congyang
2012-05-30 19:17 ` Luiz Capitulino
2012-05-30 19:17 ` Luiz Capitulino
2012-06-12 7:23 ` [Qemu-devel] " Wen Congyang
2012-06-12 7:23 ` Wen Congyang
2012-06-13 6:54 ` Wen Congyang [this message]
2012-06-13 6:54 ` Wen Congyang
2012-06-13 6:54 ` Wen Congyang
2012-05-21 6:50 ` [PATCH 2/3] update linux headers Wen Congyang
2012-05-21 6:50 ` [Qemu-devel] " Wen Congyang
2012-05-21 6:50 ` [PATCH 3/3] deal with guest panicked event Wen Congyang
2012-05-21 6:50 ` [Qemu-devel] " Wen Congyang
2012-05-22 11:32 ` Jan Kiszka
2012-05-22 11:32 ` [Qemu-devel] " Jan Kiszka
2012-05-22 11:32 ` Jan Kiszka
2012-05-30 19:23 ` [Qemu-devel] " Luiz Capitulino
2012-05-30 19:23 ` Luiz Capitulino
2012-06-12 6:55 ` [Qemu-devel] " Wen Congyang
2012-06-12 6:55 ` Wen Congyang
2012-06-12 12:35 ` Luiz Capitulino
2012-06-12 12:35 ` Luiz Capitulino
2012-06-12 12:40 ` Daniel P. Berrange
2012-06-12 12:40 ` Daniel P. Berrange
2012-06-12 13:21 ` Luiz Capitulino
2012-06-12 13:21 ` Luiz Capitulino
2012-06-12 13:29 ` Paolo Bonzini
2012-06-12 13:29 ` [Qemu-devel] " Paolo Bonzini
2012-06-13 7:02 ` Wen Congyang
2012-06-13 7:02 ` [Qemu-devel] " Wen Congyang
2012-06-13 7:53 ` Paolo Bonzini
2012-06-13 7:53 ` [Qemu-devel] " Paolo Bonzini
2012-06-13 7:53 ` Paolo Bonzini
2012-06-13 8:00 ` Wen Congyang
2012-06-13 8:00 ` [Qemu-devel] " Wen Congyang
2012-06-13 8:00 ` Wen Congyang
2012-06-12 6:47 ` [PATCH] kvm: notify host when guest panicked Wen Congyang
2012-06-12 6:47 ` [Qemu-devel] " Wen Congyang
2012-06-12 7:49 ` Christian Borntraeger
2012-06-12 7:49 ` [Qemu-devel] " Christian Borntraeger
2012-06-12 8:07 ` Wen Congyang
2012-06-12 8:07 ` [Qemu-devel] " Wen Congyang
2012-06-12 8:26 ` Wen Congyang
2012-06-12 8:26 ` [Qemu-devel] " Wen Congyang
2012-06-12 8:26 ` Wen Congyang
2012-06-12 9:49 ` Gleb Natapov
2012-06-12 9:49 ` [Qemu-devel] " Gleb Natapov
2012-06-12 9:49 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD83924.8020208@cn.fujitsu.com \
--to=wency@cn.fujitsu.com \
--cc=avi@redhat.com \
--cc=berrange@redhat.com \
--cc=gleb@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kvm@vger.kernel.org \
--cc=lcapitulino@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.