[PATCH] regmap: Remove warning on stubbed dev_get_regmap()

[PATCH] regmap: Remove warning on stubbed dev_get_regmap()

[Mark Brown]

It's perfectly sensible to ask if there's a regmap for a device which
doesn't have one so the stubbed version shouldn't complain, the caller
should be prepared for this.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
 include/linux/regmap.h |    1 -
 1 file changed, 1 deletion(-)

diff --git a/include/linux/regmap.h b/include/linux/regmap.h
index 4c9e642..c3508d0 100644
--- a/include/linux/regmap.h
+++ b/include/linux/regmap.h
@@ -388,7 +388,6 @@ static inline int regmap_register_patch(struct regmap *map,
 static inline struct regmap *dev_get_regmap(struct device *dev,
 					    const char *name)
 {
-	WARN_ONCE(1, "regmap API is disabled");
 	return NULL;
 }
 
-- 
1.7.10

Re: [PATCH] regmap: Remove warning on stubbed dev_get_regmap()

[Lee Jones]

On 13/06/12 14:38, Mark Brown wrote:
> It's perfectly sensible to ask if there's a regmap for a device which
> doesn't have one so the stubbed version shouldn't complain, the caller
> should be prepared for this.
>
> Signed-off-by: Mark Brown<broonie@opensource.wolfsonmicro.com>
> ---
>   include/linux/regmap.h |    1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/regmap.h b/include/linux/regmap.h
> index 4c9e642..c3508d0 100644
> --- a/include/linux/regmap.h
> +++ b/include/linux/regmap.h
> @@ -388,7 +388,6 @@ static inline int regmap_register_patch(struct regmap *map,
>   static inline struct regmap *dev_get_regmap(struct device *dev,
>   					    const char *name)
>   {
> -	WARN_ONCE(1, "regmap API is disabled");
>   	return NULL;
>   }

Thanks Mark.

Reported-by: Lee Jones <lee.jones@linaro.org>
Tested-by: Lee Jones <lee.jones@linaro.org>

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
M: +44 77 88 633 515
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH] regmap: Remove warning on stubbed dev_get_regmap()

[Fabio Estevam]

On Wed, Jun 13, 2012 at 10:38 AM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> It's perfectly sensible to ask if there's a regmap for a device which
> doesn't have one so the stubbed version shouldn't complain, the caller
> should be prepared for this.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

Tested-by: Fabio Estevam <fabio.estevam@freescale.com>

Thanks,

Fabio Estevam