All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging: comedi: fix Kconfig for COMEDI_PCMCIA_DRIVERS
@ 2012-06-15 16:18 H Hartley Sweeten
  2012-06-15 17:51 ` Ian Abbott
  2012-06-15 19:25 ` Randy Dunlap
  0 siblings, 2 replies; 3+ messages in thread
From: H Hartley Sweeten @ 2012-06-15 16:18 UTC (permalink / raw)
  To: Linux Kernel; +Cc: devel, abbotti, fmhess, gregkh

The depends on PCCARD is redundant. All of the comedi PCMCIA
drivers depend on PCMCIA which can only be enabled if PCCARD
is enabled. Remove the extra depends check.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfondation.org>
---
 drivers/staging/comedi/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/comedi/Kconfig b/drivers/staging/comedi/Kconfig
index 848cf7e..2ca7f08 100644
--- a/drivers/staging/comedi/Kconfig
+++ b/drivers/staging/comedi/Kconfig
@@ -1097,7 +1097,7 @@ endif # COMEDI_PCI_DRIVERS
 
 menuconfig COMEDI_PCMCIA_DRIVERS
 	tristate "Comedi PCMCIA drivers"
-	depends on (PCMCIA || PCCARD)
+	depends on PCMCIA
 	---help---
 	  Enable comedi PCMCIA and PCCARD drivers to be built
 
-- 
1.7.7


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] staging: comedi: fix Kconfig for COMEDI_PCMCIA_DRIVERS
  2012-06-15 16:18 [PATCH] staging: comedi: fix Kconfig for COMEDI_PCMCIA_DRIVERS H Hartley Sweeten
@ 2012-06-15 17:51 ` Ian Abbott
  2012-06-15 19:25 ` Randy Dunlap
  1 sibling, 0 replies; 3+ messages in thread
From: Ian Abbott @ 2012-06-15 17:51 UTC (permalink / raw)
  To: H Hartley Sweeten; +Cc: Linux Kernel, devel, Ian Abbott, fmhess, gregkh

On 2012-06-15 17:18, H Hartley Sweeten wrote:
> The depends on PCCARD is redundant. All of the comedi PCMCIA
> drivers depend on PCMCIA which can only be enabled if PCCARD
> is enabled. Remove the extra depends check.
>
> Signed-off-by: H Hartley Sweeten<hsweeten@visionengravers.com>
> Cc: Ian Abbott<abbotti@mev.co.uk>
> Cc: Frank Mori Hess<fmhess@users.sourceforge.net>
> Cc: Greg Kroah-Hartman<gregkh@linuxfondation.org>

I tested it with Randy's config from

   Subject: Re: linux-next: Tree for Jun 14 (staging/comedi)
   Message-ID: <4FDA59D7.3050200@xenotime.net>

and `make oldconfig` no longer leaves CONFIG_COMEDI_NI_LABPC_CS, etc. 
defined, so it seems to work!

Thanks.

Tested-by: Ian Abbott <abbotti@mev.co.uk>

> ---
>   drivers/staging/comedi/Kconfig |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/comedi/Kconfig b/drivers/staging/comedi/Kconfig
> index 848cf7e..2ca7f08 100644
> --- a/drivers/staging/comedi/Kconfig
> +++ b/drivers/staging/comedi/Kconfig
> @@ -1097,7 +1097,7 @@ endif # COMEDI_PCI_DRIVERS
>
>   menuconfig COMEDI_PCMCIA_DRIVERS
>   	tristate "Comedi PCMCIA drivers"
> -	depends on (PCMCIA || PCCARD)
> +	depends on PCMCIA
>   	---help---
>   	  Enable comedi PCMCIA and PCCARD drivers to be built
>


-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] staging: comedi: fix Kconfig for COMEDI_PCMCIA_DRIVERS
  2012-06-15 16:18 [PATCH] staging: comedi: fix Kconfig for COMEDI_PCMCIA_DRIVERS H Hartley Sweeten
  2012-06-15 17:51 ` Ian Abbott
@ 2012-06-15 19:25 ` Randy Dunlap
  1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2012-06-15 19:25 UTC (permalink / raw)
  To: H Hartley Sweeten; +Cc: Linux Kernel, devel, fmhess, abbotti, gregkh

On 06/15/2012 09:18 AM, H Hartley Sweeten wrote:

> The depends on PCCARD is redundant. All of the comedi PCMCIA
> drivers depend on PCMCIA which can only be enabled if PCCARD
> is enabled. Remove the extra depends check.
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Ian Abbott <abbotti@mev.co.uk>
> Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
> Cc: Greg Kroah-Hartman <gregkh@linuxfondation.org>


Reported-by: Randy Dunlap <rdunlap@xenotime.net>
Acked-by: Randy Dunlap <rdunlap@xenotime.net>

Thanks.

> ---
>  drivers/staging/comedi/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/comedi/Kconfig b/drivers/staging/comedi/Kconfig
> index 848cf7e..2ca7f08 100644
> --- a/drivers/staging/comedi/Kconfig
> +++ b/drivers/staging/comedi/Kconfig
> @@ -1097,7 +1097,7 @@ endif # COMEDI_PCI_DRIVERS
>  
>  menuconfig COMEDI_PCMCIA_DRIVERS
>  	tristate "Comedi PCMCIA drivers"
> -	depends on (PCMCIA || PCCARD)
> +	depends on PCMCIA
>  	---help---
>  	  Enable comedi PCMCIA and PCCARD drivers to be built
>  



-- 
~Randy

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-06-15 19:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-15 16:18 [PATCH] staging: comedi: fix Kconfig for COMEDI_PCMCIA_DRIVERS H Hartley Sweeten
2012-06-15 17:51 ` Ian Abbott
2012-06-15 19:25 ` Randy Dunlap

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.