* [PATCH] drm/edid: don't return stack garbage from supports_rb
@ 2012-06-19 9:33 Daniel Vetter
2012-06-19 13:19 ` Adam Jackson
2012-06-20 14:55 ` Adam Jackson
0 siblings, 2 replies; 3+ messages in thread
From: Daniel Vetter @ 2012-06-19 9:33 UTC (permalink / raw)
To: Dave Airlie; +Cc: Daniel Vetter, stable, DRI Development
We need to initialize this to false, because the is_rb callback only
ever sets it to true.
Noticed while reading through the code.
Cc: Adam Jackson <ajax@redhat.com>
Cc: stable@vger.kernel.org
Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
drivers/gpu/drm/drm_edid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index c3b5139..77a436f 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -603,7 +603,7 @@ static bool
drm_monitor_supports_rb(struct edid *edid)
{
if (edid->revision >= 4) {
- bool ret;
+ bool ret = false;
drm_for_each_detailed_block((u8 *)edid, is_rb, &ret);
return ret;
}
--
1.7.10
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/edid: don't return stack garbage from supports_rb
2012-06-19 9:33 [PATCH] drm/edid: don't return stack garbage from supports_rb Daniel Vetter
@ 2012-06-19 13:19 ` Adam Jackson
2012-06-20 14:55 ` Adam Jackson
1 sibling, 0 replies; 3+ messages in thread
From: Adam Jackson @ 2012-06-19 13:19 UTC (permalink / raw)
To: Daniel Vetter; +Cc: stable, DRI Development
On 6/19/12 5:33 AM, Daniel Vetter wrote:
> We need to initialize this to false, because the is_rb callback only
> ever sets it to true.
>
> Noticed while reading through the code.
>
> Cc: Adam Jackson <ajax@redhat.com>
> Cc: stable@vger.kernel.org
> Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Adam Jackson <ajax@redhat.com>
- ajax
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/edid: don't return stack garbage from supports_rb
2012-06-19 9:33 [PATCH] drm/edid: don't return stack garbage from supports_rb Daniel Vetter
2012-06-19 13:19 ` Adam Jackson
@ 2012-06-20 14:55 ` Adam Jackson
1 sibling, 0 replies; 3+ messages in thread
From: Adam Jackson @ 2012-06-20 14:55 UTC (permalink / raw)
To: Daniel Vetter; +Cc: stable, DRI Development
[-- Attachment #1.1: Type: text/plain, Size: 387 bytes --]
On Tue, 2012-06-19 at 11:33 +0200, Daniel Vetter wrote:
> We need to initialize this to false, because the is_rb callback only
> ever sets it to true.
>
> Noticed while reading through the code.
>
> Cc: Adam Jackson <ajax@redhat.com>
> Cc: stable@vger.kernel.org
> Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Adam Jackson <ajax@redhat.com>
- ajax
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-06-20 14:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-19 9:33 [PATCH] drm/edid: don't return stack garbage from supports_rb Daniel Vetter
2012-06-19 13:19 ` Adam Jackson
2012-06-20 14:55 ` Adam Jackson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.