From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org,
olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] ARM: tegra: apbio access using dma for tegra20 only
Date: Tue, 19 Jun 2012 11:01:21 -0600 [thread overview]
Message-ID: <4FE0B061.6070302@wwwdotorg.org> (raw)
In-Reply-To: <1340085974-9623-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 06/19/2012 12:06 AM, Laxman Dewangan wrote:
> The Tegra20 HW issue with accessing APBIO registers (such
> as fuse registers) directly from the CPU concurrently with
> APB DMA accesses has been fixed in Tegra30 and later chips.
>
> Access these registers directly from the CPU on Tegra30
> and later, and apply the workaround only for Tegra20.
> +void tegra_apb_io_init(void)
> +{
> + /* Need to use dma only when it is Tegra20 based platform */
> + if (of_machine_is_compatible("nvidia,tegra20")) {
That tests only works when the system is booted using device tree. Can
you change this to:
if (of_machine_is_compatible("nvidia,tegra20") ||
!of_have_populated_dt()) {
... and make sure you get the expected result when booting using a board
file (e.g. Harmony). Thanks.
> + apbio_read = tegra_apb_readl_using_dma;
> + apbio_write = tegra_apb_writel_using_dma;
> + } else {
> + apbio_read = tegra_apb_readl_direct;
> + apbio_write = tegra_apb_writel_direct;
> + }
> +}
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: ccross@android.com, olof@lixom.net, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: tegra: apbio access using dma for tegra20 only
Date: Tue, 19 Jun 2012 11:01:21 -0600 [thread overview]
Message-ID: <4FE0B061.6070302@wwwdotorg.org> (raw)
In-Reply-To: <1340085974-9623-1-git-send-email-ldewangan@nvidia.com>
On 06/19/2012 12:06 AM, Laxman Dewangan wrote:
> The Tegra20 HW issue with accessing APBIO registers (such
> as fuse registers) directly from the CPU concurrently with
> APB DMA accesses has been fixed in Tegra30 and later chips.
>
> Access these registers directly from the CPU on Tegra30
> and later, and apply the workaround only for Tegra20.
> +void tegra_apb_io_init(void)
> +{
> + /* Need to use dma only when it is Tegra20 based platform */
> + if (of_machine_is_compatible("nvidia,tegra20")) {
That tests only works when the system is booted using device tree. Can
you change this to:
if (of_machine_is_compatible("nvidia,tegra20") ||
!of_have_populated_dt()) {
... and make sure you get the expected result when booting using a board
file (e.g. Harmony). Thanks.
> + apbio_read = tegra_apb_readl_using_dma;
> + apbio_write = tegra_apb_writel_using_dma;
> + } else {
> + apbio_read = tegra_apb_readl_direct;
> + apbio_write = tegra_apb_writel_direct;
> + }
> +}
next prev parent reply other threads:[~2012-06-19 17:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-19 6:06 [PATCH] ARM: tegra: apbio access using dma for tegra20 only Laxman Dewangan
2012-06-19 6:06 ` Laxman Dewangan
[not found] ` <1340085974-9623-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-06-19 17:01 ` Stephen Warren [this message]
2012-06-19 17:01 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE0B061.6070302@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
--cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.