* [PATCH] mfd: MFD_MAX77693 needs to select IRQ_DOMAIN
@ 2012-06-20 1:40 Axel Lin
2012-06-20 19:53 ` [PATCH] mfd: TWL6040_CORE " Randy Dunlap
2012-06-20 19:54 ` [PATCH] mfd: MFD_MAX77693 " Randy Dunlap
0 siblings, 2 replies; 4+ messages in thread
From: Axel Lin @ 2012-06-20 1:40 UTC (permalink / raw)
To: linux-kernel
Cc: Chanwoo Choi, Myungjoo Ham, Kyungmin Park, Samuel Ortiz, Randy Dunlap
This fixes below build errors:
CC drivers/mfd/max77693-irq.o
drivers/mfd/max77693-irq.c: In function 'max77693_irq_thread':
drivers/mfd/max77693-irq.c:217:4: error: implicit declaration of function 'irq_find_mapping' [-Werror=implicit-function-declaration]
drivers/mfd/max77693-irq.c: In function 'max77693_irq_init':
drivers/mfd/max77693-irq.c:286:2: error: implicit declaration of function 'irq_domain_add_linear' [-Werror=implicit-function-declaration]
drivers/mfd/max77693-irq.c:286:9: warning: assignment makes pointer from integer without a cast [enabled by default]
cc1: some warnings being treated as errors
make[2]: *** [drivers/mfd/max77693-irq.o] Error 1
make[1]: *** [drivers/mfd] Error 2
make: *** [drivers] Error 2
Reported-by: Randy Dunlap <rdunlap@xenotime.net>
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/mfd/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index e129c82..79f1d4b 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -427,6 +427,7 @@ config MFD_MAX77693
depends on I2C=y && GENERIC_HARDIRQS
select MFD_CORE
select REGMAP_I2C
+ select IRQ_DOMAIN
help
Say yes here to support for Maxim Semiconductor MAX77693.
This is a companion Power Management IC with Flash, Haptic, Charger,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] mfd: TWL6040_CORE needs to select IRQ_DOMAIN
2012-06-20 1:40 [PATCH] mfd: MFD_MAX77693 needs to select IRQ_DOMAIN Axel Lin
@ 2012-06-20 19:53 ` Randy Dunlap
2012-07-02 14:35 ` Samuel Ortiz
2012-06-20 19:54 ` [PATCH] mfd: MFD_MAX77693 " Randy Dunlap
1 sibling, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2012-06-20 19:53 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Samuel Ortiz, Misael Lopez Cruz
From: Randy Dunlap <rdunlap@xenotime.net>
Fix build error by selecting IRQ_DOMAIN:
drivers/mfd/twl6040-irq.c:164:2: error: implicit declaration of function 'irq_domain_add_legacy'
drivers/mfd/twl6040-irq.c:165:11: error: 'irq_domain_simple_ops' undeclared (first use in this function)
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Cc: Samuel Ortiz <sameo@linux.intel.com>
Cc: Misael Lopez Cruz <misael.lopez@ti.com>
---
drivers/mfd/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20120620.orig/drivers/mfd/Kconfig
+++ linux-next-20120620/drivers/mfd/Kconfig
@@ -286,6 +286,7 @@ config TWL6040_CORE
depends on I2C=y && GENERIC_HARDIRQS
select MFD_CORE
select REGMAP_I2C
+ select IRQ_DOMAIN
default n
help
Say yes here if you want support for Texas Instruments TWL6040 audio
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mfd: MFD_MAX77693 needs to select IRQ_DOMAIN
2012-06-20 1:40 [PATCH] mfd: MFD_MAX77693 needs to select IRQ_DOMAIN Axel Lin
2012-06-20 19:53 ` [PATCH] mfd: TWL6040_CORE " Randy Dunlap
@ 2012-06-20 19:54 ` Randy Dunlap
1 sibling, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2012-06-20 19:54 UTC (permalink / raw)
To: Axel Lin
Cc: linux-kernel, Chanwoo Choi, Myungjoo Ham, Kyungmin Park, Samuel Ortiz
On 06/19/2012 06:40 PM, Axel Lin wrote:
> This fixes below build errors:
>
> CC drivers/mfd/max77693-irq.o
> drivers/mfd/max77693-irq.c: In function 'max77693_irq_thread':
> drivers/mfd/max77693-irq.c:217:4: error: implicit declaration of function 'irq_find_mapping' [-Werror=implicit-function-declaration]
> drivers/mfd/max77693-irq.c: In function 'max77693_irq_init':
> drivers/mfd/max77693-irq.c:286:2: error: implicit declaration of function 'irq_domain_add_linear' [-Werror=implicit-function-declaration]
> drivers/mfd/max77693-irq.c:286:9: warning: assignment makes pointer from integer without a cast [enabled by default]
> cc1: some warnings being treated as errors
> make[2]: *** [drivers/mfd/max77693-irq.o] Error 1
> make[1]: *** [drivers/mfd] Error 2
> make: *** [drivers] Error 2
>
> Reported-by: Randy Dunlap <rdunlap@xenotime.net>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Randy Dunlap <rdunlap@xenotime.net>
Thanks.
> ---
> drivers/mfd/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index e129c82..79f1d4b 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -427,6 +427,7 @@ config MFD_MAX77693
> depends on I2C=y && GENERIC_HARDIRQS
> select MFD_CORE
> select REGMAP_I2C
> + select IRQ_DOMAIN
> help
> Say yes here to support for Maxim Semiconductor MAX77693.
> This is a companion Power Management IC with Flash, Haptic, Charger,
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mfd: TWL6040_CORE needs to select IRQ_DOMAIN
2012-06-20 19:53 ` [PATCH] mfd: TWL6040_CORE " Randy Dunlap
@ 2012-07-02 14:35 ` Samuel Ortiz
0 siblings, 0 replies; 4+ messages in thread
From: Samuel Ortiz @ 2012-07-02 14:35 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Axel Lin, linux-kernel, Misael Lopez Cruz
Hi Randy,
On Wed, Jun 20, 2012 at 12:53:55PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> Fix build error by selecting IRQ_DOMAIN:
>
> drivers/mfd/twl6040-irq.c:164:2: error: implicit declaration of function 'irq_domain_add_legacy'
> drivers/mfd/twl6040-irq.c:165:11: error: 'irq_domain_simple_ops' undeclared (first use in this function)
This should also be fixed with MFD_CORE selecting IRQ_DOMAIN now.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-07-02 14:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-20 1:40 [PATCH] mfd: MFD_MAX77693 needs to select IRQ_DOMAIN Axel Lin
2012-06-20 19:53 ` [PATCH] mfd: TWL6040_CORE " Randy Dunlap
2012-07-02 14:35 ` Samuel Ortiz
2012-06-20 19:54 ` [PATCH] mfd: MFD_MAX77693 " Randy Dunlap
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.