All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shubhrajyoti <shubhrajyoti-l0cyMroinI0@public.gmane.org>
To: balbi-l0cyMroinI0@public.gmane.org
Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org,
	tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org,
	w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
	Kevin Hilman <khilman-l0cyMroinI0@public.gmane.org>
Subject: Re: [PATCHv10 1/7] I2C: OMAP: I2C register restore only if context is lost
Date: Tue, 26 Jun 2012 16:53:21 +0530	[thread overview]
Message-ID: <4FE99BA9.9030107@ti.com> (raw)
In-Reply-To: <4FE951C7.8070907-l0cyMroinI0@public.gmane.org>

On Tuesday 26 June 2012 11:38 AM, Shubhrajyoti wrote:
> On Monday 25 June 2012 06:00 PM, Felipe Balbi wrote:
>>> Cc: Kevin Hilman <khilman-l0cyMroinI0@public.gmane.org>
>>>> Signed-off-by: Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org>
>> how will this ever work with DT ? 
> What you say makes sense however that is what currently
> most of the omap drivers do.
>
> Will check on this.
>> I say we get rid of the OMAP-specific
>> API and build this "context lost" status directly on dev_pm_info and
>> have something like pm_runtime_lost_context() or something with pm QoS
>> tell you if a device has lost its context.
>>
>> Also, your commit log doesn't really state any problems you might have
>> reached before,
Didnt see any issues while reviewing found that the restore was done always.
>>  or any improvements wrt latency coming out of suspend
>> and so on.
I am only restoring only 4-5 registers.

>>
>> IMHO, drivers need a generic way to differentiate if they're resuming
>> from OFF or RET, otherwise we will end up with a bunch of OMAP-specific
>> hackery on all drivers
>

WARNING: multiple messages have this Message-ID (diff)
From: shubhrajyoti@ti.com (Shubhrajyoti)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv10 1/7] I2C: OMAP: I2C register restore only if context is lost
Date: Tue, 26 Jun 2012 16:53:21 +0530	[thread overview]
Message-ID: <4FE99BA9.9030107@ti.com> (raw)
In-Reply-To: <4FE951C7.8070907@ti.com>

On Tuesday 26 June 2012 11:38 AM, Shubhrajyoti wrote:
> On Monday 25 June 2012 06:00 PM, Felipe Balbi wrote:
>>> Cc: Kevin Hilman <khilman@ti.com>
>>>> Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
>> how will this ever work with DT ? 
> What you say makes sense however that is what currently
> most of the omap drivers do.
>
> Will check on this.
>> I say we get rid of the OMAP-specific
>> API and build this "context lost" status directly on dev_pm_info and
>> have something like pm_runtime_lost_context() or something with pm QoS
>> tell you if a device has lost its context.
>>
>> Also, your commit log doesn't really state any problems you might have
>> reached before,
Didnt see any issues while reviewing found that the restore was done always.
>>  or any improvements wrt latency coming out of suspend
>> and so on.
I am only restoring only 4-5 registers.

>>
>> IMHO, drivers need a generic way to differentiate if they're resuming
>> from OFF or RET, otherwise we will end up with a bunch of OMAP-specific
>> hackery on all drivers
>

  parent reply	other threads:[~2012-06-26 11:23 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-25 11:11 [PATCHv9 0/7] I2C cleanups Shubhrajyoti D
2012-06-25 11:11 ` Shubhrajyoti D
2012-06-25 11:11 ` [PATCHv10 1/7] I2C: OMAP: I2C register restore only if context is lost Shubhrajyoti D
2012-06-25 11:11   ` Shubhrajyoti D
2012-06-25 12:30   ` Felipe Balbi
2012-06-25 12:30     ` Felipe Balbi
2012-06-26  6:08     ` Shubhrajyoti
2012-06-26  6:08       ` Shubhrajyoti
     [not found]       ` <4FE951C7.8070907-l0cyMroinI0@public.gmane.org>
2012-06-26 11:23         ` Shubhrajyoti [this message]
2012-06-26 11:23           ` Shubhrajyoti
     [not found] ` <1340622702-21622-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-06-25 11:11   ` [PATCHv10 2/7] I2C: OMAP: Optimise the remove code Shubhrajyoti D
2012-06-25 11:11     ` Shubhrajyoti D
2012-06-25 11:11   ` [PATCHv10 3/7] I2C: OMAP: Use SET_RUNTIME_PM_OPS Shubhrajyoti D
2012-06-25 11:11     ` Shubhrajyoti D
2012-06-25 11:11   ` [PATCHv10 6/7] I2C: OMAP: Correct I2C revision for OMAP3 Shubhrajyoti D
2012-06-25 11:11     ` Shubhrajyoti D
     [not found]     ` <1340622702-21622-7-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-06-25 12:35       ` Felipe Balbi
2012-06-25 12:35         ` Felipe Balbi
2012-06-25 11:11 ` [PATCHv10 4/7] I2C: OMAP: Do not initialise the completion everytime Shubhrajyoti D
2012-06-25 11:11   ` Shubhrajyoti D
     [not found]   ` <1340622702-21622-5-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-06-25 12:33     ` Felipe Balbi
2012-06-25 12:33       ` Felipe Balbi
2012-06-25 11:11 ` [PATCHv10 5/7] I2C: OMAP: Remove the definition of SYSS_RESETDONE_MASK Shubhrajyoti D
2012-06-25 11:11   ` Shubhrajyoti D
     [not found]   ` <1340622702-21622-6-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-06-25 12:34     ` Felipe Balbi
2012-06-25 12:34       ` Felipe Balbi
2012-06-25 11:11 ` [PATCHv10 7/7] I2C: OMAP: Recover from Bus Busy condition Shubhrajyoti D
2012-06-25 11:11   ` Shubhrajyoti D

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FE99BA9.9030107@ti.com \
    --to=shubhrajyoti-l0cymroini0@public.gmane.org \
    --cc=balbi-l0cyMroinI0@public.gmane.org \
    --cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
    --cc=khilman-l0cyMroinI0@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
    --cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.