All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] ahci: Enable SB600 64bit DMA on MSI K9AGM2 (MS-7327)
@ 2012-06-26  2:45 Mark Nelson
  2012-06-26 10:48 ` Sergei Shtylyov
  0 siblings, 1 reply; 5+ messages in thread
From: Mark Nelson @ 2012-06-26  2:45 UTC (permalink / raw)
  To: Jeff Garzik; +Cc: linux-ide, tj

Like e65cc194f7628ecaa02462f22f42fb09b50dcd49 this patch enables 64bit DMA
for the AHCI SATA controller of a board that has the SB600 southbridge. In
this case though we're enabling 64bit DMA for another MSI motherboard, the
K9AGM2 or MS-7327. It is new enough that all of the BIOS releases since
the initial release (1.0 from 2007-02-09) work correctly with 64bit DMA 
enabled.

Signed-off-by: Mark Nelson <mdnelson8@gmail.com>
---
  drivers/ata/ahci.c |   16 ++++++++++++++++
  1 file changed, 16 insertions(+)

Index: linux-2.6/drivers/ata/ahci.c
===================================================================
--- linux-2.6.orig/drivers/ata/ahci.c
+++ linux-2.6/drivers/ata/ahci.c
@@ -777,6 +777,22 @@ static bool ahci_sb600_enable_64bit(stru
  			},
  		},
  		/*
+		 * All BIOS versions for the MSI K9AGM2 (MS-7327) support
+		 * 64bit DMA.
+		 *
+		 * This board also had the typo mentioned above in the
+		 * Manufacturer DMI field (fixed in BIOS version 1.5), so
+		 * match on DMI_BOARD_VENDOR of "MICRO-STAR INTER" again.
+		 */
+		{
+			.ident = "MSI K9AGM2",
+			.matches = {
+				DMI_MATCH(DMI_BOARD_VENDOR,
+					  "MICRO-STAR INTER"),
+				DMI_MATCH(DMI_BOARD_NAME, "MS-7327"),
+			},
+		},
+		/*
  		 * All BIOS versions for the Asus M3A support 64bit DMA.
  		 * (all release versions from 0301 to 1206 were tested)
  		 */

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/1] ahci: Enable SB600 64bit DMA on MSI K9AGM2 (MS-7327)
  2012-06-26  2:45 [PATCH 1/1] ahci: Enable SB600 64bit DMA on MSI K9AGM2 (MS-7327) Mark Nelson
@ 2012-06-26 10:48 ` Sergei Shtylyov
  2012-06-27  6:31   ` Mark Nelson
  0 siblings, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2012-06-26 10:48 UTC (permalink / raw)
  To: Mark Nelson; +Cc: Jeff Garzik, linux-ide, tj

Hello.

On 26-06-2012 6:45, Mark Nelson wrote:

> Like e65cc194f7628ecaa02462f22f42fb09b50dcd49

    Please also specify that commit's summary in parens.

> this patch enables 64bit DMA
> for the AHCI SATA controller of a board that has the SB600 southbridge. In
> this case though we're enabling 64bit DMA for another MSI motherboard, the
> K9AGM2 or MS-7327. It is new enough that all of the BIOS releases since
> the initial release (1.0 from 2007-02-09) work correctly with 64bit DMA enabled.

> Signed-off-by: Mark Nelson <mdnelson8@gmail.com>

MBR, Sergei

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/1] ahci: Enable SB600 64bit DMA on MSI K9AGM2 (MS-7327)
  2012-06-26 10:48 ` Sergei Shtylyov
@ 2012-06-27  6:31   ` Mark Nelson
  2012-06-27 11:43     ` Sergei Shtylyov
  0 siblings, 1 reply; 5+ messages in thread
From: Mark Nelson @ 2012-06-27  6:31 UTC (permalink / raw)
  To: Sergei Shtylyov; +Cc: Jeff Garzik, linux-ide, tj

On 26/06/12 20:48, Sergei Shtylyov wrote:
> Hello.
>
> On 26-06-2012 6:45, Mark Nelson wrote:
>
>> Like e65cc194f7628ecaa02462f22f42fb09b50dcd49
>
> Please also specify that commit's summary in parens.

Very good point! Should I do a simple respin of this patch adding the 
commit summary, or just do it for future patches?

Thanks!
Mark

>
>> this patch enables 64bit DMA
>> for the AHCI SATA controller of a board that has the SB600
>> southbridge. In
>> this case though we're enabling 64bit DMA for another MSI motherboard,
>> the
>> K9AGM2 or MS-7327. It is new enough that all of the BIOS releases since
>> the initial release (1.0 from 2007-02-09) work correctly with 64bit
>> DMA enabled.
>
>> Signed-off-by: Mark Nelson <mdnelson8@gmail.com>
>
> MBR, Sergei

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/1] ahci: Enable SB600 64bit DMA on MSI K9AGM2 (MS-7327)
  2012-06-27  6:31   ` Mark Nelson
@ 2012-06-27 11:43     ` Sergei Shtylyov
  2012-06-28  2:32       ` [PATCH 1/1] ahci: Enable SB600 64bit DMA on MSI K9AGM2 (MS-7327) v2 Mark Nelson
  0 siblings, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2012-06-27 11:43 UTC (permalink / raw)
  To: Mark Nelson; +Cc: Jeff Garzik, linux-ide, tj

Hello.

On 27-06-2012 10:31, Mark Nelson wrote:

>>> Like e65cc194f7628ecaa02462f22f42fb09b50dcd49

>> Please also specify that commit's summary in parens.

> Very good point! Should I do a simple respin of this patch adding the commit
> summary, or just do it for future patches?

    That's up to the maintainer but I'd respin the patch...

> Thanks!
> Mark

>>> this patch enables 64bit DMA
>>> for the AHCI SATA controller of a board that has the SB600
>>> southbridge. In
>>> this case though we're enabling 64bit DMA for another MSI motherboard,
>>> the
>>> K9AGM2 or MS-7327. It is new enough that all of the BIOS releases since
>>> the initial release (1.0 from 2007-02-09) work correctly with 64bit
>>> DMA enabled.

>>> Signed-off-by: Mark Nelson <mdnelson8@gmail.com>

MBR, Sergei

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/1] ahci: Enable SB600 64bit DMA on MSI K9AGM2 (MS-7327) v2
  2012-06-27 11:43     ` Sergei Shtylyov
@ 2012-06-28  2:32       ` Mark Nelson
  0 siblings, 0 replies; 5+ messages in thread
From: Mark Nelson @ 2012-06-28  2:32 UTC (permalink / raw)
  To: Jeff Garzik; +Cc: Sergei Shtylyov, linux-ide, tj

Like e65cc194f7628ecaa02462f22f42fb09b50dcd49 (ahci: Enable SB600 64bit
DMA on MSI K9A2 Platinum) and 3c4aa91f21f65b7b40bdfb015eacbcb8453ccae2
(ahci: Enable SB600 64bit DMA on Asus M3A), this patch enables 64bit DMA
for the AHCI SATA controller of another board that has the SB600
southbridge.

In this case though we're enabling 64bit DMA for another MSI motherboard,
the K9AGM2 or MS-7327. It is new enough that all of the BIOS releases
since the initial release (1.0 from 2007-02-09) work correctly with 64bit
DMA enabled.

Signed-off-by: Mark Nelson <mdnelson8@gmail.com>
---
v2 brings a more fleshed out commit message including the commit
summaries of the commits mentioned

  drivers/ata/ahci.c |   16 ++++++++++++++++
  1 file changed, 16 insertions(+)

Index: linux-2.6/drivers/ata/ahci.c
===================================================================
--- linux-2.6.orig/drivers/ata/ahci.c
+++ linux-2.6/drivers/ata/ahci.c
@@ -777,6 +777,22 @@ static bool ahci_sb600_enable_64bit(stru
  			},
  		},
  		/*
+		 * All BIOS versions for the MSI K9AGM2 (MS-7327) support
+		 * 64bit DMA.
+		 *
+		 * This board also had the typo mentioned above in the
+		 * Manufacturer DMI field (fixed in BIOS version 1.5), so
+		 * match on DMI_BOARD_VENDOR of "MICRO-STAR INTER" again.
+		 */
+		{
+			.ident = "MSI K9AGM2",
+			.matches = {
+				DMI_MATCH(DMI_BOARD_VENDOR,
+					  "MICRO-STAR INTER"),
+				DMI_MATCH(DMI_BOARD_NAME, "MS-7327"),
+			},
+		},
+		/*
  		 * All BIOS versions for the Asus M3A support 64bit DMA.
  		 * (all release versions from 0301 to 1206 were tested)
  		 */

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2012-06-28  2:32 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-26  2:45 [PATCH 1/1] ahci: Enable SB600 64bit DMA on MSI K9AGM2 (MS-7327) Mark Nelson
2012-06-26 10:48 ` Sergei Shtylyov
2012-06-27  6:31   ` Mark Nelson
2012-06-27 11:43     ` Sergei Shtylyov
2012-06-28  2:32       ` [PATCH 1/1] ahci: Enable SB600 64bit DMA on MSI K9AGM2 (MS-7327) v2 Mark Nelson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.