All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benoit Cousson <b-cousson@ti.com>
To: Vaibhav Hiremath <hvaibhav@ti.com>
Cc: linux-omap@vger.kernel.org, tony@atomide.com,
	linux-arm-kernel@lists.infradead.org,
	Kevin Hilman <khilman@ti.com>, Paul Walmsley <paul@pwsan.com>
Subject: Re: [PATCH-V3 3/3] ARM: OMAP2+: CLEANUP: Remove unnecessary ifdef around __omap2_set_globals
Date: Thu, 28 Jun 2012 17:05:38 +0200	[thread overview]
Message-ID: <4FEC72C2.7010106@ti.com> (raw)
In-Reply-To: <1340895567-22766-4-git-send-email-hvaibhav@ti.com>

Hi Vaibhav,

One small comment.

On 06/28/2012 04:59 PM, Vaibhav Hiremath wrote:
> The function __omap2_set_globals() can be common across all
> platforms/architectures, even in case of omap4, internally it
> calls same set of functions as in __omap2_set_globals() function
> (except for sdrc).
> This patch adds new config flag SOC_HAS_OMAP2_SDRC to handle sdrc,
> so that we can reuse same function across omap2/3/4...
>
> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Kevin Hilman <khilman@ti.com>
> Cc: Paul Walmsley <paul@pwsan.com>
>
> Changes from V1:
> 	- Added Makefile rule to build sdrc.c file for new
> 	  option SOC_HAS_OMAP2_SDRC (as per Kevin's comment).
> ---
>   arch/arm/mach-omap2/Kconfig  |    8 ++++++++
>   arch/arm/mach-omap2/Makefile |    3 ++-
>   arch/arm/mach-omap2/common.c |    8 +-------
>   arch/arm/mach-omap2/common.h |    5 +++++
>   4 files changed, 16 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> index 208b950..82d9d18 100644
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -21,12 +21,16 @@ config ARCH_OMAP2PLUS_TYPICAL
>   	help
>   	  Compile a kernel suitable for booting most boards
>
> +config SOC_HAS_OMAP2_SDRC
> +	bool "OMAP2 SDRAM Controller support"
> +
>   config ARCH_OMAP2
>   	bool "TI OMAP2"
>   	depends on ARCH_OMAP2PLUS
>   	default y
>   	select CPU_V6
>   	select MULTI_IRQ_HANDLER
> +	select SOC_HAS_OMAP2_SDRC
>
>   config ARCH_OMAP3
>   	bool "TI OMAP3"
> @@ -39,6 +43,7 @@ config ARCH_OMAP3
>   	select PM_OPP if PM
>   	select ARM_CPU_SUSPEND if PM
>   	select MULTI_IRQ_HANDLER
> +	select SOC_HAS_OMAP2_SDRC
>
>   config ARCH_OMAP4
>   	bool "TI OMAP4"
> @@ -66,16 +71,19 @@ config SOC_OMAP2420
>   	depends on ARCH_OMAP2
>   	default y
>   	select OMAP_DM_TIMER
> +	select SOC_HAS_OMAP2_SDRC

OMAP4 does not have the SDRC but the EMIF like TI8XX.

Regards,
Benoit

WARNING: multiple messages have this Message-ID (diff)
From: b-cousson@ti.com (Benoit Cousson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH-V3 3/3] ARM: OMAP2+: CLEANUP: Remove unnecessary ifdef around __omap2_set_globals
Date: Thu, 28 Jun 2012 17:05:38 +0200	[thread overview]
Message-ID: <4FEC72C2.7010106@ti.com> (raw)
In-Reply-To: <1340895567-22766-4-git-send-email-hvaibhav@ti.com>

Hi Vaibhav,

One small comment.

On 06/28/2012 04:59 PM, Vaibhav Hiremath wrote:
> The function __omap2_set_globals() can be common across all
> platforms/architectures, even in case of omap4, internally it
> calls same set of functions as in __omap2_set_globals() function
> (except for sdrc).
> This patch adds new config flag SOC_HAS_OMAP2_SDRC to handle sdrc,
> so that we can reuse same function across omap2/3/4...
>
> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Kevin Hilman <khilman@ti.com>
> Cc: Paul Walmsley <paul@pwsan.com>
>
> Changes from V1:
> 	- Added Makefile rule to build sdrc.c file for new
> 	  option SOC_HAS_OMAP2_SDRC (as per Kevin's comment).
> ---
>   arch/arm/mach-omap2/Kconfig  |    8 ++++++++
>   arch/arm/mach-omap2/Makefile |    3 ++-
>   arch/arm/mach-omap2/common.c |    8 +-------
>   arch/arm/mach-omap2/common.h |    5 +++++
>   4 files changed, 16 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> index 208b950..82d9d18 100644
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -21,12 +21,16 @@ config ARCH_OMAP2PLUS_TYPICAL
>   	help
>   	  Compile a kernel suitable for booting most boards
>
> +config SOC_HAS_OMAP2_SDRC
> +	bool "OMAP2 SDRAM Controller support"
> +
>   config ARCH_OMAP2
>   	bool "TI OMAP2"
>   	depends on ARCH_OMAP2PLUS
>   	default y
>   	select CPU_V6
>   	select MULTI_IRQ_HANDLER
> +	select SOC_HAS_OMAP2_SDRC
>
>   config ARCH_OMAP3
>   	bool "TI OMAP3"
> @@ -39,6 +43,7 @@ config ARCH_OMAP3
>   	select PM_OPP if PM
>   	select ARM_CPU_SUSPEND if PM
>   	select MULTI_IRQ_HANDLER
> +	select SOC_HAS_OMAP2_SDRC
>
>   config ARCH_OMAP4
>   	bool "TI OMAP4"
> @@ -66,16 +71,19 @@ config SOC_OMAP2420
>   	depends on ARCH_OMAP2
>   	default y
>   	select OMAP_DM_TIMER
> +	select SOC_HAS_OMAP2_SDRC

OMAP4 does not have the SDRC but the EMIF like TI8XX.

Regards,
Benoit

  reply	other threads:[~2012-06-28 15:05 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-28 14:59 [PATCH-V3 0/3] ARM: OMAP2+: Cleanup series in order to remove ARCH_OMAPx dependency Vaibhav Hiremath
2012-06-28 14:59 ` Vaibhav Hiremath
2012-06-28 14:59 ` [PATCH-V3 1/3] ARM: OMAP2+: CLEANUP: All OMAP2PLUS uses omap-device.o target so add one entry Vaibhav Hiremath
2012-06-28 14:59   ` Vaibhav Hiremath
2012-07-04  7:27   ` Tony Lindgren
2012-07-04  7:27     ` Tony Lindgren
2012-07-04  9:16     ` Hiremath, Vaibhav
2012-07-04  9:16       ` Hiremath, Vaibhav
2012-07-05  9:53       ` Tony Lindgren
2012-07-05  9:53         ` Tony Lindgren
2012-06-28 14:59 ` [PATCH-V3 2/3] ARM: OMAP2+: CLEANUP: Move omap3 dpll ops to dpll3xxx.c Vaibhav Hiremath
2012-06-28 14:59   ` Vaibhav Hiremath
2012-06-28 14:59 ` [PATCH-V3 3/3] ARM: OMAP2+: CLEANUP: Remove unnecessary ifdef around __omap2_set_globals Vaibhav Hiremath
2012-06-28 14:59   ` Vaibhav Hiremath
2012-06-28 15:05   ` Benoit Cousson [this message]
2012-06-28 15:05     ` Benoit Cousson
2012-06-28 15:36     ` Hiremath, Vaibhav
2012-06-28 15:36       ` Hiremath, Vaibhav
2012-06-28 15:39     ` Hiremath, Vaibhav
2012-06-28 15:39       ` Hiremath, Vaibhav
2012-06-28 15:41       ` Benoit Cousson
2012-06-28 15:41         ` Benoit Cousson
2012-06-29 12:44         ` Tony Lindgren
2012-06-29 12:44           ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FEC72C2.7010106@ti.com \
    --to=b-cousson@ti.com \
    --cc=hvaibhav@ti.com \
    --cc=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.