All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <dedekind1@gmail.com>
Cc: linuxppc-dev@lists.ozlabs.org,
	David Woodhouse <David.Woodhouse@intel.com>,
	linux-mtd@lists.infradead.org
Subject: Re: [PATCH 2/3] mtd: delete SBC82xx/SBC8560 MTD mapping support
Date: Fri, 29 Jun 2012 10:00:06 -0400	[thread overview]
Message-ID: <4FEDB4E6.4090109@windriver.com> (raw)
In-Reply-To: <1340958563.3070.132.camel@sauron.fi.intel.com>

On 12-06-29 04:29 AM, Artem Bityutskiy wrote:
> On Tue, 2012-06-26 at 15:54 -0400, Paul Gortmaker wrote:
>> The SBC8260 support was dropped back when we moved from ppc to
>> powerpc.  We are now also dropping the support for the EOL SBC8560,
>> so we can also delete this mapping support, as they were the only
>> users of it.
>>
>> Cc: David Woodhouse <David.Woodhouse@intel.com>
>> Cc: linux-mtd@lists.infradead.org
>> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> 
> You forgot this:
> 
> diff --git a/drivers/mtd/maps/Makefile b/drivers/mtd/maps/Makefile
> index 68a9a91..deb43e9 100644
> --- a/drivers/mtd/maps/Makefile
> +++ b/drivers/mtd/maps/Makefile
> @@ -47,7 +47,6 @@ obj-$(CONFIG_MTD_SCB2_FLASH)  += scb2_flash.o
>  obj-$(CONFIG_MTD_H720X)                += h720x-flash.o
>  obj-$(CONFIG_MTD_IXP4XX)       += ixp4xx.o
>  obj-$(CONFIG_MTD_IXP2000)      += ixp2000.o
> -obj-$(CONFIG_MTD_WRSBC8260)    += wr_sbc82xx_flash.o

Agreed.  I'd figured that died back in 2.6.2x when the old
ppc board got removed, and it never even crossed my mind to
git grep for it.  Funny that some automated orphan CONFIG_
checker script didn't find it (assuming there is one.)

Thanks,
Paul.
--

>  obj-$(CONFIG_MTD_DMV182)       += dmv182.o
>  obj-$(CONFIG_MTD_PLATRAM)      += plat-ram.o
>  obj-$(CONFIG_MTD_INTEL_VR_NOR) += intel_vr_nor.o
> 
> I've amended the patch and pushed to l2-mtd.git tree, thanks!
> 

WARNING: multiple messages have this Message-ID (diff)
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <dedekind1@gmail.com>
Cc: benh@kernel.crashing.org, linuxppc-dev@lists.ozlabs.org,
	David Woodhouse <David.Woodhouse@intel.com>,
	linux-mtd@lists.infradead.org
Subject: Re: [PATCH 2/3] mtd: delete SBC82xx/SBC8560 MTD mapping support
Date: Fri, 29 Jun 2012 10:00:06 -0400	[thread overview]
Message-ID: <4FEDB4E6.4090109@windriver.com> (raw)
In-Reply-To: <1340958563.3070.132.camel@sauron.fi.intel.com>

On 12-06-29 04:29 AM, Artem Bityutskiy wrote:
> On Tue, 2012-06-26 at 15:54 -0400, Paul Gortmaker wrote:
>> The SBC8260 support was dropped back when we moved from ppc to
>> powerpc.  We are now also dropping the support for the EOL SBC8560,
>> so we can also delete this mapping support, as they were the only
>> users of it.
>>
>> Cc: David Woodhouse <David.Woodhouse@intel.com>
>> Cc: linux-mtd@lists.infradead.org
>> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> 
> You forgot this:
> 
> diff --git a/drivers/mtd/maps/Makefile b/drivers/mtd/maps/Makefile
> index 68a9a91..deb43e9 100644
> --- a/drivers/mtd/maps/Makefile
> +++ b/drivers/mtd/maps/Makefile
> @@ -47,7 +47,6 @@ obj-$(CONFIG_MTD_SCB2_FLASH)  += scb2_flash.o
>  obj-$(CONFIG_MTD_H720X)                += h720x-flash.o
>  obj-$(CONFIG_MTD_IXP4XX)       += ixp4xx.o
>  obj-$(CONFIG_MTD_IXP2000)      += ixp2000.o
> -obj-$(CONFIG_MTD_WRSBC8260)    += wr_sbc82xx_flash.o

Agreed.  I'd figured that died back in 2.6.2x when the old
ppc board got removed, and it never even crossed my mind to
git grep for it.  Funny that some automated orphan CONFIG_
checker script didn't find it (assuming there is one.)

Thanks,
Paul.
--

>  obj-$(CONFIG_MTD_DMV182)       += dmv182.o
>  obj-$(CONFIG_MTD_PLATRAM)      += plat-ram.o
>  obj-$(CONFIG_MTD_INTEL_VR_NOR) += intel_vr_nor.o
> 
> I've amended the patch and pushed to l2-mtd.git tree, thanks!
> 

  reply	other threads:[~2012-06-29 14:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-26 19:54 [PATCH 0/3] powerpc: delete WR sbc8560 board support Paul Gortmaker
2012-06-26 19:54 ` [PATCH 1/3] powerpc: remove Wind River SBC8560 support Paul Gortmaker
2012-06-29 20:02   ` Kumar Gala
2012-06-26 19:54 ` [PATCH 2/3] mtd: delete SBC82xx/SBC8560 MTD mapping support Paul Gortmaker
2012-06-29  8:29   ` Artem Bityutskiy
2012-06-29  8:29     ` Artem Bityutskiy
2012-06-29 14:00     ` Paul Gortmaker [this message]
2012-06-29 14:00       ` Paul Gortmaker
2012-06-26 19:54 ` [PATCH 3/3] serial/8250: delete WR SBC850 UART quirk handling Paul Gortmaker
2012-06-26 19:54   ` Paul Gortmaker
2012-06-27 11:52   ` Alan Cox
2012-06-27 11:52     ` Alan Cox
2012-06-27 14:04     ` Paul Gortmaker
2012-06-27 14:04       ` Paul Gortmaker
2012-06-27 14:37       ` Alan Cox
2012-06-27 14:37         ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FEDB4E6.4090109@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=David.Woodhouse@intel.com \
    --cc=dedekind1@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.