All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: "ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org"
	<ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>,
	"olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org"
	<olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
	"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] ARM: tegra: apbio: use dmaengine based dma driver
Date: Sat, 30 Jun 2012 20:31:16 +0530	[thread overview]
Message-ID: <4FEF14BC.1080703@nvidia.com> (raw)
In-Reply-To: <4FEDE035.6040005-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>

On Friday 29 June 2012 10:34 PM, Stephen Warren wrote:
> On 06/29/2012 05:30 AM, Laxman Dewangan wrote:
>> Use the dmaengine based Tegra APB DMA driver for
>> apbio access in place of legacy Tegra APB DMA.
>>
>> The new driver is selected if legacy driver is not
>> selected and new DMA driver is enabled through config
>> file.
>> +bool tegra_apb_dma_init(void)
>> +{
> ...
>> +	tegra_apb_dma_chan = dma_request_channel(mask, NULL, NULL);
>> +	if (!tegra_apb_dma_chan) {
>> +		pr_err("%s: can not allocate dma channel\n", __func__);
>> +		goto err_dma_alloc;
>> +	}
> That fires quite a few times during boot, before the DMA driver is
> probed. I think the message should be down-graded to a pr_dbg(). Do you
> agree? I can fix that myself when applying this if you're OK with the
> change.
>

I saw that you already applied it. But for record, I am fine to change 
it to pr_debug.

> Aside from that, this looks fine to me.

WARNING: multiple messages have this Message-ID (diff)
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: "ccross@android.com" <ccross@android.com>,
	"olof@lixom.net" <olof@lixom.net>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: tegra: apbio: use dmaengine based dma driver
Date: Sat, 30 Jun 2012 20:31:16 +0530	[thread overview]
Message-ID: <4FEF14BC.1080703@nvidia.com> (raw)
In-Reply-To: <4FEDE035.6040005@wwwdotorg.org>

On Friday 29 June 2012 10:34 PM, Stephen Warren wrote:
> On 06/29/2012 05:30 AM, Laxman Dewangan wrote:
>> Use the dmaengine based Tegra APB DMA driver for
>> apbio access in place of legacy Tegra APB DMA.
>>
>> The new driver is selected if legacy driver is not
>> selected and new DMA driver is enabled through config
>> file.
>> +bool tegra_apb_dma_init(void)
>> +{
> ...
>> +	tegra_apb_dma_chan = dma_request_channel(mask, NULL, NULL);
>> +	if (!tegra_apb_dma_chan) {
>> +		pr_err("%s: can not allocate dma channel\n", __func__);
>> +		goto err_dma_alloc;
>> +	}
> That fires quite a few times during boot, before the DMA driver is
> probed. I think the message should be down-graded to a pr_dbg(). Do you
> agree? I can fix that myself when applying this if you're OK with the
> change.
>

I saw that you already applied it. But for record, I am fine to change 
it to pr_debug.

> Aside from that, this looks fine to me.


  parent reply	other threads:[~2012-06-30 15:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-29 11:30 [PATCH] ARM: tegra: apbio: use dmaengine based dma driver Laxman Dewangan
2012-06-29 11:30 ` Laxman Dewangan
     [not found] ` <1340969407-7662-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-06-29 17:04   ` Stephen Warren
2012-06-29 17:04     ` Stephen Warren
     [not found]     ` <4FEDE035.6040005-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-06-30 15:01       ` Laxman Dewangan [this message]
2012-06-30 15:01         ` Laxman Dewangan
2012-06-29 23:10   ` Stephen Warren
2012-06-29 23:10     ` Stephen Warren
2012-06-29 11:34 Laxman Dewangan
2012-06-29 11:34 ` Laxman Dewangan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FEF14BC.1080703@nvidia.com \
    --to=ldewangan-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
    --cc=ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
    --cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.