All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/3 V3b] Enable building modules on target
@ 2012-06-30  4:25 Darren Hart
  2012-06-30  4:25 ` [PATCH 1/3] kernel: Add kernel headers to kernel-dev package Darren Hart
                   ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: Darren Hart @ 2012-06-30  4:25 UTC (permalink / raw)
  To: Poky, Saul Wold, openembedded-core, Kishore Bodke; +Cc: Darren Hart

Note: As this is a major change that impacts every BSP, I suggest this
      spend some time in MUT before being included into master.

This series adds support for building modules on the target via an expanded
kernel-dev package.

Sending to both oe-core and poky as this series touches files in both
and I didn't want to confuse the intent or the dependency by splitting
them up (at least the original did, keeping it consistent).

V2:
o Add files to kernel-dev rather than create a new kernel-headers package
o Move the location to /usr/src/kernel from /usr/src/kernel-headers
o Eliminate the kernel-misc package as kernel-dev covers it now
o Fix a bug with linux-yocto-custom exposed during testing

V3b:
o Rebase on origin/master where 2 patches had already been applied
o Correct the bitbake.conf STAGING_KERNEL_DIR path which I missed in V2
o Move kernel-dev inclusion from task-core-sdk to the core-image*sdk recipes
  in order to avoid making task-core-sdk machine specific
o Kill the kernel_package_prepend() function which deleted the kernel headers
o Add a KERNEL_SRC_DIR variable to avoid missing one of the many hard-coded
  paths during an update

Testing Performed:
Built core-image-sato-sdk, core-image-lsb-sdk, and core-image-rt-sdk for
qemux86 and built the kernel scripts with:

  # make -C /usr/src/kernel scripts

For sato-sdk and lsb-sdk, copied over the hello-mod module sources and built the
hello-mod module on the target, insmod, rmmod, dmesg -n 2.  The output was
correct. rt-sdk didn't have dropbear or feasible way to quickly copy the files
across, but I'm confident knowing the scripts built.

The following changes since commit a5b2c1e4ce3ad4f2b9ea306c6d10f528c5ef8b66:

  bitbake: Hob: change 'run image' and 'deploy' Gui and work flow for building detail page (2012-06-29 14:46:47 +0100)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib dvhart/modules-v3
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=dvhart/modules-v3

Darren Hart (3):
  kernel: Add kernel headers to kernel-dev package
  linux-yocto-custom: Remove linux-tools
  core-image*sdk: Add kernel-dev to sdk images

 .../recipes-kernel/linux/linux-yocto-custom.bb     |    2 --
 meta/classes/kernel.bbclass                        |   27 +++++++++-----------
 meta/conf/bitbake.conf                             |    2 +-
 meta/recipes-extended/images/core-image-lsb-sdk.bb |    1 +
 meta/recipes-kernel/linux/linux-yocto.inc          |    2 +-
 meta/recipes-rt/images/core-image-rt-sdk.bb        |    2 +-
 meta/recipes-sato/images/core-image-sato-sdk.bb    |    3 +++
 7 files changed, 19 insertions(+), 20 deletions(-)

-- 
1.7.10.2




^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 1/3] kernel: Add kernel headers to kernel-dev package
  2012-06-30  4:25 [PATCH 0/3 V3b] Enable building modules on target Darren Hart
@ 2012-06-30  4:25 ` Darren Hart
  2012-07-01  3:51     ` Bruce Ashfield
  2012-06-30  4:25 ` [PATCH 2/3] linux-yocto-custom: Remove linux-tools Darren Hart
  2012-06-30  4:25 ` [PATCH 3/3] core-image*sdk: Add kernel-dev to sdk images Darren Hart
  2 siblings, 1 reply; 10+ messages in thread
From: Darren Hart @ 2012-06-30  4:25 UTC (permalink / raw)
  To: Poky, Saul Wold, openembedded-core, Kishore Bodke; +Cc: Darren Hart

[YOCTO #1614]

Add the kernel headers to the kernel-dev package. This packages what was
already built and kept in sysroots for building modules with bitbake.
Making this available on the target requires removing some additional
host binaries.

Move the location to /usr/src/kernel

Before use on the target, the user will need to:

    # cd /usr/src/kernel
    # make scripts

This renders the kernel-misc recipe empty, so remove it.

As we use /usr/src/kernel in several places (and I missed one in the
previous version), add a KERNEL_SRC_DIR variable and use that throughout
the class to avoid update errors in the future.

Now that we package the kernel headers, drop the
kernel_package_preprocess function which removed them from PKGD.

All *-sdk image recipes include dev-pkgs, so the kernel-dev package will
be installed by default on all such images.

Signed-off-by: Darren Hart <dvhart@linux.intel.com>
CC: Bruce Ashfield <bruce.ashfield@windriver.com>
CC: Tom Zanussi <tom.zanussi@intel.com>
CC: Khem Raj <raj.khem@gmail.com>
---
 meta/classes/kernel.bbclass               |   27 ++++++++++++---------------
 meta/conf/bitbake.conf                    |    2 +-
 meta/recipes-kernel/linux/linux-yocto.inc |    2 +-
 3 files changed, 14 insertions(+), 17 deletions(-)

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index 31e633b..44461bc 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -77,6 +77,10 @@ EXTRA_OEMAKE = ""
 
 KERNEL_ALT_IMAGETYPE ??= ""
 
+# Define where the kernel headers are installed on the target as well as where
+# they are staged.
+KERNEL_SRC_PATH = "/usr/src/kernel"
+
 KERNEL_IMAGETYPE_FOR_MAKE = "${@(lambda s: s[:-3] if s[-3:] == ".gz" else s)(d.getVar('KERNEL_IMAGETYPE', True))}"
 
 kernel_do_compile() {
@@ -130,7 +134,7 @@ kernel_do_install() {
 	# Support for external module building - create a minimal copy of the
 	# kernel source tree.
 	#
-	kerneldir=${D}/kernel
+	kerneldir=${D}${KERNEL_SRC_PATH}
 	install -d $kerneldir
 
 	#
@@ -183,23 +187,18 @@ kernel_do_install() {
 		cp arch/powerpc/lib/crtsavres.o $kerneldir/arch/powerpc/lib/crtsavres.o
 	fi
 
-	# Remove the following binaries which cause strip errors
+	# Remove the following binaries which cause strip or arch QA errors
 	# during do_package for cross-compiled platforms
 	bin_files="arch/powerpc/boot/addnote arch/powerpc/boot/hack-coff \
-	           arch/powerpc/boot/mktree"
+	           arch/powerpc/boot/mktree scripts/kconfig/zconf.tab.o \
+		   scripts/kconfig/conf.o"
 	for entry in $bin_files; do
 		rm -f $kerneldir/$entry
 	done
 }
 
-PACKAGE_PREPROCESS_FUNCS += "kernel_package_preprocess"
-
-kernel_package_preprocess () {
-	rm -rf ${PKGD}/kernel
-}
-
 sysroot_stage_all_append() {
-	sysroot_stage_dir ${D}/kernel ${SYSROOT_DESTDIR}/kernel
+	sysroot_stage_dir ${D}${KERNEL_SRC_PATH} ${SYSROOT_DESTDIR}${KERNEL_SRC_PATH}
 }
 
 kernel_do_configure() {
@@ -247,13 +246,11 @@ EXPORT_FUNCTIONS do_compile do_install do_configure
 
 # kernel-base becomes kernel-${KERNEL_VERSION}
 # kernel-image becomes kernel-image-${KERNEL_VERISON}
-PACKAGES = "kernel kernel-base kernel-vmlinux kernel-image kernel-dev kernel-misc"
+PACKAGES = "kernel kernel-base kernel-vmlinux kernel-image kernel-dev"
 FILES = ""
 FILES_kernel-image = "/boot/${KERNEL_IMAGETYPE}*"
-FILES_kernel-dev = "/boot/System.map* /boot/Module.symvers* /boot/config*"
+FILES_kernel-dev = "/boot/System.map* /boot/Module.symvers* /boot/config* ${KERNEL_SRC_PATH}"
 FILES_kernel-vmlinux = "/boot/vmlinux*"
-# misc is a package to contain files we need in staging
-FILES_kernel-misc = "/kernel/include/config /kernel/scripts /kernel/drivers/crypto /kernel/drivers/media"
 RDEPENDS_kernel = "kernel-base"
 # Allow machines to override this dependency if kernel image files are 
 # not wanted in images as standard
@@ -469,7 +466,7 @@ python populate_packages_prepend () {
 	metapkg = "kernel-modules"
 	d.setVar('ALLOW_EMPTY_' + metapkg, "1")
 	d.setVar('FILES_' + metapkg, "")
-	blacklist = [ 'kernel-dev', 'kernel-image', 'kernel-base', 'kernel-vmlinux', 'kernel-misc' ]
+	blacklist = [ 'kernel-dev', 'kernel-image', 'kernel-base', 'kernel-vmlinux' ]
 	for l in module_deps.values():
 		for i in l:
 			pkg = module_pattern % legitimize_package_name(re.match(module_regex, os.path.basename(i)).group(1))
diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index 9377ee6..7e3de09 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -381,7 +381,7 @@ SDKPATHNATIVE = "${SDKPATH}/sysroots/${SDK_SYS}"
 ##################################################################
 
 OLDEST_KERNEL = "2.6.16"
-STAGING_KERNEL_DIR = "${STAGING_DIR_HOST}/kernel"
+STAGING_KERNEL_DIR = "${STAGING_DIR_HOST}/usr/src/kernel"
 
 ##################################################################
 # Specific image creation and rootfs population info.
diff --git a/meta/recipes-kernel/linux/linux-yocto.inc b/meta/recipes-kernel/linux/linux-yocto.inc
index 9b46e74..973970d 100644
--- a/meta/recipes-kernel/linux/linux-yocto.inc
+++ b/meta/recipes-kernel/linux/linux-yocto.inc
@@ -4,7 +4,7 @@ LICENSE = "GPLv2"
 
 LIC_FILES_CHKSUM = "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7"
 
-INC_PR = "r3"
+INC_PR = "r4"
 
 # A KMACHINE is the mapping of a yocto $MACHINE to what is built
 # by the kernel. This is typically the branch that should be built,
-- 
1.7.10.2




^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 2/3] linux-yocto-custom: Remove linux-tools
  2012-06-30  4:25 [PATCH 0/3 V3b] Enable building modules on target Darren Hart
  2012-06-30  4:25 ` [PATCH 1/3] kernel: Add kernel headers to kernel-dev package Darren Hart
@ 2012-06-30  4:25 ` Darren Hart
  2012-06-30  4:25 ` [PATCH 3/3] core-image*sdk: Add kernel-dev to sdk images Darren Hart
  2 siblings, 0 replies; 10+ messages in thread
From: Darren Hart @ 2012-06-30  4:25 UTC (permalink / raw)
  To: Poky, Saul Wold, openembedded-core, Kishore Bodke; +Cc: Darren Hart

Remove the linux-tools include as perf is now packaged independently.
Without this, including meta-skeleton in bblayers.conf results in a
build failure as linux-tools.inc cannot be found.

Signed-off-by: Darren Hart <dvhart@linux.intel.com>
Acked-by: Bruce Ashfield <bruce.ashfield@windriver.com>
CC: Tom Zanussi <tom.zanussi@intel.com>
---
 meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb |    2 --
 1 file changed, 2 deletions(-)

diff --git a/meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb b/meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb
index 1438ad8..55f0c38 100644
--- a/meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb
+++ b/meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb
@@ -42,5 +42,3 @@ PR = "r0"
 PV = "${LINUX_VERSION}+git${SRCPV}"
 
 COMPATIBLE_MACHINE = "(qemuarm|qemux86|qemuppc|qemumips|qemux86-64)"
-
-require recipes-kernel/linux/linux-tools.inc
-- 
1.7.10.2




^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 3/3] core-image*sdk: Add kernel-dev to sdk images
  2012-06-30  4:25 [PATCH 0/3 V3b] Enable building modules on target Darren Hart
  2012-06-30  4:25 ` [PATCH 1/3] kernel: Add kernel headers to kernel-dev package Darren Hart
  2012-06-30  4:25 ` [PATCH 2/3] linux-yocto-custom: Remove linux-tools Darren Hart
@ 2012-06-30  4:25 ` Darren Hart
  2012-07-02 13:33     ` Darren Hart
  2 siblings, 1 reply; 10+ messages in thread
From: Darren Hart @ 2012-06-30  4:25 UTC (permalink / raw)
  To: Poky, Saul Wold, openembedded-core, Kishore Bodke; +Cc: Darren Hart

While sdk images already have dev-pkgs included, the kernel-dev package
is special and does not get installed. Add kernel-dev explicitly to the
*sdk image recipes.

Note: We have to be careful with "IMAGE_INSTALL +=" as it must appear
after "inherit core-image" which makes an "IMAGE_INSTALL ?=" assignment.

Signed-off-by: Darren Hart <dvhart@linux.intel.com>
CC: Jessica Zhang <jessica.zhang@intel.com>
CC: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-extended/images/core-image-lsb-sdk.bb |    1 +
 meta/recipes-rt/images/core-image-rt-sdk.bb        |    2 +-
 meta/recipes-sato/images/core-image-sato-sdk.bb    |    3 +++
 3 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-extended/images/core-image-lsb-sdk.bb b/meta/recipes-extended/images/core-image-lsb-sdk.bb
index 32a5077..047d66b 100644
--- a/meta/recipes-extended/images/core-image-lsb-sdk.bb
+++ b/meta/recipes-extended/images/core-image-lsb-sdk.bb
@@ -10,6 +10,7 @@ IMAGE_INSTALL = "\
     ${CORE_IMAGE_BASE_INSTALL} \
     task-core-basic \
     task-core-lsb \
+    kernel-dev \
     "
 
 inherit core-image
diff --git a/meta/recipes-rt/images/core-image-rt-sdk.bb b/meta/recipes-rt/images/core-image-rt-sdk.bb
index 6ec2d00..29512e3 100644
--- a/meta/recipes-rt/images/core-image-rt-sdk.bb
+++ b/meta/recipes-rt/images/core-image-rt-sdk.bb
@@ -11,6 +11,6 @@ DEPENDS = "linux-yocto-rt"
 IMAGE_FEATURES += "dev-pkgs tools-sdk"
 EXTRA_IMAGE_FEATURES += "tools-debug tools-profile tools-testapps debug-tweaks"
 
-IMAGE_INSTALL += "rt-tests"
+IMAGE_INSTALL += "rt-tests kernel-dev"
 
 LICENSE = "MIT"
diff --git a/meta/recipes-sato/images/core-image-sato-sdk.bb b/meta/recipes-sato/images/core-image-sato-sdk.bb
index eed1698..75ed64f 100644
--- a/meta/recipes-sato/images/core-image-sato-sdk.bb
+++ b/meta/recipes-sato/images/core-image-sato-sdk.bb
@@ -11,3 +11,6 @@ EXTRA_IMAGE_FEATURES += "tools-debug tools-profile tools-testapps debug-tweaks"
 LICENSE = "MIT"
 
 inherit core-image
+
+IMAGE_INSTALL += "kernel-dev"
+
-- 
1.7.10.2




^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/3] kernel: Add kernel headers to kernel-dev package
  2012-06-30  4:25 ` [PATCH 1/3] kernel: Add kernel headers to kernel-dev package Darren Hart
@ 2012-07-01  3:51     ` Bruce Ashfield
  0 siblings, 0 replies; 10+ messages in thread
From: Bruce Ashfield @ 2012-07-01  3:51 UTC (permalink / raw)
  To: Darren Hart; +Cc: openembedded-core, Poky

On 12-06-30 12:25 AM, Darren Hart wrote:
> [YOCTO #1614]
>
> Add the kernel headers to the kernel-dev package. This packages what was
> already built and kept in sysroots for building modules with bitbake.
> Making this available on the target requires removing some additional
> host binaries.
>
> Move the location to /usr/src/kernel
>
> Before use on the target, the user will need to:
>
>      # cd /usr/src/kernel
>      # make scripts
>
> This renders the kernel-misc recipe empty, so remove it.
>
> As we use /usr/src/kernel in several places (and I missed one in the
> previous version), add a KERNEL_SRC_DIR variable and use that throughout
> the class to avoid update errors in the future.
>
> Now that we package the kernel headers, drop the
> kernel_package_preprocess function which removed them from PKGD.
>
> All *-sdk image recipes include dev-pkgs, so the kernel-dev package will
> be installed by default on all such images.

Looks good to me .. hopefully we'll go no further than v3b!

Cheers,

Bruce

>
> Signed-off-by: Darren Hart<dvhart@linux.intel.com>
> CC: Bruce Ashfield<bruce.ashfield@windriver.com>
> CC: Tom Zanussi<tom.zanussi@intel.com>
> CC: Khem Raj<raj.khem@gmail.com>
> ---
>   meta/classes/kernel.bbclass               |   27 ++++++++++++---------------
>   meta/conf/bitbake.conf                    |    2 +-
>   meta/recipes-kernel/linux/linux-yocto.inc |    2 +-
>   3 files changed, 14 insertions(+), 17 deletions(-)
>
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 31e633b..44461bc 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -77,6 +77,10 @@ EXTRA_OEMAKE = ""
>
>   KERNEL_ALT_IMAGETYPE ??= ""
>
> +# Define where the kernel headers are installed on the target as well as where
> +# they are staged.
> +KERNEL_SRC_PATH = "/usr/src/kernel"
> +
>   KERNEL_IMAGETYPE_FOR_MAKE = "${@(lambda s: s[:-3] if s[-3:] == ".gz" else s)(d.getVar('KERNEL_IMAGETYPE', True))}"
>
>   kernel_do_compile() {
> @@ -130,7 +134,7 @@ kernel_do_install() {
>   	# Support for external module building - create a minimal copy of the
>   	# kernel source tree.
>   	#
> -	kerneldir=${D}/kernel
> +	kerneldir=${D}${KERNEL_SRC_PATH}
>   	install -d $kerneldir
>
>   	#
> @@ -183,23 +187,18 @@ kernel_do_install() {
>   		cp arch/powerpc/lib/crtsavres.o $kerneldir/arch/powerpc/lib/crtsavres.o
>   	fi
>
> -	# Remove the following binaries which cause strip errors
> +	# Remove the following binaries which cause strip or arch QA errors
>   	# during do_package for cross-compiled platforms
>   	bin_files="arch/powerpc/boot/addnote arch/powerpc/boot/hack-coff \
> -	           arch/powerpc/boot/mktree"
> +	           arch/powerpc/boot/mktree scripts/kconfig/zconf.tab.o \
> +		   scripts/kconfig/conf.o"
>   	for entry in $bin_files; do
>   		rm -f $kerneldir/$entry
>   	done
>   }
>
> -PACKAGE_PREPROCESS_FUNCS += "kernel_package_preprocess"
> -
> -kernel_package_preprocess () {
> -	rm -rf ${PKGD}/kernel
> -}
> -
>   sysroot_stage_all_append() {
> -	sysroot_stage_dir ${D}/kernel ${SYSROOT_DESTDIR}/kernel
> +	sysroot_stage_dir ${D}${KERNEL_SRC_PATH} ${SYSROOT_DESTDIR}${KERNEL_SRC_PATH}
>   }
>
>   kernel_do_configure() {
> @@ -247,13 +246,11 @@ EXPORT_FUNCTIONS do_compile do_install do_configure
>
>   # kernel-base becomes kernel-${KERNEL_VERSION}
>   # kernel-image becomes kernel-image-${KERNEL_VERISON}
> -PACKAGES = "kernel kernel-base kernel-vmlinux kernel-image kernel-dev kernel-misc"
> +PACKAGES = "kernel kernel-base kernel-vmlinux kernel-image kernel-dev"
>   FILES = ""
>   FILES_kernel-image = "/boot/${KERNEL_IMAGETYPE}*"
> -FILES_kernel-dev = "/boot/System.map* /boot/Module.symvers* /boot/config*"
> +FILES_kernel-dev = "/boot/System.map* /boot/Module.symvers* /boot/config* ${KERNEL_SRC_PATH}"
>   FILES_kernel-vmlinux = "/boot/vmlinux*"
> -# misc is a package to contain files we need in staging
> -FILES_kernel-misc = "/kernel/include/config /kernel/scripts /kernel/drivers/crypto /kernel/drivers/media"
>   RDEPENDS_kernel = "kernel-base"
>   # Allow machines to override this dependency if kernel image files are
>   # not wanted in images as standard
> @@ -469,7 +466,7 @@ python populate_packages_prepend () {
>   	metapkg = "kernel-modules"
>   	d.setVar('ALLOW_EMPTY_' + metapkg, "1")
>   	d.setVar('FILES_' + metapkg, "")
> -	blacklist = [ 'kernel-dev', 'kernel-image', 'kernel-base', 'kernel-vmlinux', 'kernel-misc' ]
> +	blacklist = [ 'kernel-dev', 'kernel-image', 'kernel-base', 'kernel-vmlinux' ]
>   	for l in module_deps.values():
>   		for i in l:
>   			pkg = module_pattern % legitimize_package_name(re.match(module_regex, os.path.basename(i)).group(1))
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index 9377ee6..7e3de09 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -381,7 +381,7 @@ SDKPATHNATIVE = "${SDKPATH}/sysroots/${SDK_SYS}"
>   ##################################################################
>
>   OLDEST_KERNEL = "2.6.16"
> -STAGING_KERNEL_DIR = "${STAGING_DIR_HOST}/kernel"
> +STAGING_KERNEL_DIR = "${STAGING_DIR_HOST}/usr/src/kernel"
>
>   ##################################################################
>   # Specific image creation and rootfs population info.
> diff --git a/meta/recipes-kernel/linux/linux-yocto.inc b/meta/recipes-kernel/linux/linux-yocto.inc
> index 9b46e74..973970d 100644
> --- a/meta/recipes-kernel/linux/linux-yocto.inc
> +++ b/meta/recipes-kernel/linux/linux-yocto.inc
> @@ -4,7 +4,7 @@ LICENSE = "GPLv2"
>
>   LIC_FILES_CHKSUM = "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7"
>
> -INC_PR = "r3"
> +INC_PR = "r4"
>
>   # A KMACHINE is the mapping of a yocto $MACHINE to what is built
>   # by the kernel. This is typically the branch that should be built,




^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/3] kernel: Add kernel headers to kernel-dev package
@ 2012-07-01  3:51     ` Bruce Ashfield
  0 siblings, 0 replies; 10+ messages in thread
From: Bruce Ashfield @ 2012-07-01  3:51 UTC (permalink / raw)
  To: Darren Hart; +Cc: Kishore Bodke, openembedded-core, Poky

On 12-06-30 12:25 AM, Darren Hart wrote:
> [YOCTO #1614]
>
> Add the kernel headers to the kernel-dev package. This packages what was
> already built and kept in sysroots for building modules with bitbake.
> Making this available on the target requires removing some additional
> host binaries.
>
> Move the location to /usr/src/kernel
>
> Before use on the target, the user will need to:
>
>      # cd /usr/src/kernel
>      # make scripts
>
> This renders the kernel-misc recipe empty, so remove it.
>
> As we use /usr/src/kernel in several places (and I missed one in the
> previous version), add a KERNEL_SRC_DIR variable and use that throughout
> the class to avoid update errors in the future.
>
> Now that we package the kernel headers, drop the
> kernel_package_preprocess function which removed them from PKGD.
>
> All *-sdk image recipes include dev-pkgs, so the kernel-dev package will
> be installed by default on all such images.

Looks good to me .. hopefully we'll go no further than v3b!

Cheers,

Bruce

>
> Signed-off-by: Darren Hart<dvhart@linux.intel.com>
> CC: Bruce Ashfield<bruce.ashfield@windriver.com>
> CC: Tom Zanussi<tom.zanussi@intel.com>
> CC: Khem Raj<raj.khem@gmail.com>
> ---
>   meta/classes/kernel.bbclass               |   27 ++++++++++++---------------
>   meta/conf/bitbake.conf                    |    2 +-
>   meta/recipes-kernel/linux/linux-yocto.inc |    2 +-
>   3 files changed, 14 insertions(+), 17 deletions(-)
>
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 31e633b..44461bc 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -77,6 +77,10 @@ EXTRA_OEMAKE = ""
>
>   KERNEL_ALT_IMAGETYPE ??= ""
>
> +# Define where the kernel headers are installed on the target as well as where
> +# they are staged.
> +KERNEL_SRC_PATH = "/usr/src/kernel"
> +
>   KERNEL_IMAGETYPE_FOR_MAKE = "${@(lambda s: s[:-3] if s[-3:] == ".gz" else s)(d.getVar('KERNEL_IMAGETYPE', True))}"
>
>   kernel_do_compile() {
> @@ -130,7 +134,7 @@ kernel_do_install() {
>   	# Support for external module building - create a minimal copy of the
>   	# kernel source tree.
>   	#
> -	kerneldir=${D}/kernel
> +	kerneldir=${D}${KERNEL_SRC_PATH}
>   	install -d $kerneldir
>
>   	#
> @@ -183,23 +187,18 @@ kernel_do_install() {
>   		cp arch/powerpc/lib/crtsavres.o $kerneldir/arch/powerpc/lib/crtsavres.o
>   	fi
>
> -	# Remove the following binaries which cause strip errors
> +	# Remove the following binaries which cause strip or arch QA errors
>   	# during do_package for cross-compiled platforms
>   	bin_files="arch/powerpc/boot/addnote arch/powerpc/boot/hack-coff \
> -	           arch/powerpc/boot/mktree"
> +	           arch/powerpc/boot/mktree scripts/kconfig/zconf.tab.o \
> +		   scripts/kconfig/conf.o"
>   	for entry in $bin_files; do
>   		rm -f $kerneldir/$entry
>   	done
>   }
>
> -PACKAGE_PREPROCESS_FUNCS += "kernel_package_preprocess"
> -
> -kernel_package_preprocess () {
> -	rm -rf ${PKGD}/kernel
> -}
> -
>   sysroot_stage_all_append() {
> -	sysroot_stage_dir ${D}/kernel ${SYSROOT_DESTDIR}/kernel
> +	sysroot_stage_dir ${D}${KERNEL_SRC_PATH} ${SYSROOT_DESTDIR}${KERNEL_SRC_PATH}
>   }
>
>   kernel_do_configure() {
> @@ -247,13 +246,11 @@ EXPORT_FUNCTIONS do_compile do_install do_configure
>
>   # kernel-base becomes kernel-${KERNEL_VERSION}
>   # kernel-image becomes kernel-image-${KERNEL_VERISON}
> -PACKAGES = "kernel kernel-base kernel-vmlinux kernel-image kernel-dev kernel-misc"
> +PACKAGES = "kernel kernel-base kernel-vmlinux kernel-image kernel-dev"
>   FILES = ""
>   FILES_kernel-image = "/boot/${KERNEL_IMAGETYPE}*"
> -FILES_kernel-dev = "/boot/System.map* /boot/Module.symvers* /boot/config*"
> +FILES_kernel-dev = "/boot/System.map* /boot/Module.symvers* /boot/config* ${KERNEL_SRC_PATH}"
>   FILES_kernel-vmlinux = "/boot/vmlinux*"
> -# misc is a package to contain files we need in staging
> -FILES_kernel-misc = "/kernel/include/config /kernel/scripts /kernel/drivers/crypto /kernel/drivers/media"
>   RDEPENDS_kernel = "kernel-base"
>   # Allow machines to override this dependency if kernel image files are
>   # not wanted in images as standard
> @@ -469,7 +466,7 @@ python populate_packages_prepend () {
>   	metapkg = "kernel-modules"
>   	d.setVar('ALLOW_EMPTY_' + metapkg, "1")
>   	d.setVar('FILES_' + metapkg, "")
> -	blacklist = [ 'kernel-dev', 'kernel-image', 'kernel-base', 'kernel-vmlinux', 'kernel-misc' ]
> +	blacklist = [ 'kernel-dev', 'kernel-image', 'kernel-base', 'kernel-vmlinux' ]
>   	for l in module_deps.values():
>   		for i in l:
>   			pkg = module_pattern % legitimize_package_name(re.match(module_regex, os.path.basename(i)).group(1))
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index 9377ee6..7e3de09 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -381,7 +381,7 @@ SDKPATHNATIVE = "${SDKPATH}/sysroots/${SDK_SYS}"
>   ##################################################################
>
>   OLDEST_KERNEL = "2.6.16"
> -STAGING_KERNEL_DIR = "${STAGING_DIR_HOST}/kernel"
> +STAGING_KERNEL_DIR = "${STAGING_DIR_HOST}/usr/src/kernel"
>
>   ##################################################################
>   # Specific image creation and rootfs population info.
> diff --git a/meta/recipes-kernel/linux/linux-yocto.inc b/meta/recipes-kernel/linux/linux-yocto.inc
> index 9b46e74..973970d 100644
> --- a/meta/recipes-kernel/linux/linux-yocto.inc
> +++ b/meta/recipes-kernel/linux/linux-yocto.inc
> @@ -4,7 +4,7 @@ LICENSE = "GPLv2"
>
>   LIC_FILES_CHKSUM = "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7"
>
> -INC_PR = "r3"
> +INC_PR = "r4"
>
>   # A KMACHINE is the mapping of a yocto $MACHINE to what is built
>   # by the kernel. This is typically the branch that should be built,



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/3] kernel: Add kernel headers to kernel-dev package
  2012-07-01  3:51     ` Bruce Ashfield
@ 2012-07-02 13:32       ` Darren Hart
  -1 siblings, 0 replies; 10+ messages in thread
From: Darren Hart @ 2012-07-02 13:32 UTC (permalink / raw)
  To: Bruce Ashfield; +Cc: openembedded-core, Poky



On 06/30/2012 08:51 PM, Bruce Ashfield wrote:
> On 12-06-30 12:25 AM, Darren Hart wrote:
>> [YOCTO #1614]
>>
>> Add the kernel headers to the kernel-dev package. This packages what was
>> already built and kept in sysroots for building modules with bitbake.
>> Making this available on the target requires removing some additional
>> host binaries.
>>
>> Move the location to /usr/src/kernel
>>
>> Before use on the target, the user will need to:
>>
>>      # cd /usr/src/kernel
>>      # make scripts
>>
>> This renders the kernel-misc recipe empty, so remove it.
>>
>> As we use /usr/src/kernel in several places (and I missed one in the
>> previous version), add a KERNEL_SRC_DIR variable and use that throughout
>> the class to avoid update errors in the future.
>>
>> Now that we package the kernel headers, drop the
>> kernel_package_preprocess function which removed them from PKGD.
>>
>> All *-sdk image recipes include dev-pkgs, so the kernel-dev package will
>> be installed by default on all such images.

You picked a great spot to reply to. This last line is wrong, which is
why I had to add kernel-sdk to the sdk images in 3/3. That... or I'm
hitting bug 2595...

> 
> Looks good to me .. hopefully we'll go no further than v3b!
> 
> Cheers,
> 
> Bruce
> 
>>
>> Signed-off-by: Darren Hart<dvhart@linux.intel.com>
>> CC: Bruce Ashfield<bruce.ashfield@windriver.com>
>> CC: Tom Zanussi<tom.zanussi@intel.com>
>> CC: Khem Raj<raj.khem@gmail.com>
>> ---
>>   meta/classes/kernel.bbclass               |   27 ++++++++++++---------------
>>   meta/conf/bitbake.conf                    |    2 +-
>>   meta/recipes-kernel/linux/linux-yocto.inc |    2 +-
>>   3 files changed, 14 insertions(+), 17 deletions(-)
>>
>> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
>> index 31e633b..44461bc 100644
>> --- a/meta/classes/kernel.bbclass
>> +++ b/meta/classes/kernel.bbclass
>> @@ -77,6 +77,10 @@ EXTRA_OEMAKE = ""
>>
>>   KERNEL_ALT_IMAGETYPE ??= ""
>>
>> +# Define where the kernel headers are installed on the target as well as where
>> +# they are staged.
>> +KERNEL_SRC_PATH = "/usr/src/kernel"
>> +
>>   KERNEL_IMAGETYPE_FOR_MAKE = "${@(lambda s: s[:-3] if s[-3:] == ".gz" else s)(d.getVar('KERNEL_IMAGETYPE', True))}"
>>
>>   kernel_do_compile() {
>> @@ -130,7 +134,7 @@ kernel_do_install() {
>>   	# Support for external module building - create a minimal copy of the
>>   	# kernel source tree.
>>   	#
>> -	kerneldir=${D}/kernel
>> +	kerneldir=${D}${KERNEL_SRC_PATH}
>>   	install -d $kerneldir
>>
>>   	#
>> @@ -183,23 +187,18 @@ kernel_do_install() {
>>   		cp arch/powerpc/lib/crtsavres.o $kerneldir/arch/powerpc/lib/crtsavres.o
>>   	fi
>>
>> -	# Remove the following binaries which cause strip errors
>> +	# Remove the following binaries which cause strip or arch QA errors
>>   	# during do_package for cross-compiled platforms
>>   	bin_files="arch/powerpc/boot/addnote arch/powerpc/boot/hack-coff \
>> -	           arch/powerpc/boot/mktree"
>> +	           arch/powerpc/boot/mktree scripts/kconfig/zconf.tab.o \
>> +		   scripts/kconfig/conf.o"
>>   	for entry in $bin_files; do
>>   		rm -f $kerneldir/$entry
>>   	done
>>   }
>>
>> -PACKAGE_PREPROCESS_FUNCS += "kernel_package_preprocess"
>> -
>> -kernel_package_preprocess () {
>> -	rm -rf ${PKGD}/kernel
>> -}
>> -
>>   sysroot_stage_all_append() {
>> -	sysroot_stage_dir ${D}/kernel ${SYSROOT_DESTDIR}/kernel
>> +	sysroot_stage_dir ${D}${KERNEL_SRC_PATH} ${SYSROOT_DESTDIR}${KERNEL_SRC_PATH}
>>   }
>>
>>   kernel_do_configure() {
>> @@ -247,13 +246,11 @@ EXPORT_FUNCTIONS do_compile do_install do_configure
>>
>>   # kernel-base becomes kernel-${KERNEL_VERSION}
>>   # kernel-image becomes kernel-image-${KERNEL_VERISON}
>> -PACKAGES = "kernel kernel-base kernel-vmlinux kernel-image kernel-dev kernel-misc"
>> +PACKAGES = "kernel kernel-base kernel-vmlinux kernel-image kernel-dev"
>>   FILES = ""
>>   FILES_kernel-image = "/boot/${KERNEL_IMAGETYPE}*"
>> -FILES_kernel-dev = "/boot/System.map* /boot/Module.symvers* /boot/config*"
>> +FILES_kernel-dev = "/boot/System.map* /boot/Module.symvers* /boot/config* ${KERNEL_SRC_PATH}"
>>   FILES_kernel-vmlinux = "/boot/vmlinux*"
>> -# misc is a package to contain files we need in staging
>> -FILES_kernel-misc = "/kernel/include/config /kernel/scripts /kernel/drivers/crypto /kernel/drivers/media"
>>   RDEPENDS_kernel = "kernel-base"
>>   # Allow machines to override this dependency if kernel image files are
>>   # not wanted in images as standard
>> @@ -469,7 +466,7 @@ python populate_packages_prepend () {
>>   	metapkg = "kernel-modules"
>>   	d.setVar('ALLOW_EMPTY_' + metapkg, "1")
>>   	d.setVar('FILES_' + metapkg, "")
>> -	blacklist = [ 'kernel-dev', 'kernel-image', 'kernel-base', 'kernel-vmlinux', 'kernel-misc' ]
>> +	blacklist = [ 'kernel-dev', 'kernel-image', 'kernel-base', 'kernel-vmlinux' ]
>>   	for l in module_deps.values():
>>   		for i in l:
>>   			pkg = module_pattern % legitimize_package_name(re.match(module_regex, os.path.basename(i)).group(1))
>> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
>> index 9377ee6..7e3de09 100644
>> --- a/meta/conf/bitbake.conf
>> +++ b/meta/conf/bitbake.conf
>> @@ -381,7 +381,7 @@ SDKPATHNATIVE = "${SDKPATH}/sysroots/${SDK_SYS}"
>>   ##################################################################
>>
>>   OLDEST_KERNEL = "2.6.16"
>> -STAGING_KERNEL_DIR = "${STAGING_DIR_HOST}/kernel"
>> +STAGING_KERNEL_DIR = "${STAGING_DIR_HOST}/usr/src/kernel"
>>
>>   ##################################################################
>>   # Specific image creation and rootfs population info.
>> diff --git a/meta/recipes-kernel/linux/linux-yocto.inc b/meta/recipes-kernel/linux/linux-yocto.inc
>> index 9b46e74..973970d 100644
>> --- a/meta/recipes-kernel/linux/linux-yocto.inc
>> +++ b/meta/recipes-kernel/linux/linux-yocto.inc
>> @@ -4,7 +4,7 @@ LICENSE = "GPLv2"
>>
>>   LIC_FILES_CHKSUM = "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7"
>>
>> -INC_PR = "r3"
>> +INC_PR = "r4"
>>
>>   # A KMACHINE is the mapping of a yocto $MACHINE to what is built
>>   # by the kernel. This is typically the branch that should be built,
> 

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel





^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/3] kernel: Add kernel headers to kernel-dev package
@ 2012-07-02 13:32       ` Darren Hart
  0 siblings, 0 replies; 10+ messages in thread
From: Darren Hart @ 2012-07-02 13:32 UTC (permalink / raw)
  To: Bruce Ashfield; +Cc: Kishore Bodke, openembedded-core, Poky



On 06/30/2012 08:51 PM, Bruce Ashfield wrote:
> On 12-06-30 12:25 AM, Darren Hart wrote:
>> [YOCTO #1614]
>>
>> Add the kernel headers to the kernel-dev package. This packages what was
>> already built and kept in sysroots for building modules with bitbake.
>> Making this available on the target requires removing some additional
>> host binaries.
>>
>> Move the location to /usr/src/kernel
>>
>> Before use on the target, the user will need to:
>>
>>      # cd /usr/src/kernel
>>      # make scripts
>>
>> This renders the kernel-misc recipe empty, so remove it.
>>
>> As we use /usr/src/kernel in several places (and I missed one in the
>> previous version), add a KERNEL_SRC_DIR variable and use that throughout
>> the class to avoid update errors in the future.
>>
>> Now that we package the kernel headers, drop the
>> kernel_package_preprocess function which removed them from PKGD.
>>
>> All *-sdk image recipes include dev-pkgs, so the kernel-dev package will
>> be installed by default on all such images.

You picked a great spot to reply to. This last line is wrong, which is
why I had to add kernel-sdk to the sdk images in 3/3. That... or I'm
hitting bug 2595...

> 
> Looks good to me .. hopefully we'll go no further than v3b!
> 
> Cheers,
> 
> Bruce
> 
>>
>> Signed-off-by: Darren Hart<dvhart@linux.intel.com>
>> CC: Bruce Ashfield<bruce.ashfield@windriver.com>
>> CC: Tom Zanussi<tom.zanussi@intel.com>
>> CC: Khem Raj<raj.khem@gmail.com>
>> ---
>>   meta/classes/kernel.bbclass               |   27 ++++++++++++---------------
>>   meta/conf/bitbake.conf                    |    2 +-
>>   meta/recipes-kernel/linux/linux-yocto.inc |    2 +-
>>   3 files changed, 14 insertions(+), 17 deletions(-)
>>
>> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
>> index 31e633b..44461bc 100644
>> --- a/meta/classes/kernel.bbclass
>> +++ b/meta/classes/kernel.bbclass
>> @@ -77,6 +77,10 @@ EXTRA_OEMAKE = ""
>>
>>   KERNEL_ALT_IMAGETYPE ??= ""
>>
>> +# Define where the kernel headers are installed on the target as well as where
>> +# they are staged.
>> +KERNEL_SRC_PATH = "/usr/src/kernel"
>> +
>>   KERNEL_IMAGETYPE_FOR_MAKE = "${@(lambda s: s[:-3] if s[-3:] == ".gz" else s)(d.getVar('KERNEL_IMAGETYPE', True))}"
>>
>>   kernel_do_compile() {
>> @@ -130,7 +134,7 @@ kernel_do_install() {
>>   	# Support for external module building - create a minimal copy of the
>>   	# kernel source tree.
>>   	#
>> -	kerneldir=${D}/kernel
>> +	kerneldir=${D}${KERNEL_SRC_PATH}
>>   	install -d $kerneldir
>>
>>   	#
>> @@ -183,23 +187,18 @@ kernel_do_install() {
>>   		cp arch/powerpc/lib/crtsavres.o $kerneldir/arch/powerpc/lib/crtsavres.o
>>   	fi
>>
>> -	# Remove the following binaries which cause strip errors
>> +	# Remove the following binaries which cause strip or arch QA errors
>>   	# during do_package for cross-compiled platforms
>>   	bin_files="arch/powerpc/boot/addnote arch/powerpc/boot/hack-coff \
>> -	           arch/powerpc/boot/mktree"
>> +	           arch/powerpc/boot/mktree scripts/kconfig/zconf.tab.o \
>> +		   scripts/kconfig/conf.o"
>>   	for entry in $bin_files; do
>>   		rm -f $kerneldir/$entry
>>   	done
>>   }
>>
>> -PACKAGE_PREPROCESS_FUNCS += "kernel_package_preprocess"
>> -
>> -kernel_package_preprocess () {
>> -	rm -rf ${PKGD}/kernel
>> -}
>> -
>>   sysroot_stage_all_append() {
>> -	sysroot_stage_dir ${D}/kernel ${SYSROOT_DESTDIR}/kernel
>> +	sysroot_stage_dir ${D}${KERNEL_SRC_PATH} ${SYSROOT_DESTDIR}${KERNEL_SRC_PATH}
>>   }
>>
>>   kernel_do_configure() {
>> @@ -247,13 +246,11 @@ EXPORT_FUNCTIONS do_compile do_install do_configure
>>
>>   # kernel-base becomes kernel-${KERNEL_VERSION}
>>   # kernel-image becomes kernel-image-${KERNEL_VERISON}
>> -PACKAGES = "kernel kernel-base kernel-vmlinux kernel-image kernel-dev kernel-misc"
>> +PACKAGES = "kernel kernel-base kernel-vmlinux kernel-image kernel-dev"
>>   FILES = ""
>>   FILES_kernel-image = "/boot/${KERNEL_IMAGETYPE}*"
>> -FILES_kernel-dev = "/boot/System.map* /boot/Module.symvers* /boot/config*"
>> +FILES_kernel-dev = "/boot/System.map* /boot/Module.symvers* /boot/config* ${KERNEL_SRC_PATH}"
>>   FILES_kernel-vmlinux = "/boot/vmlinux*"
>> -# misc is a package to contain files we need in staging
>> -FILES_kernel-misc = "/kernel/include/config /kernel/scripts /kernel/drivers/crypto /kernel/drivers/media"
>>   RDEPENDS_kernel = "kernel-base"
>>   # Allow machines to override this dependency if kernel image files are
>>   # not wanted in images as standard
>> @@ -469,7 +466,7 @@ python populate_packages_prepend () {
>>   	metapkg = "kernel-modules"
>>   	d.setVar('ALLOW_EMPTY_' + metapkg, "1")
>>   	d.setVar('FILES_' + metapkg, "")
>> -	blacklist = [ 'kernel-dev', 'kernel-image', 'kernel-base', 'kernel-vmlinux', 'kernel-misc' ]
>> +	blacklist = [ 'kernel-dev', 'kernel-image', 'kernel-base', 'kernel-vmlinux' ]
>>   	for l in module_deps.values():
>>   		for i in l:
>>   			pkg = module_pattern % legitimize_package_name(re.match(module_regex, os.path.basename(i)).group(1))
>> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
>> index 9377ee6..7e3de09 100644
>> --- a/meta/conf/bitbake.conf
>> +++ b/meta/conf/bitbake.conf
>> @@ -381,7 +381,7 @@ SDKPATHNATIVE = "${SDKPATH}/sysroots/${SDK_SYS}"
>>   ##################################################################
>>
>>   OLDEST_KERNEL = "2.6.16"
>> -STAGING_KERNEL_DIR = "${STAGING_DIR_HOST}/kernel"
>> +STAGING_KERNEL_DIR = "${STAGING_DIR_HOST}/usr/src/kernel"
>>
>>   ##################################################################
>>   # Specific image creation and rootfs population info.
>> diff --git a/meta/recipes-kernel/linux/linux-yocto.inc b/meta/recipes-kernel/linux/linux-yocto.inc
>> index 9b46e74..973970d 100644
>> --- a/meta/recipes-kernel/linux/linux-yocto.inc
>> +++ b/meta/recipes-kernel/linux/linux-yocto.inc
>> @@ -4,7 +4,7 @@ LICENSE = "GPLv2"
>>
>>   LIC_FILES_CHKSUM = "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7"
>>
>> -INC_PR = "r3"
>> +INC_PR = "r4"
>>
>>   # A KMACHINE is the mapping of a yocto $MACHINE to what is built
>>   # by the kernel. This is typically the branch that should be built,
> 

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel




^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 3/3] core-image*sdk: Add kernel-dev to sdk images
  2012-06-30  4:25 ` [PATCH 3/3] core-image*sdk: Add kernel-dev to sdk images Darren Hart
@ 2012-07-02 13:33     ` Darren Hart
  0 siblings, 0 replies; 10+ messages in thread
From: Darren Hart @ 2012-07-02 13:33 UTC (permalink / raw)
  To: Darren Hart; +Cc: Paul Eggleton, openembedded-core, Poky

Paul, do you think this patch is necessary or is this just covering up
for Bug 2595?

--
Darren

On 06/29/2012 09:25 PM, Darren Hart wrote:
> While sdk images already have dev-pkgs included, the kernel-dev package
> is special and does not get installed. Add kernel-dev explicitly to the
> *sdk image recipes.
> 
> Note: We have to be careful with "IMAGE_INSTALL +=" as it must appear
> after "inherit core-image" which makes an "IMAGE_INSTALL ?=" assignment.
> 
> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
> CC: Jessica Zhang <jessica.zhang@intel.com>
> CC: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/recipes-extended/images/core-image-lsb-sdk.bb |    1 +
>  meta/recipes-rt/images/core-image-rt-sdk.bb        |    2 +-
>  meta/recipes-sato/images/core-image-sato-sdk.bb    |    3 +++
>  3 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-extended/images/core-image-lsb-sdk.bb b/meta/recipes-extended/images/core-image-lsb-sdk.bb
> index 32a5077..047d66b 100644
> --- a/meta/recipes-extended/images/core-image-lsb-sdk.bb
> +++ b/meta/recipes-extended/images/core-image-lsb-sdk.bb
> @@ -10,6 +10,7 @@ IMAGE_INSTALL = "\
>      ${CORE_IMAGE_BASE_INSTALL} \
>      task-core-basic \
>      task-core-lsb \
> +    kernel-dev \
>      "
>  
>  inherit core-image
> diff --git a/meta/recipes-rt/images/core-image-rt-sdk.bb b/meta/recipes-rt/images/core-image-rt-sdk.bb
> index 6ec2d00..29512e3 100644
> --- a/meta/recipes-rt/images/core-image-rt-sdk.bb
> +++ b/meta/recipes-rt/images/core-image-rt-sdk.bb
> @@ -11,6 +11,6 @@ DEPENDS = "linux-yocto-rt"
>  IMAGE_FEATURES += "dev-pkgs tools-sdk"
>  EXTRA_IMAGE_FEATURES += "tools-debug tools-profile tools-testapps debug-tweaks"
>  
> -IMAGE_INSTALL += "rt-tests"
> +IMAGE_INSTALL += "rt-tests kernel-dev"
>  
>  LICENSE = "MIT"
> diff --git a/meta/recipes-sato/images/core-image-sato-sdk.bb b/meta/recipes-sato/images/core-image-sato-sdk.bb
> index eed1698..75ed64f 100644
> --- a/meta/recipes-sato/images/core-image-sato-sdk.bb
> +++ b/meta/recipes-sato/images/core-image-sato-sdk.bb
> @@ -11,3 +11,6 @@ EXTRA_IMAGE_FEATURES += "tools-debug tools-profile tools-testapps debug-tweaks"
>  LICENSE = "MIT"
>  
>  inherit core-image
> +
> +IMAGE_INSTALL += "kernel-dev"
> +
> 

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel





^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 3/3] core-image*sdk: Add kernel-dev to sdk images
@ 2012-07-02 13:33     ` Darren Hart
  0 siblings, 0 replies; 10+ messages in thread
From: Darren Hart @ 2012-07-02 13:33 UTC (permalink / raw)
  To: Darren Hart; +Cc: Paul Eggleton, Kishore Bodke, openembedded-core, Poky

Paul, do you think this patch is necessary or is this just covering up
for Bug 2595?

--
Darren

On 06/29/2012 09:25 PM, Darren Hart wrote:
> While sdk images already have dev-pkgs included, the kernel-dev package
> is special and does not get installed. Add kernel-dev explicitly to the
> *sdk image recipes.
> 
> Note: We have to be careful with "IMAGE_INSTALL +=" as it must appear
> after "inherit core-image" which makes an "IMAGE_INSTALL ?=" assignment.
> 
> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
> CC: Jessica Zhang <jessica.zhang@intel.com>
> CC: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/recipes-extended/images/core-image-lsb-sdk.bb |    1 +
>  meta/recipes-rt/images/core-image-rt-sdk.bb        |    2 +-
>  meta/recipes-sato/images/core-image-sato-sdk.bb    |    3 +++
>  3 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-extended/images/core-image-lsb-sdk.bb b/meta/recipes-extended/images/core-image-lsb-sdk.bb
> index 32a5077..047d66b 100644
> --- a/meta/recipes-extended/images/core-image-lsb-sdk.bb
> +++ b/meta/recipes-extended/images/core-image-lsb-sdk.bb
> @@ -10,6 +10,7 @@ IMAGE_INSTALL = "\
>      ${CORE_IMAGE_BASE_INSTALL} \
>      task-core-basic \
>      task-core-lsb \
> +    kernel-dev \
>      "
>  
>  inherit core-image
> diff --git a/meta/recipes-rt/images/core-image-rt-sdk.bb b/meta/recipes-rt/images/core-image-rt-sdk.bb
> index 6ec2d00..29512e3 100644
> --- a/meta/recipes-rt/images/core-image-rt-sdk.bb
> +++ b/meta/recipes-rt/images/core-image-rt-sdk.bb
> @@ -11,6 +11,6 @@ DEPENDS = "linux-yocto-rt"
>  IMAGE_FEATURES += "dev-pkgs tools-sdk"
>  EXTRA_IMAGE_FEATURES += "tools-debug tools-profile tools-testapps debug-tweaks"
>  
> -IMAGE_INSTALL += "rt-tests"
> +IMAGE_INSTALL += "rt-tests kernel-dev"
>  
>  LICENSE = "MIT"
> diff --git a/meta/recipes-sato/images/core-image-sato-sdk.bb b/meta/recipes-sato/images/core-image-sato-sdk.bb
> index eed1698..75ed64f 100644
> --- a/meta/recipes-sato/images/core-image-sato-sdk.bb
> +++ b/meta/recipes-sato/images/core-image-sato-sdk.bb
> @@ -11,3 +11,6 @@ EXTRA_IMAGE_FEATURES += "tools-debug tools-profile tools-testapps debug-tweaks"
>  LICENSE = "MIT"
>  
>  inherit core-image
> +
> +IMAGE_INSTALL += "kernel-dev"
> +
> 

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel




^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2012-07-02 13:46 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-30  4:25 [PATCH 0/3 V3b] Enable building modules on target Darren Hart
2012-06-30  4:25 ` [PATCH 1/3] kernel: Add kernel headers to kernel-dev package Darren Hart
2012-07-01  3:51   ` Bruce Ashfield
2012-07-01  3:51     ` Bruce Ashfield
2012-07-02 13:32     ` Darren Hart
2012-07-02 13:32       ` Darren Hart
2012-06-30  4:25 ` [PATCH 2/3] linux-yocto-custom: Remove linux-tools Darren Hart
2012-06-30  4:25 ` [PATCH 3/3] core-image*sdk: Add kernel-dev to sdk images Darren Hart
2012-07-02 13:33   ` Darren Hart
2012-07-02 13:33     ` Darren Hart

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.