* [PATCH] ARM: OMAP2+: hwmod data: Fix wrong McBSP clock alias on OMAP4
@ 2012-06-18 9:42 ` Cousson, Benoit
0 siblings, 0 replies; 6+ messages in thread
From: Cousson, Benoit @ 2012-06-18 9:42 UTC (permalink / raw)
To: Paul Walmsley
Cc: linux-omap, linux-arm-kernel, Ujfalusi, Peter, Guiriec,
Sebastien, Lopez Cruz, Misael
The commit 503d0ea24d1d3dd3db95e5e0edd693da7a2a23eb
ARM: OMAP4: hwmod data: Add aliases for McBSP fclk clocks
added a wrong "prcm_clk" alias for PRCM clock whereas the McBSP
driver and previous OMAPs are using "prcm_fck".
It thus lead to the following warning.
[ 47.409729] omap-mcbsp: clks: could not clk_get() prcm_fck
Fix that by changing the opt_clk role to prcm_fck.
Reported-by: Misael Lopez Cruz <misael.lopez@ti.com>
Signed-off-by: Benoit Cousson <b-cousson@ti.com>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
Tested-by: Sebastien Guiriec <s-guiriec@ti.com>
---
arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
index 950454a..1527541 100644
--- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
@@ -1924,7 +1924,7 @@ static struct omap_hwmod_dma_info omap44xx_mcbsp1_sdma_reqs[] = {
static struct omap_hwmod_opt_clk mcbsp1_opt_clks[] = {
{ .role = "pad_fck", .clk = "pad_clks_ck" },
- { .role = "prcm_clk", .clk = "mcbsp1_sync_mux_ck" },
+ { .role = "prcm_fck", .clk = "mcbsp1_sync_mux_ck" },
};
static struct omap_hwmod omap44xx_mcbsp1_hwmod = {
@@ -1959,7 +1959,7 @@ static struct omap_hwmod_dma_info omap44xx_mcbsp2_sdma_reqs[] = {
static struct omap_hwmod_opt_clk mcbsp2_opt_clks[] = {
{ .role = "pad_fck", .clk = "pad_clks_ck" },
- { .role = "prcm_clk", .clk = "mcbsp2_sync_mux_ck" },
+ { .role = "prcm_fck", .clk = "mcbsp2_sync_mux_ck" },
};
static struct omap_hwmod omap44xx_mcbsp2_hwmod = {
@@ -1994,7 +1994,7 @@ static struct omap_hwmod_dma_info omap44xx_mcbsp3_sdma_reqs[] = {
static struct omap_hwmod_opt_clk mcbsp3_opt_clks[] = {
{ .role = "pad_fck", .clk = "pad_clks_ck" },
- { .role = "prcm_clk", .clk = "mcbsp3_sync_mux_ck" },
+ { .role = "prcm_fck", .clk = "mcbsp3_sync_mux_ck" },
};
static struct omap_hwmod omap44xx_mcbsp3_hwmod = {
@@ -2029,7 +2029,7 @@ static struct omap_hwmod_dma_info omap44xx_mcbsp4_sdma_reqs[] = {
static struct omap_hwmod_opt_clk mcbsp4_opt_clks[] = {
{ .role = "pad_fck", .clk = "pad_clks_ck" },
- { .role = "prcm_clk", .clk = "mcbsp4_sync_mux_ck" },
+ { .role = "prcm_fck", .clk = "mcbsp4_sync_mux_ck" },
};
static struct omap_hwmod omap44xx_mcbsp4_hwmod = {
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ARM: OMAP2+: hwmod data: Fix wrong McBSP clock alias on OMAP4
@ 2012-06-18 9:42 ` Cousson, Benoit
0 siblings, 0 replies; 6+ messages in thread
From: Cousson, Benoit @ 2012-06-18 9:42 UTC (permalink / raw)
To: linux-arm-kernel
The commit 503d0ea24d1d3dd3db95e5e0edd693da7a2a23eb
ARM: OMAP4: hwmod data: Add aliases for McBSP fclk clocks
added a wrong "prcm_clk" alias for PRCM clock whereas the McBSP
driver and previous OMAPs are using "prcm_fck".
It thus lead to the following warning.
[ 47.409729] omap-mcbsp: clks: could not clk_get() prcm_fck
Fix that by changing the opt_clk role to prcm_fck.
Reported-by: Misael Lopez Cruz <misael.lopez@ti.com>
Signed-off-by: Benoit Cousson <b-cousson@ti.com>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
Tested-by: Sebastien Guiriec <s-guiriec@ti.com>
---
arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
index 950454a..1527541 100644
--- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
@@ -1924,7 +1924,7 @@ static struct omap_hwmod_dma_info omap44xx_mcbsp1_sdma_reqs[] = {
static struct omap_hwmod_opt_clk mcbsp1_opt_clks[] = {
{ .role = "pad_fck", .clk = "pad_clks_ck" },
- { .role = "prcm_clk", .clk = "mcbsp1_sync_mux_ck" },
+ { .role = "prcm_fck", .clk = "mcbsp1_sync_mux_ck" },
};
static struct omap_hwmod omap44xx_mcbsp1_hwmod = {
@@ -1959,7 +1959,7 @@ static struct omap_hwmod_dma_info omap44xx_mcbsp2_sdma_reqs[] = {
static struct omap_hwmod_opt_clk mcbsp2_opt_clks[] = {
{ .role = "pad_fck", .clk = "pad_clks_ck" },
- { .role = "prcm_clk", .clk = "mcbsp2_sync_mux_ck" },
+ { .role = "prcm_fck", .clk = "mcbsp2_sync_mux_ck" },
};
static struct omap_hwmod omap44xx_mcbsp2_hwmod = {
@@ -1994,7 +1994,7 @@ static struct omap_hwmod_dma_info omap44xx_mcbsp3_sdma_reqs[] = {
static struct omap_hwmod_opt_clk mcbsp3_opt_clks[] = {
{ .role = "pad_fck", .clk = "pad_clks_ck" },
- { .role = "prcm_clk", .clk = "mcbsp3_sync_mux_ck" },
+ { .role = "prcm_fck", .clk = "mcbsp3_sync_mux_ck" },
};
static struct omap_hwmod omap44xx_mcbsp3_hwmod = {
@@ -2029,7 +2029,7 @@ static struct omap_hwmod_dma_info omap44xx_mcbsp4_sdma_reqs[] = {
static struct omap_hwmod_opt_clk mcbsp4_opt_clks[] = {
{ .role = "pad_fck", .clk = "pad_clks_ck" },
- { .role = "prcm_clk", .clk = "mcbsp4_sync_mux_ck" },
+ { .role = "prcm_fck", .clk = "mcbsp4_sync_mux_ck" },
};
static struct omap_hwmod omap44xx_mcbsp4_hwmod = {
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: OMAP2+: hwmod data: Fix wrong McBSP clock alias on OMAP4
2012-06-18 9:42 ` Cousson, Benoit
@ 2012-06-18 15:57 ` Paul Walmsley
-1 siblings, 0 replies; 6+ messages in thread
From: Paul Walmsley @ 2012-06-18 15:57 UTC (permalink / raw)
To: Cousson, Benoit
Cc: Ujfalusi, Peter, Lopez Cruz, Misael, linux-omap, Guiriec,
Sebastien, linux-arm-kernel
On Mon, 18 Jun 2012, Cousson, Benoit wrote:
> The commit 503d0ea24d1d3dd3db95e5e0edd693da7a2a23eb
> ARM: OMAP4: hwmod data: Add aliases for McBSP fclk clocks
>
> added a wrong "prcm_clk" alias for PRCM clock whereas the McBSP
> driver and previous OMAPs are using "prcm_fck".
>
> It thus lead to the following warning.
>
> [ 47.409729] omap-mcbsp: clks: could not clk_get() prcm_fck
>
> Fix that by changing the opt_clk role to prcm_fck.
>
> Reported-by: Misael Lopez Cruz <misael.lopez@ti.com>
> Signed-off-by: Benoit Cousson <b-cousson@ti.com>
> Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Tested-by: Sebastien Guiriec <s-guiriec@ti.com>
Thanks, will queue this as part of the next 3.5-rc series.
- Paul
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: OMAP2+: hwmod data: Fix wrong McBSP clock alias on OMAP4
@ 2012-06-18 15:57 ` Paul Walmsley
0 siblings, 0 replies; 6+ messages in thread
From: Paul Walmsley @ 2012-06-18 15:57 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, 18 Jun 2012, Cousson, Benoit wrote:
> The commit 503d0ea24d1d3dd3db95e5e0edd693da7a2a23eb
> ARM: OMAP4: hwmod data: Add aliases for McBSP fclk clocks
>
> added a wrong "prcm_clk" alias for PRCM clock whereas the McBSP
> driver and previous OMAPs are using "prcm_fck".
>
> It thus lead to the following warning.
>
> [ 47.409729] omap-mcbsp: clks: could not clk_get() prcm_fck
>
> Fix that by changing the opt_clk role to prcm_fck.
>
> Reported-by: Misael Lopez Cruz <misael.lopez@ti.com>
> Signed-off-by: Benoit Cousson <b-cousson@ti.com>
> Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Tested-by: Sebastien Guiriec <s-guiriec@ti.com>
Thanks, will queue this as part of the next 3.5-rc series.
- Paul
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: OMAP2+: hwmod data: Fix wrong McBSP clock alias on OMAP4
2012-06-18 15:57 ` Paul Walmsley
@ 2012-07-02 15:45 ` Benoit Cousson
-1 siblings, 0 replies; 6+ messages in thread
From: Benoit Cousson @ 2012-07-02 15:45 UTC (permalink / raw)
To: Paul Walmsley
Cc: linux-omap, linux-arm-kernel, Ujfalusi, Peter, Guiriec,
Sebastien, Lopez Cruz, Misael
Hi Paul,
On 06/18/2012 05:57 PM, Paul Walmsley wrote:
> On Mon, 18 Jun 2012, Cousson, Benoit wrote:
>
>> The commit 503d0ea24d1d3dd3db95e5e0edd693da7a2a23eb
>> ARM: OMAP4: hwmod data: Add aliases for McBSP fclk clocks
>>
>> added a wrong "prcm_clk" alias for PRCM clock whereas the McBSP
>> driver and previous OMAPs are using "prcm_fck".
>>
>> It thus lead to the following warning.
>>
>> [ 47.409729] omap-mcbsp: clks: could not clk_get() prcm_fck
>>
>> Fix that by changing the opt_clk role to prcm_fck.
>>
>> Reported-by: Misael Lopez Cruz <misael.lopez@ti.com>
>> Signed-off-by: Benoit Cousson <b-cousson@ti.com>
>> Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
>> Tested-by: Sebastien Guiriec <s-guiriec@ti.com>
>
> Thanks, will queue this as part of the next 3.5-rc series.
I might be wrong but it seems that this one is not yet in 3.5-rc5.
Thanks,
Benoit
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: OMAP2+: hwmod data: Fix wrong McBSP clock alias on OMAP4
@ 2012-07-02 15:45 ` Benoit Cousson
0 siblings, 0 replies; 6+ messages in thread
From: Benoit Cousson @ 2012-07-02 15:45 UTC (permalink / raw)
To: linux-arm-kernel
Hi Paul,
On 06/18/2012 05:57 PM, Paul Walmsley wrote:
> On Mon, 18 Jun 2012, Cousson, Benoit wrote:
>
>> The commit 503d0ea24d1d3dd3db95e5e0edd693da7a2a23eb
>> ARM: OMAP4: hwmod data: Add aliases for McBSP fclk clocks
>>
>> added a wrong "prcm_clk" alias for PRCM clock whereas the McBSP
>> driver and previous OMAPs are using "prcm_fck".
>>
>> It thus lead to the following warning.
>>
>> [ 47.409729] omap-mcbsp: clks: could not clk_get() prcm_fck
>>
>> Fix that by changing the opt_clk role to prcm_fck.
>>
>> Reported-by: Misael Lopez Cruz <misael.lopez@ti.com>
>> Signed-off-by: Benoit Cousson <b-cousson@ti.com>
>> Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
>> Tested-by: Sebastien Guiriec <s-guiriec@ti.com>
>
> Thanks, will queue this as part of the next 3.5-rc series.
I might be wrong but it seems that this one is not yet in 3.5-rc5.
Thanks,
Benoit
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-07-02 15:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-18 9:42 [PATCH] ARM: OMAP2+: hwmod data: Fix wrong McBSP clock alias on OMAP4 Cousson, Benoit
2012-06-18 9:42 ` Cousson, Benoit
2012-06-18 15:57 ` Paul Walmsley
2012-06-18 15:57 ` Paul Walmsley
2012-07-02 15:45 ` Benoit Cousson
2012-07-02 15:45 ` Benoit Cousson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.