All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Include <net/ip6_checksum.h> for csum_ipv6_magic
@ 2012-07-03 18:33 Kevin Locke
  2012-07-03 20:54 ` Jan Engelhardt
  0 siblings, 1 reply; 3+ messages in thread
From: Kevin Locke @ 2012-07-03 18:33 UTC (permalink / raw)
  To: netfilter-devel

xt_ECHO fails to build on PPC because csum_ipv6_magic is declared in
<net/ip6_checksum.h>, which is not implicitly included from other
headers on PPC causing build failures due to this function being
undefined.  So, include this header explicitly.

Note:  Same cause as <http://bugzilla.netfilter.org/show_bug.cgi?id=307>.

Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
---
 extensions/xt_ECHO.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/extensions/xt_ECHO.c b/extensions/xt_ECHO.c
index efbceff..057d81a 100644
--- a/extensions/xt_ECHO.c
+++ b/extensions/xt_ECHO.c
@@ -18,6 +18,7 @@
 #	include <linux/netfilter_bridge.h>
 #endif
 #include <net/ip.h>
+#include <net/ip6_checksum.h>
 #include <net/ip6_route.h>
 #include <net/route.h>
 #include "compat_xtables.h"
-- 
1.7.10

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] Include <net/ip6_checksum.h> for csum_ipv6_magic
  2012-07-03 18:33 [PATCH] Include <net/ip6_checksum.h> for csum_ipv6_magic Kevin Locke
@ 2012-07-03 20:54 ` Jan Engelhardt
  2012-07-03 23:02   ` Kevin Locke
  0 siblings, 1 reply; 3+ messages in thread
From: Jan Engelhardt @ 2012-07-03 20:54 UTC (permalink / raw)
  To: Kevin Locke; +Cc: netfilter-devel

On Tuesday 2012-07-03 20:33, Kevin Locke wrote:

>xt_ECHO fails to build on PPC because csum_ipv6_magic is declared in
><net/ip6_checksum.h>, which is not implicitly included from other
>headers on PPC causing build failures due to this function being
>undefined.  So, include this header explicitly.

Fixed.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Include <net/ip6_checksum.h> for csum_ipv6_magic
  2012-07-03 20:54 ` Jan Engelhardt
@ 2012-07-03 23:02   ` Kevin Locke
  0 siblings, 0 replies; 3+ messages in thread
From: Kevin Locke @ 2012-07-03 23:02 UTC (permalink / raw)
  To: Jan Engelhardt; +Cc: netfilter-devel

On 07/03/2012 02:54 PM, Jan Engelhardt wrote:
> On Tuesday 2012-07-03 20:33, Kevin Locke wrote:
>> xt_ECHO fails to build on PPC because csum_ipv6_magic is declared in
>> <net/ip6_checksum.h>, which is not implicitly included from other
>> headers on PPC causing build failures due to this function being
>> undefined.  So, include this header explicitly.
>
> Fixed.

Great.  Thanks!

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-07-03 23:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-03 18:33 [PATCH] Include <net/ip6_checksum.h> for csum_ipv6_magic Kevin Locke
2012-07-03 20:54 ` Jan Engelhardt
2012-07-03 23:02   ` Kevin Locke

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.